[jira] [Commented] (KYLIN-2721) Introduce a new metrics framework based on dropwizard metrics
[ https://issues.apache.org/jira/browse/KYLIN-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338608#comment-16338608 ] Zhong Yanghong commented on KYLIN-2721: --- Hi [~yimingliu], [ KYLIN-2724 | https://issues.apache.org/jira/browse/KYLIN-2724] is moved out. I'll resolve this issue. > Introduce a new metrics framework based on dropwizard metrics > - > > Key: KYLIN-2721 > URL: https://issues.apache.org/jira/browse/KYLIN-2721 > Project: Kylin > Issue Type: New Feature >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Attachments: Metrics Framework.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2721) Introduce a new metrics framework based on dropwizard metrics
[ https://issues.apache.org/jira/browse/KYLIN-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337773#comment-16337773 ] Billy Liu commented on KYLIN-2721: -- [~yaho] this is only one sub issue left for V2.3 right now. Hope KYLIN-2721 be ready for the V2.3 > Introduce a new metrics framework based on dropwizard metrics > - > > Key: KYLIN-2721 > URL: https://issues.apache.org/jira/browse/KYLIN-2721 > Project: Kylin > Issue Type: New Feature >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Attachments: Metrics Framework.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-2721) Introduce a new metrics framework based on dropwizard metrics
[ https://issues.apache.org/jira/browse/KYLIN-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102651#comment-16102651 ] hongbin ma commented on KYLIN-2721: --- [~yaho] please try to keep up with latest code. Consider kylin master branch or 2.1.x branch > Introduce a new metrics framework based on dropwizard metrics > - > > Key: KYLIN-2721 > URL: https://issues.apache.org/jira/browse/KYLIN-2721 > Project: Kylin > Issue Type: New Feature >Affects Versions: v2.0.0 >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong > Attachments: Metrics Framework.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2721) Introduce a new metrics framework based on dropwizard metrics
[ https://issues.apache.org/jira/browse/KYLIN-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101693#comment-16101693 ] Zhong Yanghong commented on KYLIN-2721: --- Btw, what's the timeline for 2.1.0 release? We are considering whether to prepare patch for 2.1.0 or 2.0.0. As consulting with [~liyang.g...@gmail.com], we hope to create an independent branch first for these patches. Then merge this branch to the master branch. And I'll hurry up with patch preparation.:) > Introduce a new metrics framework based on dropwizard metrics > - > > Key: KYLIN-2721 > URL: https://issues.apache.org/jira/browse/KYLIN-2721 > Project: Kylin > Issue Type: New Feature >Affects Versions: v2.0.0 >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong > Attachments: Metrics Framework.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2721) Introduce a new metrics framework based on dropwizard metrics
[ https://issues.apache.org/jira/browse/KYLIN-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101678#comment-16101678 ] Zhong Yanghong commented on KYLIN-2721: --- Hi [~mahongbin], thanks for your comments. bq. You claimed hadoop metrics is less stable, do you have any published evidence?\ I'm sorry that maybe the word 'stable' is a little confusing. What I mean is metrics collection is relatively independent and should not depend on hadoop. As I know, currently hadoop metrics is within hadoop-common. Do we really need to update kylin metrics module with the update of hadoop? In my opinion, I prefer to keep kylin metrics module an independent one. bq. You claimed codehale is lightweight, but as I calculated hadoop metrics has only ~15000 lines of java code (including test), while latest codehale project (https://github.com/dropwizard/metrics.git) has ~23000 lines of java code. "Lightweight" does not favor codehale In my point of view, as an independent metrics framework, dropwizard is lightweight. And it's also widely used by others, like kafka. bq. Although your proposal serves different purpose with existing QueryMetrics, we still need to avoid two metrics frameworks. That said, If we decide to choose dropwizard, we need to migrate QueryMetrics to use dropwizard ASAP I agree that there should be only one metrics framework serving for kylin. Depending on the final conclusion, we'll see whether to migrate QueryMetrics to dropwizard or vice versa. > Introduce a new metrics framework based on dropwizard metrics > - > > Key: KYLIN-2721 > URL: https://issues.apache.org/jira/browse/KYLIN-2721 > Project: Kylin > Issue Type: New Feature >Affects Versions: v2.0.0 >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong > Attachments: Metrics Framework.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2721) Introduce a new metrics framework based on dropwizard metrics
[ https://issues.apache.org/jira/browse/KYLIN-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101592#comment-16101592 ] hongbin ma commented on KYLIN-2721: --- dropwizard, yammer, codehale is talking about the same thing (http://ningg.top/yammer-metrics/) let's stop confusing the term. [~yaho] I still have two questions. 1. You claimed hadoop metrics is less stable, do you have any published evidence? 2. Although your proposal serves different purpose with existing QueryMetrics, we still need to avoid two metrics frameworks. That said, If we decide to choose dropwizard, we need to migrate QueryMetrics to use dropwizard ASAP > Introduce a new metrics framework based on dropwizard metrics > - > > Key: KYLIN-2721 > URL: https://issues.apache.org/jira/browse/KYLIN-2721 > Project: Kylin > Issue Type: New Feature >Affects Versions: v2.0.0 >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong > Attachments: Metrics Framework.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2721) Introduce a new metrics framework based on dropwizard metrics
[ https://issues.apache.org/jira/browse/KYLIN-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099936#comment-16099936 ] liyang commented on KYLIN-2721: --- I'm also fine with dropwizard. It is a big step forward if we are all happy with it. :-) Can we be specific of a dropwizard version? Need to do more investigation on the library. > Introduce a new metrics framework based on dropwizard metrics > - > > Key: KYLIN-2721 > URL: https://issues.apache.org/jira/browse/KYLIN-2721 > Project: Kylin > Issue Type: New Feature >Affects Versions: v2.0.0 >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong > Attachments: Metrics Framework.png > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
