[jira] [Commented] (KYLIN-2944) HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in serialize()
[ https://issues.apache.org/jira/browse/KYLIN-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213766#comment-16213766 ] liyang commented on KYLIN-2944: --- Added a performance test case and result shows, for HLLCSerializer, returning shared object or not DON'T impact performance. I've no concern now. > HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in > serialize() > > > Key: KYLIN-2944 > URL: https://issues.apache.org/jira/browse/KYLIN-2944 > Project: Kylin > Issue Type: Bug >Reporter: Shaofeng SHI >Assignee: Shaofeng SHI > Fix For: v2.2.0 > > > This is a bug, which causing incorrect query result. See more in KYLIN-2926 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2944) HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in serialize()
[ https://issues.apache.org/jira/browse/KYLIN-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213640#comment-16213640 ] liyang commented on KYLIN-2944: --- If the consumer want new objects, the consumer can always clone the measure objects by itself. > HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in > serialize() > > > Key: KYLIN-2944 > URL: https://issues.apache.org/jira/browse/KYLIN-2944 > Project: Kylin > Issue Type: Bug >Reporter: Shaofeng SHI >Assignee: Shaofeng SHI > Fix For: v2.2.0 > > > This is a bug, which causing incorrect query result. See more in KYLIN-2926 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2944) HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in serialize()
[ https://issues.apache.org/jira/browse/KYLIN-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213638#comment-16213638 ] liyang commented on KYLIN-2944: --- Hold on a bit... by creating new objects, the increased may cause performance decrease in many places. Have we tested the performance difference at least? > HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in > serialize() > > > Key: KYLIN-2944 > URL: https://issues.apache.org/jira/browse/KYLIN-2944 > Project: Kylin > Issue Type: Bug >Reporter: Shaofeng SHI >Assignee: Shaofeng SHI > Fix For: v2.2.0 > > > This is a bug, which causing incorrect query result. See more in KYLIN-2926 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2944) HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in serialize()
[ https://issues.apache.org/jira/browse/KYLIN-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208677#comment-16208677 ] Shaofeng SHI commented on KYLIN-2944: - Integration test passed, merged in master branch as well. > HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in > serialize() > > > Key: KYLIN-2944 > URL: https://issues.apache.org/jira/browse/KYLIN-2944 > Project: Kylin > Issue Type: Bug >Reporter: Shaofeng SHI >Assignee: Shaofeng SHI > Fix For: v2.2.0 > > > This is a bug, which causing incorrect query result. See more in KYLIN-2926 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2944) HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in serialize()
[ https://issues.apache.org/jira/browse/KYLIN-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207741#comment-16207741 ] Shaofeng SHI commented on KYLIN-2944: - Staged in 2.2.x branch: https://github.com/apache/kylin/commit/d25ac5d00bc70f5e9d62f7ebcc6dd547ce0d846d Will run IT over it. > HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in > serialize() > > > Key: KYLIN-2944 > URL: https://issues.apache.org/jira/browse/KYLIN-2944 > Project: Kylin > Issue Type: Bug >Reporter: Shaofeng SHI >Assignee: Shaofeng SHI > Fix For: v2.2.0 > > > This is a bug, which causing incorrect query result. See more in KYLIN-2926 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
