[jira] [Commented] (KYLIN-2967) Add the dependency check when deleting a project
[ https://issues.apache.org/jira/browse/KYLIN-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241974#comment-16241974 ] peng.jianhua commented on KYLIN-2967: - Hi,[~yimingliu],I've resubmitted the patch. And I found that the testDropNonemptyProject() in ProjectManagerTest has coverd the condition when (projectInstance.getModels().size() != 0). Thank you. > Add the dependency check when deleting a project > - > > Key: KYLIN-2967 > URL: https://issues.apache.org/jira/browse/KYLIN-2967 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.0 >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-2967-Add-the-dependency-check-when-deleting-a-.patch, 01.PNG, > 02.PNG, 03.PNG, 04.PNG > > > Can't drop model when I delete the project first. > 1,create project1 and project2,create model_01 for project1 and model_02 for > project2,just like 01.png and 02.png. > 2,delete project2,then try to drop model_02,it shows like 04.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2967) Add the dependency check when deleting a project
[ https://issues.apache.org/jira/browse/KYLIN-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240503#comment-16240503 ] peng.jianhua commented on KYLIN-2967: - thanks [~yimingliu].No problem,I'll update the patch. > Add the dependency check when deleting a project > - > > Key: KYLIN-2967 > URL: https://issues.apache.org/jira/browse/KYLIN-2967 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.0 >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-2967-Add-the-dependency-check-when-deleting-a-.patch, 01.PNG, > 02.PNG, 03.PNG, 04.PNG > > > Can't drop model when I delete the project first. > 1,create project1 and project2,create model_01 for project1 and model_02 for > project2,just like 01.png and 02.png. > 2,delete project2,then try to drop model_02,it shows like 04.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2967) Add the dependency check when deleting a project
[ https://issues.apache.org/jira/browse/KYLIN-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240364#comment-16240364 ] Billy Liu commented on KYLIN-2967: -- Thanks [~peng.jianhua] for the updated patch. More comments: Could you update the check dependency into two statements, one is for model check, the other one is for realization check. They should have different exception messages. One more thing, the test case in ProjectManagerTest is highly recommended. > Add the dependency check when deleting a project > - > > Key: KYLIN-2967 > URL: https://issues.apache.org/jira/browse/KYLIN-2967 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.0 >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-2967-Add-the-dependency-check-when-deleting-a-.patch, 01.PNG, > 02.PNG, 03.PNG, 04.PNG > > > Can't drop model when I delete the project first. > 1,create project1 and project2,create model_01 for project1 and model_02 for > project2,just like 01.png and 02.png. > 2,delete project2,then try to drop model_02,it shows like 04.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-2967) Add the dependency check when deleting a project
[ https://issues.apache.org/jira/browse/KYLIN-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240320#comment-16240320 ] peng.jianhua commented on KYLIN-2967: - Hi,[~Shaofengshi] and [~yimingliu],sorry to disturb you. I've resubmitted the patch.Now when you attempt to delete a project,we will check if there is model in it. > Add the dependency check when deleting a project > - > > Key: KYLIN-2967 > URL: https://issues.apache.org/jira/browse/KYLIN-2967 > Project: Kylin > Issue Type: Bug >Affects Versions: v2.3.0 >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-2967-Add-the-dependency-check-when-deleting-a-.patch, 01.PNG, > 02.PNG, 03.PNG, 04.PNG > > > Can't drop model when I delete the project first. > 1,create project1 and project2,create model_01 for project1 and model_02 for > project2,just like 01.png and 02.png. > 2,delete project2,then try to drop model_02,it shows like 04.png. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
