[jira] [Commented] (KYLIN-3103) Export result failed when sql with comments
[ https://issues.apache.org/jira/browse/KYLIN-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290724#comment-16290724 ] peng.jianhua commented on KYLIN-3103: - And if comments like "/* */" has content like "--",such as /* comments--comments */ will convert to "/* comments -- comments */",it will export failed too. please refer to KYLIN-3072. However,it can export results in windows system,because "Enter key" is '"\r\n" in windows system. > Export result failed when sql with comments > --- > > Key: KYLIN-3103 > URL: https://issues.apache.org/jira/browse/KYLIN-3103 > Project: Kylin > Issue Type: Bug >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3103-Export-result-failed-when-sql-with-commen.patch, error.PNG > > > \-- query trans_id > select trans_id from kylin_sales > sql like this above,execute success,export failed,please refer to error.PNG -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3103) Export result failed when sql with comments
[ https://issues.apache.org/jira/browse/KYLIN-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290652#comment-16290652 ] peng.jianhua commented on KYLIN-3103: - Hi,[~Shaofengshi], if the sql has comments formats like "/* */" ,then convert '\n' to space,the sql still works. such as : /* query trans_id */ select trans_id from kylin_sales would convert to /* query trans_id */ select trans_id from kylin_sales > Export result failed when sql with comments > --- > > Key: KYLIN-3103 > URL: https://issues.apache.org/jira/browse/KYLIN-3103 > Project: Kylin > Issue Type: Bug >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3103-Export-result-failed-when-sql-with-commen.patch, error.PNG > > > \-- query trans_id > select trans_id from kylin_sales > sql like this above,execute success,export failed,please refer to error.PNG -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3103) Export result failed when sql with comments
[ https://issues.apache.org/jira/browse/KYLIN-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290573#comment-16290573 ] Shaofeng SHI commented on KYLIN-3103: - How about other comment formats like "/* */"? > Export result failed when sql with comments > --- > > Key: KYLIN-3103 > URL: https://issues.apache.org/jira/browse/KYLIN-3103 > Project: Kylin > Issue Type: Bug >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3103-Export-result-failed-when-sql-with-commen.patch, error.PNG > > > \-- query trans_id > select trans_id from kylin_sales > sql like this above,execute success,export failed,please refer to error.PNG -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3103) Export result failed when sql with comments
[ https://issues.apache.org/jira/browse/KYLIN-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290420#comment-16290420 ] peng.jianhua commented on KYLIN-3103: - Hi,[~Zhixiong Chen],if the sql like following: -- query trans_id select trans_id from kylin_sales The old code will convert '\n' to space,so the sql will become "-- query trans_id select trans_id from kylin_sales" when we export the result. Therefore，we can't download the result. > Export result failed when sql with comments > --- > > Key: KYLIN-3103 > URL: https://issues.apache.org/jira/browse/KYLIN-3103 > Project: Kylin > Issue Type: Bug >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3103-Export-result-failed-when-sql-with-commen.patch, error.PNG > > > \-- query trans_id > select trans_id from kylin_sales > sql like this above,execute success,export failed,please refer to error.PNG -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KYLIN-3103) Export result failed when sql with comments
[ https://issues.apache.org/jira/browse/KYLIN-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290302#comment-16290302 ] Zhixiong Chen commented on KYLIN-3103: -- Hi,[~peng.jianhua] The old code work for me. Could you provide more detail about it. > Export result failed when sql with comments > --- > > Key: KYLIN-3103 > URL: https://issues.apache.org/jira/browse/KYLIN-3103 > Project: Kylin > Issue Type: Bug >Reporter: peng.jianhua >Assignee: peng.jianhua > Attachments: > 0001-KYLIN-3103-Export-result-failed-when-sql-with-commen.patch, error.PNG > > > \-- query trans_id > select trans_id from kylin_sales > sql like this above,execute success,export failed,please refer to error.PNG -- This message was sent by Atlassian JIRA (v6.4.14#64029)
