[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-12-05 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711088#comment-16711088
 ] 

ASF subversion and git services commented on KYLIN-3187:


Commit 09851df665c38d4c30d3611808382baf1648d239 in kylin's branch 
refs/heads/2.5.x-hadoop3.1 from etherge
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=09851df ]

KYLIN-3187 Forbid calls to JDK APIs that use the default locale


> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Major
>  Labels: usability
> Fix For: v2.5.2
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-11-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704618#comment-16704618
 ] 

ASF subversion and git services commented on KYLIN-3187:


Commit 09851df665c38d4c30d3611808382baf1648d239 in kylin's branch 
refs/heads/2.5.x from etherge
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=09851df ]

KYLIN-3187 Forbid calls to JDK APIs that use the default locale


> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Major
>  Labels: usability
> Fix For: v2.6.0
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704612#comment-16704612
 ] 

ASF GitHub Bot commented on KYLIN-3187:
---

hit-lacus commented on issue #368: KYLIN-3187 Forbid calls to JDK APIs that use 
the default locale
URL: https://github.com/apache/kylin/pull/368#issuecomment-443176896
 
 
   ```sql
   select uid, act_type, count(*)  as cnt
   from useraction as ua 
   where act_type > '播放'
   group by uid, act_type
   order by uid, act_type;
   
   ```
   
   This sql query result is correct compare Kylin with Hive.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Major
>  Labels: usability
> Fix For: v2.6.0
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704544#comment-16704544
 ] 

ASF GitHub Bot commented on KYLIN-3187:
---

asfgit commented on issue #368: KYLIN-3187 Forbid calls to JDK APIs that use 
the default locale
URL: https://github.com/apache/kylin/pull/368#issuecomment-443161048
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Major
>  Labels: usability
> Fix For: v2.6.0
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704543#comment-16704543
 ] 

ASF GitHub Bot commented on KYLIN-3187:
---

hit-lacus opened a new pull request #368: KYLIN-3187 Forbid calls to JDK APIs 
that use the default locale
URL: https://github.com/apache/kylin/pull/368
 
 
   Fix encode bugs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Major
>  Labels: usability
> Fix For: v2.6.0
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-09-02 Thread Shaofeng SHI (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601730#comment-16601730
 ] 

Shaofeng SHI commented on KYLIN-3187:
-

Merged in master and passed integration test. As this commit changed too many 
files, to be safe we will stage it for a while, the on-going 2.5.0 will not 
include the change. Target release version is 2.6.0

> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Major
>  Labels: usability
> Fix For: v2.5.0
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-08-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598737#comment-16598737
 ] 

ASF GitHub Bot commented on KYLIN-3187:
---

etherge commented on issue #217: KYLIN-3187 Forbid calls to JDK APIs that use 
the default locale, time…
URL: https://github.com/apache/kylin/pull/217#issuecomment-417666948
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Major
>  Labels: usability
> Fix For: v2.5.0
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-08-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598220#comment-16598220
 ] 

ASF GitHub Bot commented on KYLIN-3187:
---

asfgit commented on issue #217: KYLIN-3187 Forbid calls to JDK APIs that use 
the default locale, time…
URL: https://github.com/apache/kylin/pull/217#issuecomment-417546376
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>  Components: REST Service
>Reporter: Ted Yu
>Assignee:  Kaige Liu
>Priority: Major
>  Labels: usability
> Fix For: v2.5.0
>
>
> Here are a few examples:
> {code}
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> {code}
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3187) JDK APIs using the default locale, time zone or character set should be avoided

2018-01-23 Thread Billy Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336931#comment-16336931
 ] 

Billy Liu commented on KYLIN-3187:
--

+1

> JDK APIs using the default locale, time zone or character set should be 
> avoided
> ---
>
> Key: KYLIN-3187
> URL: https://issues.apache.org/jira/browse/KYLIN-3187
> Project: Kylin
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Major
>
> Here are a few examples:
> server-base/src/main/java/org/apache/kylin/rest/service/JobService.java:  
>   Calendar calendar = Calendar.getInstance();
> storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/HbaseStreamingInput.java:
> Calendar cal = Calendar.getInstance();
> Locale should be specified.
> See CALCITE-1667 for related information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)