[jira] [Commented] (KYLIN-3243) Optimize the code and keep the code consistent in the access.html

2018-02-06 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353725#comment-16353725
 ] 

Zhixiong Chen commented on KYLIN-3243:
--

OK, Thanks.

I will merge it into Kylin master.

> Optimize the code and keep the code consistent in the access.html
> -
>
> Key: KYLIN-3243
> URL: https://issues.apache.org/jira/browse/KYLIN-3243
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Trivial
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3243.patch
>
>
> Using "$rootScope.permissions.xxx.mask" instead of figure will be more uniform



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3243) Optimize the code and keep the code consistent in the access.html

2018-02-06 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353584#comment-16353584
 ] 

Zhixiong Chen commented on KYLIN-3243:
--

Hi,[~xingpeng1]

Could you check other pages to use permissions.xxx.mask instead of figure ?

> Optimize the code and keep the code consistent in the access.html
> -
>
> Key: KYLIN-3243
> URL: https://issues.apache.org/jira/browse/KYLIN-3243
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Peng Xing
>Assignee: Peng Xing
>Priority: Trivial
> Fix For: v2.3.0
>
> Attachments: 0001-KYLIN-3243.patch
>
>
> Using "$rootScope.permissions.xxx.mask" instead of figure will be more uniform



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)