[jira] [Commented] (KYLIN-3364) Make the behavior of BigDecimalSumAggregator consistent with hive

[liyang (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507223#comment-16507223
 ] 

liyang commented on KYLIN-3364:
---

This is fine, given we are aware that all aggregators must have consistent 
behavior in the end.

> Make the behavior of BigDecimalSumAggregator consistent with hive
> -
>
> Key: KYLIN-3364
> URL: https://issues.apache.org/jira/browse/KYLIN-3364
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Fix For: v2.4.0
>
> Attachments: KYLIN-3364.patch
>
>
> When aggregating on a sequence of BigDecimal values, if all values are null, 
> the result should be null. Otherwise, null should be regarded as 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3364) Make the behavior of BigDecimalSumAggregator consistent with hive

[Zhong Yanghong (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493041#comment-16493041
 ] 

Zhong Yanghong commented on KYLIN-3364:
---

Here, this patch is mainly for sum(case when). If no else in the case when 
expression, exception will happen without this patch. If other aggregators have 
the same issue, we may create other JIRAs.

> Make the behavior of BigDecimalSumAggregator consistent with hive
> -
>
> Key: KYLIN-3364
> URL: https://issues.apache.org/jira/browse/KYLIN-3364
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Attachments: KYLIN-3364.patch
>
>
> When aggregating on a sequence of BigDecimal values, if all values are null, 
> the result should be null. Otherwise, null should be regarded as 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3364) Make the behavior of BigDecimalSumAggregator consistent with hive

[liyang (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493008#comment-16493008
 ] 

liyang commented on KYLIN-3364:
---

Besides BigDecimalSumAggregator, other aggregators have the same issue I think.

Also at value ingestion time of MeasureType, the NULL value is already replaced 
by 0... so we still need a more complete solution of handling NULLs.

> Make the behavior of BigDecimalSumAggregator consistent with hive
> -
>
> Key: KYLIN-3364
> URL: https://issues.apache.org/jira/browse/KYLIN-3364
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Attachments: KYLIN-3364.patch
>
>
> When aggregating on a sequence of BigDecimal values, if all values are null, 
> the result should be null. Otherwise, null should be regarded as 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KYLIN-3364) Make the behavior of BigDecimalSumAggregator consistent with hive

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480428#comment-16480428
 ] 

ASF subversion and git services commented on KYLIN-3364:


Commit 1c89fe242fe6b6f296bb652acdfcc065d7761c4c in kylin's branch 
refs/heads/KYLIN-3359 from Zhong
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=1c89fe2 ]

KYLIN-3364 make it consistent with hive for BigDecimalSumAggregator dealing 
with null

Signed-off-by: shaofengshi 


> Make the behavior of BigDecimalSumAggregator consistent with hive
> -
>
> Key: KYLIN-3364
> URL: https://issues.apache.org/jira/browse/KYLIN-3364
> Project: Kylin
>  Issue Type: Sub-task
>Reporter: Zhong Yanghong
>Assignee: Zhong Yanghong
>Priority: Major
> Attachments: KYLIN-3364.patch
>
>
> When aggregating on a sequence of BigDecimal values, if all values are null, 
> the result should be null. Otherwise, null should be regarded as 0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)