[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669788#comment-16669788 ] Na Zhai commented on KYLIN-3565: I verified this, it works now. > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: Roger >Priority: Minor > Labels: usability > Fix For: v2.5.1 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625501#comment-16625501 ] ASF subversion and git services commented on KYLIN-3565: Commit aee4b57ece21ad1bd5f33efd23feb79542235d91 in kylin's branch refs/heads/update_travis_maven from Emiya0306 [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=aee4b57 ] KYLIN-3565 User login error message is inaccurate > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: Roger >Priority: Minor > Labels: usability > Fix For: v2.5.1 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620133#comment-16620133 ] ASF subversion and git services commented on KYLIN-3565: Commit b62b457a595c8201381c373764e370363bb6994b in kylin's branch refs/heads/2.5.x from Emiya0306 [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=b62b457 ] KYLIN-3565 User login error message is inaccurate > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: Roger >Priority: Minor > Labels: usability > Fix For: v2.5.1 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620106#comment-16620106 ] Marc Wu commented on KYLIN-3565: Thanks a lot! That would be helpful. > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: XiaoXiang Yu >Priority: Minor > Labels: usability > Fix For: v2.6.0 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620091#comment-16620091 ] XiaoXiang Yu commented on KYLIN-3565: - When a RuntimeExecption was thrown, the status code of response is 500(server error). But when authentication failed, the status code is 401(unauthorized). So the front end will show different msg according to status code. > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: XiaoXiang Yu >Priority: Minor > Labels: usability > Fix For: v2.6.0 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[
https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620043#comment-16620043
]
ASF GitHub Bot commented on KYLIN-3565:
---
luguosheng1314 closed pull request #238: KYLIN-3565 User login error message is
inaccurate
URL: https://github.com/apache/kylin/pull/238
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/webapp/app/js/controllers/auth.js
b/webapp/app/js/controllers/auth.js
index 6e5fa30d56..949093ee4e 100644
--- a/webapp/app/js/controllers/auth.js
+++ b/webapp/app/js/controllers/auth.js
@@ -36,7 +36,9 @@ KylinApp.controller('LoginCtrl', function ($scope,
$rootScope, $location, $base6
$location.path(UserService.getHomePage());
}, function (error) {
$scope.loading = false;
- $scope.error = "Unable to login, please check your username/password.";
+ $scope.error = error.status < 500
+? "Unable to login, please check your username/password."
+: "System error, please contact your administrator.";
});
};
});
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> User login error message is inaccurate
> --
>
> Key: KYLIN-3565
> URL: https://issues.apache.org/jira/browse/KYLIN-3565
> Project: Kylin
> Issue Type: Bug
> Components: REST Service, Web
>Affects Versions: v2.4.1
> Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456
>Reporter: Marc Wu
>Assignee: XiaoXiang Yu
>Priority: Minor
> Labels: usability
> Fix For: v2.6.0
>
> Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png,
> 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png,
> image-2018-09-17-20-25-54-896.png
>
>
> Hi Kylin team,
>
> We found one issue when log in Kylin. The error message will misunderstood
> user.
>
> I couldn't log in Kylin even I input correct username & password (enable
> LDAP).
> So I checked the log on server, it showed me that there exist HBase
> connection issues.
> Root cause is that the HBase server which Kylin used as metadata server is
> down, but the login message showed me that I should check my username or
> password. It's really confusing.
> Then I read some source codes about login module, and found out Kylin shares
> the same error message for different cases.
>
> We suggested two options:
> # redirect to global error page when HBase connection fail after login,
> shows error message(e.g. System Error, please contact system administrator).
> # enhance the error code for login logic, make the error message more
> specific.
>
> There are login error message and the log. And I log in successfully after
> recover HBase servers.
> !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620044#comment-16620044 ] ASF subversion and git services commented on KYLIN-3565: Commit aee4b57ece21ad1bd5f33efd23feb79542235d91 in kylin's branch refs/heads/master from Emiya0306 [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=aee4b57 ] KYLIN-3565 User login error message is inaccurate > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: XiaoXiang Yu >Priority: Minor > Labels: usability > Fix For: v2.6.0 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620015#comment-16620015 ] ASF GitHub Bot commented on KYLIN-3565: --- asfgit commented on issue #238: KYLIN-3565 User login error message is inaccurate URL: https://github.com/apache/kylin/pull/238#issuecomment-422632052 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: XiaoXiang Yu >Priority: Minor > Labels: usability > Fix For: v2.6.0 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620016#comment-16620016 ] ASF GitHub Bot commented on KYLIN-3565: --- asfgit commented on issue #238: KYLIN-3565 User login error message is inaccurate URL: https://github.com/apache/kylin/pull/238#issuecomment-422632054 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: XiaoXiang Yu >Priority: Minor > Labels: usability > Fix For: v2.6.0 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620014#comment-16620014 ] ASF GitHub Bot commented on KYLIN-3565: --- Emiya0306 opened a new pull request #238: KYLIN-3565 User login error message is inaccurate URL: https://github.com/apache/kylin/pull/238 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: XiaoXiang Yu >Priority: Minor > Labels: usability > Fix For: v2.6.0 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3565) User login error message is inaccurate
[ https://issues.apache.org/jira/browse/KYLIN-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618524#comment-16618524 ] Shaofeng SHI commented on KYLIN-3565: - Xiaoxiang, go ahead! > User login error message is inaccurate > -- > > Key: KYLIN-3565 > URL: https://issues.apache.org/jira/browse/KYLIN-3565 > Project: Kylin > Issue Type: Bug > Components: REST Service, Web >Affects Versions: v2.4.1 > Environment: CentOS 6.7, HBase 1.2.0+cdh5.14.2+456 >Reporter: Marc Wu >Assignee: XiaoXiang Yu >Priority: Minor > Labels: usability > Fix For: v2.6.0 > > Attachments: 2018-09-17_16-56-12.png, 2018-09-17_16-56-38.png, > 2018-09-17_16-59-31.png, image-2018-09-17-20-22-20-294.png, > image-2018-09-17-20-25-54-896.png > > > Hi Kylin team, > > We found one issue when log in Kylin. The error message will misunderstood > user. > > I couldn't log in Kylin even I input correct username & password (enable > LDAP). > So I checked the log on server, it showed me that there exist HBase > connection issues. > Root cause is that the HBase server which Kylin used as metadata server is > down, but the login message showed me that I should check my username or > password. It's really confusing. > Then I read some source codes about login module, and found out Kylin shares > the same error message for different cases. > > We suggested two options: > # redirect to global error page when HBase connection fail after login, > shows error message(e.g. System Error, please contact system administrator). > # enhance the error code for login logic, make the error message more > specific. > > There are login error message and the log. And I log in successfully after > recover HBase servers. > !image-2018-09-17-20-25-54-896.png!!image-2018-09-17-20-22-20-294.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
