[jira] [Commented] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633159#comment-16633159 ] ASF GitHub Bot commented on KYLIN-3602: --- shaofengshi closed pull request #277: KYLIN-3602 Enable more checkstyle rules URL: https://github.com/apache/kylin/pull/277 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/dev-support/checkstyle-suppressions.xml b/dev-support/checkstyle-suppressions.xml index 06de62554f..f110b7c3ef 100644 --- a/dev-support/checkstyle-suppressions.xml +++ b/dev-support/checkstyle-suppressions.xml @@ -25,4 +25,40 @@ + + + + + + + + + + + + + + + + + + + + + + + diff --git a/dev-support/checkstyle.xml b/dev-support/checkstyle.xml index 45325bf950..d8eb73fc89 100644 --- a/dev-support/checkstyle.xml +++ b/dev-support/checkstyle.xml @@ -28,11 +28,31 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin are too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633160#comment-16633160 ] ASF subversion and git services commented on KYLIN-3602: Commit f42e937a2e968f94d8484f7bdafa7a86903eaa58 in kylin's branch refs/heads/master from [~yichen.zhou] [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=f42e937 ] KYLIN-3602 Enable more checkstyle rules > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin are too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633007#comment-16633007 ] ASF GitHub Bot commented on KYLIN-3602: --- codecov-io commented on issue #277: KYLIN-3602 Enable more checkstyle rules URL: https://github.com/apache/kylin/pull/277#issuecomment-425644108 # [Codecov](https://codecov.io/gh/apache/kylin/pull/277?src=pr=h1) Report > Merging [#277](https://codecov.io/gh/apache/kylin/pull/277?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/bd8961c884cdc8ec5a9903a1d5a317bb626a2dff?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/277?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #277 +/- ## + Coverage 21.14% 21.15% +0.01% - Complexity 4405 4406 +1 Files 1086 1086 Lines 6980269802 Branches 1011010110 + Hits 1475914768 +9 + Misses5364253637 -5 + Partials 1401 1397 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/277?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/277/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.6%)` | `7% <0%> (ø)` | :arrow_down: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/277/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/277/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/277/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `78.37% <0%> (+5.4%)` | `6% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/277?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/277?src=pr=footer). Last update [bd8961c...fefc0ec](https://codecov.io/gh/apache/kylin/pull/277?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin are too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633006#comment-16633006 ] ASF GitHub Bot commented on KYLIN-3602: --- coveralls commented on issue #277: KYLIN-3602 Enable more checkstyle rules URL: https://github.com/apache/kylin/pull/277#issuecomment-425644083 ## Pull Request Test Coverage Report for [Build 3719](https://coveralls.io/builds/19261940) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.007%**) to **23.161%** --- | Totals | [](https://coveralls.io/builds/19261940) | | :-- | --: | | Change from base [Build 3717](https://coveralls.io/builds/19261333): | 0.007% | | Covered Lines: | 16167 | | Relevant Lines: | 69802 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin are too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632993#comment-16632993 ] ASF GitHub Bot commented on KYLIN-3602: --- ZhouYC627 opened a new pull request #277: KYLIN-3602 Enable more checkstyle rules URL: https://github.com/apache/kylin/pull/277 Enable more checkstyle rules and suppress the checkstyle errors of old files in _dev-support/checkstyle-suppressions.xml_ https://issues.apache.org/jira/browse/KYLIN-3602 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin are too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632994#comment-16632994 ] ASF GitHub Bot commented on KYLIN-3602: --- asfgit commented on issue #277: KYLIN-3602 Enable more checkstyle rules URL: https://github.com/apache/kylin/pull/277#issuecomment-425642269 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin are too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631917#comment-16631917 ] Billy Liu commented on KYLIN-3602: -- I think we could enable the Google error-prone also. > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin is too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3602) Enable more checkstyle rules
[ https://issues.apache.org/jira/browse/KYLIN-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631825#comment-16631825 ] Shaofeng SHI commented on KYLIN-3602: - +1 > Enable more checkstyle rules > > > Key: KYLIN-3602 > URL: https://issues.apache.org/jira/browse/KYLIN-3602 > Project: Kylin > Issue Type: Improvement > Components: Others >Reporter: Yichen Zhou >Priority: Major > Fix For: v2.6.0 > > Attachments: checkstyle-aggregate.html > > > The checkstyle rules of kylin is too weak. We need to reinfore them to > achieve better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
