[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-26 Thread Zhong Yanghong (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729259#comment-16729259
 ] 

Zhong Yanghong commented on KYLIN-3628:
---

[~Na Zhai], thanks for your patch. PR has been merged and I'll mark this as 
Resolved.

> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, there is no mechanism to choose which 
> cube being used. So it maybe gets the error result. I have an idea, choose 
> the latest cube to answer the query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728902#comment-16728902
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

shaofengshi commented on pull request #359: KYLIN-3628 The wrong result when a 
query with one lookup table
URL: https://github.com/apache/kylin/pull/359
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, there is no mechanism to choose which 
> cube being used. So it maybe gets the error result. I have an idea, choose 
> the latest cube to answer the query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-25 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728903#comment-16728903
 ] 

ASF subversion and git services commented on KYLIN-3628:


Commit e3896af23471672ae0b1b4a5aa2053eda3079175 in kylin's branch 
refs/heads/master from GinaZhai
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=e3896af ]

KYLIN-3628 The wrong result when a query with one lookup table


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, there is no mechanism to choose which 
> cube being used. So it maybe gets the error result. I have an idea, choose 
> the latest cube to answer the query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-25 Thread Na Zhai (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728858#comment-16728858
 ] 

Na Zhai commented on KYLIN-3628:


Hi [~yaho] , when two cubes meet the query, I will choose the latest one. I 
have modified my PR according to Shaofeng Shi comment.

> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, there is no mechanism to choose which 
> cube being used. So it maybe gets the error result. I have an idea, choose 
> the latest cube to answer the query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-24 Thread Zhong Yanghong (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728247#comment-16728247
 ] 

Zhong Yanghong commented on KYLIN-3628:
---

Hi [~Na Zhai], could you explain more details about your solution for this 
issue? And what's the status of the PR now?

> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713908#comment-16713908
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

coveralls edited a comment on issue #359: KYLIN-3628 The wrong result when a 
query with one lookup table
URL: https://github.com/apache/kylin/pull/359#issuecomment-441255939
 
 
   ## Pull Request Test Coverage Report for [Build 
3931](https://coveralls.io/builds/20531775)
   
   * **0** of **37**   **(0.0%)**  changed or added relevant lines in **2** 
files are covered.
   * **8** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **25.925%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[query/src/main/java/org/apache/kylin/query/enumerator/LookupTableEnumerator.java](https://coveralls.io/builds/20531775/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Fenumerator%2FLookupTableEnumerator.java#L57)
 | 0 | 9 | 0.0%
   | 
[core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/20531775/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L1173)
 | 0 | 28 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/20531775/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319)
 | 1 | 81.08% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/20531775/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20531775/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/20531775/badge)](https://coveralls.io/builds/20531775)
 |
   | :-- | --: |
   | Change from base [Build 3929](https://coveralls.io/builds/20530205): |  
-0.02% |
   | Covered Lines: | 17690 |
   | Relevant Lines: | 68235 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713907#comment-16713907
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

codecov-io commented on issue #359: KYLIN-3628 The wrong result when a query 
with one lookup table
URL: https://github.com/apache/kylin/pull/359#issuecomment-445522483
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr=h1) Report
   > Merging [#359](https://codecov.io/gh/apache/kylin/pull/359?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/39878baa405385e850820838f86fcfe56a10b0ca?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/359/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/359?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #359  +/-   ##
   
   - Coverage 23.64%   23.62%   -0.02% 
   - Complexity 4839 4840   +1 
   
 Files  1131 1131  
 Lines 6820068235  +35 
 Branches   9685 9692   +7 
   
   - Hits  1612316122   -1 
   - Misses5050950545  +36 
 Partials   1568 1568
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/359?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../main/java/org/apache/kylin/cube/CubeInstance.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVJbnN0YW5jZS5qYXZh)
 | `37.9% <0%> (ø)` | `50 <0> (ø)` | :arrow_down: |
   | 
[...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=)
 | `38.47% <0%> (-1.92%)` | `44 <0> (ø)` | |
   | 
[.../kylin/query/enumerator/LookupTableEnumerator.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L2VudW1lcmF0b3IvTG9va3VwVGFibGVFbnVtZXJhdG9yLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
   | 
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/359/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
 | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/359?src=pr=footer). Last 
update 
[39878ba...a8cbcde](https://codecov.io/gh/apache/kylin/pull/359?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-09 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713906#comment-16713906
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

coveralls edited a comment on issue #359: KYLIN-3628 The wrong result when a 
query with one lookup table
URL: https://github.com/apache/kylin/pull/359#issuecomment-441255939
 
 
   ## Pull Request Test Coverage Report for [Build 
3930](https://coveralls.io/builds/20531736)
   
   * **0** of **37**   **(0.0%)**  changed or added relevant lines in **2** 
files are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.01%**) to **25.931%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[query/src/main/java/org/apache/kylin/query/enumerator/LookupTableEnumerator.java](https://coveralls.io/builds/20531736/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Fenumerator%2FLookupTableEnumerator.java#L57)
 | 0 | 9 | 0.0%
   | 
[core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/20531736/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L1173)
 | 0 | 28 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20531736/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/20531736/badge)](https://coveralls.io/builds/20531736)
 |
   | :-- | --: |
   | Change from base [Build 3929](https://coveralls.io/builds/20530205): |  
-0.01% |
   | Covered Lines: | 17694 |
   | Relevant Lines: | 68235 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712231#comment-16712231
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong 
result when a query with one lookup table
URL: https://github.com/apache/kylin/pull/359#discussion_r239673151
 
 

 ##
 File path: core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java
 ##
 @@ -717,4 +724,51 @@ public static CubeSegment findSegmentWithJobId(String 
jobID, CubeInstance cubeIn
 throw new IllegalStateException("No segment's last build job ID equals 
" + jobID);
 }
 
+public CubeInstance findLastSnapshot(List 
realizationEntries, String lookupTableName) {
+if (realizationEntries.size() > 0) {
+List realizationList = Lists.newArrayList();
+RealizationRegistry registry = 
RealizationRegistry.getInstance(config);
+for (int i = 0; i < realizationEntries.size(); i++) {
+IRealization realization = 
registry.getRealization(realizationEntries.get(i).getType(), 
realizationEntries.get(i).getRealization());
+if (realization == null) {
+logger.error("Realization '" + realizationEntries.get(i) + 
" is not found '" + this.getName() + "'");
+continue;
+}
+if (realization.isReady() == false) {
+logger.error("Realization '" + realization.getName() + " 
is disabled '" + this.getName() + "'");
 
 Review comment:
   This is not an error, should not be error level.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-12-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712225#comment-16712225
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

shaofengshi commented on a change in pull request #359: KYLIN-3628 The wrong 
result when a query with one lookup table
URL: https://github.com/apache/kylin/pull/359#discussion_r239672844
 
 

 ##
 File path: core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java
 ##
 @@ -77,6 +82,8 @@
 public static final int COST_WEIGHT_DIMENSION = 10;
 public static final int COST_WEIGHT_INNER_JOIN = 100;
 
+private volatile IRealization[] realizations = null;
 
 Review comment:
   This is not needed. Please narrow down the scope of a variable as much as 
possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-11-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697210#comment-16697210
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

coveralls commented on issue #359: KYLIN-3628 The wrong result when a query 
with one lookup table
URL: https://github.com/apache/kylin/pull/359#issuecomment-441255939
 
 
   ## Pull Request Test Coverage Report for [Build 
3879](https://coveralls.io/builds/20260836)
   
   * **1** of **43**   **(2.33%)**  changed or added relevant lines in **2** 
files are covered.
   * **7** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **25.896%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[query/src/main/java/org/apache/kylin/query/enumerator/LookupTableEnumerator.java](https://coveralls.io/builds/20260836/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Fenumerator%2FLookupTableEnumerator.java#L57)
 | 0 | 7 | 0.0%
   | 
[core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/20260836/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L728)
 | 1 | 36 | 2.78%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/20260836/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72)
 | 1 | 47.62% |
   | 
[core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/20260836/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319)
 | 1 | 81.08% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/20260836/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/20260836/badge)](https://coveralls.io/builds/20260836)
 |
   | :-- | --: |
   | Change from base [Build 3871](https://coveralls.io/builds/20236865): |  
-0.02% |
   | Covered Lines: | 17647 |
   | Relevant Lines: | 68145 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-11-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697182#comment-16697182
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

asfgit commented on issue #359: KYLIN-3628 The wrong result when a query with 
one lookup table
URL: https://github.com/apache/kylin/pull/359#issuecomment-441250502
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3628) The wrong result when a query with one lookup table

2018-11-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697181#comment-16697181
 ] 

ASF GitHub Bot commented on KYLIN-3628:
---

GinaZhai opened a new pull request #359: KYLIN-3628 The wrong result when a 
query with one lookup table
URL: https://github.com/apache/kylin/pull/359
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The wrong result when a query with one lookup table
> ---
>
> Key: KYLIN-3628
> URL: https://issues.apache.org/jira/browse/KYLIN-3628
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v2.6.0
>
>
> Two cubes use the same lookup table, and then the lookup table data in Hive 
> changes. One of Kylin's cubes builds the new data, and the other doesn't. 
> When Kylin queries the lookup table, the data gets confused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)