[jira] [Commented] (KYLIN-4113) Remove the surplus allCubes field
[
https://issues.apache.org/jira/browse/KYLIN-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898854#comment-16898854
]
ASF GitHub Bot commented on KYLIN-4113:
---
nichunen commented on pull request #780: KYLIN-4113 Remove the surplus
allCubes field
URL: https://github.com/apache/kylin/pull/780
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove the surplus allCubes field
> -
>
> Key: KYLIN-4113
> URL: https://issues.apache.org/jira/browse/KYLIN-4113
> Project: Kylin
> Issue Type: Improvement
> Components: Web , Website
>Affects Versions: v2.6.1
> Environment: computery：macOS Mojave 10.14.5
>Reporter: Smile鑫
>Assignee: Smile鑫
>Priority: Major
> Labels: easyfix
> Attachments: image-2019-07-25-15-26-05-703.png,
> image-2019-07-25-15-42-39-130.png
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> After selecting the project-name, it will go to the backend to get the cube
> under the current project, but there will be a request to get all the cubes,
> even if the backend does not succeed in the permission control, but this is
> superfluous. I checked and found that all the cubes were obtained only
> because I need to judge whether there is a cube with the same name when
> editing or creating the cube. This should not be done in the front end, but
> the information is submitted to the back end when the cube is created. A
> unified judgment is made by the back end. Otherwise, there will be a
> situation where the number of cubes that can be viewed by the current
> logged-in user's privilege is limited, so it is not complete to determine
> whether the cube is renamed at the time of creation. This leads to the fact
> that even if the cube with the same name is created, you can see two cubes
> with the same name when you can view all cube users (admin). . .
> The extra code path to get the cube request:
>
> {code:java}
> webapp/app/js/controllers/cubeSchema.js{code}
>
> In this position ：
> !image-2019-07-25-15-42-39-130.png!
>
> This code should not be written directly in the CubeSchemaCtrl controller,
> otherwise it will trigger the execution of this code when a page references
> the controller, and there is a case of repeated request to initiate the
> request. I don't know why. Perhaps it is because the other properties or
> methods under this controller change to trigger the execution of this code.
>
> I pass the check backend
>
> {code:java}
> server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java{code}
> The file found that there is a ready-made check interface, and I don't know
> why it is not connected. I refer it to the front end for the request and
> delete the other redundant code.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (KYLIN-4113) Remove the surplus allCubes field
[
https://issues.apache.org/jira/browse/KYLIN-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898849#comment-16898849
]
ASF GitHub Bot commented on KYLIN-4113:
---
luguosheng1314 commented on pull request #782: KYLIN-4113 Remove the surplus
allCubes field & optimize the request to get the cube name
URL: https://github.com/apache/kylin/pull/782
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove the surplus allCubes field
> -
>
> Key: KYLIN-4113
> URL: https://issues.apache.org/jira/browse/KYLIN-4113
> Project: Kylin
> Issue Type: Improvement
> Components: Web , Website
>Affects Versions: v2.6.1
> Environment: computery：macOS Mojave 10.14.5
>Reporter: Smile鑫
>Assignee: Smile鑫
>Priority: Major
> Labels: easyfix
> Attachments: image-2019-07-25-15-26-05-703.png,
> image-2019-07-25-15-42-39-130.png
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> After selecting the project-name, it will go to the backend to get the cube
> under the current project, but there will be a request to get all the cubes,
> even if the backend does not succeed in the permission control, but this is
> superfluous. I checked and found that all the cubes were obtained only
> because I need to judge whether there is a cube with the same name when
> editing or creating the cube. This should not be done in the front end, but
> the information is submitted to the back end when the cube is created. A
> unified judgment is made by the back end. Otherwise, there will be a
> situation where the number of cubes that can be viewed by the current
> logged-in user's privilege is limited, so it is not complete to determine
> whether the cube is renamed at the time of creation. This leads to the fact
> that even if the cube with the same name is created, you can see two cubes
> with the same name when you can view all cube users (admin). . .
> The extra code path to get the cube request:
>
> {code:java}
> webapp/app/js/controllers/cubeSchema.js{code}
>
> In this position ：
> !image-2019-07-25-15-42-39-130.png!
>
> This code should not be written directly in the CubeSchemaCtrl controller,
> otherwise it will trigger the execution of this code when a page references
> the controller, and there is a case of repeated request to initiate the
> request. I don't know why. Perhaps it is because the other properties or
> methods under this controller change to trigger the execution of this code.
>
> I pass the check backend
>
> {code:java}
> server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java{code}
> The file found that there is a ready-made check interface, and I don't know
> why it is not connected. I refer it to the front end for the request and
> delete the other redundant code.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (KYLIN-4113) Remove the surplus allCubes field
[
https://issues.apache.org/jira/browse/KYLIN-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896615#comment-16896615
]
Shaofeng SHI commented on KYLIN-4113:
-
The PR is [https://github.com/apache/kylin/pull/780]
[~bob123] guosheng, can you help to reviwe this? Thanks!
> Remove the surplus allCubes field
> -
>
> Key: KYLIN-4113
> URL: https://issues.apache.org/jira/browse/KYLIN-4113
> Project: Kylin
> Issue Type: Improvement
> Components: Web , Website
>Affects Versions: v2.6.1
> Environment: computery：macOS Mojave 10.14.5
>Reporter: 陈伟双
>Assignee: 陈伟双
>Priority: Major
> Labels: easyfix
> Attachments: image-2019-07-25-15-26-05-703.png,
> image-2019-07-25-15-42-39-130.png
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> After selecting the project-name, it will go to the backend to get the cube
> under the current project, but there will be a request to get all the cubes,
> even if the backend does not succeed in the permission control, but this is
> superfluous. I checked and found that all the cubes were obtained only
> because I need to judge whether there is a cube with the same name when
> editing or creating the cube. This should not be done in the front end, but
> the information is submitted to the back end when the cube is created. A
> unified judgment is made by the back end. Otherwise, there will be a
> situation where the number of cubes that can be viewed by the current
> logged-in user's privilege is limited, so it is not complete to determine
> whether the cube is renamed at the time of creation. This leads to the fact
> that even if the cube with the same name is created, you can see two cubes
> with the same name when you can view all cube users (admin). . .
> The extra code path to get the cube request:
>
> {code:java}
> webapp/app/js/controllers/cubeSchema.js{code}
>
> In this position ：
> !image-2019-07-25-15-42-39-130.png!
>
> This code should not be written directly in the CubeSchemaCtrl controller,
> otherwise it will trigger the execution of this code when a page references
> the controller, and there is a case of repeated request to initiate the
> request. I don't know why. Perhaps it is because the other properties or
> methods under this controller change to trigger the execution of this code.
>
> I pass the check backend
>
> {code:java}
> server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java{code}
> The file found that there is a ready-made check interface, and I don't know
> why it is not connected. I refer it to the front end for the request and
> delete the other redundant code.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
