[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212839#comment-17212839 ] ASF GitHub Bot commented on KYLIN-4508: --- hit-lacus commented on pull request #1446: URL: https://github.com/apache/kylin/pull/1446#issuecomment-707501290 Can not resolve `org.apache.hadoop.hdfs.DistributedFileSystem` . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212840#comment-17212840 ] ASF subversion and git services commented on KYLIN-4508: Commit d8af2c8385535f804009bbbca1f618918de71702 in kylin's branch refs/heads/master-hadoop3 from Xiaoxiang Yu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=d8af2c8 ] Revert "KYLIN-4508 Add unit test for core-metrics module & reporters" This reverts commit 8d894e2c8098a41d3778933cc93484a2c5f582e3. > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212841#comment-17212841 ] ASF GitHub Bot commented on KYLIN-4508: --- hit-lacus merged pull request #1446: URL: https://github.com/apache/kylin/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212838#comment-17212838 ] ASF GitHub Bot commented on KYLIN-4508: --- hit-lacus opened a new pull request #1446: URL: https://github.com/apache/kylin/pull/1446 This reverts commit 8d894e2c8098a41d3778933cc93484a2c5f582e3. ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151490#comment-17151490 ] ASF subversion and git services commented on KYLIN-4508: Commit a70707f3b77d005aa54a5779c45eeb1ae6191070 in kylin's branch refs/heads/master from Zhong, Yanghong [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a70707f ] KYLIN-4508 Add unit test for core-metrics module & reporters > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151489#comment-17151489 ] ASF GitHub Bot commented on KYLIN-4508: --- hit-lacus merged pull request #1276: URL: https://github.com/apache/kylin/pull/1276 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151488#comment-17151488 ] ASF GitHub Bot commented on KYLIN-4508: --- hit-lacus commented on pull request #1276: URL: https://github.com/apache/kylin/pull/1276#issuecomment-653848602 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140405#comment-17140405 ] ASF GitHub Bot commented on KYLIN-4508: --- coveralls edited a comment on pull request #1276: URL: https://github.com/apache/kylin/pull/1276#issuecomment-646507925 ## Pull Request Test Coverage Report for [Build 6047](https://coveralls.io/builds/31558459) * **45** of **57** **(78.95%)** changed or added relevant lines in **6** files are covered. * **7** unchanged lines in **4** files lost coverage. * Overall coverage increased (+**0.1%**) to **28.094%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [metrics-reporter-hive/src/main/java/org/apache/kylin/metrics/lib/impl/hive/HiveProducerRecord.java](https://coveralls.io/builds/31558459/source?filename=metrics-reporter-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2Fhive%2FHiveProducerRecord.java#L73) | 26 | 30 | 86.67% | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/TimedRecordEvent.java](https://coveralls.io/builds/31558459/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FTimedRecordEvent.java#L49) | 0 | 8 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/31558459/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/31558459/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/31558459/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/31558459/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | Totals | [](https://coveralls.io/builds/31558459) | | :-- | --: | | Change from base [Build 6043](https://coveralls.io/builds/31539724): | 0.1% | | Covered Lines: | 26218 | | Relevant Lines: | 93321 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140402#comment-17140402 ] ASF GitHub Bot commented on KYLIN-4508: --- coveralls edited a comment on pull request #1276: URL: https://github.com/apache/kylin/pull/1276#issuecomment-646507925 ## Pull Request Test Coverage Report for [Build 6046](https://coveralls.io/builds/31558305) * **45** of **57** **(78.95%)** changed or added relevant lines in **6** files are covered. * **5** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.1%**) to **28.098%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [metrics-reporter-hive/src/main/java/org/apache/kylin/metrics/lib/impl/hive/HiveProducerRecord.java](https://coveralls.io/builds/31558305/source?filename=metrics-reporter-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2Fhive%2FHiveProducerRecord.java#L73) | 26 | 30 | 86.67% | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/TimedRecordEvent.java](https://coveralls.io/builds/31558305/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FTimedRecordEvent.java#L49) | 0 | 8 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31558305/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L44) | 1 | 83.33% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/31558305/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/31558305/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | Totals | [](https://coveralls.io/builds/31558305) | | :-- | --: | | Change from base [Build 6043](https://coveralls.io/builds/31539724): | 0.1% | | Covered Lines: | 26221 | | Relevant Lines: | 93321 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140332#comment-17140332 ] ASF GitHub Bot commented on KYLIN-4508: --- coveralls commented on pull request #1276: URL: https://github.com/apache/kylin/pull/1276#issuecomment-646507925 ## Pull Request Test Coverage Report for [Build 6045](https://coveralls.io/builds/31556325) * **45** of **57** **(78.95%)** changed or added relevant lines in **6** files are covered. * **8** unchanged lines in **3** files lost coverage. * Overall coverage increased (+**0.1%**) to **28.101%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [metrics-reporter-hive/src/main/java/org/apache/kylin/metrics/lib/impl/hive/HiveProducerRecord.java](https://coveralls.io/builds/31556325/source?filename=metrics-reporter-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2Fhive%2FHiveProducerRecord.java#L73) | 26 | 30 | 86.67% | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/TimedRecordEvent.java](https://coveralls.io/builds/31556325/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FTimedRecordEvent.java#L49) | 0 | 8 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/31556325/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/31556325/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31556325/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/31556325) | | :-- | --: | | Change from base [Build 6043](https://coveralls.io/builds/31539724): | 0.1% | | Covered Lines: | 26224 | | Relevant Lines: | 93321 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140252#comment-17140252 ] ASF GitHub Bot commented on KYLIN-4508: --- kyotoYaho opened a new pull request #1276: URL: https://github.com/apache/kylin/pull/1276 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > Fix For: v3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114095#comment-17114095 ] ASF GitHub Bot commented on KYLIN-4508: --- shaofengshi commented on pull request #1228: URL: https://github.com/apache/kylin/pull/1228#issuecomment-632722692 Merged by manual. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114096#comment-17114096 ] ASF GitHub Bot commented on KYLIN-4508: --- shaofengshi closed pull request #1228: URL: https://github.com/apache/kylin/pull/1228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114094#comment-17114094 ] ASF subversion and git services commented on KYLIN-4508: Commit e220b9a20c4eae09c8c240c066b730595eb03693 in kylin's branch refs/heads/master from Ma,Gang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=e220b9a ] KYLIN-4508 Add more unit tests for MR module Signed-off-by: shaofengshi > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114093#comment-17114093 ] ASF subversion and git services commented on KYLIN-4508: Commit 2d718c83db2abd91d053b77a44ed4a98648adcdc in kylin's branch refs/heads/master from Zhong, Yanghong [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=2d718c8 ] KYLIN-4508 Add more unit tests for core-metrics module Signed-off-by: shaofengshi > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113851#comment-17113851 ] ASF GitHub Bot commented on KYLIN-4508: --- codecov-commenter commented on pull request #1228: URL: https://github.com/apache/kylin/pull/1228#issuecomment-632572024 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1228?src=pr=h1) Report > Merging [#1228](https://codecov.io/gh/apache/kylin/pull/1228?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **increase** coverage by `1.10%`. > The diff coverage is `56.52%`. [](https://codecov.io/gh/apache/kylin/pull/1228?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1228 +/- ## + Coverage 24.85% 25.96% +1.10% - Complexity 6266 6520 +254 Files 1453 1453 Lines 8922589243 +18 Branches 1245612458 +2 + Hits 2218123173 +992 + Misses6486963810-1059 - Partials 2175 2260 +85 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1228?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/kylin/metrics/lib/impl/RecordEvent.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL1JlY29yZEV2ZW50LmphdmE=) | `72.04% <0.00%> (+72.04%)` | `24.00 <0.00> (+24.00)` | | | [...pache/kylin/metrics/lib/impl/TimePropertyEnum.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL1RpbWVQcm9wZXJ0eUVudW0uamF2YQ==) | `73.68% <ø> (+73.68%)` | `4.00 <0.00> (+4.00)` | | | [...pache/kylin/engine/mr/common/JobInfoConverter.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0pvYkluZm9Db252ZXJ0ZXIuamF2YQ==) | `60.29% <58.33%> (+31.61%)` | `23.00 <0.00> (+2.00)` | | | [...ache/kylin/metrics/lib/impl/BlockingReservoir.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL0Jsb2NraW5nUmVzZXJ2b2lyLmphdmE=) | `53.33% <66.66%> (+53.33%)` | `13.00 <2.00> (+13.00)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | | | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.94% <0.00%> (+0.50%)` | `3.00% <0.00%> (+1.00%)` | | | ... and [35 more](https://codecov.io/gh/apache/kylin/pull/1228/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1228?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø
[jira] [Commented] (KYLIN-4508) Add more unit tests to improve test coverage
[ https://issues.apache.org/jira/browse/KYLIN-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113792#comment-17113792 ] ASF GitHub Bot commented on KYLIN-4508: --- kyotoYaho opened a new pull request #1228: URL: https://github.com/apache/kylin/pull/1228 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add more unit tests to improve test coverage > > > Key: KYLIN-4508 > URL: https://issues.apache.org/jira/browse/KYLIN-4508 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
