[GitHub] [kylin] codecov-io edited a comment on issue #502: KYLIN-3839 Strorage clean up after refreshing and deleting segment

[GitBox]

codecov-io edited a comment on issue #502: KYLIN-3839 Strorage clean up after 
refreshing and deleting segment
URL: https://github.com/apache/kylin/pull/502#issuecomment-470484793
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/502?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@fe43a3e`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/502/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/502?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #502   +/-   ##
   =
 Coverage  ?   24.41%   
 Complexity? 5023   
   =
 Files ? 1161   
 Lines ?70442   
 Branches  ?10018   
   =
 Hits  ?17200   
 Misses?51505   
 Partials  ? 1737
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/502?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...torage/hbase/steps/HBaseSparkOutputTransition.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZVNwYXJrT3V0cHV0VHJhbnNpdGlvbi5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../main/java/org/apache/kylin/cube/CubeInstance.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVJbnN0YW5jZS5qYXZh)
 | `37.85% <0%> (ø)` | `50 <0> (?)` | |
   | 
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
 | `14.06% <0%> (ø)` | `41 <0> (?)` | |
   | 
[...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...che/kylin/storage/hbase/util/StorageCleanUtil.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL1N0b3JhZ2VDbGVhblV0aWwuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...pache/kylin/storage/hbase/steps/HBaseJobSteps.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZUpvYlN0ZXBzLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/502?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/502?src=pr=footer). Last 
update 
[fe43a3e...664167f](https://codecov.io/gh/apache/kylin/pull/502?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #515: KYLIN-3841 Build Global Dict by MR/Hive

[GitBox]

asfgit commented on issue #515: KYLIN-3841 Build Global Dict by MR/Hive
URL: https://github.com/apache/kylin/pull/515#issuecomment-472740917
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #517: KYLIN-3852 Provide Flink binary package download script

[GitBox]

asfgit commented on issue #517: KYLIN-3852 Provide Flink binary package 
download script
URL: https://github.com/apache/kylin/pull/517#issuecomment-472836534
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] yanghua opened a new pull request #517: KYLIN-3852 Provide Flink binary package download script

[GitBox]

yanghua opened a new pull request #517: KYLIN-3852 Provide Flink binary package 
download script
URL: https://github.com/apache/kylin/pull/517
 
 
   JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3852


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #516: KYLIN-3874 "Convert Cuboid Data to HFile" failed when HBase and MR use different HDFS clusters

[GitBox]

codecov-io commented on issue #516: KYLIN-3874 "Convert Cuboid Data to HFile" 
failed when HBase and MR use different HDFS clusters
URL: https://github.com/apache/kylin/pull/516#issuecomment-472811473
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/516?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@d23d2bd`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/516/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/516?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #516   +/-   ##
   =
 Coverage  ?   24.44%   
 Complexity? 5024   
   =
 Files ? 1160   
 Lines ?70390   
 Branches  ?10013   
   =
 Hits  ?17204   
 Misses?51450   
 Partials  ? 1736
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/516?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://codecov.io/gh/apache/kylin/pull/516/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSEZpbGVKb2IuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/516?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/516?src=pr=footer). Last 
update 
[d23d2bd...fd0bc97](https://codecov.io/gh/apache/kylin/pull/516?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #516: KYLIN-3874 "Convert Cuboid Data to HFile" failed when HBase and MR use different HDFS clusters

[GitBox]

asfgit commented on issue #516: KYLIN-3874 "Convert Cuboid Data to HFile" 
failed when HBase and MR use different HDFS clusters
URL: https://github.com/apache/kylin/pull/516#issuecomment-472804056
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #517: KYLIN-3852 Provide Flink binary package download script

[GitBox]

codecov-io commented on issue #517: KYLIN-3852 Provide Flink binary package 
download script
URL: https://github.com/apache/kylin/pull/517#issuecomment-472850098
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/517?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`engine-flink@3e5eda7`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/517/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/517?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ## engine-flink #517   +/-   ##
   ===
 Coverage?   24.27%   
 Complexity  ? 5029   
   ===
 Files   ? 1166   
 Lines   ?70903   
 Branches?10078   
   ===
 Hits?17215   
 Misses  ?51948   
 Partials? 1740
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/517?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/517?src=pr=footer). Last 
update 
[3e5eda7...24c3c03](https://codecov.io/gh/apache/kylin/pull/517?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] guangxuCheng opened a new pull request #516: KYLIN-3874 "Convert Cuboid Data to HFile" failed when HBase and MR use different HDFS clusters

[GitBox]

guangxuCheng opened a new pull request #516: KYLIN-3874 "Convert Cuboid Data to 
HFile" failed when HBase and MR use different HDFS clusters
URL: https://github.com/apache/kylin/pull/516
 
 
   Detail: https://issues.apache.org/jira/browse/KYLIN-3874


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #522: KYLIN-3817: Duration in Cube building is a negative number

[GitBox]

codecov-io commented on issue #522: KYLIN-3817: Duration in Cube building is a 
negative number
URL: https://github.com/apache/kylin/pull/522#issuecomment-473372929
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/522?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@756d582`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/522/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/522?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #522   +/-   ##
   =
 Coverage  ?   24.44%   
 Complexity? 5026   
   =
 Files ? 1160   
 Lines ?70390   
 Branches  ?10013   
   =
 Hits  ?17206   
 Misses?51448   
 Partials  ? 1736
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/522?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/kylin/job/execution/ExecutableManager.java](https://codecov.io/gh/apache/kylin/pull/522/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vRXhlY3V0YWJsZU1hbmFnZXIuamF2YQ==)
 | `33.33% <100%> (ø)` | `35 <0> (?)` | |
   | 
[.../kylin/job/execution/DefaultChainedExecutable.java](https://codecov.io/gh/apache/kylin/pull/522/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vRGVmYXVsdENoYWluZWRFeGVjdXRhYmxlLmphdmE=)
 | `66.99% <100%> (ø)` | `22 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/522?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/522?src=pr=footer). Last 
update 
[756d582...6693e33](https://codecov.io/gh/apache/kylin/pull/522?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #522: KYLIN-3817: Duration in Cube building is a negative number

[GitBox]

asfgit commented on issue #522: KYLIN-3817: Duration in Cube building is a 
negative number
URL: https://github.com/apache/kylin/pull/522#issuecomment-473343452
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lshmouse opened a new pull request #522: KYLIN-3817: Duration in Cube building is a negative number

[GitBox]

lshmouse opened a new pull request #522: KYLIN-3817: Duration in Cube building 
is a negative number
URL: https://github.com/apache/kylin/pull/522
 
 
   See KYLIN-3817.
   
   After building the cube for a few minutes, click the Refresh button and the 
duration of the job becomes negative.
   
   This bug is introduced in KYLIN-3780: 
https://github.com/apache/kylin/pull/442/commits/b3728040e39bf32412624907e493f666c49dfb5c


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #522: KYLIN-3817: Duration in Cube building is a negative number

[GitBox]

asfgit commented on issue #522: KYLIN-3817: Duration in Cube building is a 
negative number
URL: https://github.com/apache/kylin/pull/522#issuecomment-473343458
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #526: KYLIN-3882: kylin master build failed for pom issues

[GitBox]

asfgit commented on issue #526: KYLIN-3882: kylin master build failed for pom 
issues
URL: https://github.com/apache/kylin/pull/526#issuecomment-473760058
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #526: KYLIN-3882: kylin master build failed for pom issues

[GitBox]

shaofengshi merged pull request #526: KYLIN-3882: kylin master build failed for 
pom issues
URL: https://github.com/apache/kylin/pull/526
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi commented on a change in pull request #502: KYLIN-3839 Strorage clean up after refreshing and deleting segment

[GitBox]

shaofengshi commented on a change in pull request #502: KYLIN-3839 Strorage 
clean up after refreshing and deleting segment
URL: https://github.com/apache/kylin/pull/502#discussion_r266297875
 
 

 ##
 File path: 
server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
 ##
 @@ -550,7 +558,30 @@ public CubeInstance deleteSegment(CubeInstance cube, 
String segmentName) throws
 logger.warn(String.format(Locale.ROOT, 
msg.getDELETE_SEGMENT_CAUSE_GAPS(), cube.getName(), segmentName));
 }
 
-return 
CubeManager.getInstance(getConfig()).updateCubeDropSegments(cube, toDelete);
+CubeInstance cubeInstance = 
CubeManager.getInstance(getConfig()).updateCubeDropSegments(cube, toDelete);
+
+cleanSegmentStorage(Collections.singletonList(toDelete));
+
+return cubeInstance;
+}
+
+// clean segment data in hbase and hdfs
+private void cleanSegmentStorage(List toRemoveSegs) throws 
IOException {
+if (KylinConfig.getInstanceFromEnv().cleanStorageAfterDelOperation()) {
 
 Review comment:
   If not enabled, directly return, to make the code more clear (less embed 
logic);


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi commented on a change in pull request #502: KYLIN-3839 Strorage clean up after refreshing and deleting segment

[GitBox]

shaofengshi commented on a change in pull request #502: KYLIN-3839 Strorage 
clean up after refreshing and deleting segment
URL: https://github.com/apache/kylin/pull/502#discussion_r266297943
 
 

 ##
 File path: 
server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
 ##
 @@ -550,7 +558,30 @@ public CubeInstance deleteSegment(CubeInstance cube, 
String segmentName) throws
 logger.warn(String.format(Locale.ROOT, 
msg.getDELETE_SEGMENT_CAUSE_GAPS(), cube.getName(), segmentName));
 }
 
-return 
CubeManager.getInstance(getConfig()).updateCubeDropSegments(cube, toDelete);
+CubeInstance cubeInstance = 
CubeManager.getInstance(getConfig()).updateCubeDropSegments(cube, toDelete);
+
+cleanSegmentStorage(Collections.singletonList(toDelete));
+
+return cubeInstance;
+}
+
+// clean segment data in hbase and hdfs
+private void cleanSegmentStorage(List toRemoveSegs) throws 
IOException {
+if (KylinConfig.getInstanceFromEnv().cleanStorageAfterDelOperation()) {
+if (toRemoveSegs != null) {
+List toDropHTables = 
Lists.newArrayListWithCapacity(toRemoveSegs.size());
+List toDelHDFSPaths = 
Lists.newArrayListWithCapacity(toRemoveSegs.size());
+for (CubeSegment seg : toRemoveSegs) {
+toDropHTables.add(seg.getStorageLocationIdentifier());
+
toDelHDFSPaths.add(JobBuilderSupport.getJobWorkingDir(seg.getConfig().getHdfsWorkingDirectory(),
 seg.getLastBuildJobID()));
+}
+
+if (!toRemoveSegs.isEmpty()) {
 
 Review comment:
   Please combine this line with the previous " if (toRemoveSegs != null)" 
check.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] xbirbird opened a new pull request #528: KYLIN-3883 Kylin supports column count aggregation

[GitBox]

xbirbird opened a new pull request #528: KYLIN-3883 Kylin supports column count 
aggregation
URL: https://github.com/apache/kylin/pull/528
 
 
   
Kylin目前只支持对常量1进行count聚合预计算，即count(1)，count(col_1)的查询内部全部重写到对count(1)的查询，这样会导致一个问题：当col_1列中存在null值时，count(col_1)的查询结果并不准确。这样就导致Kylin的查询结果和Hive、Spark等不一致。该Patch中，提供了对count(col_1)的支持。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #528: KYLIN-3883 Kylin supports column count aggregation

[GitBox]

asfgit commented on issue #528: KYLIN-3883 Kylin supports column count 
aggregation
URL: https://github.com/apache/kylin/pull/528#issuecomment-473780026
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lshmouse opened a new pull request #526: KYLIN-3882: kylin master build failed for pom issues

[GitBox]

lshmouse opened a new pull request #526: KYLIN-3882: kylin master build failed 
for pom issues
URL: https://github.com/apache/kylin/pull/526
 
 
   See: https://issues.apache.org/jira/browse/KYLIN-3882


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #526: KYLIN-3882: kylin master build failed for pom issues

[GitBox]

asfgit commented on issue #526: KYLIN-3882: kylin master build failed for pom 
issues
URL: https://github.com/apache/kylin/pull/526#issuecomment-473760059
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #509: KYLIN-3864 Provide a function to judge whether the os type is Mac os x or not

[GitBox]

shaofengshi merged pull request #509: KYLIN-3864 Provide a function to judge 
whether the os type is Mac os x or not
URL: https://github.com/apache/kylin/pull/509
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi commented on issue #509: KYLIN-3864 Provide a function to judge whether the os type is Mac os x or not

[GitBox]

shaofengshi commented on issue #509: KYLIN-3864 Provide a function to judge 
whether the os type is Mac os x or not
URL: https://github.com/apache/kylin/pull/509#issuecomment-473761504
 
 
   I see, there will be subsequent changes based on this. I will merge it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #527: KYLIN-3880: DataType is incompatible in Kylin HBase coprocessor

[GitBox]

asfgit commented on issue #527: KYLIN-3880: DataType is incompatible in Kylin 
HBase coprocessor
URL: https://github.com/apache/kylin/pull/527#issuecomment-473761291
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #529: KYLIN-3884: loading hfile to HBase failed for temporary dir in output path

[GitBox]

asfgit commented on issue #529: KYLIN-3884: loading hfile to HBase failed for 
temporary dir in output path
URL: https://github.com/apache/kylin/pull/529#issuecomment-473791423
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lshmouse opened a new pull request #529: KYLIN-3884: loading hfile to HBase failed for temporary dir in output path

[GitBox]

lshmouse opened a new pull request #529: KYLIN-3884: loading hfile to HBase 
failed for temporary dir in output path
URL: https://github.com/apache/kylin/pull/529
 
 
   See: https://issues.apache.org/jira/browse/KYLIN-3884
   
   Delete the temporary dir before loading hfiles to HBase tables.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #529: KYLIN-3884: loading hfile to HBase failed for temporary dir in output path

[GitBox]

asfgit commented on issue #529: KYLIN-3884: loading hfile to HBase failed for 
temporary dir in output path
URL: https://github.com/apache/kylin/pull/529#issuecomment-473791422
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lshmouse opened a new pull request #530: KYLIN-3886: Missing argument for options for yarn command

[GitBox]

lshmouse opened a new pull request #530: KYLIN-3886:  Missing argument for 
options for yarn command
URL: https://github.com/apache/kylin/pull/530
 
 
   See: https://issues.apache.org/jira/browse/KYLIN-3886
   
   The app id may be empty which cause the yarn command failed for missing 
argument.
   Checking the app id before executing yarn command


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #530: KYLIN-3886: Missing argument for options for yarn command

[GitBox]

asfgit commented on issue #530: KYLIN-3886:  Missing argument for options for 
yarn command
URL: https://github.com/apache/kylin/pull/530#issuecomment-473792463
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #530: KYLIN-3886: Missing argument for options for yarn command

[GitBox]

asfgit commented on issue #530: KYLIN-3886:  Missing argument for options for 
yarn command
URL: https://github.com/apache/kylin/pull/530#issuecomment-473792462
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] yanghua commented on issue #509: KYLIN-3864 Provide a function to judge whether the os type is Mac os x or not

[GitBox]

yanghua commented on issue #509: KYLIN-3864 Provide a function to judge whether 
the os type is Mac os x or not
URL: https://github.com/apache/kylin/pull/509#issuecomment-473759267
 
 
   Hi @shaofengshi  Now, In kylin project, there are many places where the code 
would check the os type is **Darwin** (Mac os X) such as `download-spark.sh`, 
`download-flink.sh`, `tool-wrapper.sh`. And there are some places where Kylin 
is not compatible with Mac os X (it does not check the os type), it caused some 
errors, such as [KYLIN-3756](https://issues.apache.org/jira/browse/KYLIN-3756) 
and [KYLIN-3757](https://issues.apache.org/jira/browse/KYLIN-3757). This util 
method provides a general function to verify whether the current os type is Mac 
os X or not.
   
   By providing this function, we can do generic checking for the different 
`like-UNIX` os, and fix those compatible issues existing in the shell script.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #516: KYLIN-3874 "Convert Cuboid Data to HFile" failed when HBase and MR use different HDFS clusters

[GitBox]

shaofengshi merged pull request #516: KYLIN-3874 "Convert Cuboid Data to HFile" 
failed when HBase and MR use different HDFS clusters
URL: https://github.com/apache/kylin/pull/516
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #525: KYLIN-3879 Implement FlinkEntry

[GitBox]

shaofengshi merged pull request #525: KYLIN-3879 Implement FlinkEntry
URL: https://github.com/apache/kylin/pull/525
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #523: KYLIN-3869 Implement Flink batch merge job builder

[GitBox]

shaofengshi merged pull request #523: KYLIN-3869 Implement Flink batch merge 
job builder
URL: https://github.com/apache/kylin/pull/523
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #522: KYLIN-3817: Duration in Cube building is a negative number

[GitBox]

shaofengshi merged pull request #522: KYLIN-3817: Duration in Cube building is 
a negative number
URL: https://github.com/apache/kylin/pull/522
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi commented on issue #509: KYLIN-3864 Provide a function to judge whether the os type is Mac os x or not

[GitBox]

shaofengshi commented on issue #509: KYLIN-3864 Provide a function to judge 
whether the os type is Mac os x or not
URL: https://github.com/apache/kylin/pull/509#issuecomment-473755179
 
 
   Hi Hua, which script will use this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #527: KYLIN-3880: DataType is incompatible in Kylin HBase coprocessor

[GitBox]

asfgit commented on issue #527: KYLIN-3880: DataType is incompatible in Kylin 
HBase coprocessor
URL: https://github.com/apache/kylin/pull/527#issuecomment-473761296
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lshmouse opened a new pull request #527: KYLIN-3880: DataType is incompatible in Kylin HBase coprocessor

[GitBox]

lshmouse opened a new pull request #527: KYLIN-3880: DataType is incompatible 
in Kylin HBase coprocessor
URL: https://github.com/apache/kylin/pull/527
 
 
   See: https://issues.apache.org/jira/browse/KYLIN-3880
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #528: KYLIN-3883 Kylin supports column count aggregation

[GitBox]

asfgit commented on issue #528: KYLIN-3883 Kylin supports column count 
aggregation
URL: https://github.com/apache/kylin/pull/528#issuecomment-473780022
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #511: KYLIN-3830 return wrong result when 'SELECT SUM(dim1)' without set a …

[GitBox]

asfgit commented on issue #511: KYLIN-3830 return wrong result when 'SELECT 
SUM(dim1)' without set a …
URL: https://github.com/apache/kylin/pull/511#issuecomment-471886751
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] Qsimple opened a new pull request #511: KYLIN-3830 return wrong result when 'SELECT SUM(dim1)' without set a …

[GitBox]

Qsimple opened a new pull request #511: KYLIN-3830 return wrong result when 
'SELECT SUM(dim1)' without set a …
URL: https://github.com/apache/kylin/pull/511
 
 
   just remove FUNC_SUM in BUILT_IN_AGGREGATIONS, which make the kylin doesn't 
support query sum(dim1) without set a relative metric of dim1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #511: KYLIN-3830 return wrong result when 'SELECT SUM(dim1)' without set a …

[GitBox]

coveralls commented on issue #511: KYLIN-3830 return wrong result when 'SELECT 
SUM(dim1)' without set a …
URL: https://github.com/apache/kylin/pull/511#issuecomment-471893048
 
 
   ## Pull Request Test Coverage Report for [Build 
4225](https://coveralls.io/builds/22123338)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage decreased (**-0.001%**) to **26.942%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22123338/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553)
 | 1 | 78.12% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/22123338/badge)](https://coveralls.io/builds/22123338)
 |
   | :-- | --: |
   | Change from base [Build 4216](https://coveralls.io/builds/22079929): |  
-0.001% |
   | Covered Lines: | 18955 |
   | Relevant Lines: | 70355 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #510: KYLIN-3867 Enable JDBC to use key store & trust store for https connection

[GitBox]

asfgit commented on issue #510: KYLIN-3867 Enable JDBC to use key store & trust 
store for https connection
URL: https://github.com/apache/kylin/pull/510#issuecomment-471850646
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] kyotoYaho opened a new pull request #510: KYLIN-3867 Enable JDBC to use key store & trust store for https connection

[GitBox]

kyotoYaho opened a new pull request #510: KYLIN-3867 Enable JDBC to use key 
store & trust store for https connection
URL: https://github.com/apache/kylin/pull/510
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #508: KYLIN-3848 Flink cubing step : build by layer

[GitBox]

shaofengshi merged pull request #508: KYLIN-3848 Flink cubing step : build by 
layer
URL: https://github.com/apache/kylin/pull/508
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #510: KYLIN-3867 Enable JDBC to use key store & trust store for https connection

[GitBox]

coveralls commented on issue #510: KYLIN-3867 Enable JDBC to use key store & 
trust store for https connection
URL: https://github.com/apache/kylin/pull/510#issuecomment-471857303
 
 
   ## Pull Request Test Coverage Report for [Build 
4224](https://coveralls.io/builds/22121544)
   
   * **1** of **22**   **(4.55%)**  changed or added relevant lines in **1** 
file are covered.
   * **7** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.009%**) to **26.934%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[jdbc/src/main/java/org/apache/kylin/jdbc/KylinClient.java](https://coveralls.io/builds/22121544/source?filename=jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjdbc%2FKylinClient.java#L91)
 | 1 | 22 | 4.55%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/22121544/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22121544/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/22121544/badge)](https://coveralls.io/builds/22121544)
 |
   | :-- | --: |
   | Change from base [Build 4216](https://coveralls.io/builds/22079929): |  
-0.009% |
   | Covered Lines: | 18955 |
   | Relevant Lines: | 70375 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] Qsimple opened a new pull request #513: KYLIN-3860 Add doc about configuration of kylin.web.hide-measures

[GitBox]

Qsimple opened a new pull request #513: KYLIN-3860 Add doc about configuration 
of kylin.web.hide-measures
URL: https://github.com/apache/kylin/pull/513
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #513: KYLIN-3860 Add doc about configuration of kylin.web.hide-measures

[GitBox]

asfgit commented on issue #513: KYLIN-3860 Add doc about configuration of 
kylin.web.hide-measures
URL: https://github.com/apache/kylin/pull/513#issuecomment-472280286
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #511: KYLIN-3830 return wrong result when 'SELECT SUM(dim1)' without set a …

[GitBox]

shaofengshi merged pull request #511: KYLIN-3830 return wrong result when 
'SELECT SUM(dim1)' without set a …
URL: https://github.com/apache/kylin/pull/511
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #513: KYLIN-3860 Add doc about configuration of kylin.web.hide-measures

[GitBox]

shaofengshi merged pull request #513: KYLIN-3860 Add doc about configuration of 
kylin.web.hide-measures
URL: https://github.com/apache/kylin/pull/513
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #507: KYLIN-3857 Disable quote when needed

[GitBox]

asfgit commented on issue #507: KYLIN-3857 Disable quote when needed
URL: https://github.com/apache/kylin/pull/507#issuecomment-471363742
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #507: KYLIN-3857 Disable quote when needed

[GitBox]

coveralls commented on issue #507: KYLIN-3857 Disable quote when needed
URL: https://github.com/apache/kylin/pull/507#issuecomment-471365403
 
 
   ## Pull Request Test Coverage Report for [Build 
4218](https://coveralls.io/builds/22094916)
   
   * **17** of **45**   **(37.78%)**  changed or added relevant lines in **10** 
files are covered.
   * **7** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.002%**) to **26.945%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/22094916/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L986)
 | 1 | 2 | 50.0%
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/model/TableRef.java](https://coveralls.io/builds/22094916/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableRef.java#L73)
 | 0 | 1 | 0.0%
   | 
[core-metadata/src/main/java/org/apache/kylin/source/adhocquery/HivePushDownConverter.java](https://coveralls.io/builds/22094916/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fadhocquery%2FHivePushDownConverter.java#L194)
 | 0 | 1 | 0.0%
   | 
[core-job/src/main/java/org/apache/kylin/job/util/FlatTableSqlQuoteUtils.java](https://coveralls.io/builds/22094916/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Futil%2FFlatTableSqlQuoteUtils.java#L53)
 | 4 | 8 | 50.0%
   | 
[source-hive/src/main/java/org/apache/kylin/source/hive/GarbageCollectionStep.java](https://coveralls.io/builds/22094916/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FGarbageCollectionStep.java#L42)
 | 0 | 6 | 0.0%
   | 
[source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/22094916/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L93)
 | 6 | 12 | 50.0%
   | 
[core-job/src/main/java/org/apache/kylin/job/JoinedFlatTable.java](https://coveralls.io/builds/22094916/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2FJoinedFlatTable.java#L57)
 | 0 | 9 | 0.0%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[source-hive/src/main/java/org/apache/kylin/source/hive/GarbageCollectionStep.java](https://coveralls.io/builds/22094916/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FGarbageCollectionStep.java#L74)
 | 1 | 0.0% |
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/model/TableRef.java](https://coveralls.io/builds/22094916/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableRef.java#L74)
 | 1 | 54.55% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22094916/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/22094916/badge)](https://coveralls.io/builds/22094916)
 |
   | :-- | --: |
   | Change from base [Build 4216](https://coveralls.io/builds/22079929): |  
0.002% |
   | Covered Lines: | 18963 |
   | Relevant Lines: | 70377 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on issue #507: KYLIN-3857 Disable quote when needed

[GitBox]

hit-lacus commented on issue #507: KYLIN-3857 Disable quote when needed
URL: https://github.com/apache/kylin/pull/507#issuecomment-471377662
 
 
   Local CI Test passed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus opened a new pull request #507: KYLIN-3857 Disable quote when needed

[GitBox]

hit-lacus opened a new pull request #507: KYLIN-3857 Disable quote when needed
URL: https://github.com/apache/kylin/pull/507
 
 
   1. add quote for create table ddl
   2. add switch for turn off quote


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #507: KYLIN-3857 Disable quote when needed

[GitBox]

codecov-io commented on issue #507: KYLIN-3857 Disable quote when needed
URL: https://github.com/apache/kylin/pull/507#issuecomment-471365737
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@fb52a1d`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/507/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/507?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #507   +/-   ##
   =
 Coverage  ?   24.46%   
 Complexity? 5029   
   =
 Files ? 1161   
 Lines ?70377   
 Branches  ?10017   
   =
 Hits  ?17221   
 Misses?51418   
 Partials  ? 1738
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/507?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...kylin/source/adhocquery/HivePushDownConverter.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2FkaG9jcXVlcnkvSGl2ZVB1c2hEb3duQ29udmVydGVyLmphdmE=)
 | `65.51% <0%> (ø)` | `16 <0> (?)` | |
   | 
[...pache/kylin/source/hive/GarbageCollectionStep.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0dhcmJhZ2VDb2xsZWN0aW9uU3RlcC5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...java/org/apache/kylin/metadata/model/TableRef.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVSZWYuamF2YQ==)
 | `50% <0%> (ø)` | `11 <0> (?)` | |
   | 
[...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...pache/kylin/source/datagen/ModelDataGenerator.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vTW9kZWxEYXRhR2VuZXJhdG9yLmphdmE=)
 | `89.3% <100%> (ø)` | `53 <1> (?)` | |
   | 
[...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=)
 | `82.19% <100%> (ø)` | `12 <0> (?)` | |
   | 
[...in/sdk/datasource/framework/conv/SqlConverter.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9jb252L1NxbENvbnZlcnRlci5qYXZh)
 | `90.62% <100%> (ø)` | `7 <3> (?)` | |
   | 
[.../apache/kylin/job/util/FlatTableSqlQuoteUtils.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL0ZsYXRUYWJsZVNxbFF1b3RlVXRpbHMuamF2YQ==)
 | `21.81% <37.5%> (ø)` | `10 <2> (?)` | |
   | 
[...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==)
 | `12.97% <41.66%> (ø)` | `4 <0> (?)` | |
   | 
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
 | `14.14% <50%> (ø)` | `42 <1> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=footer). Last 
update 
[fb52a1d...2938ac7](https://codecov.io/gh/apache/kylin/pull/507?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:

[GitHub] [kylin] shaofengshi merged pull request #512: KYLIN-3865 Centralize the zookeeper related info

[GitBox]

shaofengshi merged pull request #512: KYLIN-3865 Centralize the zookeeper 
related info
URL: https://github.com/apache/kylin/pull/512
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #510: KYLIN-3867 Enable JDBC to use key store & trust store for https connection

[GitBox]

shaofengshi merged pull request #510: KYLIN-3867 Enable JDBC to use key store & 
trust store for https connection
URL: https://github.com/apache/kylin/pull/510
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] yanghua opened a new pull request #514: KYLIN-3868 Implement Flink batch cubing job builder

[GitBox]

yanghua opened a new pull request #514: KYLIN-3868 Implement Flink batch cubing 
job builder
URL: https://github.com/apache/kylin/pull/514
 
 
   JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3868


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #514: KYLIN-3868 Implement Flink batch cubing job builder

[GitBox]

asfgit commented on issue #514: KYLIN-3868 Implement Flink batch cubing job 
builder
URL: https://github.com/apache/kylin/pull/514#issuecomment-472463994
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #514: KYLIN-3868 Implement Flink batch cubing job builder

[GitBox]

codecov-io commented on issue #514: KYLIN-3868 Implement Flink batch cubing job 
builder
URL: https://github.com/apache/kylin/pull/514#issuecomment-472498731
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/514?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`engine-flink@d4f8eb2`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/514/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/514?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ## engine-flink #514   +/-   ##
   ===
 Coverage?   24.27%   
 Complexity  ? 5029   
   ===
 Files   ? 1166   
 Lines   ?70903   
 Branches?10078   
   ===
 Hits?17215   
 Misses  ?51948   
 Partials? 1740
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/514?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...org/apache/kylin/engine/flink/FlinkExecutable.java](https://codecov.io/gh/apache/kylin/pull/514/diff?src=pr=tree#diff-ZW5naW5lLWZsaW5rL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvZmxpbmsvRmxpbmtFeGVjdXRhYmxlLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...ylin/engine/flink/FlinkBatchCubingJobBuilder2.java](https://codecov.io/gh/apache/kylin/pull/514/diff?src=pr=tree#diff-ZW5naW5lLWZsaW5rL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvZmxpbmsvRmxpbmtCYXRjaEN1YmluZ0pvYkJ1aWxkZXIyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...e/kylin/engine/flink/FlinkOnYarnConfigMapping.java](https://codecov.io/gh/apache/kylin/pull/514/diff?src=pr=tree#diff-ZW5naW5lLWZsaW5rL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvZmxpbmsvRmxpbmtPbllhcm5Db25maWdNYXBwaW5nLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/514?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/514?src=pr=footer). Last 
update 
[d4f8eb2...af1af4b](https://codecov.io/gh/apache/kylin/pull/514?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #502: KYLIN-3839 Strorage clean up after refreshing and deleting segment

[GitBox]

codecov-io commented on issue #502: KYLIN-3839 Strorage clean up after 
refreshing and deleting segment
URL: https://github.com/apache/kylin/pull/502#issuecomment-470484793
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/502?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@c0b9e51`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `13.18%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/502/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/502?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #502   +/-   ##
   =
 Coverage  ?   24.46%   
 Complexity? 5029   
   =
 Files ? 1161   
 Lines ?70393   
 Branches  ?10019   
   =
 Hits  ?17220   
 Misses?51433   
 Partials  ? 1740
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/502?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...torage/hbase/steps/HBaseSparkOutputTransition.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZVNwYXJrT3V0cHV0VHJhbnNpdGlvbi5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../main/java/org/apache/kylin/cube/CubeInstance.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVJbnN0YW5jZS5qYXZh)
 | `38.57% <0%> (ø)` | `52 <0> (?)` | |
   | 
[...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../apache/kylin/storage/hbase/steps/HBaseGCStep.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZUdDU3RlcC5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...pache/kylin/storage/hbase/steps/HBaseJobSteps.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZUpvYlN0ZXBzLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...pache/kylin/rest/job/StorageCleanJobHbaseUtil.java](https://codecov.io/gh/apache/kylin/pull/502/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbkpvYkhiYXNlVXRpbC5qYXZh)
 | `39.04% <28.57%> (ø)` | `8 <2> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/502?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/502?src=pr=footer). Last 
update 
[c0b9e51...115c952](https://codecov.io/gh/apache/kylin/pull/502?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #498: Realtime olap release

[GitBox]

coveralls edited a comment on issue #498: Realtime olap release
URL: https://github.com/apache/kylin/pull/498#issuecomment-470416047
 
 
   ## Pull Request Test Coverage Report for [Build 
4208](https://coveralls.io/builds/22039915)
   
   * **3663** of **10680**   **(34.3%)**  changed or added relevant lines in 
**231** files are covered.
   * **8** unchanged lines in **5** files lost coverage.
   * Overall coverage increased (+**1.0%**) to **27.928%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/debug/BackdoorToggles.java](https://coveralls.io/builds/22039915/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fdebug%2FBackdoorToggles.java#L123)
 | 0 | 1 | 0.0%
   | 
[core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/22039915/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1435)
 | 0 | 1 | 0.0%
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/TableMetadataManager.java](https://coveralls.io/builds/22039915/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2FTableMetadataManager.java#L157)
 | 0 | 1 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java](https://coveralls.io/builds/22039915/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FDeployCoprocessorCLI.java#L531)
 | 0 | 1 | 0.0%
   | 
[stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/exception/ClusterStateException.java](https://coveralls.io/builds/22039915/source?filename=stream-coordinator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcoordinator%2Fexception%2FClusterStateException.java#L39)
 | 13 | 14 | 92.86%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/consumer/IStopConsumptionCondition.java](https://coveralls.io/builds/22039915/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fconsumer%2FIStopConsumptionCondition.java#L28)
 | 0 | 1 | 0.0%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/source/ISourcePositionHandler.java](https://coveralls.io/builds/22039915/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fsource%2FISourcePositionHandler.java#L24)
 | 0 | 1 | 0.0%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/LZ4CompressedColumnReader.java](https://coveralls.io/builds/22039915/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2Fcompress%2FLZ4CompressedColumnReader.java#L118)
 | 40 | 41 | 97.56%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/NoCompressedColumnReader.java](https://coveralls.io/builds/22039915/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2Fcompress%2FNoCompressedColumnReader.java#L78)
 | 20 | 21 | 95.24%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/RunLengthCompressedColumnReader.java](https://coveralls.io/builds/22039915/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2Fcompress%2FRunLengthCompressedColumnReader.java#L135)
 | 62 | 63 | 98.41%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java](https://coveralls.io/builds/22039915/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FCubeMigrationCLI.java#L346)
 | 1 | 0.0% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperUtil.java](https://coveralls.io/builds/22039915/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FZookeeperUtil.java#L32)
 | 1 | 0.0% |
   | 
[core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/22039915/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319)
 | 1 | 81.08% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/22039915/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22039915/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 3 | 78.42% |
   
   
   |  Totals | [![Coverage 

[GitHub] [kylin] codecov-io edited a comment on issue #498: Realtime olap release

[GitBox]

codecov-io edited a comment on issue #498: Realtime olap release
URL: https://github.com/apache/kylin/pull/498#issuecomment-470416724
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/498?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@c0b9e51`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `22.56%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/498/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/498?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #498   +/-   ##
   =
 Coverage  ?   25.43%   
 Complexity? 5804   
   =
 Files ? 1371   
 Lines ?81016   
 Branches  ?11363   
   =
 Hits  ?20606   
 Misses?58394   
 Partials  ? 2016
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/498?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ream/server/rest/exception/ForbiddenException.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLXJlY2VpdmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vc2VydmVyL3Jlc3QvZXhjZXB0aW9uL0ZvcmJpZGRlbkV4Y2VwdGlvbi5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...ge/columnar/invertindex/SeqIIColumnDescriptor.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvaW52ZXJ0aW5kZXgvU2VxSUlDb2x1bW5EZXNjcmlwdG9yLmphdmE=)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[.../stream/core/storage/columnar/protocol/Footer.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvcHJvdG9jb2wvRm9vdGVyLmphdmE=)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...org/apache/kylin/stream/core/util/RestService.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3V0aWwvUmVzdFNlcnZpY2UuamF2YQ==)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...eam/core/storage/columnar/FragmentFilesMerger.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRnJhZ21lbnRGaWxlc01lcmdlci5qYXZh)
 | `96.55% <ø> (ø)` | `30 <0> (?)` | |
   | 
[...am/core/storage/columnar/FragmentFileSearcher.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRnJhZ21lbnRGaWxlU2VhcmNoZXIuamF2YQ==)
 | `49.7% <ø> (ø)` | `8 <0> (?)` | |
   | 
[...lumnar/invertindex/FixLenColInvertIndexWriter.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvaW52ZXJ0aW5kZXgvRml4TGVuQ29sSW52ZXJ0SW5kZXhXcml0ZXIuamF2YQ==)
 | `94.11% <ø> (ø)` | `5 <0> (?)` | |
   | 
[.../kylin/stream/server/ReplicaSetLeaderSelector.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLXJlY2VpdmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vc2VydmVyL1JlcGxpY2FTZXRMZWFkZXJTZWxlY3Rvci5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...e/columnar/compress/LZ4CompressedColumnWriter.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvY29tcHJlc3MvTFo0Q29tcHJlc3NlZENvbHVtbldyaXRlci5qYXZh)
 | `89.28% <ø> (ø)` | `4 <0> (?)` | |
   | 
[...orage/columnar/ColumnarMetricsEncodingFactory.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJNZXRyaWNzRW5jb2RpbmdGYWN0b3J5LmphdmE=)
 | `42.59% <ø> (ø)` | `3 <0> (?)` | |
   | ... and [200 
more](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree-more) | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/498?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/498?src=pr=footer). Last 
update 
[c0b9e51...f1227df](https://codecov.io/gh/apache/kylin/pull/498?src=pr=lastupdated).
 Read the [comment 

[GitHub] [kylin] codecov-io commented on issue #498: Realtime olap release

[GitBox]

codecov-io commented on issue #498: Realtime olap release
URL: https://github.com/apache/kylin/pull/498#issuecomment-470416724
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/498?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@c0b9e51`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `22.56%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/498/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/498?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #498   +/-   ##
   =
 Coverage  ?   25.43%   
 Complexity? 5803   
   =
 Files ? 1371   
 Lines ?81016   
 Branches  ?11363   
   =
 Hits  ?20607   
 Misses?58393   
 Partials  ? 2016
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/498?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ream/server/rest/exception/ForbiddenException.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLXJlY2VpdmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vc2VydmVyL3Jlc3QvZXhjZXB0aW9uL0ZvcmJpZGRlbkV4Y2VwdGlvbi5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...ge/columnar/invertindex/SeqIIColumnDescriptor.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvaW52ZXJ0aW5kZXgvU2VxSUlDb2x1bW5EZXNjcmlwdG9yLmphdmE=)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[.../stream/core/storage/columnar/protocol/Footer.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvcHJvdG9jb2wvRm9vdGVyLmphdmE=)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...org/apache/kylin/stream/core/util/RestService.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3V0aWwvUmVzdFNlcnZpY2UuamF2YQ==)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...eam/core/storage/columnar/FragmentFilesMerger.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRnJhZ21lbnRGaWxlc01lcmdlci5qYXZh)
 | `96.55% <ø> (ø)` | `30 <0> (?)` | |
   | 
[...am/core/storage/columnar/FragmentFileSearcher.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRnJhZ21lbnRGaWxlU2VhcmNoZXIuamF2YQ==)
 | `49.7% <ø> (ø)` | `8 <0> (?)` | |
   | 
[...lumnar/invertindex/FixLenColInvertIndexWriter.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvaW52ZXJ0aW5kZXgvRml4TGVuQ29sSW52ZXJ0SW5kZXhXcml0ZXIuamF2YQ==)
 | `94.11% <ø> (ø)` | `5 <0> (?)` | |
   | 
[.../kylin/stream/server/ReplicaSetLeaderSelector.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLXJlY2VpdmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vc2VydmVyL1JlcGxpY2FTZXRMZWFkZXJTZWxlY3Rvci5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...e/columnar/compress/LZ4CompressedColumnWriter.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvY29tcHJlc3MvTFo0Q29tcHJlc3NlZENvbHVtbldyaXRlci5qYXZh)
 | `89.28% <ø> (ø)` | `4 <0> (?)` | |
   | 
[...orage/columnar/ColumnarMetricsEncodingFactory.java](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJNZXRyaWNzRW5jb2RpbmdGYWN0b3J5LmphdmE=)
 | `42.59% <ø> (ø)` | `3 <0> (?)` | |
   | ... and [200 
more](https://codecov.io/gh/apache/kylin/pull/498/diff?src=pr=tree-more) | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/498?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/498?src=pr=footer). Last 
update 
[c0b9e51...f387faf](https://codecov.io/gh/apache/kylin/pull/498?src=pr=lastupdated).
 Read the [comment 

[GitHub] [kylin] asfgit commented on issue #502: KYLIN-3839 Strorage clean up after refreshing and deleting segment

[GitBox]

asfgit commented on issue #502: KYLIN-3839 Strorage clean up after refreshing 
and deleting segment
URL: https://github.com/apache/kylin/pull/502#issuecomment-470470945
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] Wayne1c opened a new pull request #502: KYLIN-3839 Strorage clean up after refreshing and deleting segment

[GitBox]

Wayne1c opened a new pull request #502: KYLIN-3839 Strorage clean up after 
refreshing and deleting segment
URL: https://github.com/apache/kylin/pull/502
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #502: KYLIN-3839 Strorage clean up after refreshing and deleting segment

[GitBox]

coveralls commented on issue #502: KYLIN-3839 Strorage clean up after 
refreshing and deleting segment
URL: https://github.com/apache/kylin/pull/502#issuecomment-470485608
 
 
   ## Pull Request Test Coverage Report for [Build 
4209](https://coveralls.io/builds/22041419)
   
   * **12** of **91**   **(13.19%)**  changed or added relevant lines in **6** 
files are covered.
   * **8** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.008%**) to **26.94%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseGCStep.java](https://coveralls.io/builds/22041419/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FHBaseGCStep.java#L50)
 | 0 | 1 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseSparkOutputTransition.java](https://coveralls.io/builds/22041419/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FHBaseSparkOutputTransition.java#L63)
 | 0 | 1 | 0.0%
   | 
[core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/22041419/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L189)
 | 0 | 4 | 0.0%
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java](https://coveralls.io/builds/22041419/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java#L354)
 | 0 | 14 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseJobSteps.java](https://coveralls.io/builds/22041419/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FHBaseJobSteps.java#L143)
 | 0 | 29 | 0.0%
   | 
[server-base/src/main/java/org/apache/kylin/rest/job/StorageCleanJobHbaseUtil.java](https://coveralls.io/builds/22041419/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FStorageCleanJobHbaseUtil.java#L127)
 | 12 | 42 | 28.57%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java](https://coveralls.io/builds/22041419/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeInstance.java#L200)
 | 1 | 43.57% |
   | 
[core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/22041419/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319)
 | 1 | 81.08% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22041419/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 3 | 78.42% |
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java](https://coveralls.io/builds/22041419/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java#L361)
 | 3 | 0.0% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/22041419/badge)](https://coveralls.io/builds/22041419)
 |
   | :-- | --: |
   | Change from base [Build 4206](https://coveralls.io/builds/22034992): |  
-0.008% |
   | Covered Lines: | 18964 |
   | Relevant Lines: | 70393 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #498: Realtime olap release

[GitBox]

coveralls commented on issue #498: Realtime olap release
URL: https://github.com/apache/kylin/pull/498#issuecomment-470416047
 
 
   ## Pull Request Test Coverage Report for [Build 
4207](https://coveralls.io/builds/22037960)
   
   * **3665** of **10680**   **(34.32%)**  changed or added relevant lines in 
**231** files are covered.
   * **8** unchanged lines in **5** files lost coverage.
   * Overall coverage increased (+**1.0%**) to **27.929%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-|--||---: |
   | 
[core-common/src/main/java/org/apache/kylin/common/debug/BackdoorToggles.java](https://coveralls.io/builds/22037960/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fdebug%2FBackdoorToggles.java#L123)
 | 0 | 1 | 0.0%
   | 
[core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/22037960/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1435)
 | 0 | 1 | 0.0%
   | 
[core-metadata/src/main/java/org/apache/kylin/metadata/TableMetadataManager.java](https://coveralls.io/builds/22037960/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2FTableMetadataManager.java#L157)
 | 0 | 1 | 0.0%
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java](https://coveralls.io/builds/22037960/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FDeployCoprocessorCLI.java#L531)
 | 0 | 1 | 0.0%
   | 
[stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/exception/ClusterStateException.java](https://coveralls.io/builds/22037960/source?filename=stream-coordinator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcoordinator%2Fexception%2FClusterStateException.java#L39)
 | 13 | 14 | 92.86%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/consumer/IStopConsumptionCondition.java](https://coveralls.io/builds/22037960/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fconsumer%2FIStopConsumptionCondition.java#L28)
 | 0 | 1 | 0.0%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/source/ISourcePositionHandler.java](https://coveralls.io/builds/22037960/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fsource%2FISourcePositionHandler.java#L24)
 | 0 | 1 | 0.0%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/LZ4CompressedColumnReader.java](https://coveralls.io/builds/22037960/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2Fcompress%2FLZ4CompressedColumnReader.java#L118)
 | 40 | 41 | 97.56%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/NoCompressedColumnReader.java](https://coveralls.io/builds/22037960/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2Fcompress%2FNoCompressedColumnReader.java#L78)
 | 20 | 21 | 95.24%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/compress/RunLengthCompressedColumnReader.java](https://coveralls.io/builds/22037960/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2Fcompress%2FRunLengthCompressedColumnReader.java#L135)
 | 62 | 63 | 98.41%
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java](https://coveralls.io/builds/22037960/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FCubeMigrationCLI.java#L346)
 | 1 | 0.0% |
   | 
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperUtil.java](https://coveralls.io/builds/22037960/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Futil%2FZookeeperUtil.java#L32)
 | 1 | 0.0% |
   | 
[core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/22037960/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L319)
 | 1 | 81.08% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/22037960/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
 | 2 | 68.46% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22037960/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 3 | 78.42% |
   
   
   |  Totals | [![Coverage 

[GitHub] [kylin] yanghua opened a new pull request #506: KYLIN-3853 Support Flink cube engine for Kylin web UI

[GitBox]

yanghua opened a new pull request #506: KYLIN-3853 Support Flink cube engine 
for Kylin web UI
URL: https://github.com/apache/kylin/pull/506
 
 
   jira ref : https://issues.apache.org/jira/browse/KYLIN-3853


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #506: KYLIN-3853 Support Flink cube engine for Kylin web UI

[GitBox]

asfgit commented on issue #506: KYLIN-3853 Support Flink cube engine for Kylin 
web UI
URL: https://github.com/apache/kylin/pull/506#issuecomment-470949289
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #503: KYLIN-3846 Create Flink engine module and initialize module structure

[GitBox]

asfgit commented on issue #503: KYLIN-3846 Create Flink engine module and 
initialize module structure
URL: https://github.com/apache/kylin/pull/503#issuecomment-470604932
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] yanghua opened a new pull request #503: KYLIN-3846 Create Flink engine module and initialize module structure

[GitBox]

yanghua opened a new pull request #503: KYLIN-3846 Create Flink engine module 
and initialize module structure
URL: https://github.com/apache/kylin/pull/503
 
 
   JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3846


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #506: KYLIN-3853 Support Flink cube engine for Kylin web UI

[GitBox]

shaofengshi merged pull request #506: KYLIN-3853 Support Flink cube engine for 
Kylin web UI
URL: https://github.com/apache/kylin/pull/506
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] yanghua commented on issue #506: KYLIN-3853 Support Flink cube engine for Kylin web UI

[GitBox]

yanghua commented on issue #506: KYLIN-3853 Support Flink cube engine for Kylin 
web UI
URL: https://github.com/apache/kylin/pull/506#issuecomment-471132456
 
 
   Hi @shaofengshi please review this PR, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get the public configuration …

[GitBox]

coveralls commented on issue #500: KYLIN-3842 kylinProperties.js Unable to get 
the public configuration …
URL: https://github.com/apache/kylin/pull/500#issuecomment-469963679
 
 
   ## Pull Request Test Coverage Report for [Build 
4203](https://coveralls.io/builds/22010290)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.006%**) to **26.954%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22010290/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
 | 3 | 78.42% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/22010290/badge)](https://coveralls.io/builds/22010290)
 |
   | :-- | --: |
   | Change from base [Build 4201](https://coveralls.io/builds/21985216): |  
0.006% |
   | Covered Lines: | 18961 |
   | Relevant Lines: | 70347 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi commented on issue #528: KYLIN-3883 Kylin supports column count aggregation

[GitBox]

shaofengshi commented on issue #528: KYLIN-3883 Kylin supports column count 
aggregation
URL: https://github.com/apache/kylin/pull/528#issuecomment-473929129
 
 
   Hi @xbirbird, thank you for the patch! The change looks good, could you 
please add some test case for this? Or at least it can be covered by the 
integration test (BuildCubeWithEngine.java). Just let me know how you test and 
verify this feature, thx!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #535: KYLIN-3895 Failed to register new MBean when "kylin.server.query-metrics-enabled" set true

[GitBox]

asfgit commented on issue #535: KYLIN-3895 Failed to register new MBean when 
"kylin.server.query-metrics-enabled" set true
URL: https://github.com/apache/kylin/pull/535#issuecomment-474661101
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #537: KYLIN-3896 Implement IFlinkOutput based on HBase

[GitBox]

codecov-io commented on issue #537: KYLIN-3896 Implement IFlinkOutput based on 
HBase
URL: https://github.com/apache/kylin/pull/537#issuecomment-474698645
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/537?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`engine-flink@e9b520b`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/537/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/537?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ## engine-flink#537   +/-   ##
   ==
 Coverage?   24.2%   
 Complexity  ?5029   
   ==
 Files   ?1171   
 Lines   ?   71146   
 Branches?   10096   
   ==
 Hits?   17218   
 Misses  ?   52189   
 Partials?1739
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/537?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...a/org/apache/kylin/storage/hbase/HBaseStorage.java](https://codecov.io/gh/apache/kylin/pull/537/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZVN0b3JhZ2UuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...torage/hbase/steps/HBaseFlinkOutputTransition.java](https://codecov.io/gh/apache/kylin/pull/537/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IQmFzZUZsaW5rT3V0cHV0VHJhbnNpdGlvbi5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/537?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/537?src=pr=footer). Last 
update 
[e9b520b...e880db6](https://codecov.io/gh/apache/kylin/pull/537?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] yanghua opened a new pull request #537: KYLIN-3896 Implement IFlinkOutput based on HBase

[GitBox]

yanghua opened a new pull request #537: KYLIN-3896 Implement IFlinkOutput based 
on HBase
URL: https://github.com/apache/kylin/pull/537
 
 
   JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3896


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #537: KYLIN-3896 Implement IFlinkOutput based on HBase

[GitBox]

asfgit commented on issue #537: KYLIN-3896 Implement IFlinkOutput based on HBase
URL: https://github.com/apache/kylin/pull/537#issuecomment-474693922
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #537: KYLIN-3896 Implement IFlinkOutput based on HBase

[GitBox]

asfgit commented on issue #537: KYLIN-3896 Implement IFlinkOutput based on HBase
URL: https://github.com/apache/kylin/pull/537#issuecomment-474693921
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #536: KYLIN-3474 Tableau 10.5 get malformed token

[GitBox]

codecov-io commented on issue #536: KYLIN-3474 Tableau 10.5 get malformed token
URL: https://github.com/apache/kylin/pull/536#issuecomment-474670454
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/536?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@4abe712`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/536/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/536?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #536   +/-   ##
   =
 Coverage  ?   24.41%   
 Complexity? 5025   
   =
 Files ? 1161   
 Lines ?70460   
 Branches  ?10020   
   =
 Hits  ?17206   
 Misses?51518   
 Partials  ? 1736
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/536?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...va/org/apache/kylin/rest/security/ManagedUser.java](https://codecov.io/gh/apache/kylin/pull/536/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvTWFuYWdlZFVzZXIuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/536?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/536?src=pr=footer). Last 
update 
[4abe712...ebedd89](https://codecov.io/gh/apache/kylin/pull/536?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps

[GitBox]

asfgit commented on issue #538: KYLIN-3898 Cube level properties are 
ineffective in the some build steps
URL: https://github.com/apache/kylin/pull/538#issuecomment-474753667
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #538: KYLIN-3898 Cube level properties are ineffective in the some build steps

[GitBox]

asfgit commented on issue #538: KYLIN-3898 Cube level properties are 
ineffective in the some build steps
URL: https://github.com/apache/kylin/pull/538#issuecomment-474753669
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #535: KYLIN-3895 Failed to register new MBean when "kylin.server.query-metrics-enabled" set true

[GitBox]

asfgit commented on issue #535: KYLIN-3895 Failed to register new MBean when 
"kylin.server.query-metrics-enabled" set true
URL: https://github.com/apache/kylin/pull/535#issuecomment-474661100
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] guangxuCheng opened a new pull request #535: KYLIN-3895 Failed to register new MBean when "kylin.server.query-metrics-enabled" set true

[GitBox]

guangxuCheng opened a new pull request #535: KYLIN-3895 Failed to register new 
MBean when "kylin.server.query-metrics-enabled" set true
URL: https://github.com/apache/kylin/pull/535
 
 
   see: https://issues.apache.org/jira/browse/KYLIN-3895


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #537: KYLIN-3896 Implement IFlinkOutput based on HBase

[GitBox]

shaofengshi merged pull request #537: KYLIN-3896 Implement IFlinkOutput based 
on HBase
URL: https://github.com/apache/kylin/pull/537
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #539: KYLIN-3897 Implement IFlinkInput based on Hive

[GitBox]

shaofengshi merged pull request #539: KYLIN-3897 Implement IFlinkInput based on 
Hive
URL: https://github.com/apache/kylin/pull/539
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #536: KYLIN-3474 Tableau 10.5 get malformed token

[GitBox]

asfgit commented on issue #536: KYLIN-3474 Tableau 10.5 get malformed token
URL: https://github.com/apache/kylin/pull/536#issuecomment-474662782
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] TempleZhou opened a new pull request #536: KYLIN-3474 Tableau 10.5 get malformed token

[GitBox]

TempleZhou opened a new pull request #536: KYLIN-3474 Tableau 10.5 get 
malformed token
URL: https://github.com/apache/kylin/pull/536
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #536: KYLIN-3474 Tableau 10.5 get malformed token

[GitBox]

asfgit commented on issue #536: KYLIN-3474 Tableau 10.5 get malformed token
URL: https://github.com/apache/kylin/pull/536#issuecomment-474662781
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #535: KYLIN-3895 Failed to register new MBean when "kylin.server.query-metrics-enabled" set true

[GitBox]

codecov-io commented on issue #535: KYLIN-3895 Failed to register new MBean 
when "kylin.server.query-metrics-enabled" set true
URL: https://github.com/apache/kylin/pull/535#issuecomment-474666849
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/535?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@4abe712`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/535/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/535?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #535   +/-   ##
   =
 Coverage  ?   24.42%   
 Complexity? 5025   
   =
 Files ? 1161   
 Lines ?70461   
 Branches  ?10020   
   =
 Hits  ?17208   
 Misses?51518   
 Partials  ? 1735
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/535?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/kylin/rest/metrics/QueryMetricsFacade.java](https://codecov.io/gh/apache/kylin/pull/535/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvbWV0cmljcy9RdWVyeU1ldHJpY3NGYWNhZGUuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/535?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/535?src=pr=footer). Last 
update 
[4abe712...70e2f49](https://codecov.io/gh/apache/kylin/pull/535?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #539: KYLIN-3897 Implement IFlinkInput based on Hive

[GitBox]

asfgit commented on issue #539: KYLIN-3897 Implement IFlinkInput based on Hive
URL: https://github.com/apache/kylin/pull/539#issuecomment-474788907
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #539: KYLIN-3897 Implement IFlinkInput based on Hive

[GitBox]

asfgit commented on issue #539: KYLIN-3897 Implement IFlinkInput based on Hive
URL: https://github.com/apache/kylin/pull/539#issuecomment-474788908
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] yanghua opened a new pull request #539: KYLIN-3897 Implement IFlinkInput based on Hive

[GitBox]

yanghua opened a new pull request #539: KYLIN-3897 Implement IFlinkInput based 
on Hive
URL: https://github.com/apache/kylin/pull/539
 
 
   JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3897


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] TempleZhou opened a new pull request #538: KYLIN-3898 Cube level properties are ineffective in the some build steps

[GitBox]

TempleZhou opened a new pull request #538: KYLIN-3898 Cube level properties are 
ineffective in the some build steps
URL: https://github.com/apache/kylin/pull/538
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] yanghua opened a new pull request #540: KYLIN-3851 Flink cubing step : merge dictionary

[GitBox]

yanghua opened a new pull request #540: KYLIN-3851 Flink cubing step : merge 
dictionary
URL: https://github.com/apache/kylin/pull/540
 
 
   JIRA ref : https://issues.apache.org/jira/browse/KYLIN-3851


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary

[GitBox]

asfgit commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary
URL: https://github.com/apache/kylin/pull/540#issuecomment-474811835
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary

[GitBox]

asfgit commented on issue #540: KYLIN-3851 Flink cubing step : merge dictionary
URL: https://github.com/apache/kylin/pull/540#issuecomment-474811834
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] asfgit commented on issue #533: kylin-3812 optimize the child CompareTupleFilter in a CompareTupleFilter

[GitBox]

asfgit commented on issue #533: kylin-3812 optimize the child 
CompareTupleFilter in a CompareTupleFilter
URL: https://github.com/apache/kylin/pull/533#issuecomment-474179709
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] kyotoYaho opened a new pull request #533: kylin-3812 optimize the child CompareTupleFilter in a CompareTupleFilter

[GitBox]

kyotoYaho opened a new pull request #533: kylin-3812 optimize the child 
CompareTupleFilter in a CompareTupleFilter
URL: https://github.com/apache/kylin/pull/533
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services