[GitHub] asfgit commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not friendly
asfgit commented on issue #462: KYLIN-3804 Advanced Snapshot Table save not friendly URL: https://github.com/apache/kylin/pull/462#issuecomment-459705960 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #460: KYLIN-3800 Measure get incorrect result
asfgit commented on issue #460: KYLIN-3800 Measure get incorrect result URL: https://github.com/apache/kylin/pull/460#issuecomment-459282885 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #460: KYLIN-3800 Measure get incorrect result
asfgit commented on issue #460: KYLIN-3800 Measure get incorrect result URL: https://github.com/apache/kylin/pull/460#issuecomment-459282883 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hit-lacus opened a new pull request #459: KYLIN-3798 SQL Server cannot show databases
hit-lacus opened a new pull request #459: KYLIN-3798 SQL Server cannot show databases URL: https://github.com/apache/kylin/pull/459 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #460: KYLIN-3800 Measure get incorrect result
asfgit commented on issue #460: KYLIN-3800 Measure get incorrect result URL: https://github.com/apache/kylin/pull/460#issuecomment-459282888 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Wayne1c opened a new pull request #460: KYLIN-3800 Measure get incorrect result
Wayne1c opened a new pull request #460: KYLIN-3800 Measure get incorrect result URL: https://github.com/apache/kylin/pull/460 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #459: KYLIN-3798 SQL Server cannot show databases
asfgit commented on issue #459: KYLIN-3798 SQL Server cannot show databases URL: https://github.com/apache/kylin/pull/459#issuecomment-459282819 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #459: KYLIN-3798 SQL Server cannot show databases
asfgit commented on issue #459: KYLIN-3798 SQL Server cannot show databases URL: https://github.com/apache/kylin/pull/459#issuecomment-459282817 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #459: KYLIN-3798 SQL Server cannot show databases
asfgit commented on issue #459: KYLIN-3798 SQL Server cannot show databases URL: https://github.com/apache/kylin/pull/459#issuecomment-459282818 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allenma merged pull request #460: KYLIN-3800 Measure get incorrect result
allenma merged pull request #460: KYLIN-3800 Measure get incorrect result URL: https://github.com/apache/kylin/pull/460 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #459: KYLIN-3798 SQL Server cannot show databases
codecov-io commented on issue #459: KYLIN-3798 SQL Server cannot show databases URL: https://github.com/apache/kylin/pull/459#issuecomment-459295752 # [Codecov](https://codecov.io/gh/apache/kylin/pull/459?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@24f1987`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `80%`. [](https://codecov.io/gh/apache/kylin/pull/459?src=pr=tree) ```diff @@Coverage Diff@@ ## master #459 +/- ## = Coverage ? 24.48% Complexity? 4961 = Files ? 1143 Lines ?69390 Branches ? 9893 = Hits ?16987 Misses?50689 Partials ? 1714 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/459?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/source/jdbc/metadata/SQLServerJdbcMetadata.java](https://codecov.io/gh/apache/kylin/pull/459/diff?src=pr=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL1NRTFNlcnZlckpkYmNNZXRhZGF0YS5qYXZh) | `92.3% <80%> (ø)` | `4 <3> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/459?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/459?src=pr=footer). Last update [24f1987...599ec6b](https://codecov.io/gh/apache/kylin/pull/459?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #459: KYLIN-3798 SQL Server cannot show databases
coveralls commented on issue #459: KYLIN-3798 SQL Server cannot show databases URL: https://github.com/apache/kylin/pull/459#issuecomment-459321178 ## Pull Request Test Coverage Report for [Build 4104](https://coveralls.io/builds/21376487) * **5** of **5** **(100.0%)** changed or added relevant lines in **1** file are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.007%**) to **26.956%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21376487/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/21376487) | | :-- | --: | | Change from base [Build 4103](https://coveralls.io/builds/21370739): | 0.007% | | Covered Lines: | 18705 | | Relevant Lines: | 69390 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh
asfgit commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh URL: https://github.com/apache/kylin/pull/461#issuecomment-459394616 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh
codecov-io commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh URL: https://github.com/apache/kylin/pull/461#issuecomment-459407066 # [Codecov](https://codecov.io/gh/apache/kylin/pull/461?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@24f1987`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/461?src=pr=tree) ```diff @@Coverage Diff@@ ## master #461 +/- ## = Coverage ? 24.47% Complexity? 4961 = Files ? 1143 Lines ?69390 Branches ? 9893 = Hits ?16986 Misses?50690 Partials ? 1714 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/461?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/461?src=pr=footer). Last update [24f1987...d84724d](https://codecov.io/gh/apache/kylin/pull/461?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh
coveralls commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh URL: https://github.com/apache/kylin/pull/461#issuecomment-459407922 ## Pull Request Test Coverage Report for [Build 4106](https://coveralls.io/builds/21382926) * **0** of **0** changed or added relevant lines in **0** files are covered. * **4** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.006%**) to **26.955%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/21382926/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% | | Totals | [](https://coveralls.io/builds/21382926) | | :-- | --: | | Change from base [Build 4103](https://coveralls.io/builds/21370739): | 0.006% | | Covered Lines: | 18704 | | Relevant Lines: | 69390 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh
asfgit commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh URL: https://github.com/apache/kylin/pull/461#issuecomment-459394612 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kikniknik opened a new pull request #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh
kikniknik opened a new pull request #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh URL: https://github.com/apache/kylin/pull/461 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh
asfgit commented on issue #461: KYLIN-3801 Add --text flag in grep in find-hive-dependency.sh URL: https://github.com/apache/kylin/pull/461#issuecomment-459394609 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen commented on issue #579: KYLIN-3926 set sourceRecordCount when updating statistics
nichunen commented on issue #579: KYLIN-3926 set sourceRecordCount when updating statistics URL: https://github.com/apache/kylin/pull/579#issuecomment-481942009 Should SparkMergingDictionary MergeDictionaryMapper also be changed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job
codecov-io commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job URL: https://github.com/apache/kylin/pull/594#issuecomment-481996978 # [Codecov](https://codecov.io/gh/apache/kylin/pull/594?src=pr=h1) Report > Merging [#594](https://codecov.io/gh/apache/kylin/pull/594?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ddc51f3307616a33536c76ff61023b7634e3d289?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/594?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #594 +/- ## - Coverage 25.25% 25.24% -0.02% + Complexity 5811 5810 -1 Files 1379 1379 Lines 8166981677 +8 Branches 1143611438 +2 - Hits 2062820618 -10 - Misses5902759042 +15 - Partials 2014 2017 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/594?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...n/java/org/apache/kylin/rest/util/AclEvaluate.java](https://codecov.io/gh/apache/kylin/pull/594/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9BY2xFdmFsdWF0ZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/594/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `37.77% <0%> (-0.39%)` | `44 <0> (ø)` | | | [...java/org/apache/kylin/rest/service/JobService.java](https://codecov.io/gh/apache/kylin/pull/594/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9Kb2JTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/594/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/594/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `48.83% <0%> (-3.49%)` | `7% <0%> (ø)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/594/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/594/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/594?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/594?src=pr=footer). Last update [ddc51f3...3e771c2](https://codecov.io/gh/apache/kylin/pull/594?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] Wayne1c closed pull request #591: KYLIN-3946 Fix count column compatibility
Wayne1c closed pull request #591: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #593: KYLIN-3946 Fix count column compatibility
codecov-io commented on issue #593: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/593#issuecomment-481986395 # [Codecov](https://codecov.io/gh/apache/kylin/pull/593?src=pr=h1) Report > Merging [#593](https://codecov.io/gh/apache/kylin/pull/593?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ddc51f3307616a33536c76ff61023b7634e3d289?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/593?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #593 +/- ## - Coverage 25.25% 25.24% -0.02% + Complexity 5811 5810 -1 Files 1379 1379 Lines 8166981682 +13 Branches 1143611441 +5 - Hits 2062820619 -9 - Misses5902759046 +19 - Partials 2014 2017 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/593?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...a/org/apache/kylin/cube/CubeCapabilityChecker.java](https://codecov.io/gh/apache/kylin/pull/593/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVDYXBhYmlsaXR5Q2hlY2tlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/kylin/query/relnode/OLAPAggregateRel.java](https://codecov.io/gh/apache/kylin/pull/593/diff?src=pr=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JlbG5vZGUvT0xBUEFnZ3JlZ2F0ZVJlbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/593/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/593/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `48.83% <0%> (-3.49%)` | `7% <0%> (ø)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/593/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/593/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/593/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/593/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `78.37% <0%> (+5.4%)` | `7% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/593?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/593?src=pr=footer). Last update [ddc51f3...ef8f5b7](https://codecov.io/gh/apache/kylin/pull/593?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] coveralls commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job
coveralls commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job URL: https://github.com/apache/kylin/pull/594#issuecomment-481996661 ## Pull Request Test Coverage Report for [Build 4379](https://coveralls.io/builds/22739134) * **0** of **13** **(0.0%)** changed or added relevant lines in **3** files are covered. * **11** unchanged lines in **5** files lost coverage. * Overall coverage decreased (**-0.01%**) to **27.718%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/service/JobService.java](https://coveralls.io/builds/22739134/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FJobService.java#L640) | 0 | 1 | 0.0% | [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/22739134/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L312) | 0 | 6 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/util/AclEvaluate.java](https://coveralls.io/builds/22739134/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FAclEvaluate.java#L52) | 0 | 6 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [server-base/src/main/java/org/apache/kylin/rest/util/AclEvaluate.java](https://coveralls.io/builds/22739134/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FAclEvaluate.java#L60) | 1 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/22739134/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/22739134/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L71) | 2 | 55.81% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/22739134/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22739134/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/22739134) | | :-- | --: | | Change from base [Build 4377](https://coveralls.io/builds/22736256): | -0.01% | | Covered Lines: | 22639 | | Relevant Lines: | 81677 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #593: KYLIN-3946 Fix count column compatibility
asfgit commented on issue #593: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/593#issuecomment-481977168 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] Wayne1c opened a new pull request #593: KYLIN-3946 Fix count column compatibility
Wayne1c opened a new pull request #593: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #593: KYLIN-3946 Fix count column compatibility
asfgit commented on issue #593: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/593#issuecomment-481977164 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #593: KYLIN-3946 Fix count column compatibility
asfgit commented on issue #593: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/593#issuecomment-481977165 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] coveralls commented on issue #593: KYLIN-3946 Fix count column compatibility
coveralls commented on issue #593: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/593#issuecomment-481984931 ## Pull Request Test Coverage Report for [Build 4378](https://coveralls.io/builds/22738346) * **0** of **15** **(0.0%)** changed or added relevant lines in **2** files are covered. * **11** unchanged lines in **5** files lost coverage. * Overall coverage decreased (**-0.01%**) to **27.717%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-cube/src/main/java/org/apache/kylin/cube/CubeCapabilityChecker.java](https://coveralls.io/builds/22738346/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeCapabilityChecker.java#L228) | 0 | 4 | 0.0% | [query/src/main/java/org/apache/kylin/query/relnode/OLAPAggregateRel.java](https://coveralls.io/builds/22738346/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPAggregateRel.java#L500) | 0 | 11 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [query/src/main/java/org/apache/kylin/query/relnode/OLAPAggregateRel.java](https://coveralls.io/builds/22738346/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPAggregateRel.java#L512) | 1 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/22738346/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/22738346/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L71) | 2 | 55.81% | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/22738346/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/22738346/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/22738346) | | :-- | --: | | Change from base [Build 4377](https://coveralls.io/builds/22736256): | -0.01% | | Covered Lines: | 22640 | | Relevant Lines: | 81682 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job
asfgit commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job URL: https://github.com/apache/kylin/pull/594#issuecomment-481985545 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job
asfgit commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job URL: https://github.com/apache/kylin/pull/594#issuecomment-481985546 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job
asfgit commented on issue #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job URL: https://github.com/apache/kylin/pull/594#issuecomment-481985542 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] Wayne1c opened a new pull request #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job
Wayne1c opened a new pull request #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job URL: https://github.com/apache/kylin/pull/594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #560: KYLIN-3918: Add project name in cube and job pages
shaofengshi merged pull request #560: KYLIN-3918: Add project name in cube and job pages URL: https://github.com/apache/kylin/pull/560 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #575: KYLIN-3843, List Kylin instances with their server mode on web.
codecov-io edited a comment on issue #575: KYLIN-3843, List Kylin instances with their server mode on web. URL: https://github.com/apache/kylin/pull/575#issuecomment-478833253 # [Codecov](https://codecov.io/gh/apache/kylin/pull/575?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@49cb815`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `15.27%`. [](https://codecov.io/gh/apache/kylin/pull/575?src=pr=tree) ```diff @@Coverage Diff@@ ## master #575 +/- ## = Coverage ? 25.36% Complexity? 5803 = Files ? 1374 Lines ?81205 Branches ?11384 = Hits ?20599 Misses?58592 Partials ? 2014 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/575?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lin/rest/service/ServiceDiscoveryStateService.java](https://codecov.io/gh/apache/kylin/pull/575/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9TZXJ2aWNlRGlzY292ZXJ5U3RhdGVTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/575/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `13.15% <0%> (ø)` | `41 <0> (?)` | | | [...org/apache/kylin/common/restclient/RestClient.java](https://codecov.io/gh/apache/kylin/pull/575/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9yZXN0Y2xpZW50L1Jlc3RDbGllbnQuamF2YQ==) | `13.52% <0%> (ø)` | `3 <0> (?)` | | | [...st/controller/ServiceDiscoveryStateController.java](https://codecov.io/gh/apache/kylin/pull/575/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TZXJ2aWNlRGlzY292ZXJ5U3RhdGVDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../kylin/job/impl/curator/CuratorLeaderSelector.java](https://codecov.io/gh/apache/kylin/pull/575/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL2N1cmF0b3IvQ3VyYXRvckxlYWRlclNlbGVjdG9yLmphdmE=) | `67.44% <100%> (ø)` | `8 <1> (?)` | | | [...pache/kylin/job/impl/curator/CuratorScheduler.java](https://codecov.io/gh/apache/kylin/pull/575/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL2N1cmF0b3IvQ3VyYXRvclNjaGVkdWxlci5qYXZh) | `64.1% <100%> (ø)` | `7 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/575?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/575?src=pr=footer). Last update [49cb815...443d563](https://codecov.io/gh/apache/kylin/pull/575?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen commented on issue #589: KYLIN-3892 Set cubing job priority
nichunen commented on issue #589: KYLIN-3892 Set cubing job priority URL: https://github.com/apache/kylin/pull/589#issuecomment-481560472 @TempleZhou Hi, this pr has conflict with master, please resolve it. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen commented on issue #590: KYLIN-3912 fix CI
nichunen commented on issue #590: KYLIN-3912 fix CI URL: https://github.com/apache/kylin/pull/590#issuecomment-481550075 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen merged pull request #590: KYLIN-3912 fix CI
nichunen merged pull request #590: KYLIN-3912 fix CI URL: https://github.com/apache/kylin/pull/590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] chenzhx commented on issue #575: KYLIN-3843, List Kylin instances with their server mode on web.
chenzhx commented on issue #575: KYLIN-3843, List Kylin instances with their server mode on web. URL: https://github.com/apache/kylin/pull/575#issuecomment-481515846 It is fine to me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #590: KYLIN-3912 fix CI
codecov-io commented on issue #590: KYLIN-3912 fix CI URL: https://github.com/apache/kylin/pull/590#issuecomment-481556488 # [Codecov](https://codecov.io/gh/apache/kylin/pull/590?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@49cb815`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/590?src=pr=tree) ```diff @@Coverage Diff@@ ## master #590 +/- ## = Coverage ? 25.27% Complexity? 5805 = Files ? 1374 Lines ?81503 Branches ?11430 = Hits ?20603 Misses?58887 Partials ? 2013 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/590?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/kylin/source/hive/CreateMrHiveDictStep.java](https://codecov.io/gh/apache/kylin/pull/590/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NyZWF0ZU1ySGl2ZURpY3RTdGVwLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/590?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/590?src=pr=footer). Last update [49cb815...5e5f2ee](https://codecov.io/gh/apache/kylin/pull/590?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] TempleZhou commented on issue #589: KYLIN-3892 Set cubing job priority
TempleZhou commented on issue #589: KYLIN-3892 Set cubing job priority URL: https://github.com/apache/kylin/pull/589#issuecomment-481561755 > @TempleZhou Hi, this pr has conflict with master, please resolve it. Thanks Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen merged pull request #589: KYLIN-3892 Set cubing job priority
nichunen merged pull request #589: KYLIN-3892 Set cubing job priority URL: https://github.com/apache/kylin/pull/589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #590: KYLIN-3912 fix CI
asfgit commented on issue #590: KYLIN-3912 fix CI URL: https://github.com/apache/kylin/pull/590#issuecomment-481546127 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] GinaZhai opened a new pull request #590: KYLIN-3912 fix CI
GinaZhai opened a new pull request #590: KYLIN-3912 fix CI URL: https://github.com/apache/kylin/pull/590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #590: KYLIN-3912 fix CI
asfgit commented on issue #590: KYLIN-3912 fix CI URL: https://github.com/apache/kylin/pull/590#issuecomment-481546125 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #590: KYLIN-3912 fix CI
asfgit commented on issue #590: KYLIN-3912 fix CI URL: https://github.com/apache/kylin/pull/590#issuecomment-481546121 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen commented on a change in pull request #582: Read password from file for Beeline
nichunen commented on a change in pull request #582: Read password from file for Beeline URL: https://github.com/apache/kylin/pull/582#discussion_r273795697 ## File path: source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java ## @@ -27,6 +27,7 @@ import java.sql.Statement; import java.util.List; import java.util.Properties; +import java.io.*; Review comment: You can set up your kylin development environment by following http://kylin.apache.org/development/dev_env.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #595: Update events and meetup info
asfgit commented on issue #595: Update events and meetup info URL: https://github.com/apache/kylin/pull/595#issuecomment-482036427 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #595: Update events and meetup info
asfgit commented on issue #595: Update events and meetup info URL: https://github.com/apache/kylin/pull/595#issuecomment-482036430 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #595: Update events and meetup info
asfgit commented on issue #595: Update events and meetup info URL: https://github.com/apache/kylin/pull/595#issuecomment-482036428 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen merged pull request #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job
nichunen merged pull request #594: KYLIN-3938 Fix can't discard OPTMIZE CHECKPOINT job URL: https://github.com/apache/kylin/pull/594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #595: Update events and meetup info
shaofengshi merged pull request #595: Update events and meetup info URL: https://github.com/apache/kylin/pull/595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] GinaZhai opened a new pull request #595: Update events and meetup info
GinaZhai opened a new pull request #595: Update events and meetup info URL: https://github.com/apache/kylin/pull/595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen merged pull request #593: KYLIN-3946 Fix count column compatibility
nichunen merged pull request #593: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #588: Update document
shaofengshi commented on issue #588: Update document URL: https://github.com/apache/kylin/pull/588#issuecomment-481619954 Merged, thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #588: Update document
shaofengshi merged pull request #588: Update document URL: https://github.com/apache/kylin/pull/588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #592: Update Kylin architecture diagram
asfgit commented on issue #592: Update Kylin architecture diagram URL: https://github.com/apache/kylin/pull/592#issuecomment-481645803 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #592: Update Kylin architecture diagram
asfgit commented on issue #592: Update Kylin architecture diagram URL: https://github.com/apache/kylin/pull/592#issuecomment-481645805 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #592: Update Kylin architecture diagram
asfgit commented on issue #592: Update Kylin architecture diagram URL: https://github.com/apache/kylin/pull/592#issuecomment-481645804 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] GinaZhai opened a new pull request #592: Update Kylin architecture diagram
GinaZhai opened a new pull request #592: Update Kylin architecture diagram URL: https://github.com/apache/kylin/pull/592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen merged pull request #575: KYLIN-3843, List Kylin instances with their server mode on web.
nichunen merged pull request #575: KYLIN-3843, List Kylin instances with their server mode on web. URL: https://github.com/apache/kylin/pull/575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #591: KYLIN-3946 Fix count column compatibility
asfgit commented on issue #591: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/591#issuecomment-481616549 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #591: KYLIN-3946 Fix count column compatibility
asfgit commented on issue #591: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/591#issuecomment-481616550 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] Wayne1c opened a new pull request #591: KYLIN-3946 Fix count column compatibility
Wayne1c opened a new pull request #591: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #591: KYLIN-3946 Fix count column compatibility
asfgit commented on issue #591: KYLIN-3946 Fix count column compatibility URL: https://github.com/apache/kylin/pull/591#issuecomment-481616551 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen merged pull request #592: Update Kylin architecture diagram
nichunen merged pull request #592: Update Kylin architecture diagram URL: https://github.com/apache/kylin/pull/592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] freewh opened a new pull request #587: KYLIN-3934 add config for sqoop config null-string and null-non-string
freewh opened a new pull request #587: KYLIN-3934 add config for sqoop config null-string and null-non-string URL: https://github.com/apache/kylin/pull/587 add config for sqoop config null-string and null-non-string fix build error with adding source version and target version in scala-maven-plugin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #587: KYLIN-3934 add config for sqoop config null-string and null-non-string
asfgit commented on issue #587: KYLIN-3934 add config for sqoop config null-string and null-non-string URL: https://github.com/apache/kylin/pull/587#issuecomment-481092774 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #587: KYLIN-3934 add config for sqoop config null-string and null-non-string
asfgit commented on issue #587: KYLIN-3934 add config for sqoop config null-string and null-non-string URL: https://github.com/apache/kylin/pull/587#issuecomment-481092773 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] zhaojintaozhao commented on issue #583: KYLIN-3788 modify the time conversion time zone of the kafka streaming access; It solves the problems that the kafka stream time is different f
zhaojintaozhao commented on issue #583: KYLIN-3788 modify the time conversion time zone of the kafka streaming access; It solves the problems that the kafka stream time is different from the real time URL: https://github.com/apache/kylin/pull/583#issuecomment-481089274 In my Kylin system, this pull requests solve the problem of time errors in kafka streaming tasks. I hope my code can be fitted into the kylin trunk brach. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] coveralls commented on issue #587: KYLIN-3934 add config for sqoop config null-string and null-non-string
coveralls commented on issue #587: KYLIN-3934 add config for sqoop config null-string and null-non-string URL: https://github.com/apache/kylin/pull/587#issuecomment-481097377 ## Pull Request Test Coverage Report for [Build 4365](https://coveralls.io/builds/22685927) * **0** of **5** **(0.0%)** changed or added relevant lines in **2** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.001%**) to **27.739%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/22685927/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1011) | 0 | 2 | 0.0% | [source-jdbc/src/main/java/org/apache/kylin/source/jdbc/JdbcHiveInputBase.java](https://coveralls.io/builds/22685927/source?filename=source-jdbc%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fjdbc%2FJdbcHiveInputBase.java#L173) | 0 | 3 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/22685927/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | Totals | [](https://coveralls.io/builds/22685927) | | :-- | --: | | Change from base [Build 4364](https://coveralls.io/builds/22685230): | -0.001% | | Covered Lines: | 22611 | | Relevant Lines: | 81512 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #585: KYLIN-3936 MR/Spark task will still run after the job is stopped
codecov-io commented on issue #585: KYLIN-3936 MR/Spark task will still run after the job is stopped URL: https://github.com/apache/kylin/pull/585#issuecomment-481087044 # [Codecov](https://codecov.io/gh/apache/kylin/pull/585?src=pr=h1) Report > Merging [#585](https://codecov.io/gh/apache/kylin/pull/585?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/e9dfaf9a5465ff3f6f3bfa3460ca8b2adb8c6617?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/585?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #585 +/- ## + Coverage 25.26% 25.26% +<.01% Complexity 5803 5803 Files 1374 1374 Lines 8150881524 +16 Branches 1142911435 +6 + Hits 2059220598 +6 - Misses5890158913 +12 + Partials 2015 2013 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/585?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/kylin/job/execution/ExecutableManager.java](https://codecov.io/gh/apache/kylin/pull/585/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vRXhlY3V0YWJsZU1hbmFnZXIuamF2YQ==) | `32.32% <0%> (-1.01%)` | `35 <0> (ø)` | | | [...java/org/apache/kylin/rest/service/JobService.java](https://codecov.io/gh/apache/kylin/pull/585/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9Kb2JTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/kylin/rest/controller/JobController.java](https://codecov.io/gh/apache/kylin/pull/585/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9Kb2JDb250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/585/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/585/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/585?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/585?src=pr=footer). Last update [e9dfaf9...224ac4c](https://codecov.io/gh/apache/kylin/pull/585?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi commented on a change in pull request #582: Read password from file for Beeline
shaofengshi commented on a change in pull request #582: Read password from file for Beeline URL: https://github.com/apache/kylin/pull/582#discussion_r273348735 ## File path: source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java ## @@ -27,6 +27,7 @@ import java.sql.Statement; import java.util.List; import java.util.Properties; +import java.io.*; Review comment: I think "import *" is not allowed in Kylin's static code analysis. Could you please change to use the detailed class import? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #556: KYLIN-3912: Support cube level mapreduuce queue config for BeelineHiveClient
shaofengshi merged pull request #556: KYLIN-3912: Support cube level mapreduuce queue config for BeelineHiveClient URL: https://github.com/apache/kylin/pull/556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen commented on issue #435: when dimvalue`s len > short.max_value then [Extract Fact Table Distinct Columns] err
nichunen commented on issue #435: when dimvalue`s len > short.max_value then [Extract Fact Table Distinct Columns] err URL: https://github.com/apache/kylin/pull/435#issuecomment-481174883 After discussed with @javalife0312 We think this is not a common case, and there is workaround way to deal with long dimensions. Close this pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen closed pull request #435: when dimvalue`s len > short.max_value then [Extract Fact Table Distinct Columns] err
nichunen closed pull request #435: when dimvalue`s len > short.max_value then [Extract Fact Table Distinct Columns] err URL: https://github.com/apache/kylin/pull/435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #588: Update document
asfgit commented on issue #588: Update document URL: https://github.com/apache/kylin/pull/588#issuecomment-481112114 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #588: Update document
asfgit commented on issue #588: Update document URL: https://github.com/apache/kylin/pull/588#issuecomment-481112113 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] GinaZhai opened a new pull request #588: Update document
GinaZhai opened a new pull request #588: Update document URL: https://github.com/apache/kylin/pull/588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #586: KYLIN-3608 Move dependency versions to top level pom properties
shaofengshi merged pull request #586: KYLIN-3608 Move dependency versions to top level pom properties URL: https://github.com/apache/kylin/pull/586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] GinaZhai opened a new pull request #596: Add Kylin Configuration and update docs URL for 3.0
GinaZhai opened a new pull request #596: Add Kylin Configuration and update docs URL for 3.0 URL: https://github.com/apache/kylin/pull/596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #596: Add Kylin Configuration and update docs URL for 3.0
asfgit commented on issue #596: Add Kylin Configuration and update docs URL for 3.0 URL: https://github.com/apache/kylin/pull/596#issuecomment-482415700 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #596: Add Kylin Configuration and update docs URL for 3.0
asfgit commented on issue #596: Add Kylin Configuration and update docs URL for 3.0 URL: https://github.com/apache/kylin/pull/596#issuecomment-482415698 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #596: Add Kylin Configuration and update docs URL for 3.0
asfgit commented on issue #596: Add Kylin Configuration and update docs URL for 3.0 URL: https://github.com/apache/kylin/pull/596#issuecomment-482415702 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable
asfgit commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable URL: https://github.com/apache/kylin/pull/597#issuecomment-482426534 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] Wayne1c opened a new pull request #597: KYLIN-3950 Make optimize job algorithm configurable
Wayne1c opened a new pull request #597: KYLIN-3950 Make optimize job algorithm configurable URL: https://github.com/apache/kylin/pull/597 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable
asfgit commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable URL: https://github.com/apache/kylin/pull/597#issuecomment-482426536 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable
asfgit commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable URL: https://github.com/apache/kylin/pull/597#issuecomment-482426535 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable
codecov-io commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable URL: https://github.com/apache/kylin/pull/597#issuecomment-482475930 # [Codecov](https://codecov.io/gh/apache/kylin/pull/597?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@8f5f830`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/597?src=pr=tree) ```diff @@Coverage Diff@@ ## master #597 +/- ## = Coverage ? 25.24% Complexity? 5810 = Files ? 1379 Lines ?81691 Branches ?11443 = Hits ?20626 Misses?59050 Partials ? 2015 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/597?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/597/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `13.14% <0%> (ø)` | `42 <0> (?)` | | | [...kylin/engine/mr/common/StatisticsDecisionUtil.java](https://codecov.io/gh/apache/kylin/pull/597/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL1N0YXRpc3RpY3NEZWNpc2lvblV0aWwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/597?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/597?src=pr=footer). Last update [8f5f830...35b896f](https://codecov.io/gh/apache/kylin/pull/597?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #598: KYLIN-3932 KafkaConfigOverride to take effect
codecov-io commented on issue #598: KYLIN-3932 KafkaConfigOverride to take effect URL: https://github.com/apache/kylin/pull/598#issuecomment-482488241 # [Codecov](https://codecov.io/gh/apache/kylin/pull/598?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@8f5f830`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/598?src=pr=tree) ```diff @@Coverage Diff@@ ## master #598 +/- ## = Coverage ? 25.24% Complexity? 5810 = Files ? 1379 Lines ?81694 Branches ?11443 = Hits ?20623 Misses?59055 Partials ? 2016 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/598?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/kylin/stream/source/kafka/KafkaSource.java](https://codecov.io/gh/apache/kylin/pull/598/diff?src=pr=tree#diff-c3RyZWFtLXNvdXJjZS1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RyZWFtL3NvdXJjZS9rYWZrYS9LYWZrYVNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/598?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/598?src=pr=footer). Last update [8f5f830...5ac19d5](https://codecov.io/gh/apache/kylin/pull/598?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] nichunen merged pull request #597: KYLIN-3950 Make optimize job algorithm configurable
nichunen merged pull request #597: KYLIN-3950 Make optimize job algorithm configurable URL: https://github.com/apache/kylin/pull/597 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] javalife0312 opened a new pull request #598: KYLIN-3932 KafkaConfigOverride to take effect
javalife0312 opened a new pull request #598: KYLIN-3932 KafkaConfigOverride to take effect URL: https://github.com/apache/kylin/pull/598 KafkaSource load method need kafka propeties to structure kafkaConsumer; but default code can not pass cube overwrite properties to use like : kylin.source.kafka.config-override.security.protoco SASL_PLAINTEXT kylin.source.kafka.config-override.sasl.mechanism PLAIN kylin.source.kafka.config-override.sasl.jaas.config sasl.jaas.config kylin.source.kafka.config-override.group.id group_id https://issues.apache.org/jira/browse/KYLIN-3932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #598: KYLIN-3932 KafkaConfigOverride to take effect
asfgit commented on issue #598: KYLIN-3932 KafkaConfigOverride to take effect URL: https://github.com/apache/kylin/pull/598#issuecomment-482474176 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #598: KYLIN-3932 KafkaConfigOverride to take effect
asfgit commented on issue #598: KYLIN-3932 KafkaConfigOverride to take effect URL: https://github.com/apache/kylin/pull/598#issuecomment-482474174 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #598: KYLIN-3932 KafkaConfigOverride to take effect
asfgit commented on issue #598: KYLIN-3932 KafkaConfigOverride to take effect URL: https://github.com/apache/kylin/pull/598#issuecomment-482474175 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] coveralls commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable
coveralls commented on issue #597: KYLIN-3950 Make optimize job algorithm configurable URL: https://github.com/apache/kylin/pull/597#issuecomment-482431231 ## Pull Request Test Coverage Report for [Build 4382](https://coveralls.io/builds/22762779) * **0** of **2** **(0.0%)** changed or added relevant lines in **2** files are covered. * **2** unchanged lines in **1** file lost coverage. * Overall coverage decreased (**-0.003%**) to **27.718%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/22762779/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L609) | 0 | 1 | 0.0% | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/StatisticsDecisionUtil.java](https://coveralls.io/builds/22762779/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FStatisticsDecisionUtil.java#L51) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/22762779/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% | | Totals | [](https://coveralls.io/builds/22762779) | | :-- | --: | | Change from base [Build 4381](https://coveralls.io/builds/22762295): | -0.003% | | Covered Lines: | 22643 | | Relevant Lines: | 81691 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] asfgit commented on issue #606: update blog
asfgit commented on issue #606: update blog URL: https://github.com/apache/kylin/pull/606#issuecomment-483095641 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] GinaZhai opened a new pull request #606: update blog
GinaZhai opened a new pull request #606: update blog URL: https://github.com/apache/kylin/pull/606 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #606: update blog
shaofengshi merged pull request #606: update blog URL: https://github.com/apache/kylin/pull/606 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi closed pull request #601: KYLIN-3955 Real-time streaming tech blog
shaofengshi closed pull request #601: KYLIN-3955 Real-time streaming tech blog URL: https://github.com/apache/kylin/pull/601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #601: KYLIN-3955 Real-time streaming tech blog
shaofengshi commented on issue #601: KYLIN-3955 Real-time streaming tech blog URL: https://github.com/apache/kylin/pull/601#issuecomment-483134855 Merged together with a refine commit, in another pr. Thank you Gang! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
