date:20191013

[jira] [Created] (SOLR-13842) Remove wt=json from Implicit API definition's defaults

2019-10-13 Thread Munendra S N (Jira)

Munendra S N created SOLR-13842:
---

 Summary: Remove wt=json from Implicit API definition's defaults
 Key: SOLR-13842
 URL: https://issues.apache.org/jira/browse/SOLR-13842
 Project: Solr
  Issue Type: Task
  Security Level: Public (Default Security Level. Issues are Public)
Reporter: Munendra S N


>From solr 7, {{json}} is the default response writer. So, {{wt=json}} can be 
>removed from implicit API definitions



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API

2019-10-13 Thread Munendra S N (Jira)



[ 
https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950715#comment-16950715
 ] 

Munendra S N commented on SOLR-13827:
-

I have raised the PR. 

> Fail on Unknown operation in Request Parameters API
> ---
>
> Key: SOLR-13827
> URL: https://issues.apache.org/jira/browse/SOLR-13827
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: config-api
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-13827.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Request Parameters API supports set, update and delete operations. For any 
> other operation, The API should fail and return error.
> Currently, for unknown operation API returns 200 status
> The config/overlay API fails on unknown operations



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] munendrasn opened a new pull request #949: SOLR-13827: fail on unknown operation in request params API

2019-10-13 Thread GitBox

munendrasn opened a new pull request #949: SOLR-13827: fail on unknown 
operation in request params API
URL: https://github.com/apache/lucene-solr/pull/949
 
 
   
   
   
   # Description
   
   Please provide a short description of the changes you're making with this 
pull request.
   
   # Solution
   
   Please provide a short description of the approach taken to implement your 
solution.
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch 
implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [ ] I am authorized to contribute this code to the ASF and have removed 
any code I do not have a license to distribute.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `master` branch.
   - [ ] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Assigned] (SOLR-13403) Terms component fails for DatePointField

2019-10-13 Thread Munendra S N (Jira)



 [ 
https://issues.apache.org/jira/browse/SOLR-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Munendra S N reassigned SOLR-13403:
---

Assignee: Munendra S N

> Terms component fails for DatePointField
> 
>
> Key: SOLR-13403
> URL: https://issues.apache.org/jira/browse/SOLR-13403
> Project: Solr
>  Issue Type: Bug
>  Components: SearchComponents - other
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Major
> Attachments: SOLR-13403.patch, SOLR-13403.patch, SOLR-13403.patch
>
>
> Getting terms for PointFields except DatePointField. For DatePointField, the 
> request fails NPE



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13403) Terms component fails for DatePointField

2019-10-13 Thread Munendra S N (Jira)



[ 
https://issues.apache.org/jira/browse/SOLR-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950710#comment-16950710
 ] 

Munendra S N commented on SOLR-13403:
-

 [^SOLR-13403.patch] 
Slightly refactored one, where object to string is handled similarly, how it is 
handled in other place in codebase

> Terms component fails for DatePointField
> 
>
> Key: SOLR-13403
> URL: https://issues.apache.org/jira/browse/SOLR-13403
> Project: Solr
>  Issue Type: Bug
>  Components: SearchComponents - other
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13403.patch, SOLR-13403.patch, SOLR-13403.patch
>
>
> Getting terms for PointFields except DatePointField. For DatePointField, the 
> request fails NPE



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-13403) Terms component fails for DatePointField

2019-10-13 Thread Munendra S N (Jira)



 [ 
https://issues.apache.org/jira/browse/SOLR-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Munendra S N updated SOLR-13403:

Attachment: SOLR-13403.patch

> Terms component fails for DatePointField
> 
>
> Key: SOLR-13403
> URL: https://issues.apache.org/jira/browse/SOLR-13403
> Project: Solr
>  Issue Type: Bug
>  Components: SearchComponents - other
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13403.patch, SOLR-13403.patch, SOLR-13403.patch
>
>
> Getting terms for PointFields except DatePointField. For DatePointField, the 
> request fails NPE



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13824) JSON Request API ignores prematurely closing curly brace.

2019-10-13 Thread Munendra S N (Jira)



[ 
https://issues.apache.org/jira/browse/SOLR-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950709#comment-16950709
 ] 

Munendra S N commented on SOLR-13824:
-

Hey [~mkhl]
Few other observations
* In some cases, Utils.fromJSON is used which calls {{getVal()}} directly.
* 
[CommandOperation|https://github.com/apache/lucene-solr/blob/b6ea7d60b7005d29400161eae291e51697a11b05/solr/solrj/src/java/org/apache/solr/common/util/CommandOperation.java#L268]
 also calls {{getVal()}} directly. I was able to reproduce the issue with here 
too

So, I was thinking probably a fix might need changes in {{getVal()}}
Something like
{code:java}
public Object getVal(boolean validateEOF) {
Object val = _getVal();
// validate for EOF
return val;
}
public Object getVal() {
return getVal(true);
}
{code}
Current, {{getVal}} becomes {{_getVal}}
So, by default we validate EOF and commandOperation can disable this and handle 
separately

Current patch LGTM as it fixes in JSON request API. It would be great if we 
could fix all such issues irrespective of the API.
If we are going ahead with the current patch then few suggestions
* can we please {{expectThrows}} to validate exception thrown
* {{Throws \{@link IllegalArgumentException} otherwise}}, I think this should 
have been {{Throws \{@link ParseException} otherwise}}

Also, I was able to reproduce this issue for extra }. Is there any other 
scenario where we could enter same issue. If so, patch would still work but we 
might need to change the error message

> JSON Request API ignores prematurely closing curly brace. 
> --
>
> Key: SOLR-13824
> URL: https://issues.apache.org/jira/browse/SOLR-13824
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: JSON Request API
>Reporter: Mikhail Khludnev
>Priority: Major
> Attachments: SOLR-13824.patch
>
>
> {code:java}
> json={query:"content:foo", facet:{zz:{field:id}}}
> {code}
> this works fine, but if we mistype {{}}} instead of {{,}}
> {code:java}
> json={query:"content:foo"} facet:{zz:{field:id}}}
> {code}
> It's captured only partially, here's we have under debug
> {code:java}
>   "json":{"query":"content:foo"},
> {code}
> I suppose it should throw an error with 400 code.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] noblepaul opened a new pull request #948: SOLR-13841: Add jackson databind annotations to SolrJ classpath

2019-10-13 Thread GitBox

noblepaul opened a new pull request #948: SOLR-13841: Add jackson databind
annotations to SolrJ classpath
URL: https://github.com/apache/lucene-solr/pull/948

# Description

Please provide a short description of the changes you're making with this
pull request.

# Solution

Please provide a short description of the approach taken to implement your
solution.

# Tests

Please describe the tests you've developed or run to confirm this patch
implements the feature or solves the problem.

# Checklist

Please review the following and check all that apply:

- [ ] I have reviewed the guidelines for [How to
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms
to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request
title.
- [ ] I am authorized to contribute this code to the ASF and have removed
any code I do not have a license to distribute.
- [ ] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `ant precommit` and the appropriate test suite.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

71 matches

Mail list logo