[GitHub] [lucene] vigyasharma commented on issue #12000: Lucene-facet leaves ThreadLocal that creates a memory leak
vigyasharma commented on issue #12000: URL: https://github.com/apache/lucene/issues/12000#issuecomment-1396551522 Removed UTF8TaxonomyWriterCache from main, and deprecated it in 9.x. We now default to LruTaxonomyWriterCache. PRs have been merged in. Closing this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] vigyasharma closed issue #12000: Lucene-facet leaves ThreadLocal that creates a memory leak
vigyasharma closed issue #12000: Lucene-facet leaves ThreadLocal that creates a memory leak URL: https://github.com/apache/lucene/issues/12000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] vigyasharma commented on issue #12082: LeafFieldComparator setBottom not being called before compareBottom
vigyasharma commented on issue #12082: URL: https://github.com/apache/lucene/issues/12082#issuecomment-1396549638 I think you're right that `bottom` should be scoped outside the `LeafFieldComparator`. It stores the bottom slot value for competitive hits and should survive across leaf contexts. I checked a few FieldComparator implementations however, and I do see it scoped outside the LeafFieldComparator. For e.g. [DoubleComparator](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java#L32), and [DocComparator](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java#L31) This also seems to be the case in Lucene 8.11.2 ([[1]](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.11.2/lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java#L33), [[2]](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.11.2/lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java#L34)) Can you share code references/links for some comparators where you see this is an issue? Or perhaps a test which reproduces this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] LuXugang merged pull request #12084: Same bound with fallbackQuery
LuXugang merged PR #12084: URL: https://github.com/apache/lucene/pull/12084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)
uschindler commented on code in PR #12094:
URL: https://github.com/apache/lucene/pull/12094#discussion_r1080680435
##
dev-tools/scripts/buildAndPushRelease.py:
##
@@ -120,6 +120,8 @@ def prepare(root, version, gpg_key_id, gpg_password,
gpg_home=None, sign_gradle=
print(' prepare-release')
cmd = './gradlew --no-daemon assembleRelease' \
' -Dversion.release=%s' % version
Review Comment:
Actually this should also be `-P`, but it won't break, but for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)
uschindler commented on code in PR #12094:
URL: https://github.com/apache/lucene/pull/12094#discussion_r1080679818
##
dev-tools/scripts/buildAndPushRelease.py:
##
@@ -120,6 +120,8 @@ def prepare(root, version, gpg_key_id, gpg_password,
gpg_home=None, sign_gradle=
print(' prepare-release')
cmd = './gradlew --no-daemon assembleRelease' \
' -Dversion.release=%s' % version
+ if mf_username is not None:
+cmd += ' -Dmanifest.username=%s' % mf_username
Review Comment:
This should be `-Pmanifest.username=%s`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)
uschindler commented on code in PR #12094:
URL: https://github.com/apache/lucene/pull/12094#discussion_r1080678559
##
gradle/java/jar-manifest.gradle:
##
@@ -46,7 +46,9 @@ subprojects {
if (snapshotBuild) {
return "${project.version} ${gitRev} [snapshot build, details
omitted]"
} else {
- return "${project.version} ${gitRev} -
${System.properties['user.name']} - ${buildDate} ${buildTime}"
+ def sysProps = System.properties
Review Comment:
Please don't use system properties directly for build properties; with
gradle it should be project properties. Our build system has a method to get
project properties which also falls back to sysprops. In short: use
`propertyOrDefault('manifest.username', System.properties['user.name'])`
"user.name" is a real system property, so it is correct to use it here
(otherwise you could fake it). But the project property should be given by
gradle. This also allows to set it in your local gradle.properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)
uschindler commented on code in PR #12094:
URL: https://github.com/apache/lucene/pull/12094#discussion_r1080678559
##
gradle/java/jar-manifest.gradle:
##
@@ -46,7 +46,9 @@ subprojects {
if (snapshotBuild) {
return "${project.version} ${gitRev} [snapshot build, details
omitted]"
} else {
- return "${project.version} ${gitRev} -
${System.properties['user.name']} - ${buildDate} ${buildTime}"
+ def sysProps = System.properties
Review Comment:
Please don't use system properties directly, with gradle it should be
project propreties. Our build system has a method to get project properties
which also falls back to sysprops. In short: use
`propertyOrDefault('manifest.username', System.properties['user.name'])`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] vigyasharma merged pull request #12093: Deprecate support for UTF8TaxonomyWriterCache
vigyasharma merged PR #12093: URL: https://github.com/apache/lucene/pull/12093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge
jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1080646383
##
lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java:
##
@@ -94,36 +93,83 @@ public int size() {
}
/**
- * Add node on the given level
+ * Add node on the given level. Nodes can be inserted out of order, but it
requires that the nodes
Review Comment:
Added a commit for it here:
https://github.com/jmazanec15/lucene/commit/9c54de56fa37a35bdff241abd9ebe3a6f1d8ba3a.
Running some performance tests to compare results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] vigyasharma merged pull request #12092: Remove UTF8TaxonomyWriterCache
vigyasharma merged PR #12092: URL: https://github.com/apache/lucene/pull/12092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] vigyasharma commented on pull request #12093: Deprecate support for UTF8TaxonomyWriterCache
vigyasharma commented on PR #12093: URL: https://github.com/apache/lucene/pull/12093#issuecomment-1387643504 > hange the default implementation in branch_9x to LRU as well? (either here on this issue or via #12092). I think it would be good to not default to the deprecated impl. Ah, good point. I'll update this PR to change the default here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #12093: Deprecate support for UTF8TaxonomyWriterCache
rmuir commented on PR #12093: URL: https://github.com/apache/lucene/pull/12093#issuecomment-1387508863 @vigyasharma do you intend to change the default implementation in branch_9x to LRU as well? (either here on this issue or via #12092). I think it would be good to not default to the deprecated impl. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] magibney opened a new pull request, #12095: buildAndPushRelease should optionally pause before assembleRelease
magibney opened a new pull request, #12095: URL: https://github.com/apache/lucene/pull/12095 buildAndPushRelease currently proceeds directly from running tests to assembling the release (and signing jars). Since assembleRelease prompts for GPG key PIN, it can easily happen that the RM steps away while tests are running, and returns to find that tests have completed, but the script has failed due to timing out waiting for GPG pinentry in the `assembleRelease` step. To address this issue, this PR adds a (optional, non-default) pause for user confirmation before proceeding to the `assembleRelease` phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] magibney opened a new pull request, #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)
magibney opened a new pull request, #12094: URL: https://github.com/apache/lucene/pull/12094 buildAndPushRelease (release script) currently sets the username portion of the `ImplementationVersion` property MANIFEST.MF entry for built jars according the local machine username of the active user. It is straightforward to support explicitly setting this value, allowing for official Apache release artifacts to consistently indicate the apache Id of the release manager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #12091: Speeding up Lucene Vector Similarity through the Java Vector API
rmuir commented on issue #12091: URL: https://github.com/apache/lucene/issues/12091#issuecomment-1386986370 There is nothing to do here about it. Convince OpenJDK to stop hostaging the vector api in incubating status like they have done for years. When it is at least in "Preview" status then we can use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #12090: Building a Lucene posting format that leverages the Java Vector API
rmuir commented on issue #12090: URL: https://github.com/apache/lucene/issues/12090#issuecomment-1386986113 There is nothing to do here about it. Convince OpenJDK to stop hostaging the vector api in incubating status like they have done for years. When it is at least in "Preview" status then we can use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #11902: Customization of Edit distance costs for different operations
rmuir commented on issue #11902: URL: https://github.com/apache/lucene/issues/11902#issuecomment-1386981136 this would be far too trappy, entirely too slow. use toy python libraries like the one referenced if you want to build toys, but this is a library for building search engines -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir closed issue #11902: Customization of Edit distance costs for different operations
rmuir closed issue #11902: Customization of Edit distance costs for different operations URL: https://github.com/apache/lucene/issues/11902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mohamedniyaz1996 commented on issue #11902: Customization of Edit distance costs for different operations
mohamedniyaz1996 commented on issue #11902: URL: https://github.com/apache/lucene/issues/11902#issuecomment-1386830082 @tang-hi , I agree it will be a dip in performance - but still it can be provided as a feature with a warning about performance drop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
