Re: [PR] Add Facets#getBulkSpecificValues method [lucene]
epotyom commented on PR #12862: URL: https://github.com/apache/lucene/pull/12862#issuecomment-1882551314 @mikemccand oh I just realised that replying to code line comment doesn't send a notification! Thank you for reviewing, I listed some alternatives above, but I still think that current approach is better and I think it's ok to only merge to 10.0, but please let me know if you think otherwise. I've rebased the branch to resolve conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Split taxonomy arrays across chunks [lucene]
msfroh commented on PR #12995: URL: https://github.com/apache/lucene/pull/12995#issuecomment-1882537143 > As far as testing, can we add some unit tests that allocate more than one chunk and exercise the new functionality? Should we also run some benchmarks to understand if there's any sort of performance regression? I can take care of the first part. @stefanvodita, do you mind running the Lucene benchmarks against this change to see how it performs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Copy collected acc(maxFreqs) into empty acc, rather than merge them. [lucene]
vsop-479 commented on code in PR #12846:
URL: https://github.com/apache/lucene/pull/12846#discussion_r1445677720
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99SkipWriter.java:
##
@@ -202,7 +202,11 @@ protected void writeSkipData(int level, DataOutput
skipBuffer) throws IOExceptio
CompetitiveImpactAccumulator competitiveFreqNorms =
curCompetitiveFreqNorms[level];
assert competitiveFreqNorms.getCompetitiveFreqNormPairs().size() > 0;
if (level + 1 < numberOfSkipLevels) {
- curCompetitiveFreqNorms[level + 1].addAll(competitiveFreqNorms);
+ if (curCompetitiveFreqNorms[level + 1].isEmpty()) {
+curCompetitiveFreqNorms[level + 1].copy(competitiveFreqNorms);
+ } else {
+curCompetitiveFreqNorms[level + 1].addAll(competitiveFreqNorms);
+ }
Review Comment:
Yes, This optimization only affects non-zero level acc.
I measured the called count with TestTermScore.testRandomTopDocs (numDocs =
TEST_NIGHTLY):
Method | count
-- | --
copy zero level (bufferSkip) | 1270
copy non zero (writeSkipData) | 214
addAll (writeSkipData) | 1196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid reset BlockDocsEnum#freqBuffer when indexHasFreq is false [lucene]
easyice commented on PR #12997: URL: https://github.com/apache/lucene/pull/12997#issuecomment-1882374457 > another approach could consist of filling at most docFreq entries in the freq buffer It's a nice idea! > I didn't know we had such leniency around frequencies/positions/offsets. Yes, It feels like it should be more clear. I found there is a big different speedup between java versions, the benchmark shows a significant speedup on java17, but only 3% on java21 **java17:** ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value PKLookup 89.14 (10.0%) 104.32 (9.1%) 17.0% ( -1% - 40%) 0.000 ``` **java21:** ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value PKLookup 113.20 (11.9%) 116.58 (10.7%)3.0% ( -17% - 28%) 0.402 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation [lucene]
github-actions[bot] commented on PR #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-1882027747 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-9634: Fix highlighting of extended intervals matched using offset [lucene]
github-actions[bot] commented on PR #16: URL: https://github.com/apache/lucene/pull/16#issuecomment-1882027687 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-9798 : Fix looping bug when calculating full KNN results in KnnGraphTester [lucene]
github-actions[bot] commented on PR #83: URL: https://github.com/apache/lucene/pull/83#issuecomment-1882027628 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Expunge big segment with oversize deletePct caused by continuously updating a batch of data [lucene]
github-actions[bot] commented on PR #92: URL: https://github.com/apache/lucene/pull/92#issuecomment-1882027550 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-9869 allow for configuring a custom cache purge scheduler in Monitor (aka Luwak) [lucene]
github-actions[bot] commented on PR #99: URL: https://github.com/apache/lucene/pull/99#issuecomment-1882027460 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query [lucene]
github-actions[bot] commented on PR #101: URL: https://github.com/apache/lucene/pull/101#issuecomment-1882027391 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-9335: [Discussion Only] Implement BMM with BulkScorer interface [lucene]
github-actions[bot] commented on PR #113: URL: https://github.com/apache/lucene/pull/113#issuecomment-1882027328 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Update spanish_stop.txt [lucene]
github-actions[bot] commented on PR #117: URL: https://github.com/apache/lucene/pull/117#issuecomment-1882027252 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10073: Reduce merging overhead of NRT by using a greater mergeFactor on tiny segments. [lucene]
github-actions[bot] commented on PR #266: URL: https://github.com/apache/lucene/pull/266#issuecomment-1882027143 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10059: Additional fix to handle n_best backtrace [lucene]
github-actions[bot] commented on PR #284: URL: https://github.com/apache/lucene/pull/284#issuecomment-1882027059 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10086: Fix an AssertionError when KoreanTokenizer tries to backtrace from and to the same position [lucene]
github-actions[bot] commented on PR #285: URL: https://github.com/apache/lucene/pull/285#issuecomment-1882026999 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10099: Add -Ptests.asyncprofile option. [lucene]
github-actions[bot] commented on PR #295: URL: https://github.com/apache/lucene/pull/295#issuecomment-1882026931 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] SOLR-15665: Move polling logic under main [lucene]
github-actions[bot] commented on PR #328: URL: https://github.com/apache/lucene/pull/328#issuecomment-1882026857 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10133: Specialize the write path for sorted doc values. [lucene]
github-actions[bot] commented on PR #330: URL: https://github.com/apache/lucene/pull/330#issuecomment-1882026779 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10202: spatial: feature-variants [lucene]
github-actions[bot] commented on PR #411: URL: https://github.com/apache/lucene/pull/411#issuecomment-1882026665 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10195: Improve Gradle build speed [lucene]
github-actions[bot] commented on PR #414: URL: https://github.com/apache/lucene/pull/414#issuecomment-1882026595 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery [lucene]
github-actions[bot] commented on PR #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-1882026525 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10230 make demo builds easier to execute [lucene]
github-actions[bot] commented on PR #433: URL: https://github.com/apache/lucene/pull/433#issuecomment-1882026451 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-8739: custom codec providing Zstandard compression/decompression [lucene]
github-actions[bot] commented on PR #439: URL: https://github.com/apache/lucene/pull/439#issuecomment-1882026368 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10247 - reduce size of FSTs by relative coding [lucene]
github-actions[bot] commented on PR #460: URL: https://github.com/apache/lucene/pull/460#issuecomment-1882026303 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10157 - Added IndriOr, IndriWeightedSum, and IndriQueryParser [lucene]
github-actions[bot] commented on PR #463: URL: https://github.com/apache/lucene/pull/463#issuecomment-1882026237 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10251: Add the compliant "Direct" doc-value format [lucene]
github-actions[bot] commented on PR #464: URL: https://github.com/apache/lucene/pull/464#issuecomment-1882026172 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10254: Remove Scorable#smoothingScore. [lucene]
github-actions[bot] commented on PR #469: URL: https://github.com/apache/lucene/pull/469#issuecomment-1882026092 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-9619: Remove IntersectVisitor from PointsTree API [lucene]
github-actions[bot] commented on PR #486: URL: https://github.com/apache/lucene/pull/486#issuecomment-1882026028 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues [lucene]
github-actions[bot] commented on PR #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-1882025949 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid use docsSeen in BKDWriter [lucene]
github-actions[bot] commented on PR #12658: URL: https://github.com/apache/lucene/pull/12658#issuecomment-1882024454 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Fix a bug in ShapeTestUtil [lucene]
heemin32 commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1881932572 There are existing tests which should fails. https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java#L67 However because we are catching exception and try until we get the correct polygon, it never fails. https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/document/BaseXYShapeTestCase.java#L228-L235 I cannot remove the try-catch statement as of now because there are bug in `surpriseMePolygon()` and `createRegularPolygon()` which fails to create a valid polygon because of type casting from double to float. One of attempt to fix it is in https://github.com/apache/lucene/pull/12757. I would like to wait until the other issues are resolved and remove the try-catch statement rather than writing a unit test for just the test utility code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] use Automaton for SurroundQuery prefix/pattern matching [lucene]
magibney opened a new pull request, #12999: URL: https://github.com/apache/lucene/pull/12999 SurroundQuery still does matching using `java.util.Pattern` (quite slow). This PR switches over SrndTruncQuery and SrndPrefixQuery to use Automaton-based matching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]
dweiss merged PR #12973: URL: https://github.com/apache/lucene/pull/12973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]
dweiss commented on code in PR #12973:
URL: https://github.com/apache/lucene/pull/12973#discussion_r1445347859
##
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/EscapeQuerySyntaxImpl.java:
##
@@ -40,105 +40,109 @@ public class EscapeQuerySyntaxImpl implements
EscapeQuerySyntax {
"AND", "OR", "NOT", "TO", "WITHIN", "SENTENCE", "PARAGRAPH", "INORDER"
};
- private static final CharSequence escapeChar(CharSequence str, Locale
locale) {
-if (str == null || str.length() == 0) return str;
+ private static CharSequence escapeChar(CharSequence str, Locale locale) {
+if (str == null || str.isEmpty()) return str;
CharSequence buffer = str;
-// regular escapable Char for terms
-for (int i = 0; i < escapableTermChars.length; i++) {
- buffer = replaceIgnoreCase(buffer,
escapableTermChars[i].toLowerCase(locale), "\\", locale);
+// regular escapable char for terms
+for (String escapableTermChar : escapableTermChars) {
+ buffer = escapeIgnoringCase(buffer,
escapableTermChar.toLowerCase(locale), "\\", locale);
}
-// First Character of a term as more escaping chars
-for (int i = 0; i < escapableTermExtraFirstChars.length; i++) {
- if (buffer.charAt(0) == escapableTermExtraFirstChars[i].charAt(0)) {
-buffer = "\\" + buffer.charAt(0) + buffer.subSequence(1,
buffer.length());
+// first char of a term as more escaping chars
+for (String escapableTermExtraFirstChar : escapableTermExtraFirstChars) {
+ if (buffer.charAt(0) == escapableTermExtraFirstChar.charAt(0)) {
+buffer = "\\" + buffer;
break;
}
}
return buffer;
}
- private final CharSequence escapeQuoted(CharSequence str, Locale locale) {
-if (str == null || str.length() == 0) return str;
+ private static CharSequence escapeQuoted(CharSequence str, Locale locale) {
+if (str == null || str.isEmpty()) return str;
CharSequence buffer = str;
-for (int i = 0; i < escapableQuotedChars.length; i++) {
- buffer = replaceIgnoreCase(buffer,
escapableTermChars[i].toLowerCase(locale), "\\", locale);
+for (String escapableQuotedChar : escapableQuotedChars) {
+ buffer = escapeIgnoringCase(buffer,
escapableQuotedChar.toLowerCase(locale), "\\", locale);
}
return buffer;
}
- private static final CharSequence escapeTerm(CharSequence term, Locale
locale) {
-if (term == null) return term;
+ private static CharSequence escapeTerm(CharSequence term, Locale locale) {
+if (term == null || term.isEmpty()) return term;
-// Escape single Chars
+// escape single chars
term = escapeChar(term, locale);
term = escapeWhiteChar(term, locale);
-// Escape Parser Words
-for (int i = 0; i < escapableWordTokens.length; i++) {
- if (escapableWordTokens[i].equalsIgnoreCase(term.toString())) return
"\\" + term;
+// escape parser words
+for (String escapableWordToken : escapableWordTokens) {
+ if (escapableWordToken.equalsIgnoreCase(term.toString())) return "\\" +
term;
}
return term;
}
/**
- * replace with ignore case
+ * Prepend every case-insensitive occurrence of the {@code sequence1} in the
{@code string} with
+ * the {@code escapeChar}. When the {@code sequence1} is empty, every
character in the {@code
+ * string} is escaped.
*
- * @param string string to get replaced
+ * @param string string to apply escaping to
* @param sequence1 the old character sequence in lowercase
- * @param escapeChar the new character to prefix sequence1 in return string.
- * @return the new String
+ * @param escapeChar the escape character to prefix sequence1 in the
returned string
+ * @return CharSequence with every occurrence of {@code sequence1} prepended
with {@code
+ * escapeChar}
*/
- private static CharSequence replaceIgnoreCase(
+ private static CharSequence escapeIgnoringCase(
CharSequence string, CharSequence sequence1, CharSequence escapeChar,
Locale locale) {
if (escapeChar == null || sequence1 == null || string == null) throw new
NullPointerException();
-// empty string case
int count = string.length();
int sequence1Length = sequence1.length();
+
+// empty search string - escape every character
if (sequence1Length == 0) {
- StringBuilder result = new StringBuilder((count + 1) *
escapeChar.length());
- result.append(escapeChar);
+ StringBuilder result = new StringBuilder(count * (1 +
escapeChar.length()));
for (int i = 0; i < count; i++) {
-result.append(string.charAt(i));
Review Comment:
I am not that familiar with this code but I think it'd be good to keep the
cosmetic cleanups separate from functional changes - if you don't mind, I'll
push this change first, then you can come up with a more focused cleanup?
--
This is an automated message from the Apache Git Service.
To
Re: [PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]
dweiss commented on code in PR #12973:
URL: https://github.com/apache/lucene/pull/12973#discussion_r1445345012
##
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/EscapeQuerySyntaxImpl.java:
##
@@ -184,7 +186,7 @@ public CharSequence escape(CharSequence text, Locale
locale, Type type) {
* Returns a String where the escape char has been removed, or kept only
once if there was a
* double escape.
*
- * Supports escaped unicode characters, e. g. translates A
to A.
+ * Supports escaped Unicode characters, e.g. translates A to
A.
Review Comment:
Thank you for investigating. I think javac and javadoc should be consistent
here - if they're not, it's worth firing a message to openjdk...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] There may be can simpler in DefaultIndexingChain [LUCENE-9303] [lucene]
janhoy closed issue #10343: There may be can simpler in DefaultIndexingChain [LUCENE-9303] URL: https://github.com/apache/lucene/issues/10343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] upgrade to OpenNLP 2.3.1 [lucene]
dweiss commented on PR #12674: URL: https://github.com/apache/lucene/pull/12674#issuecomment-1881823621 Hi @cpoerschke - apologies for the delay. This looks ok to me. It is a pity the dependency sucks in so much other software (slf4j included). I guess this is unavoidable if somebody wants to use it though. It would be good migrate the model regeneration to gradle - probably a good follow-up issue on its own though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] [Minor] Fix the only use of java.lang.String#toLowerCase() with no Locale [lucene]
dweiss merged PR #12856: URL: https://github.com/apache/lucene/pull/12856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove unnecessary fields loop from extractWeightedSpanTerms() [lucene]
dweiss commented on PR #12965: URL: https://github.com/apache/lucene/pull/12965#issuecomment-1881815163 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove unnecessary fields loop from extractWeightedSpanTerms() [lucene]
dweiss merged PR #12965: URL: https://github.com/apache/lucene/pull/12965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] There may be can simpler in DefaultIndexingChain [LUCENE-9303] [lucene]
shaikhu commented on issue #10343: URL: https://github.com/apache/lucene/issues/10343#issuecomment-1881735389 Hi @janhoy @kkewwei, I think this issues can be closed now? It looks like the followng [PR ](https://github.com/apache/lucene-solr/pull/2076) fixed the issue on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Fix for the bug where JapaneseReadingFormFilter cannot convert some hiragana to romaji [lucene]
zhaih commented on PR #12885: URL: https://github.com/apache/lucene/pull/12885#issuecomment-1881591349 Thank you bot I obviously forgot to merge this one. @kuramitsu could you please add an CHANGES.txt entry under Lucene 9.10? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] GITHUB#11728: Improve code clarity for OrdinalMap [lucene]
jpountz commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1881513260 Oops, sorry about that. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] GITHUB#11728: Improve code clarity for OrdinalMap [lucene]
mdmarshmallow commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1881511709 Hi @jpountz, thanks for pushing! I took a look back at the comment and I think it references some variable names changes that were added with some of the code changes that weren't included. I'll make a follow up commit in the next few days to address some of those inconsistencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid reset BlockDocsEnum#freqBuffer when indexHasFreq is false [lucene]
jpountz commented on PR #12997:
URL: https://github.com/apache/lucene/pull/12997#issuecomment-1881470555
Sorry I might have put you on the wrong track, I didn't know we had such
leniency around frequencies/positions/offsets. Out of curiosity, I tried to add
checks to AssertingLeafReader to fail when reading
freqs/positions/offsets/payloads if they have not been requested in the flags,
and there are many test failures. It's not entirely clear to me how intentional
that is, @rmuir do you have context by any chance?
For the case you're trying to improve, another approach could consist of
filling at most `docFreq` entries in the freq buffer:
```patch
diff --git
a/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsReader.java
b/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsReader.java
index 80d24917477..362fb34539e 100644
---
a/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsReader.java
+++
b/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsReader.java
@@ -400,9 +400,9 @@ public final class Lucene99PostingsReader extends
PostingsReaderBase {
this.needsFreq = PostingsEnum.featureRequested(flags,
PostingsEnum.FREQS);
this.isFreqsRead = true;
if (indexHasFreq == false || needsFreq == false) {
-for (int i = 0; i < ForUtil.BLOCK_SIZE; ++i) {
- freqBuffer[i] = 1;
-}
+// Filling this buffer may not be cheap when doing primary key
lookups, so we make sure to
+// not fill more than `docFreq` entries.
+Arrays.fill(freqBuffer, 0, Math.min(ForUtil.BLOCK_SIZE, docFreq),
1);
}
accum = 0;
blockUpto = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10366: Override #readVInt and #readVLong for ByteBufferDataInput to avoid the abstraction confusion of #readByte. [lucene]
uschindler commented on PR #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1881225703 Does this also affect `MemorySegmentIndexInput`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use `instanceof` pattern-matching where possible [lucene]
JarvisCraft commented on PR #12295: URL: https://github.com/apache/lucene/pull/12295#issuecomment-1881153765 Apologies for the late reply, I've lost the track of the message in the thread. I will soon coma back to it and see what should be changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid reset BlockDocsEnum#freqBuffer when indexHasFreq is false [lucene]
easyice commented on code in PR #12997:
URL: https://github.com/apache/lucene/pull/12997#discussion_r1444747244
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsReader.java:
##
@@ -399,7 +400,9 @@ public PostingsEnum reset(IntBlockTermState termState, int
flags) throws IOExcep
doc = -1;
this.needsFreq = PostingsEnum.featureRequested(flags,
PostingsEnum.FREQS);
this.isFreqsRead = true;
- if (indexHasFreq == false || needsFreq == false) {
+ // if reuse, we don't consider whether the needsFreq is changed. this is
undefined in freq().
+ // see also: BasePostingsFormatTestCase#testPostingsEnumFreqs
+ if ((indexHasFreq == false || needsFreq == false) && reuse == false) {
Review Comment:
Thank you for explaining @jpountz! makes sense to me, the only problem is
the `PostingsEnum#freq()` method might return 0, although this is undefined, is
this looks good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Speed up disjunctions by computing estimations of the score of the k-th top hit up-front. [lucene]
mikemccand commented on PR #12526: URL: https://github.com/apache/lucene/pull/12526#issuecomment-188101 > > Maybe we should add OrHighVeryLow to nightly benchy too? > > @mikemccand I started looking into this, but my enwiki (`enwiki-20120502-lines-with-random-label.txt`) seems to have slightly different frequencies compared to frequencies reported in wikinightly.tasks, are nightly benchmarks using the same export or a different one? I think it could make sense to have two new tasks `OrHighLow110` where the low-frequency term always has a frequency of 110 >k and `OrHighLow90` where the low-frequency term always has a frequency of 90
Re: [PR] Optimize FST on-heap BytesReader [lucene]
dungba88 commented on PR #12879: URL: https://github.com/apache/lucene/pull/12879#issuecomment-1881083302 Thanks @mikemccand for merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField #12125 [lucene]
jpountz commented on PR #12821: URL: https://github.com/apache/lucene/pull/12821#issuecomment-1881081841 @SreehariG73 Do you plan on removing the unintended changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Copy collected acc(maxFreqs) into empty acc, rather than merge them. [lucene]
jpountz commented on code in PR #12846:
URL: https://github.com/apache/lucene/pull/12846#discussion_r1444698183
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99SkipWriter.java:
##
@@ -202,7 +202,11 @@ protected void writeSkipData(int level, DataOutput
skipBuffer) throws IOExceptio
CompetitiveImpactAccumulator competitiveFreqNorms =
curCompetitiveFreqNorms[level];
assert competitiveFreqNorms.getCompetitiveFreqNormPairs().size() > 0;
if (level + 1 < numberOfSkipLevels) {
- curCompetitiveFreqNorms[level + 1].addAll(competitiveFreqNorms);
+ if (curCompetitiveFreqNorms[level + 1].isEmpty()) {
+curCompetitiveFreqNorms[level + 1].copy(competitiveFreqNorms);
+ } else {
+curCompetitiveFreqNorms[level + 1].addAll(competitiveFreqNorms);
+ }
Review Comment:
This optimization doesn't look like it would kick in often, does it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Speed up disjunctions by computing estimations of the score of the k-th top hit up-front. [lucene]
jpountz closed pull request #12526: Speed up disjunctions by computing estimations of the score of the k-th top hit up-front. URL: https://github.com/apache/lucene/pull/12526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Speed up disjunctions by computing estimations of the score of the k-th top hit up-front. [lucene]
jpountz commented on PR #12526: URL: https://github.com/apache/lucene/pull/12526#issuecomment-1881064294 I'll reopen when I have time to get back to this, this could be a useful optimization, though the benefit has become lower thanks to other optimizations to disjunctions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]
jpountz commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1881059520 @mikemccand I could use your help to review this change, it's quite deep in the guts of block tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove redundant code in Lucene search [lucene]
jpountz commented on PR #12035: URL: https://github.com/apache/lucene/pull/12035#issuecomment-1881058014 Sorry for the very long delay. This sort of detection of loop invariants is indeed handled by C1/C2 compilers, not javac. Without a benchmark suggesting that there is no performance impact, I would err on the safe side and keep the check outside of the loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LockVerifyServer does not need to reuse addresses nor set accept timeout [lucene]
mikemccand commented on PR #12535: URL: https://github.com/apache/lucene/pull/12535#issuecomment-1881040587 Aha, thank you @uschindler! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LockVerifyServer does not need to reuse addresses nor set accept timeout [lucene]
uschindler commented on PR #12535: URL: https://github.com/apache/lucene/pull/12535#issuecomment-1881005988 Hi @mikemccand, I merged this stale PR. Thanks for taking care. Let's see what Jenkins says. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Clean up sleep in TestBackwardsCompatibility#testCreateMoreTermsIndex [lucene]
uschindler commented on PR #12914: URL: https://github.com/apache/lucene/pull/12914#issuecomment-1881005112 Thanks @gf2121, I merged this stale PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] GITHUB#11728: Improve code clarity for OrdinalMap [lucene]
jpountz commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1880971838 Hey @mdmarshmallow. There have been some changes in the meantime that introduced many conflicts, so what I did is that I took your main comment that describes the OrdinalMap algorithm and pushed it under your name. Sorry for the delay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] GITHUB#11728: Improve code clarity for OrdinalMap [lucene]
jpountz closed pull request #11729: GITHUB#11728: Improve code clarity for OrdinalMap URL: https://github.com/apache/lucene/pull/11729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Improve code clarity for OrdinalMap [lucene]
jpountz closed issue #11728: Improve code clarity for OrdinalMap URL: https://github.com/apache/lucene/issues/11728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Reduce ArrayUtil#grow in decompress [lucene]
easyice commented on code in PR #12996:
URL: https://github.com/apache/lucene/pull/12996#discussion_r1444591749
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java:
##
@@ -128,10 +128,12 @@ public void decompress(DataInput in, int originalLength,
int offset, int length,
}
// Read blocks that intersect with the interval we need
+ if (offsetInBlock < offset + length) {
Review Comment:
Okay, it's fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery [lucene]
uschindler commented on PR #12135: URL: https://github.com/apache/lucene/pull/12135#issuecomment-1880959801 I think we can also close this one, correct? I already closed my proposal: #12141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach) [lucene]
uschindler commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1880958137 We have another solution for this already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach) [lucene]
uschindler closed pull request #12141: Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach) URL: https://github.com/apache/lucene/pull/12141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LockVerifyServer does not need to reuse addresses nor set accept timeout [lucene]
uschindler merged PR #12535: URL: https://github.com/apache/lucene/pull/12535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Clean up sleep in TestBackwardsCompatibility#testCreateMoreTermsIndex [lucene]
uschindler merged PR #12914: URL: https://github.com/apache/lucene/pull/12914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10634: Speed up WANDScorer. [lucene]
jpountz commented on PR #999: URL: https://github.com/apache/lucene/pull/999#issuecomment-1880941055 I'm closing for now, I may revisit this later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10634: Speed up WANDScorer. [lucene]
jpountz closed pull request #999: LUCENE-10634: Speed up WANDScorer. URL: https://github.com/apache/lucene/pull/999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10519: Improvement for CloseableThreadLocal [lucene]
jpountz commented on PR #816: URL: https://github.com/apache/lucene/pull/816#issuecomment-1880940378 I'm closing this PR. Since this PR got opened, we removed threadlocals from `SegmentReader` (#11998) so the number of threadlocal objects no longer scales with the number of open segments, which should help mitigate the issue that prompted this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10519: Improvement for CloseableThreadLocal [lucene]
jpountz closed pull request #816: LUCENE-10519: Improvement for CloseableThreadLocal URL: https://github.com/apache/lucene/pull/816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10366: Override #readVInt and #readVLong for ByteBufferDataInput to avoid the abstraction confusion of #readByte. [lucene]
mikemccand commented on PR #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1880939587 Hello @gf2121! Looks like @uschindler wants you to have to honor of merging this (now stale!) PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Reduce duplication in taxonomy facets; always do counts [lucene]
mikemccand commented on PR #12966: URL: https://github.com/apache/lucene/pull/12966#issuecomment-1880935940 > 3\. Is it important to preserve a default aggregation value of the right type in the results (i.e. `-1` for int aggregations, `-1f` for float aggregations)? If not, we can make a small simplification to always return `-1`. Maybe defer this to a separate issue? I can see callers expecting a consistent type, though, if you cast `(float) Number` where `Number` is an int, the cast would be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Reduce duplication in taxonomy facets; always do counts [lucene]
mikemccand commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1444557053
##
lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java:
##
@@ -202,7 +202,7 @@ public FacetResult getTopChildren(int topN, String dim,
String... path) throws I
}
reuse = q.insertWithOverflow(reuse);
if (q.size() == topN) {
-bottomCount = q.top().value;
+bottomCount = (int) q.top().value;
Review Comment:
Hmm why is this cast necessary? Oh -- I see, this `value` is now a
`Number`. Hence the warning about added boxing/unboxing in hotspots here...
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]
sabi0 commented on code in PR #12973:
URL: https://github.com/apache/lucene/pull/12973#discussion_r1444504974
##
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/EscapeQuerySyntaxImpl.java:
##
@@ -184,7 +186,7 @@ public CharSequence escape(CharSequence text, Locale
locale, Type type) {
* Returns a String where the escape char has been removed, or kept only
once if there was a
* double escape.
*
- * Supports escaped unicode characters, e. g. translates A
to A.
+ * Supports escaped Unicode characters, e.g. translates A to
A.
Review Comment:
Thank you for the link. I did not know about the `\uu...` either.
Unfortunately, javadoc seems to swallow all of those 'u's anyway:
```
Returns a String where the escape char has been removed,
or kept only once if there was a
double escape.
Supports escaped Unicode characters, e.g. translates A to
A.
```
The `{@code ...}` markup works the same:
```
\u0041 => A
\uu0041 => A
\\u0041 => \\u0041
{@code \u0041} => A
{@code \uu0041} => A
{@code \\u0041} => \\u0041
```
JDK Javadoc uses Unicode escape for the backslash itself: `{@code
\u005Cu0800}`:
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/io/DataInput.java#L116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues [lucene]
mikemccand commented on PR #562: URL: https://github.com/apache/lucene/pull/562#issuecomment-1880919115 Hi @gf2121 -- did we ever performance test this change? It sounds compelling! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues [lucene]
github-actions[bot] commented on PR #562: URL: https://github.com/apache/lucene/pull/562#issuecomment-1880905213 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10409: Improve BKDWriter's DocIdsWriter to better encode decreasing sequences of doc IDs [lucene]
github-actions[bot] commented on PR #666: URL: https://github.com/apache/lucene/pull/666#issuecomment-1880905011 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Lucene-10336: DirectDocValueFormat: use RandomAccessSlice instead of loading giant byte[] arrays [lucene]
github-actions[bot] commented on PR #662: URL: https://github.com/apache/lucene/pull/662#issuecomment-1880905067 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Lucene-10254: Remove Scorable#smoothingScore [lucene]
github-actions[bot] commented on PR #669: URL: https://github.com/apache/lucene/pull/669#issuecomment-1880904947 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Lucene-10177: Rename VectorValues#dimension to VectorValues#getNumDimensions [lucene]
github-actions[bot] commented on PR #670: URL: https://github.com/apache/lucene/pull/670#issuecomment-1880904898 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10311: remove complex cost estimation and abstraction leakage around it [lucene]
github-actions[bot] commented on PR #709: URL: https://github.com/apache/lucene/pull/709#issuecomment-1880904794 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use similarity.tf() in MoreLikeThis [lucene]
github-actions[bot] commented on PR #940: URL: https://github.com/apache/lucene/pull/940#issuecomment-1880904681 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10519: Improvement for CloseableThreadLocal [lucene]
github-actions[bot] commented on PR #816: URL: https://github.com/apache/lucene/pull/816#issuecomment-1880904741 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10322: Enable -Xlint:path and -Xlint:-exports [lucene]
github-actions[bot] commented on PR #681: URL: https://github.com/apache/lucene/pull/681#issuecomment-1880904855 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] [LUCENE-10624] Binary Search for Sparse IndexedDISI advanceWithinBloc… [lucene]
github-actions[bot] commented on PR #968: URL: https://github.com/apache/lucene/pull/968#issuecomment-1880904641 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] [LUCENE-2587] Highlighter fragment bug [lucene]
github-actions[bot] commented on PR #1069: URL: https://github.com/apache/lucene/pull/1069#issuecomment-1880904461 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] LUCENE-10616: optimizing decompress when only retrieving some fields [lucene]
github-actions[bot] commented on PR #1003: URL: https://github.com/apache/lucene/pull/1003#issuecomment-1880904534 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove redundant code in Lucene geo [lucene]
github-actions[bot] commented on PR #12036: URL: https://github.com/apache/lucene/pull/12036#issuecomment-1880903913 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery [lucene]
github-actions[bot] commented on PR #12135: URL: https://github.com/apache/lucene/pull/12135#issuecomment-1880903859 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove redundant code in Lucene search [lucene]
github-actions[bot] commented on PR #12035: URL: https://github.com/apache/lucene/pull/12035#issuecomment-1880903973 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Reproduce multi-word synonym regression (SOLR-16652) [lucene]
github-actions[bot] commented on PR #12157: URL: https://github.com/apache/lucene/pull/12157#issuecomment-1880903735 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach) [lucene]
github-actions[bot] commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1880903779 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Add Romanian stopwords with s with comma [lucene]
github-actions[bot] commented on PR #12172: URL: https://github.com/apache/lucene/pull/12172#issuecomment-1880903620 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Change offset to start when data is all equals in StoredFieldsInts.java [lucene]
github-actions[bot] commented on PR #12258: URL: https://github.com/apache/lucene/pull/12258#issuecomment-1880903287 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] simplify PrefixQuery to avoid requiring Automaton [lucene]
github-actions[bot] commented on PR #12207: URL: https://github.com/apache/lucene/pull/12207#issuecomment-1880903543 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Deduplicate ensureValidMerge check [lucene]
github-actions[bot] commented on PR #12237: URL: https://github.com/apache/lucene/pull/12237#issuecomment-1880903404 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Avoid Redundant Loop for Checking Array Element Equality [lucene]
github-actions[bot] commented on PR #12262: URL: https://github.com/apache/lucene/pull/12262#issuecomment-1880903226 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Exclude words ending in -ion from Swedish minimal and light stemmers. [lucene]
github-actions[bot] commented on PR #12247: URL: https://github.com/apache/lucene/pull/12247#issuecomment-1880903343 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
