[jira] [Commented] (SOLR-14151) Make schema components load from packages
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204157#comment-17204157
]
Daniel Worley commented on SOLR-14151:
--
[~ichattopadhyaya] looks good on branch_8x.
> Make schema components load from packages
> -
>
> Key: SOLR-14151
> URL: https://issues.apache.org/jira/browse/SOLR-14151
> Project: Solr
> Issue Type: Sub-task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Blocker
> Labels: packagemanager
> Fix For: 8.7
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> Example:
> {code:xml}
>
>
>
>generateNumberParts="0" catenateWords="0"
> catenateNumbers="0" catenateAll="0"/>
>
>
>
>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed,
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14151) Make schema components load from packages
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197712#comment-17197712
]
Daniel Worley commented on SOLR-14151:
--
[~noble.paul] Just tested and looks good! Will this make it into 8.7 or is that
to be determined? Thanks!
> Make schema components load from packages
> -
>
> Key: SOLR-14151
> URL: https://issues.apache.org/jira/browse/SOLR-14151
> Project: Solr
> Issue Type: Sub-task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Labels: packagemanager
> Fix For: 8.7
>
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> Example:
> {code:xml}
>
>
>
>generateNumberParts="0" catenateWords="0"
> catenateNumbers="0" catenateAll="0"/>
>
>
>
>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed,
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14151) Make schema components load from packages
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197334#comment-17197334
]
Daniel Worley commented on SOLR-14151:
--
Apologies for the wrong diagnosis earlier. I debugged some more and noticed
SolrResourceLoader::findClass was never making use of the schemaLoader. I
added the following code to the top of that method and the test will pass using
a packaged class for the encoder on a delimited payload filter. Not sure if
this has other repercussions or if there's something cleaner but I thought I'd
share the findings.
{{if (cname.contains(":") && schemaLoader != null) {}}
{{ return schemaLoader.findClass(cname, expectedType);}}
{{}}}
> Make schema components load from packages
> -
>
> Key: SOLR-14151
> URL: https://issues.apache.org/jira/browse/SOLR-14151
> Project: Solr
> Issue Type: Sub-task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Labels: packagemanager
> Fix For: 8.7
>
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> Example:
> {code:xml}
>
>
>
>generateNumberParts="0" catenateWords="0"
> catenateNumbers="0" catenateAll="0"/>
>
>
>
>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed,
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14151) Make schema components load from packages
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197297#comment-17197297
]
Daniel Worley edited comment on SOLR-14151 at 9/17/20, 2:17 AM:
I've been testing these updates against some plugin code that utilizes a custom
encoder for the DelimitedPayloadTokenFilterFactory. It appears that Lucene
level code does not pick up on loaded packages. -I believe this is due to the
SolrResourceLoader defaulting to a list of hardcoded packages when a list of
subpackages is not provided which will be the case with Lucene level code.-
edit: After looking more I don't think that is related.
To reproduce you could add a dummy PayloadEncoder to your sample package then
try using it on a DelimitedPayloadTokenFilterFactory in
TestPackages::testSchemaPlugins, something like:
{{" 'filters' : [\\{ 'class':'solr.DelimitedPayloadTokenFilterFactory',
'encoder':'schemapkg:my.pkg.MyEncoder' }]\n";}}
was (Author: worleydl):
I've been testing these updates against some plugin code that utilizes a custom
encoder for the DelimitedPayloadTokenFilterFactory. It appears that Lucene
level code does not pick up on loaded packages. I believe this is due to the
SolrResourceLoader defaulting to a list of hardcoded packages when a list of
subpackages is not provided which will be the case with Lucene level code.
To reproduce you could add a dummy PayloadEncoder to your sample package then
try using it on a DelimitedPayloadTokenFilterFactory in
TestPackages::testSchemaPlugins, something like:
{{" 'filters' : [\{ 'class':'solr.DelimitedPayloadTokenFilterFactory',
'encoder':'schemapkg:my.pkg.MyEncoder' }]\n";}}
> Make schema components load from packages
> -
>
> Key: SOLR-14151
> URL: https://issues.apache.org/jira/browse/SOLR-14151
> Project: Solr
> Issue Type: Sub-task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Labels: packagemanager
> Fix For: 8.7
>
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> Example:
> {code:xml}
>
>
>
>generateNumberParts="0" catenateWords="0"
> catenateNumbers="0" catenateAll="0"/>
>
>
>
>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed,
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14151) Make schema components load from packages
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197318#comment-17197318
]
Daniel Worley edited comment on SOLR-14151 at 9/17/20, 1:44 AM:
[~noble.paul] Under TestPackages::testSchemaPlugins edit the filters String to
include a `solr.DelimitedPayloadTokenFilterFactory` but try to specify a
[package]:[class] as the encoder and it should fail. See my last comment for
an example string you can use.
The issue was originally discovered installing the package from
[https://github.com/o19s/payload-component] and setting up an analyzer chain
with: `` which caused it to
error out.
was (Author: worleydl):
[~noble.paul] Under TestPackages::testSchemaPlugins edit the filters String to
include a `solr.DelimitedPayloadTokenFilterFactory` but try to specify a
[package]:[class] as the encoder and it should fail. See my last comment for
an example string you can use.
The issue was originally discovered installing the plugin from
https://github.com/o19s/payload-component and setting up an analyzer chain
with: `` which caused it to
error out.
> Make schema components load from packages
> -
>
> Key: SOLR-14151
> URL: https://issues.apache.org/jira/browse/SOLR-14151
> Project: Solr
> Issue Type: Sub-task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Labels: packagemanager
> Fix For: 8.7
>
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> Example:
> {code:xml}
>
>
>
>generateNumberParts="0" catenateWords="0"
> catenateNumbers="0" catenateAll="0"/>
>
>
>
>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed,
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14151) Make schema components load from packages
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197318#comment-17197318
]
Daniel Worley commented on SOLR-14151:
--
[~noble.paul] Under TestPackages::testSchemaPlugins edit the filters String to
include a `solr.DelimitedPayloadTokenFilterFactory` but try to specify a
[package]:[class] as the encoder and it should fail. See my last comment for
an example string you can use.
The issue was originally discovered installing the plugin from
https://github.com/o19s/payload-component and setting up an analyzer chain
with: `` which caused it to
error out.
> Make schema components load from packages
> -
>
> Key: SOLR-14151
> URL: https://issues.apache.org/jira/browse/SOLR-14151
> Project: Solr
> Issue Type: Sub-task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Labels: packagemanager
> Fix For: 8.7
>
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> Example:
> {code:xml}
>
>
>
>generateNumberParts="0" catenateWords="0"
> catenateNumbers="0" catenateAll="0"/>
>
>
>
>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed,
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14151) Make schema components load from packages
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197297#comment-17197297
]
Daniel Worley commented on SOLR-14151:
--
I've been testing these updates against some plugin code that utilizes a custom
encoder for the DelimitedPayloadTokenFilterFactory. It appears that Lucene
level code does not pick up on loaded packages. I believe this is due to the
SolrResourceLoader defaulting to a list of hardcoded packages when a list of
subpackages is not provided which will be the case with Lucene level code.
To reproduce you could add a dummy PayloadEncoder to your sample package then
try using it on a DelimitedPayloadTokenFilterFactory in
TestPackages::testSchemaPlugins, something like:
{{" 'filters' : [\{ 'class':'solr.DelimitedPayloadTokenFilterFactory',
'encoder':'schemapkg:my.pkg.MyEncoder' }]\n";}}
> Make schema components load from packages
> -
>
> Key: SOLR-14151
> URL: https://issues.apache.org/jira/browse/SOLR-14151
> Project: Solr
> Issue Type: Sub-task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Labels: packagemanager
> Fix For: 8.7
>
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> Example:
> {code:xml}
>
>
>
>generateNumberParts="0" catenateWords="0"
> catenateNumbers="0" catenateAll="0"/>
>
>
>
>
> {code}
> * When a package is updated, the entire {{IndexSchema}} object is refreshed,
> but the SolrCore object is not reloaded
> * Any component can be prefixed with the package name
> * The semantics of loading plugins remain the same as that of the components
> in {{solrconfig.xml}}
> * Plugins can be registered using schema API
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
