[jira] [Commented] (SOLR-14333) Implement toString() in CollapsingPostFilter
[
https://issues.apache.org/jira/browse/SOLR-14333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063832#comment-17063832
]
Guna Sekhar Dora commented on SOLR-14333:
-
[~munendrasn] Added a fix for this at
[https://github.com/apache/lucene-solr/pull/1371]. Please review.
> Implement toString() in CollapsingPostFilter
>
>
> Key: SOLR-14333
> URL: https://issues.apache.org/jira/browse/SOLR-14333
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Munendra S N
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{toString()}} is not overridden in CollapsingPostFilter. Debug component
> returns {{parsed_filter_queries}}, for multiple CollapsingPostFilter in
> request, value in {{parsed_filter_queries}} is always
> {{CollapsingPostFilter()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14333) Implement toString() in CollapsingPostFilter
[
https://issues.apache.org/jira/browse/SOLR-14333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063824#comment-17063824
]
Guna Sekhar Dora commented on SOLR-14333:
-
[~munendrasn] I'll take this up.
> Implement toString() in CollapsingPostFilter
>
>
> Key: SOLR-14333
> URL: https://issues.apache.org/jira/browse/SOLR-14333
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Munendra S N
>Priority: Major
>
> {{toString()}} is not overridden in CollapsingPostFilter. Debug component
> returns {{parsed_filter_queries}}, for multiple CollapsingPostFilter in
> request, value in {{parsed_filter_queries}} is always
> {{CollapsingPostFilter()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13492) Disallow explicit GC by default during Solr startup
[ https://issues.apache.org/jira/browse/SOLR-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063758#comment-17063758 ] Guna Sekhar Dora commented on SOLR-13492: - On a side note, comments in solr.in.sh and solr.in.cmd related to GC settings are outdated. > Disallow explicit GC by default during Solr startup > --- > > Key: SOLR-13492 > URL: https://issues.apache.org/jira/browse/SOLR-13492 > Project: Solr > Issue Type: Improvement > Components: scripts and tools >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Solr should use the -XX:+DisableExplicitGC option as part of its default GC > tuning. > None of Solr's stock code uses explicit GCs, so that option will have no > effect on most installs. The effective result of this is that if somebody > adds custom code to Solr and THAT code does an explicit GC, it won't be > allowed to function. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13492) Disallow explicit GC by default during Solr startup
[ https://issues.apache.org/jira/browse/SOLR-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063752#comment-17063752 ] Guna Sekhar Dora commented on SOLR-13492: - [~elyograg] I'm taking this up. > Disallow explicit GC by default during Solr startup > --- > > Key: SOLR-13492 > URL: https://issues.apache.org/jira/browse/SOLR-13492 > Project: Solr > Issue Type: Improvement > Components: scripts and tools >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Major > > Solr should use the -XX:+DisableExplicitGC option as part of its default GC > tuning. > None of Solr's stock code uses explicit GCs, so that option will have no > effect on most installs. The effective result of this is that if somebody > adds custom code to Solr and THAT code does an explicit GC, it won't be > allowed to function. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13839) MaxScore is returned as NAN when group.query doesn't match any docs
[ https://issues.apache.org/jira/browse/SOLR-13839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005995#comment-17005995 ] Guna Sekhar Dora commented on SOLR-13839: - [~munendrasn] [~ichattopadhyaya] Added a fix for this at [https://github.com/apache/lucene-solr/pull/1132]. Can you please have a look at it? > MaxScore is returned as NAN when group.query doesn't match any docs > --- > > Key: SOLR-13839 > URL: https://issues.apache.org/jira/browse/SOLR-13839 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: search >Reporter: Munendra S N >Priority: Minor > Attachments: SOLR-13839.patch > > Time Spent: 10m > Remaining Estimate: 0h > > When the main query matches some products but group.query doesn't match any > docs then maxScore=NAN would be returned in the response. > * This happens only in standalone/single shard mode > * score needs to fetched in the response to encounter this issue -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13839) MaxScore is returned as NAN when group.query doesn't match any docs
[ https://issues.apache.org/jira/browse/SOLR-13839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995657#comment-16995657 ] Guna Sekhar Dora commented on SOLR-13839: - [~munendrasn] I'll work on this bug. > MaxScore is returned as NAN when group.query doesn't match any docs > --- > > Key: SOLR-13839 > URL: https://issues.apache.org/jira/browse/SOLR-13839 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: search >Reporter: Munendra S N >Priority: Minor > Attachments: SOLR-13839.patch > > > When the main query matches some products but group.query doesn't match any > docs then maxScore=NAN would be returned in the response. > * This happens only in standalone/single shard mode > * score needs to fetched in the response to encounter this issue -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13806) SolrJ QueryResponse._explainMap is incorrectly typed
[
https://issues.apache.org/jira/browse/SOLR-13806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985497#comment-16985497
]
Guna Sekhar Dora commented on SOLR-13806:
-
[~ab] Added a draft PR at [https://github.com/apache/lucene-solr/pull/1048] for
now. I will have to check if this can be unit tested.
> SolrJ QueryResponse._explainMap is incorrectly typed
>
>
> Key: SOLR-13806
> URL: https://issues.apache.org/jira/browse/SOLR-13806
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 8.3
>Reporter: Andrzej Bialecki
>Priority: Major
> Labels: newdev
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This field, and the corresponding getter, and the code that extracts debug
> information from the NamedList response in {{extractDebugInfo}}, all use a
> {{Map}} type.
> However, when {{debug.explain.structured=true}} is used the values returned
> in response are not String-s, instead they are {{SimpleOrderedMap}}-s. This
> causes the following exception to be thrown:
> {code}
> java.lang.ClassCastException: class
> org.apache.solr.common.util.SimpleOrderedMap cannot be cast to class
> java.lang.String (org.apache.solr.common.util.SimpleOrderedMap is in unnamed
> module of loader 'app'; java.lang.String is in module java.base of loader
> 'bootstrap')
> at
> __randomizedtesting.SeedInfo.seed([1D6FB4036A639051:173F5FF19E860E6F]:0)
> at
> org.apache.solr.client.solrj.response.QueryResponse.extractDebugInfo(QueryResponse.java:246)
> at
> org.apache.solr.client.solrj.response.QueryResponse.setResponse(QueryResponse.java:143)
> at
> org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:207)
> at org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:987)
> ...
> {code}
> The simple fix is to change the type of this field to {{Map}}
> but this would change the public API of {{QueryResponse.getExplainMap()}} in
> incompatible way. Still, I would argue it's worth to change it - AFAIK this
> getter is not used anywhere in the Solr's codebase, and the change makes it
> more consistent with other getters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13806) SolrJ QueryResponse._explainMap is incorrectly typed
[
https://issues.apache.org/jira/browse/SOLR-13806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985349#comment-16985349
]
Guna Sekhar Dora commented on SOLR-13806:
-
[~ab] May I pick this up?
> SolrJ QueryResponse._explainMap is incorrectly typed
>
>
> Key: SOLR-13806
> URL: https://issues.apache.org/jira/browse/SOLR-13806
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 8.3
>Reporter: Andrzej Bialecki
>Priority: Major
> Labels: newdev
>
> This field, and the corresponding getter, and the code that extracts debug
> information from the NamedList response in {{extractDebugInfo}}, all use a
> {{Map}} type.
> However, when {{debug.explain.structured=true}} is used the values returned
> in response are not String-s, instead they are {{SimpleOrderedMap}}-s. This
> causes the following exception to be thrown:
> {code}
> java.lang.ClassCastException: class
> org.apache.solr.common.util.SimpleOrderedMap cannot be cast to class
> java.lang.String (org.apache.solr.common.util.SimpleOrderedMap is in unnamed
> module of loader 'app'; java.lang.String is in module java.base of loader
> 'bootstrap')
> at
> __randomizedtesting.SeedInfo.seed([1D6FB4036A639051:173F5FF19E860E6F]:0)
> at
> org.apache.solr.client.solrj.response.QueryResponse.extractDebugInfo(QueryResponse.java:246)
> at
> org.apache.solr.client.solrj.response.QueryResponse.setResponse(QueryResponse.java:143)
> at
> org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:207)
> at org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:987)
> ...
> {code}
> The simple fix is to change the type of this field to {{Map}}
> but this would change the public API of {{QueryResponse.getExplainMap()}} in
> incompatible way. Still, I would argue it's worth to change it - AFAIK this
> getter is not used anywhere in the Solr's codebase, and the change makes it
> more consistent with other getters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
