[jira] [Commented] (SOLR-13238) BlobHandler generates non-padded md5
[
https://issues.apache.org/jira/browse/SOLR-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930971#comment-16930971
]
Jeff Walraven commented on SOLR-13238:
--
[~janhoy] Thanks! I will keep that in mind for future PRs :)
> BlobHandler generates non-padded md5
>
>
> Key: SOLR-13238
> URL: https://issues.apache.org/jira/browse/SOLR-13238
> Project: Solr
> Issue Type: Bug
> Components: blobstore
>Affects Versions: 6.0, 6.6.5, 7.0, 7.6, 7.7
>Reporter: Jeff Walraven
>Assignee: Jan Høydahl
>Priority: Major
> Fix For: 8.3
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Introduced in SOLR-6787
> The blob handler currently uses the following logic for generating/storing
> the md5 for uploads:
> {code:java}
> MessageDigest m = MessageDigest.getInstance("MD5");
> m.update(payload.array(), payload.position(), payload.limit());
> String md5 = new BigInteger(1, m.digest()).toString(16);
> {code}
> Unfortunately, this method does not provide padding for any md5 with less
> than 0x10 for its most significant byte. This means that on many occasions it
> could end up with a md5 hash of 31 characters instead of 32.
> I have opened a PR with the following recommended change:
> {code:java}
> String md5 = new String(Hex.encodeHex(m.digest()));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13238) BlobHandler generates non-padded md5
[
https://issues.apache.org/jira/browse/SOLR-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929776#comment-16929776
]
Jeff Walraven commented on SOLR-13238:
--
[~janhoy] [~noble.paul] Anything else you need from me to get this merged?
> BlobHandler generates non-padded md5
>
>
> Key: SOLR-13238
> URL: https://issues.apache.org/jira/browse/SOLR-13238
> Project: Solr
> Issue Type: Bug
> Components: blobstore
>Affects Versions: 6.0, 6.6.5, 7.0, 7.6, 7.7
>Reporter: Jeff Walraven
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Introduced in SOLR-6787
> The blob handler currently uses the following logic for generating/storing
> the md5 for uploads:
> {code:java}
> MessageDigest m = MessageDigest.getInstance("MD5");
> m.update(payload.array(), payload.position(), payload.limit());
> String md5 = new BigInteger(1, m.digest()).toString(16);
> {code}
> Unfortunately, this method does not provide padding for any md5 with less
> than 0x10 for its most significant byte. This means that on many occasions it
> could end up with a md5 hash of 31 characters instead of 32.
> I have opened a PR with the following recommended change:
> {code:java}
> String md5 = new String(Hex.encodeHex(m.digest()));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-13238) BlobHandler generates non-padded md5
[
https://issues.apache.org/jira/browse/SOLR-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Walraven updated SOLR-13238:
-
Status: Open (was: Patch Available)
> BlobHandler generates non-padded md5
>
>
> Key: SOLR-13238
> URL: https://issues.apache.org/jira/browse/SOLR-13238
> Project: Solr
> Issue Type: Bug
> Components: blobstore
>Affects Versions: 6.0, 6.6.5, 7.0, 7.6, 7.7
>Reporter: Jeff Walraven
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Introduced in SOLR-6787
> The blob handler currently uses the following logic for generating/storing
> the md5 for uploads:
> {code:java}
> MessageDigest m = MessageDigest.getInstance("MD5");
> m.update(payload.array(), payload.position(), payload.limit());
> String md5 = new BigInteger(1, m.digest()).toString(16);
> {code}
> Unfortunately, this method does not provide padding for any md5 with less
> than 0x10 for its most significant byte. This means that on many occasions it
> could end up with a md5 hash of 31 characters instead of 32.
> I have opened a PR with the following recommended change:
> {code:java}
> String md5 = new String(Hex.encodeHex(m.digest()));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-13238) BlobHandler generates non-padded md5
[
https://issues.apache.org/jira/browse/SOLR-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Walraven updated SOLR-13238:
-
Status: Patch Available (was: Open)
> BlobHandler generates non-padded md5
>
>
> Key: SOLR-13238
> URL: https://issues.apache.org/jira/browse/SOLR-13238
> Project: Solr
> Issue Type: Bug
> Components: blobstore
>Affects Versions: 6.0, 6.6.5, 7.0, 7.6, 7.7
>Reporter: Jeff Walraven
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Introduced in SOLR-6787
> The blob handler currently uses the following logic for generating/storing
> the md5 for uploads:
> {code:java}
> MessageDigest m = MessageDigest.getInstance("MD5");
> m.update(payload.array(), payload.position(), payload.limit());
> String md5 = new BigInteger(1, m.digest()).toString(16);
> {code}
> Unfortunately, this method does not provide padding for any md5 with less
> than 0x10 for its most significant byte. This means that on many occasions it
> could end up with a md5 hash of 31 characters instead of 32.
> I have opened a PR with the following recommended change:
> {code:java}
> String md5 = new String(Hex.encodeHex(m.digest()));
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
