[GitHub] [lucene-solr] athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-604724994 Fixed the obsolete comments, just did a grep for old instances and found a few more that needed changing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-604588248 Hi David, thank you for the feedback and my apologies in the delayed response. I agree, 'schema' is an overloaded word in Solr that we could avoid. Your suggestion of `connectionSocketFactoryRegistry` is better, but there's still a Provider on top of that, and having a `connectionSocketFactoryRegistryProvider` sounds like too much Java word-salad to me. Maybe just drop the "connection" (since it's implied by a socket)? Or `connectionSocketFactoriesProvider`? As to using a Supplier, we could use `Supplier>`, but that would be a dodgy cast (at HttpClientUtil.java:161) due to the generics so I think I'll keep it a concrete class for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil
athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-586520791 FYI @dsmiley This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
