[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-597376064 I propose that in 8.x, I leave the methods that were moved but mark them as deprecated. Otherwise, the rest of the changes are rather internal and can be applied to 8x, thus helping reduce possible merge conflicts for our future work. I'll put an entry in Other Changes for 9.x: "SolrResourceLoader remove deprecated methods (numerous)." Simple and succinct. The commit message will have lots of info. On 8x I'll say "SolrResourceLoader: marked many methods as deprecated, and in some cases rerouted exiting logic to avoid them". Since this is very internal stuff, people can go see for themselves. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-593403812 @madrob can you approve this PR or suggest improvements? What do we think about master only vs 8x? I'm not sure honestly... I don't think the changes are drastic for plugin writers in 8x. As @mkhludnev advised me on another issue recently, perhaps we immediately (for 8.5) mark these methods deprecated and then do the change for 8.6. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-586399204 FYI tomorrow I'll be on vacation for a week with minimal internet access, so I may not respond much for a bit. Again, I think the issue is ready for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-583950052 Perhaps the remaining larger changes relating to new classes (e.g. StandaloneSolrResourceLoader) should wait for a follow-on commit; there's plenty here already. Maybe a few static methods could/should move elsewhere but this is ready for a review I think. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-578586761 I rebased off master since there were some upstream changes. Also resolved some getInstancePath callers though didn't actually remove it yet. I think it can move (not remain in SRL) to ZkSolrResourceLoader (until 9x, then remove) and a new StandaloneSolrResourceLoader. I think a StandaloneSolrResourceLoader is the next step at this point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-577499972 An interface sounds fine but it will take some steps to get to that juncture, method-by-method reducing needless scope of the very use of SRL that needn't be there. The PR is maybe 80% of the way there; close. BTW when looking over this, be sure to look commit-by-commit and not all at once since each commit is usually fairly focused. Extracting "properties" was a bit hard. getInstancePath was too but that one isn't even done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org