[GitHub] [lucene-solr] dweiss commented on a change in pull request #2448: SOLR-14759: a few initial changes so that Lucene can be built independently while Solr code is still in place.

2021-03-04 Thread GitBox 


dweiss commented on a change in pull request #2448:
URL: https://github.com/apache/lucene-solr/pull/2448#discussion_r587241698



##
File path: gradle/documentation/documentation.gradle
##
@@ -20,34 +20,41 @@ configure(rootProject) {
   def refguideUrlVersion = 
project.baseVersion.replaceFirst(/^(\d+)\.(\d+).*$/, '$1_$2')
 
   ext {
-luceneDocUrl = project.propertyOrDefault('lucene.javadoc.url', {
-  if (project.version != project.baseVersion) {
-// non-release build
-new File(project('lucene:documentation').buildDir, 
'site').toURI().toASCIIString().minus(~'/$')
-  } else {
-// release build
-"https://lucene.apache.org/core/${urlVersion};
-  }
-}())
-
-solrDocUrl = project.propertyOrDefault('solr.javadoc.url', {
-  if (project.version != project.baseVersion) {
-// non-release build
-new File(project('solr:documentation').buildDir, 
'site').toURI().toASCIIString().minus(~'/$')
-  } else {
-// release build
-"https://lucene.apache.org/solr/${urlVersion};
-  }
-}())
+if (!skipLucene) {
+  luceneDocUrl = project.propertyOrDefault('lucene.javadoc.url', {
+if (project.version != project.baseVersion) {
+  // non-release build
+  new File(project('lucene:documentation').buildDir, 
'site').toURI().toASCIIString().minus(~'/$')
+} else {
+  // release build
+  "https://lucene.apache.org/core/${urlVersion};
+}
+  }())
+}
 
-solrRefguideUrl = project.propertyOrDefault('solr.refguide.url', 
"https://lucene.apache.org/solr/guide/${refguideUrlVersion};)
+// SOLR ONLY
+if (!skipSolr) {
+  solrDocUrl = project.propertyOrDefault('solr.javadoc.url', {
+if (project.version != project.baseVersion) {
+  // non-release build
+  new File(project('solr:documentation').buildDir, 
'site').toURI().toASCIIString().minus(~'/$')
+} else {
+  // release build
+  "https://lucene.apache.org/solr/${urlVersion};
+}
+  }())
+
+  solrRefguideUrl = project.propertyOrDefault('solr.refguide.url', 
"https://lucene.apache.org/solr/guide/${refguideUrlVersion};)
+}
   }
 
   task documentation() {
 group = 'documentation'
 description = 'Generate all documentation'
 
-dependsOn ':lucene:documentation:assemble'
+if (!skipLucene) {
+  dependsOn ':lucene:documentation:assemble'
+}
 dependsOn ':solr:documentation:assemble'

Review comment:
   top-level documentation wasn't part of assemble, that's why it worked.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2448: SOLR-14759: a few initial changes so that Lucene can be built independently while Solr code is still in place.

2021-03-03 Thread GitBox 


dweiss commented on a change in pull request #2448:
URL: https://github.com/apache/lucene-solr/pull/2448#discussion_r587235498



##
File path: gradle/documentation/documentation.gradle
##
@@ -20,34 +20,41 @@ configure(rootProject) {
   def refguideUrlVersion = 
project.baseVersion.replaceFirst(/^(\d+)\.(\d+).*$/, '$1_$2')
 
   ext {
-luceneDocUrl = project.propertyOrDefault('lucene.javadoc.url', {
-  if (project.version != project.baseVersion) {
-// non-release build
-new File(project('lucene:documentation').buildDir, 
'site').toURI().toASCIIString().minus(~'/$')
-  } else {
-// release build
-"https://lucene.apache.org/core/${urlVersion};
-  }
-}())
-
-solrDocUrl = project.propertyOrDefault('solr.javadoc.url', {
-  if (project.version != project.baseVersion) {
-// non-release build
-new File(project('solr:documentation').buildDir, 
'site').toURI().toASCIIString().minus(~'/$')
-  } else {
-// release build
-"https://lucene.apache.org/solr/${urlVersion};
-  }
-}())
+if (!skipLucene) {
+  luceneDocUrl = project.propertyOrDefault('lucene.javadoc.url', {
+if (project.version != project.baseVersion) {
+  // non-release build
+  new File(project('lucene:documentation').buildDir, 
'site').toURI().toASCIIString().minus(~'/$')
+} else {
+  // release build
+  "https://lucene.apache.org/core/${urlVersion};
+}
+  }())
+}
 
-solrRefguideUrl = project.propertyOrDefault('solr.refguide.url', 
"https://lucene.apache.org/solr/guide/${refguideUrlVersion};)
+// SOLR ONLY
+if (!skipSolr) {
+  solrDocUrl = project.propertyOrDefault('solr.javadoc.url', {
+if (project.version != project.baseVersion) {
+  // non-release build
+  new File(project('solr:documentation').buildDir, 
'site').toURI().toASCIIString().minus(~'/$')
+} else {
+  // release build
+  "https://lucene.apache.org/solr/${urlVersion};
+}
+  }())
+
+  solrRefguideUrl = project.propertyOrDefault('solr.refguide.url', 
"https://lucene.apache.org/solr/guide/${refguideUrlVersion};)
+}
   }
 
   task documentation() {
 group = 'documentation'
 description = 'Generate all documentation'
 
-dependsOn ':lucene:documentation:assemble'
+if (!skipLucene) {
+  dependsOn ':lucene:documentation:assemble'
+}
 dependsOn ':solr:documentation:assemble'

Review comment:
   For some reason this actually works... 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org