[GitHub] [lucene-solr] ebehrendt commented on a change in pull request #1208: SOLR-13101: Convert nanotime to ms
ebehrendt commented on a change in pull request #1208: SOLR-13101: Convert
nanotime to ms
URL: https://github.com/apache/lucene-solr/pull/1208#discussion_r374883205
##
File path:
solr/core/src/java/org/apache/solr/store/blob/util/BlobStoreUtils.java
##
@@ -75,6 +76,16 @@ public static String generateMetadataSuffix() {
return UUID.randomUUID().toString();
}
+ /**
+ * Returns current nano time in millisecond resolution for use in measuring
elapsed time.
+ *
+ * Note: Do not combine this value with currentTimeMillis -
currentTimeMillis will return ms relative to epoch
+ * while this method returns ms relative to some arbitrary time
+ */
+ public static long getCurrentNanoTimeInMs() {
Review comment:
Sure - I had named this way to avoid combining with currentTimeMillis but if
the javadoc is good enough for that I'll rename
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] ebehrendt commented on a change in pull request #1208: SOLR-13101: Convert nanotime to ms
ebehrendt commented on a change in pull request #1208: SOLR-13101: Convert
nanotime to ms
URL: https://github.com/apache/lucene-solr/pull/1208#discussion_r370881326
##
File path:
solr/core/src/java/org/apache/solr/store/blob/metadata/CorePushPull.java
##
@@ -499,7 +500,7 @@ void enqueueForHardDelete(BlobCoreMetadataBuilder
bcmBuilder) throws Exception {
@VisibleForTesting
protected boolean okForHardDelete(BlobCoreMetadata.BlobFileToDelete file) {
// For now we only check how long ago the file was marked for delete.
- return System.nanoTime() - file.getDeletedAt() >=
deleteManager.getDeleteDelayMs();
+ return (System.nanoTime() / 100) - file.getDeletedAt() >=
deleteManager.getDeleteDelayMs();
Review comment:
From what I could find, deletedAt and deleteDelay is only set using
System.nanoTime/100, so there should not be any mismatch from comparing
times that used nanoTime and times that used currentTimeMillis
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
