[GitHub] [lucene-solr] janhoy commented on issue #1202: SOLR-14149: CHANGES.txt Remove off-topic stuff

2020-01-24 Thread GitBox
janhoy commented on issue #1202: SOLR-14149: CHANGES.txt Remove off-topic stuff
URL: https://github.com/apache/lucene-solr/pull/1202#issuecomment-578188915
 
 
   Agree on the PR template. An even more “live” page for master upgrade notes 
would be 
https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/solr-upgrade-notes.adoc


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] janhoy commented on issue #1202: SOLR-14149: CHANGES.txt Remove off-topic stuff

2020-01-24 Thread GitBox
janhoy commented on issue #1202: SOLR-14149: CHANGES.txt Remove off-topic stuff
URL: https://github.com/apache/lucene-solr/pull/1202#issuecomment-578152267
 
 
   > Or maybe we don't and this is a difference between both branches for the 
asciidoc file similarly to how CHANGES.txt is necessarily different?
   
   I believe this would work. The master branch should contain what would go in 
a 9.0 release if we released today, so why not maintain the Upgrade Notes there 
from the start? Since it is easier to forget to touch two files, perhaps this 
should be a new checkbox in GH PR template "[ ] I have added an Upgrade Note to 
RefGuide if there are breaking changes".


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org