[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2245: Move old field infos format to backwards-codecs.
jtibshirani commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564138601 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java ## @@ -311,6 +312,11 @@ private static IndexOptions getIndexOptions(IndexInput input, byte b) throws IOE } } + /** + * Note: although this format is only used on older versions, we need to keep the write logic Review comment: I hope this assumption is accurate, would appreciate someone double-checking it. ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java ## @@ -311,6 +312,11 @@ private static IndexOptions getIndexOptions(IndexInput input, byte b) throws IOE } } + /** + * Note: although this format is only used on older versions, we need to keep the write logic Review comment: I hope this is accurate, would appreciate someone double-checking it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2245: Move old field infos format to backwards-codecs.
jtibshirani commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564138601 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java ## @@ -311,6 +312,11 @@ private static IndexOptions getIndexOptions(IndexInput input, byte b) throws IOE } } + /** + * Note: although this format is only used on older versions, we need to keep the write logic Review comment: I hope this is accurate, would appreciate someone double-checking it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2245: Move old field infos format to backwards-codecs.
jtibshirani commented on a change in pull request #2245: URL: https://github.com/apache/lucene-solr/pull/2245#discussion_r564138601 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene60/Lucene60FieldInfosFormat.java ## @@ -311,6 +312,11 @@ private static IndexOptions getIndexOptions(IndexInput input, byte b) throws IOE } } + /** + * Note: although this format is only used on older versions, we need to keep the write logic Review comment: I hope this assumption is accurate, would appreciate someone double-checking it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
