madrob commented on a change in pull request #1509:
URL: https://github.com/apache/lucene-solr/pull/1509#discussion_r425360430
##########
File path:
solr/core/src/java/org/apache/solr/handler/AnalysisRequestHandlerBase.java
##########
@@ -82,7 +82,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
*
* @throws Exception When analysis fails.
*/
- protected abstract NamedList doAnalysis(SolrQueryRequest req) throws
Exception;
+ protected abstract NamedList<?> doAnalysis(SolrQueryRequest req) throws
Exception;
Review comment:
I think best practice is to use `NamedList<Object>` as the return type,
and `NamedList<?>` as the argument type in methods, but I can't find a
reference for it right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
