mariemat opened a new pull request #1373: SOLR-14340 - ZkStateReader.readConfigName is doing too much work URL: https://github.com/apache/lucene-solr/pull/1373 # Description Reduced the scope of ZkStateReader.readConfigName() as described in the JIRA by David. # Solution * Removed the check to ensure that the Zk Node exists. * Removed the check for the existence of the Configset entry. In a local test with 600 collections, it saved 2/5 of the GETCLUSTERSTATUS execution time. # Tests Removed an assert in TestCollectionAPI that tests that a collection with missing configset are not returned. That behavior will not happen anymore. # Checklist Please review the following and check all that apply: - [ X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ X] I have developed this patch against the `master` branch. - [ X] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
