[GitHub] [lucene-solr] s1monw commented on a change in pull request #1576: Alternative approach to LUCENE-8962
s1monw commented on a change in pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r441125936
##
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##
@@ -399,8 +423,19 @@ public String segString(Directory dir) {
}
return b.toString();
}
+
+boolean await(long timeout, TimeUnit unit) {
+ for (OneMerge merge : merges) {
+if (merge.await(timeout, unit) == false) {
Review comment:
I fixed this in the followup PR
https://github.com/apache/lucene-solr/pull/1585
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] s1monw commented on a change in pull request #1576: Alternative approach to LUCENE-8962
s1monw commented on a change in pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r440359230
##
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##
@@ -399,8 +423,19 @@ public String segString(Directory dir) {
}
return b.toString();
}
+
+boolean await(long timeout, TimeUnit unit) {
+ for (OneMerge merge : merges) {
+if (merge.await(timeout, unit) == false) {
Review comment:
in a real change that's correct. in a prototype as this is it's really
just there to visualize the idea. I didn't do this on purpose to not discuss
impl details. that's not the point of this it's really just a PR to make
commenting simpler.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
