[GitHub] [lucene-solr] uschindler commented on issue #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml
uschindler commented on issue #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml URL: https://github.com/apache/lucene-solr/pull/1018#issuecomment-555706171 Ok, I know. For the default servlet, the path has to be just "/". This is how it's implicitly configured for an empty webapp by jetty (it uses a special class DefaultServlet for this). The embedded jetty has no webapp only a context, so there is no default servlet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on issue #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml
uschindler commented on issue #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml URL: https://github.com/apache/lucene-solr/pull/1018#issuecomment-555604686 I have the feeling this issues comes from the fact that without the default 404 servlet, Jetty returns some arbitrary error (like invalid method) when something is not found. Maybe we should revive the hard 404 if the filter does not handle some path? I am not fully sure, but I can look into this later! We should at least make sure that SolrDispatchFilter returns 404 not found when path is invalid. In addition during bootup time of a new server we should make sure that a valid error is returned. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on issue #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml
uschindler commented on issue #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml URL: https://github.com/apache/lucene-solr/pull/1018#issuecomment-95038 Does this fail reproducible. From the error message this looks common, I also see it on Jenkins. If that url won't accept POST, more than that would fail. It could be something else related to the 404. You removed the servlet, but it looks like the dispatch filter is installed a little bit delayed. Maybe the test is accessing to early and instead of 404 and retry it fails because method is incorrect? What happens if the 404 servlet stays alive? Uwe This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on issue #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml
uschindler commented on issue #1018: SOLR-13941: Configure JettySolrRunner same as in web.xml URL: https://github.com/apache/lucene-solr/pull/1018#issuecomment-555257355 You can remove the dummy 404Servlet from source code. It's obsolete now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
