[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686556365 Short info: After backporting to 8.x, of course JDK 8u192 was detected as **non-buggy**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686528216 Hi, I did further tests (except Java 8, I need to merge first), Results looking fine: - OpenJDK JDK 11.0.2 reports **non-buggy** - AdoptJDK 11.0.5 reports **buggy** - Oracle JDK 11.0.8 reports **buggy** - JDK 12 reports **non-buggy** - JDK 13 reports **buggy** - JDK 14 reports **buggy** I keep the class for now as package private. Thoughts: - If Elasticsearch or Solr want to report on startup that the JDK they are using is buggy and they should upgrade (once they have a fix available, a fix for JDK 11 looks promising as this was a regression!), we can make the class public, so startup code has access to the boolean flag - We may print a Info in the test, so when running tests you get informed about the issue (useful for quick testing a new JDK release) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686471292 I converted this to a draf, because checks failed with precommit. But this should stay in for doing quick checks by @jpountz like commented before! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686468187 Hi, I added detectction in my latest commit: ``` C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1>java -version openjdk version "11.0.2" 2019-01-15 OpenJDK Runtime Environment 18.9 (build 11.0.2+9) OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode) C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1>gradlew -Ptests.verbose=true :lucene:core:test --tests TestLucene87StoredFieldsFormatHighCompression | grep buggy 2> JDK is buggy: false ``` vs. ``` C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1>java -version openjdk version "13" 2019-09-17 OpenJDK Runtime Environment (build 13+33) OpenJDK 64-Bit Server VM (build 13+33, mixed mode, sharing) C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1>gradlew -Ptests.verbose=true :lucene:core:test --tests TestLucene87StoredFieldsFormatHighCompression | grep buggy 2> JDK is buggy: true ``` The `System.err.println()` needs of course be removed before merge :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686427056 This effectively reverts @jpountz's hotfix commit, but as he moved classes around in the meantime, I had to do it manually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org