[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #231: Add conditional dependency for zk-operator helm chart
HoustonPutman commented on pull request #231: URL: https://github.com/apache/lucene-solr-operator/pull/231#issuecomment-797149720 I think I'm good now. Will let it sit for a day or two, and then merge! Reach out if you think there is anything missing. Once again, thanks for all of your great work @chaicesan!! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #231: Add conditional dependency for zk-operator helm chart
HoustonPutman commented on pull request #231: URL: https://github.com/apache/lucene-solr-operator/pull/231#issuecomment-797106816 I think we are very close to having this merge ready. I updated the zk-connection string to use the new URLs used by this version of the ZK Operator. We just need to make all the other fields update cleanly. We should probably auto-populate the kubeDomain field from the SolrCloud Spec into the ZK Cluster spec as well... But that's very very easy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #231: Add conditional dependency for zk-operator helm chart
HoustonPutman commented on pull request #231: URL: https://github.com/apache/lucene-solr-operator/pull/231#issuecomment-795697523 No worries at all @chaicesan , I've mainly just been taking care of random documentation and licensing issues. I think this is almost ready to go. I'm going to do some testing first to make sure that we don't need to change the Solr operator code at all, and everything runs smoothly. I have a bet we will need to do at least one thing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #231: Add conditional dependency for zk-operator helm chart
HoustonPutman commented on pull request #231: URL: https://github.com/apache/lucene-solr-operator/pull/231#issuecomment-794557931 Hey @chaicesan , I went ahead and changed the variable name myself, and added backwards compatibility with the old `useZkOperator` option. I also updated various docs across the project. I'm not so sure about using Chart.lock and keeping the `charts/zookeeper-operator-0.2.9.tgz` and `Chart.lock` in the repo. That's something that can be generated at release time, when building the chart. Is there a reason why you included it in the PR specifically? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #231: Add conditional dependency for zk-operator helm chart
HoustonPutman commented on pull request #231: URL: https://github.com/apache/lucene-solr-operator/pull/231#issuecomment-792876296 This is starting to look very good! I'll give it a test locally soon, to make sure that there are no issues with the Zookeeper Cluster that is created in the new version of the zookeeper-operator. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
