[ https://issues.apache.org/jira/browse/SOLR-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930735#comment-16930735 ]
Munendra S N edited comment on SOLR-13725 at 9/16/19 5:47 PM: -------------------------------------------------------------- [^SOLR-13725.patch] [~gerlowskija] I have removed check from {{setLimit}}. I checked {{setMinCount}}, solrJ doesn't allow mincount to be 0. Currently, solr doesn't support mincount=0 for numeric fieldtypes in terms facet but, for other types it is supported. Shouldn't we just allow setting mincount to 0 and handle this case at Server(Solr already throws error on mincount=0 for numeric types) was (Author: munendrasn): [^SOLR-13725.patch] [~gerlowskija] I have removed check from {{setLimit}}. I checked {{setMinCount}}, solrJ doesn't allow mincount to be 0. Currently, solr doesn't support mincount=0 for numeric fieldtypes in terms facet but, for other types it is supported. Shouldn't we just allow setting mincount to 0 and handle this case at Server(Solr already throws error on mincount=0 for numeric types) > TermsFacetMap.setLimit() unnecessarily rejects negative parameter value > ----------------------------------------------------------------------- > > Key: SOLR-13725 > URL: https://issues.apache.org/jira/browse/SOLR-13725 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ > Affects Versions: 8.2 > Reporter: Richard Walker > Assignee: Munendra S N > Priority: Trivial > Attachments: SOLR-13725.patch, SOLR-13725.patch > > > SolrJ's {{TermsFacetMap.setLimit(int maximumBuckets)}} rejects a negative > parameter value with an IllegalArgumentException "Parameter 'maximumBuckets' > must be non-negative". > But a negative value for the limit parameter is accepted by Solr server, and > is meaningful: i.e., it means "no limit". > The {{setLimit()}} method shouldn't reject a negative parameter value. -- This message was sent by Atlassian Jira (v8.3.2#803003) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org