[
https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007096#comment-17007096
]
Kevin Risden edited comment on SOLR-14154 at 1/2/20 9:42 PM:
-------------------------------------------------------------
{quote}Do I make PR's for each version I want this to be backported to?{quote}
No don't worry about it. I'll backport the change to the applicable branches.
{quote}
I'm trying to write a Solr driver for [Metabase|https://www.metabase.com/] and
the JDBC route seemed the way to go for me. Unfortunately metabase creates a
pooled connection wich uses the getTransactionIsolation() method and crashes
{quote}
Ah neat. Looks like there isn't a check before getting the isolation level.
https://github.com/swaldman/c3p0/blob/master/src/java/com/mchange/v2/c3p0/impl/NewPooledConnection.java#L120
{quote}created the pull requests.{quote}
Thanks I'll try to get this in today or tomorrow.
was (Author: risdenk):
{quote}Do I make PR's for each version I want this to be backported to?{quote}
No don't worry about it. I'll backport the change to the applicable branches.
{code:java}
I'm trying to write a Solr driver for [Metabase|https://www.metabase.com/] and
the JDBC route seemed the way to go for me. Unfortunately metabase creates a
pooled connection wich uses the getTransactionIsolation() method and crashes
{code}
Ah neat. Looks like there isn't a check before getting the isolation level.
https://github.com/swaldman/c3p0/blob/master/src/java/com/mchange/v2/c3p0/impl/NewPooledConnection.java#L120
{quote}created the pull requests.{quote}
Thanks I'll try to get this in today or tomorrow.
> Return correct isolation level when retrieving it from the SQL Connection
> -------------------------------------------------------------------------
>
> Key: SOLR-14154
> URL: https://issues.apache.org/jira/browse/SOLR-14154
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Parallel SQL
> Affects Versions: 8.4
> Reporter: Nick Vercammen
> Assignee: Kevin Risden
> Priority: Minor
> Fix For: 8.5, 8.4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When calling the getTransactionIsolation() on the Sql.ConnectionImpl an
> UnsupportedException is thrown. It would be better to return TRANSACTION_NONE
> so clients can determine themselves it is not supported without receiving an
> exception
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
