[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112720#comment-17112720
]
Cao Manh Dat edited comment on SOLR-14419 at 5/21/20, 2:12 AM:
---
{quote}
Query DSL objects need to go into dedicated {{queries}} property see SOLR-12490:
{quote}
If that is the case, will it confusing? It will be simpler for user to assume
that, this part (inside main query or filters)
{code}
{"param": "paramName"}
{code}
will be translated to
{code}
paramValue // can be a string, a list, a json object picked from params
{code}
{quote}
I recently get to solving this puzzle it's really tricky. I can share how to
if you wish to see.
{quote}
Yes, this makes me curious.
was (Author: caomanhdat):
{quote}
Query DSL objects need to go into dedicated {{queries}} property see SOLR-12490:
{quote}
If that is the case, will it confusing? It will be simpler for user to assume
that, this part
{code}
{"param": "paramName"}
{code}
will be translated to
{code}
paramValue // can be a string, a list, a json object.
{code}
{quote}
I recently get to solving this puzzle it's really tricky. I can share how to
if you wish to see.
{quote}
Yes, this makes me curious.
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112534#comment-17112534
]
Mikhail Khludnev edited comment on SOLR-14419 at 5/20/20, 6:57 PM:
---
Query DSL objects need to go into dedicated {{queries}} property see SOLR-12490:
{code}
{ "query": {
"bool":{ "must": {"param":"must_clauses"}
, "must_not":{"param":{"must_not_clauses"}}
}},
"queries": {
"must_clauses":["type:parent", "type2:parent"],
"must_not_clauses" : {"bool": {...}}
}
}
{code}
was (Author: mkhludnev):
Query DSL objects need to go into dedicated {{queries}} property:
{code}
{ "query": {
"bool":{ "must": {"param":"must_clauses"}
, "must_not":{"param":{"must_not_clauses"}}
}},
"queries": {
"must_clauses":["type:parent", "type2:parent"],
"must_not_clauses" : {"bool": {...}}
}
}
{code}
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112536#comment-17112536
]
Mikhail Khludnev edited comment on SOLR-14419 at 5/20/20, 6:56 PM:
---
bq. I mean I don't see many usecase this feature will be useful?
This is absolutely necessary. Think about that classic killer feature:
https://lucene.apache.org/solr/guide/6_6/faceting.html#Faceting-TaggingandExcludingFilters
the question how to achieve is with Query DSL for nested objects in json
facets and domain switch. I recently get to solving this puzzle it's really
tricky. I can share how to if you wish to see. Nevertheless, these refs are
needful.
was (Author: mkhludnev):
bq. I mean I don't see many usecase this feature will be useful?
This is absolutely necessary. Think about that classic killer feature:
https://lucene.apache.org/solr/guide/6_6/faceting.html#Faceting-TaggingandExcludingFilters
the question how to achieve is with Query DSL for nested objects in json
facets and domain switch. I recently get to solving this puzzle it's really
tricky. I can share how to if you wish to see. Nevertheless, those refs are
needful.
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112182#comment-17112182
]
Cao Manh Dat edited comment on SOLR-14419 at 5/20/20, 1:15 PM:
---
When I say paramValue as a JsonObject, I mean this
{code:json}
{ "query": {
"bool":{ "must": {"param":"must_clauses"}
, "must_not":{"param":{"must_not_clauses"}}
}},
"params": {
"must_clauses":["type:parent", "type2:parent"],
"must_not_clauses" : {"bool": {...}}
}
}
{code}
was (Author: caomanhdat):
When I say paramValue as a JsonObject, I mean this
{ "query": { "bool":{ "must":{"param":"must_clauses"},
"must_not":{"param":\{"must_not_clauses" "params": {
"must_clauses":["type:parent", "type2:parent"],
"must_not_clauses" : \{"bool": {...}}
}
}
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112002#comment-17112002
]
Cao Manh Dat edited comment on SOLR-14419 at 5/20/20, 9:58 AM:
---
{quote}recursive dependency
{quote}
My point here is the paramValue here is just a String ("type:parent"), It will
be nice if paramValue is a JsonObject, then recurisve dependency will be a
problem.
{quote}_feature is kinda limited_ I see no limits so far.
{quote}
I mean I don't see many usecase this feature will be useful?
Right, the $ will be a problem if the query start with $. Then how the
tranditional local params solve that problem?
was (Author: caomanhdat):
{quote}recursive dependency
{quote}
My point here is the paramValue here is just a String ("type:parent"), It will
be nice if paramValue is a JsonObject, then recurisve dependency will be a
problem.
{quote}_feature is kinda limited_ I see no limits so far.
{quote}
I mean I don't see many usecase this feature will be useful?
Right, the $ will be a problem if the query start with $.
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112002#comment-17112002
]
Cao Manh Dat edited comment on SOLR-14419 at 5/20/20, 9:57 AM:
---
{quote}recursive dependency
{quote}
My point here is the paramValue here is just a String ("type:parent"), It will
be nice if paramValue is a JsonObject, then recurisve dependency will be a
problem.
{quote}_feature is kinda limited_ I see no limits so far.
{quote}
I mean I don't see many usecase this feature will be useful?
Right, the $ will be a problem if the query start with $.
was (Author: caomanhdat):
{quote}recursive dependency
{quote}
My point here is the paramValue here is just a String ("type:parent"), It will
be nice if paramValue is a JsonObject, then recurisve dependency will be a
problem.
{quote}_feature is kinda limited_ I see no limits so far.
{quote}
I mean I don't see many usecase this feature will be useful?
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111882#comment-17111882
]
Cao Manh Dat edited comment on SOLR-14419 at 5/20/20, 7:53 AM:
---
It seems \{'param': 'paramName'} too verbose and vague at the same time? Can it
be {{$paramName}} only (I don't like special character, but we already have
tags).
It seems like paramValue can only be a String. If we support paramValue as a
Json object, it may leads to recursive dependency, i.e: paramA -> paramB ->
paramA -> etc
So the application of this feature is kinda limited, is it?
was (Author: caomanhdat):
It seems {{{'param': 'paramName'}}} too verbose and vague at the same time? Can
it be {{$paramName}} only (I don't like special character, but we already have
tags).
It seems like paramValue can only be a String. If we support paramValue as a
Json object, it may leads to recursive dependency, i.e: paramA -> paramB ->
paramA -> etc
So the application of this feature is kinda limited, is it?
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111882#comment-17111882
]
Cao Manh Dat edited comment on SOLR-14419 at 5/20/20, 7:53 AM:
---
It seems {{{'param': 'paramName'}}} too verbose and vague at the same time? Can
it be {{$paramName}} only (I don't like special character, but we already have
tags).
It seems like paramValue can only be a String. If we support paramValue as a
Json object, it may leads to recursive dependency, i.e: paramA -> paramB ->
paramA -> etc
So the application of this feature is kinda limited, is it?
was (Author: caomanhdat):
It seems \{'param': 'paramName'} too verbose and vague at the same time? Can it
be {{$paramName}} only (I don't like special character, but we already have
tags).
It seems like paramValue can only be a String. If we support paramValue as a
Json object, it may leads to recursive dependency, i.e: paramA -> paramB ->
paramA -> ...
So the application of this feature is kinda limited, is it?
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14419) Query DLS {"param":"ref"}
[
https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111882#comment-17111882
]
Cao Manh Dat edited comment on SOLR-14419 at 5/20/20, 7:52 AM:
---
It seems \{'param': 'paramName'} too verbose and vague at the same time? Can it
be {{$paramName}} only (I don't like special character, but we already have
tags).
It seems like paramValue can only be a String. If we support paramValue as a
Json object, it may leads to recursive dependency, i.e: paramA -> paramB ->
paramA -> ...
So the application of this feature is kinda limited, is it?
was (Author: caomanhdat):
It seems {'param': 'paramName'} too verbose and vague at the same time? Can it
be {{$paramName}} only (I don't like special character, but we already have
tags).
It seems like paramValue can only be a String. If we support paramValue as a
Json object, it may leads to recursive dependency, i.e: paramA -> paramB ->
paramA -> ...
So the application of this feature is kinda limited, is it?
> Query DLS {"param":"ref"}
> -
>
> Key: SOLR-14419
> URL: https://issues.apache.org/jira/browse/SOLR-14419
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: JSON Request API
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.6
>
> Attachments: SOLR-14419.patch, SOLR-14419.patch, SOLR-14419.patch
>
>
> What we can do with plain params:
> {{q=\{!parent which=$prnts}...&prnts=type:parent}}
> obviously I want to have something like this in Query DSL:
> {code}
> { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}}
> "params": {
> "prnts":"type:parent"
>}
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
