[jira] [Commented] (LUCENE-10523) facilitate UnifiedHighlighter extension w.r.t. FieldHighlighter

2022-07-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566443#comment-17566443
 ] 

ASF subversion and git services commented on LUCENE-10523:
--

Commit f014c97aa26cb269e63a82c538918a2fa37bb4a0 in lucene's branch 
refs/heads/branch_9x from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=f014c97aa26 ]

LUCENE-10523: factor out UnifiedHighlighter.newFieldHighlighter() method (#821)

(cherry picked from commit 56462b5f9628ba1d465fa005e5106c55494a2011)


> facilitate UnifiedHighlighter extension w.r.t. FieldHighlighter
> ---
>
> Key: LUCENE-10523
> URL: https://issues.apache.org/jira/browse/LUCENE-10523
> Project: Lucene - Core
>  Issue Type: Wish
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> If the {{UnifiedHighlighter}} had a protected {{newFieldHighlighter}} method 
> then less {{getFieldHighlighter}} code would need to be duplicated if one 
> wanted to use a custom {{FieldHighlighter}}.
> Proposed change: https://github.com/apache/lucene/pull/821
> A possible usage scenario:
>  * e.g. via Solr's {{HTMLStripFieldUpdateProcessorFactory}} any HTML markup 
> could be stripped at document ingestion time but this may not suit all use 
> cases
>  * e.g. via Solr's {{hl.encoder=html}} parameter any HTML markup could be 
> escaped at document search time when returning highlighting snippets but this 
> may not suit all use cases
>  * extension illustration: https://github.com/apache/solr/pull/811
>  ** i.e. at document search time remove any HTML markup prior to highlight 
> snippet extraction



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-10523) facilitate UnifiedHighlighter extension w.r.t. FieldHighlighter

2022-07-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566441#comment-17566441
 ] 

ASF subversion and git services commented on LUCENE-10523:
--

Commit 56462b5f9628ba1d465fa005e5106c55494a2011 in lucene's branch 
refs/heads/main from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=56462b5f962 ]

LUCENE-10523: factor out UnifiedHighlighter.newFieldHighlighter() method (#821)



> facilitate UnifiedHighlighter extension w.r.t. FieldHighlighter
> ---
>
> Key: LUCENE-10523
> URL: https://issues.apache.org/jira/browse/LUCENE-10523
> Project: Lucene - Core
>  Issue Type: Wish
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> If the {{UnifiedHighlighter}} had a protected {{newFieldHighlighter}} method 
> then less {{getFieldHighlighter}} code would need to be duplicated if one 
> wanted to use a custom {{FieldHighlighter}}.
> Proposed change: https://github.com/apache/lucene/pull/821
> A possible usage scenario:
>  * e.g. via Solr's {{HTMLStripFieldUpdateProcessorFactory}} any HTML markup 
> could be stripped at document ingestion time but this may not suit all use 
> cases
>  * e.g. via Solr's {{hl.encoder=html}} parameter any HTML markup could be 
> escaped at document search time when returning highlighting snippets but this 
> may not suit all use cases
>  * extension illustration: https://github.com/apache/solr/pull/811
>  ** i.e. at document search time remove any HTML markup prior to highlight 
> snippet extraction



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org