[jira] [Commented] (LUCENE-9342) Collector's totalHitsThreshold should not be lower than numHits
[ https://issues.apache.org/jira/browse/LUCENE-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090919#comment-17090919 ] ASF subversion and git services commented on LUCENE-9342: - Commit edd00d933f6144293d74fc727fec6190f28c57a0 in lucene-solr's branch refs/heads/branch_8x from Tomas Eduardo Fernandez Lobbe [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=edd00d9 ] LUCENE-9342: Collector's totalHitsThreshold should not be lower than numHits (#1448) Use the maximum of the two, this is so that relation is EQUAL_TO in the case of the number of hits in a query is less than the collector's numHits > Collector's totalHitsThreshold should not be lower than numHits > --- > > Key: LUCENE-9342 > URL: https://issues.apache.org/jira/browse/LUCENE-9342 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Tomas Eduardo Fernandez Lobbe >Priority: Minor > > While looking at SOLR-13289 I noticed this situation. If I create a collector > with {{numHits}} greater than {{totalHitsThreshold}}, and the number of hits > in the query is somewhere between those two numbers, the collector’s > {{totalHitRelation}} will be {{TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO}}, > however the count will be accurate in this case. While this doesn't violate > the current contract, the {{totalHitRelation}} could be changed to > {{TotalHits.Relation.EQUAL_TO}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9342) Collector's totalHitsThreshold should not be lower than numHits
[ https://issues.apache.org/jira/browse/LUCENE-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090849#comment-17090849 ] ASF subversion and git services commented on LUCENE-9342: - Commit a11b78e06a5947ffb43a9b66b37033ebe64753e0 in lucene-solr's branch refs/heads/master from Tomas Eduardo Fernandez Lobbe [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a11b78e ] LUCENE-9342: Collector's totalHitsThreshold should not be lower than numHits (#1448) Use the maximum of the two, this is so that relation is EQUAL_TO in the case of the number of hits in a query is less than the collector's numHits > Collector's totalHitsThreshold should not be lower than numHits > --- > > Key: LUCENE-9342 > URL: https://issues.apache.org/jira/browse/LUCENE-9342 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Tomas Eduardo Fernandez Lobbe >Priority: Minor > > While looking at SOLR-13289 I noticed this situation. If I create a collector > with {{numHits}} greater than {{totalHitsThreshold}}, and the number of hits > in the query is somewhere between those two numbers, the collector’s > {{totalHitRelation}} will be {{TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO}}, > however the count will be accurate in this case. While this doesn't violate > the current contract, the {{totalHitRelation}} could be changed to > {{TotalHits.Relation.EQUAL_TO}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org