[jira] [Commented] (SOLR-12769) Incorrect documentation for Request Parameter API names (unset/delete)

2019-10-18 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954727#comment-16954727
 ] 

ASF subversion and git services commented on SOLR-12769:


Commit b8213cef1a7a8c262a3e0184a380f0e83821d99e in lucene-solr's branch 
refs/heads/branch_8x from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b8213ce ]

SOLR-12769: correct documentation for delete op in request params API


> Incorrect documentation for Request Parameter API  names (unset/delete)
> ---
>
> Key: SOLR-12769
> URL: https://issues.apache.org/jira/browse/SOLR-12769
> Project: Solr
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 7.4
>Reporter: Alexandre Rafalovitch
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-12769.patch, SOLR-12769.patch
>
>
> The [documentation for the Request Parameter 
> APIhttps://lucene.apache.org/solr/guide/7_4/request-parameters-api.html#setting-request-parameters]
>  names operations as set/update/unset.
> So does the introspection.
> However, the code for the SolrConfigHandler#handleParams uses 
> set/update/delete. So, the *unset* is not a correct description. The manual 
> testing also shows only *delete* command working.
> Furthermore, the format of the delete command is different from others 
> (array, not map), so this should be documented as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12769) Incorrect documentation for Request Parameter API names (unset/delete)

2019-10-18 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954716#comment-16954716
 ] 

ASF subversion and git services commented on SOLR-12769:


Commit 227a624f8afe846a8e1157d1114a312c7f84df66 in lucene-solr's branch 
refs/heads/master from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=227a624 ]

SOLR-12769: correct documentation for delete op in request params API


> Incorrect documentation for Request Parameter API  names (unset/delete)
> ---
>
> Key: SOLR-12769
> URL: https://issues.apache.org/jira/browse/SOLR-12769
> Project: Solr
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 7.4
>Reporter: Alexandre Rafalovitch
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-12769.patch, SOLR-12769.patch
>
>
> The [documentation for the Request Parameter 
> APIhttps://lucene.apache.org/solr/guide/7_4/request-parameters-api.html#setting-request-parameters]
>  names operations as set/update/unset.
> So does the introspection.
> However, the code for the SolrConfigHandler#handleParams uses 
> set/update/delete. So, the *unset* is not a correct description. The manual 
> testing also shows only *delete* command working.
> Furthermore, the format of the delete command is different from others 
> (array, not map), so this should be documented as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12769) Incorrect documentation for Request Parameter API names (unset/delete)

2019-10-15 Thread Lucene/Solr QA (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952462#comment-16952462
 ] 

Lucene/Solr QA commented on SOLR-12769:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  0m 54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  0m 51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} | 
{color:green}  0m 51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m 
31s{color} | {color:green} solrj in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  8m 19s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12769 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12983011/SOLR-12769.patch |
| Optional Tests |  compile  javac  unit  ratsources  validatesourcepatterns  
validaterefguide  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 939b3364e60 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/577/testReport/ |
| modules | C: solr/solrj solr/solr-ref-guide U: solr |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/577/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Incorrect documentation for Request Parameter API  names (unset/delete)
> ---
>
> Key: SOLR-12769
> URL: https://issues.apache.org/jira/browse/SOLR-12769
> Project: Solr
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 7.4
>Reporter: Alexandre Rafalovitch
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-12769.patch, SOLR-12769.patch
>
>
> The [documentation for the Request Parameter 
> APIhttps://lucene.apache.org/solr/guide/7_4/request-parameters-api.html#setting-request-parameters]
>  names operations as set/update/unset.
> So does the introspection.
> However, the code for the SolrConfigHandler#handleParams uses 
> set/update/delete. So, the *unset* is not a correct description. The manual 
> testing also shows only *delete* command working.
> Furthermore, the format of the delete command is different from others 
> (array, not map), so this should be documented as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12769) Incorrect documentation for Request Parameter API names (unset/delete)

2019-10-14 Thread Munendra S N (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951567#comment-16951567
 ] 

Munendra S N commented on SOLR-12769:
-

 [^SOLR-12769.patch] 
Thanks [~ctargett]
Fixed JSON specification

> Incorrect documentation for Request Parameter API  names (unset/delete)
> ---
>
> Key: SOLR-12769
> URL: https://issues.apache.org/jira/browse/SOLR-12769
> Project: Solr
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 7.4
>Reporter: Alexandre Rafalovitch
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-12769.patch, SOLR-12769.patch
>
>
> The [documentation for the Request Parameter 
> APIhttps://lucene.apache.org/solr/guide/7_4/request-parameters-api.html#setting-request-parameters]
>  names operations as set/update/unset.
> So does the introspection.
> However, the code for the SolrConfigHandler#handleParams uses 
> set/update/delete. So, the *unset* is not a correct description. The manual 
> testing also shows only *delete* command working.
> Furthermore, the format of the delete command is different from others 
> (array, not map), so this should be documented as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12769) Incorrect documentation for Request Parameter API names (unset/delete)

2019-10-14 Thread Cassandra Targett (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951455#comment-16951455
 ] 

Cassandra Targett commented on SOLR-12769:
--

The patch fixes the docs, but the apispec is also wrong (see 
{{./solr/solrj/src/resources/core.config.Params.Commands.json}}). We should fix 
that too.

> Incorrect documentation for Request Parameter API  names (unset/delete)
> ---
>
> Key: SOLR-12769
> URL: https://issues.apache.org/jira/browse/SOLR-12769
> Project: Solr
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 7.4
>Reporter: Alexandre Rafalovitch
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-12769.patch
>
>
> The [documentation for the Request Parameter 
> APIhttps://lucene.apache.org/solr/guide/7_4/request-parameters-api.html#setting-request-parameters]
>  names operations as set/update/unset.
> So does the introspection.
> However, the code for the SolrConfigHandler#handleParams uses 
> set/update/delete. So, the *unset* is not a correct description. The manual 
> testing also shows only *delete* command working.
> Furthermore, the format of the delete command is different from others 
> (array, not map), so this should be documented as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12769) Incorrect documentation for Request Parameter API names (unset/delete)

2019-10-08 Thread Lucene/Solr QA (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946938#comment-16946938
 ] 

Lucene/Solr QA commented on SOLR-12769:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  0m  3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  0m  3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} | 
{color:green}  0m  3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:black}{color} | {color:black} {color} | {color:black}  1m 17s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12769 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12982483/SOLR-12769.patch |
| Optional Tests |  ratsources  validatesourcepatterns  validaterefguide  |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP 
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 44dc516 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| modules | C: solr/solr-ref-guide U: solr/solr-ref-guide |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/571/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Incorrect documentation for Request Parameter API  names (unset/delete)
> ---
>
> Key: SOLR-12769
> URL: https://issues.apache.org/jira/browse/SOLR-12769
> Project: Solr
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 7.4
>Reporter: Alexandre Rafalovitch
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-12769.patch
>
>
> The [documentation for the Request Parameter 
> APIhttps://lucene.apache.org/solr/guide/7_4/request-parameters-api.html#setting-request-parameters]
>  names operations as set/update/unset.
> So does the introspection.
> However, the code for the SolrConfigHandler#handleParams uses 
> set/update/delete. So, the *unset* is not a correct description. The manual 
> testing also shows only *delete* command working.
> Furthermore, the format of the delete command is different from others 
> (array, not map), so this should be documented as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12769) Incorrect documentation for Request Parameter API names (unset/delete)

2019-10-08 Thread Munendra S N (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946757#comment-16946757
 ] 

Munendra S N commented on SOLR-12769:
-

 [^SOLR-12769.patch] 
[~arafalov]
Please review

> Incorrect documentation for Request Parameter API  names (unset/delete)
> ---
>
> Key: SOLR-12769
> URL: https://issues.apache.org/jira/browse/SOLR-12769
> Project: Solr
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 7.4
>Reporter: Alexandre Rafalovitch
>Priority: Minor
> Attachments: SOLR-12769.patch
>
>
> The [documentation for the Request Parameter 
> APIhttps://lucene.apache.org/solr/guide/7_4/request-parameters-api.html#setting-request-parameters]
>  names operations as set/update/unset.
> So does the introspection.
> However, the code for the SolrConfigHandler#handleParams uses 
> set/update/delete. So, the *unset* is not a correct description. The manual 
> testing also shows only *delete* command working.
> Furthermore, the format of the delete command is different from others 
> (array, not map), so this should be documented as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org