[jira] [Commented] (SOLR-13762) Support binary values when using XMLCodec
[ https://issues.apache.org/jira/browse/SOLR-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966683#comment-16966683 ] ASF subversion and git services commented on SOLR-13762: Commit a98198cc045dc55171df867e5541aaf292cc044b in lucene-solr's branch refs/heads/branch_8x from Jason Gerlowski [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a98198c ] SOLR-13762: Allow BinaryField use with non-binary wt's. Closes #883 > Support binary values when using XMLCodec > - > > Key: SOLR-13762 > URL: https://issues.apache.org/jira/browse/SOLR-13762 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers, Response Writers, Server, SolrJ, > UpdateRequestProcessors >Affects Versions: master (9.0), 8.3 >Reporter: Thomas Wöckinger >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > As Solr can handle binary fields, it should be possible to use XML as Codec > to encode and decode it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13762) Support binary values when using XMLCodec
[ https://issues.apache.org/jira/browse/SOLR-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957662#comment-16957662 ] Thomas Wöckinger commented on SOLR-13762: - [~gerlowskija] allready had time to review? > Support binary values when using XMLCodec > - > > Key: SOLR-13762 > URL: https://issues.apache.org/jira/browse/SOLR-13762 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers, Response Writers, Server, SolrJ, > UpdateRequestProcessors >Affects Versions: master (9.0), 8.3 >Reporter: Thomas Wöckinger >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > As Solr can handle binary fields, it should be possible to use XML as Codec > to encode and decode it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13762) Support binary values when using XMLCodec
[ https://issues.apache.org/jira/browse/SOLR-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951870#comment-16951870 ] Jason Gerlowski commented on SOLR-13762: Thanks Thomas, I'll take another look shortly! > Support binary values when using XMLCodec > - > > Key: SOLR-13762 > URL: https://issues.apache.org/jira/browse/SOLR-13762 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers, Response Writers, Server, SolrJ, > UpdateRequestProcessors >Affects Versions: master (9.0), 8.3 >Reporter: Thomas Wöckinger >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > As Solr can handle binary fields, it should be possible to use XML as Codec > to encode and decode it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13762) Support binary values when using XMLCodec
[ https://issues.apache.org/jira/browse/SOLR-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950812#comment-16950812 ] Thomas Wöckinger commented on SOLR-13762: - Any new information on this? [~gerlowskija] anything where i can support you? > Support binary values when using XMLCodec > - > > Key: SOLR-13762 > URL: https://issues.apache.org/jira/browse/SOLR-13762 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers, Response Writers, Server, SolrJ, > UpdateRequestProcessors >Affects Versions: master (9.0), 8.3 >Reporter: Thomas Wöckinger >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > As Solr can handle binary fields, it should be possible to use XML as Codec > to encode and decode it. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13762) Support binary values when using XMLCodec
[ https://issues.apache.org/jira/browse/SOLR-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931224#comment-16931224 ] Thomas Wöckinger commented on SOLR-13762: - When using JSON there are 2 widely used approaches: .) Using Base64 for en- and decoding. .) Using Mulitpart Form Data. The second one is much more efficient. > Support binary values when using XMLCodec > - > > Key: SOLR-13762 > URL: https://issues.apache.org/jira/browse/SOLR-13762 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers, Response Writers, Server, SolrJ, > UpdateRequestProcessors >Affects Versions: master (9.0), 8.3 >Reporter: Thomas Wöckinger >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > As Solr can handle binary fields, it should be possible to use XML as Codec > to encode and decode it. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13762) Support binary values when using XMLCodec
[
https://issues.apache.org/jira/browse/SOLR-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930858#comment-16930858
]
Jason Gerlowski commented on SOLR-13762:
It looks like there's some [prior
discussion|https://issues.apache.org/jira/browse/SOLR-1116] around how binary
fields should be encoded to fit within XML and other text-based formats. The
consensus there was base64, which I think lines up with your PR? It's also
interesting that someone (at some point) thought about fitting fields with
binary content into text-base response formats. I wonder whether this still
works for fields of type {{BinaryField}}, or whether this broke at some point.
If the code in SOLR-1116 (the link above) is still valid, we should probably
try to fix things here in a similar manner. (unless there's some particular
reason not to do so).
Additionally, I know this issue is scoped somewhat narrowly to XML, but I
wonder if we couldn't also fix this problem in JSON with a similar amount of
work. Still need to do more digging into the SOLR-1116 commit, and how these
codecs work today to say whether that's possible though. Maybe it's not.
> Support binary values when using XMLCodec
> -
>
> Key: SOLR-13762
> URL: https://issues.apache.org/jira/browse/SOLR-13762
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: query parsers, Response Writers, Server, SolrJ,
> UpdateRequestProcessors
>Affects Versions: master (9.0), 8.3
>Reporter: Thomas Wöckinger
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As Solr can handle binary fields, it should be possible to use XML as Codec
> to encode and decode it.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13762) Support binary values when using XMLCodec
[ https://issues.apache.org/jira/browse/SOLR-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930791#comment-16930791 ] Jason Gerlowski commented on SOLR-13762: Dumb question: do you know what field types this all effects? Or are there a few fields where this is definitely an issue? I'm asking to make sure to try each of them out, and make sure we have tests if it makes sense. But I'm also looking for an easy way to reproduce. So if you've got a concrete way to trigger this, feel free to post a script or something as an attachment. I'd like to review this, but it'll take me some time to read up on the jira history and code involved. Aiming to get some feedback out by next weekend. If anyone else with more context wants to jump in, please do. > Support binary values when using XMLCodec > - > > Key: SOLR-13762 > URL: https://issues.apache.org/jira/browse/SOLR-13762 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: query parsers, Response Writers, Server, SolrJ, > UpdateRequestProcessors >Affects Versions: master (9.0), 8.3 >Reporter: Thomas Wöckinger >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > As Solr can handle binary fields, it should be possible to use XML as Codec > to encode and decode it. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
