[jira] [Commented] (SOLR-13902) "ant precommit" is inconsistent in branch_8x vs. master

2019-11-11 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-13902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971897#comment-16971897
 ] 

Uwe Schindler commented on SOLR-13902:
--

+1

I am still trying to find out why the version numbers on master and 8.x were 
different.

> "ant precommit" is inconsistent in branch_8x vs. master
> ---
>
> Key: SOLR-13902
> URL: https://issues.apache.org/jira/browse/SOLR-13902
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Noble Paul
>Priority: Major
>
> Missing {{package-info.java}} does not fail in master , but it fails in 
> {{branch_8x}}. If it's required , it should fail everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-13902) "ant precommit" is inconsistent in branch_8x vs. master

2019-11-11 Thread Kevin Risden (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-13902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971839#comment-16971839
 ] 

Kevin Risden commented on SOLR-13902:
-

[~noble.paul] / [~ab] do you know if this was related to javadoc checks or 
something that ecj would check? 

Branch 8x has 3.18.0 - 
https://github.com/apache/lucene-solr/blob/branch_8x/lucene/common-build.xml#L2123
master has 3.17.0 - 
https://github.com/apache/lucene-solr/blob/master/lucene/common-build.xml#L2039

[~uschindler] found this when I was looking at LUCENE-9041. I plan to fix both 
8x and master to be the same ecj version.

> "ant precommit" is inconsistent in branch_8x vs. master
> ---
>
> Key: SOLR-13902
> URL: https://issues.apache.org/jira/browse/SOLR-13902
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Noble Paul
>Priority: Major
>
> Missing {{package-info.java}} does not fail in master , but it fails in 
> {{branch_8x}}. If it's required , it should fail everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-13902) "ant precommit" is inconsistent in branch_8x vs. master

2019-11-08 Thread Andrzej Bialecki (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-13902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970041#comment-16970041
 ] 

Andrzej Bialecki commented on SOLR-13902:
-

It should fail on both branches. I also encountered a case where there were 2 
files in the same packages - one in core and one in test sources, both in the 
same package. This wasn't caught either but it later caused a weird error from 
the javadoc build.

> "ant precommit" is inconsistent in branch_8x vs. master
> ---
>
> Key: SOLR-13902
> URL: https://issues.apache.org/jira/browse/SOLR-13902
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Noble Paul
>Priority: Major
>
> Missing {{package-info.java}} does not fail in master , but it fails in 
> {{branch_8x}}. If it's required , it should fail everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org