[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-22 Thread Munendra S N (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980261#comment-16980261
 ] 

Munendra S N commented on SOLR-13912:
-

I usually resolve issues as Fixed only for bugs whereas tasks, improvements and 
new features resolve them as Done since, we are not usually fixing anything 
those issues. 
Thanks for the suggestion. From now on, I will follow the convention of 
resolving them Fixed.

> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Major
> Fix For: 8.4
>
> Attachments: SOLR-13912.patch, SOLR-13912.patch, SOLR-13912.patch, 
> SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-22 Thread Erick Erickson (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980164#comment-16980164
 ] 

Erick Erickson commented on SOLR-13912:
---

[~munendrasn] I don't think there's any formal requirement, but people usually 
resolve these as "Fixed" when the code's been pushed rather than "Done". No big 
deal

> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Major
> Fix For: 8.4
>
> Attachments: SOLR-13912.patch, SOLR-13912.patch, SOLR-13912.patch, 
> SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-22 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980136#comment-16980136
 ] 

ASF subversion and git services commented on SOLR-13912:


Commit 2ba55b7e3c284936ef6a6f5bd975c7e2280a586a in lucene-solr's branch 
refs/heads/branch_8x from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2ba55b7 ]

SOLR-13912: add support for countvals aggregation in JSON facet module

* This aggregation is equivalent to StatsComponent's count


> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13912.patch, SOLR-13912.patch, SOLR-13912.patch, 
> SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-22 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980129#comment-16980129
 ] 

ASF subversion and git services commented on SOLR-13912:


Commit 2740d90dee8aef81d98afd63a53ac06320b7e73e in lucene-solr's branch 
refs/heads/master from Munendra S N
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2740d90 ]

SOLR-13912: add support for countvals aggregation in JSON facet module

* This aggregation is equivalent to StatsComponent's count


> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13912.patch, SOLR-13912.patch, SOLR-13912.patch, 
> SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-17 Thread Lucene/Solr QA (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976329#comment-16976329
 ] 

Lucene/Solr QA commented on SOLR-13912:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  1m 13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  1m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  1m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} | 
{color:green}  1m 10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 45m 
47s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 53s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13912 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12986051/SOLR-13912.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  validaterefguide  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 0857bb60d3b |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/598/testReport/ |
| modules | C: solr/core solr/solr-ref-guide U: solr |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/598/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13912.patch, SOLR-13912.patch, SOLR-13912.patch, 
> SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-17 Thread Munendra S N (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976095#comment-16976095
 ] 

Munendra S N commented on SOLR-13912:
-

 [^SOLR-13912.patch] 
Further refactoring in DocValues Accumulator

> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13912.patch, SOLR-13912.patch, SOLR-13912.patch, 
> SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-16 Thread Lucene/Solr QA (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975929#comment-16975929
 ] 

Lucene/Solr QA commented on SOLR-13912:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  1m  6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  1m  2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  1m  2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate ref guide {color} | 
{color:green}  1m  2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 44m 38s{color} 
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m  9s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.search.facet.TestJsonFacets |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13912 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12986016/SOLR-13912.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  validaterefguide  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 5200ee0ef99 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| unit | 
https://builds.apache.org/job/PreCommit-SOLR-Build/597/artifact/out/patch-unit-solr_core.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/597/testReport/ |
| modules | C: solr/core solr/solr-ref-guide U: solr |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/597/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13912.patch, SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-16 Thread Munendra S N (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975688#comment-16975688
 ] 

Munendra S N commented on SOLR-13912:
-

 [^SOLR-13912.patch] 
Above patch includes
* Ref-Guide changes
* uncommenting tests from SOLR-11695
* Aggregation name is {{countvals}}

{quote}do we not have any existing general purpose abstractions for the 
differences between Accumulating values over SortedSetDV, SortedNumericDV that 
could be reuse here w/simple subclasses the only worry about the 
"counting"{quote}
We don't have general purpose abstractions right now. Most Acc are bound to 
particular Agg this is true especially for Multivalued case. 
In the latest patch, I have added abstractions for DocValues fields and made 
some minor refactoring in UniqueAgg and HllAgg. Hopefully, this could be 
improved further while adding support for multivalued fields in other 
Aggregations

[~hossman]
Could you please review this once more? Let me know if any changes required

> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13912.patch, SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-10 Thread Lucene/Solr QA (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971306#comment-16971306
 ] 

Lucene/Solr QA commented on SOLR-13912:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  1m  1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  1m  1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  1m  1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 46m 
58s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 51s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13912 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12985453/SOLR-13912.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 7a207a93537 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/593/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/593/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13912) Support Count aggregation in JSON facet module

2019-11-10 Thread Munendra S N (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971102#comment-16971102
 ] 

Munendra S N commented on SOLR-13912:
-

 [^SOLR-13912.patch] 
Initial patch for count aggregation support.
* Name of the aggregation - {{countvals}}
* Aggregated value would always be {{long}} irrespective of single or 
multi-shard
* Multivalued non-docvalues support is based on {{UniqueMultiValuedSlotAcc}}

[~mkhl] [~hossman] [~ysee...@gmail.com] could you please review?

> Support Count aggregation in JSON facet module
> --
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
>  Issue Type: Sub-task
>  Components: Facet Module
>Reporter: Munendra S N
>Priority: Major
> Attachments: SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org