[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981195#comment-16981195 ] Erick Erickson commented on SOLR-13952: --- Yes I did see your comments. And I spend a day re-doing it so _substantive_ changes are not included. This all suppress warnings, etc. Next up is substantive changes. See SOLR-13964. I'm a bit frustrated too, this feels like swimming upstream to try to make progress. "did you take what Mark did blindly" No. I admit I didn't test each and every SuppressWarning to see if it really did suppress a warning after some spot-checking. If I'd done it blindly, I'd have pushed all the files changed by "ant regenerate" (another half day trying to get to run) and the manual changes to generated files rather than save untangling those for a different JIRA. "did you...notice the fully qualified class references." Yes I did. Static imports can be ambiguous if two or more static imports define the same variable. Which I've run into more than once in our code. So these changes, while ugly, are arguably more correct. I'm "iffy" on this due to the fact that they _are_ ugly, so if they were changed back I wouldn't mind. Feel free. I'll change the title and "CHANGES.txt" when I work on the next related JIRA. Your point about what this looks like to someone else (or even me) 6 months down the road is well taken. > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13952.patch, fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > This turned out not to be as hard as I expected. I'll create a sub-task for > the functional changes and use this one for the non-functional changes. > Non-functional changes are the overwhelming majority of changes. There are a > few categories of change here: > * SuppressWarnings, rawtypes, deprecated. > * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter > and QuickPatchThreadsFilter. These are know thread leaks from third-party > products (IBM Java, and a Log4J2 thread was added) > * some static imports were removed > * some reformatting, given that this whole patch is not about functional > changes I decided to leave them in. > * Some very minor code changes: > ** change "new Path(leaderPath).getParent().toString();" to > "Paths.get(leaderPath).getParent().toString();" > ** mods like new HashMap(); <- new HashMap<>(); > * Log messages added -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981170#comment-16981170 ] David Smiley commented on SOLR-13952: - Also, I recommend that we attribute Mark's work to Mark in the commit. Too late here; I know. As an aside, minor issues like this one needn't have a CHANGES.txt entry (in my opinion) so that's up to you. It's just noise to me. > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13952.patch, fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > This turned out not to be as hard as I expected. I'll create a sub-task for > the functional changes and use this one for the non-functional changes. > Non-functional changes are the overwhelming majority of changes. There are a > few categories of change here: > * SuppressWarnings, rawtypes, deprecated. > * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter > and QuickPatchThreadsFilter. These are know thread leaks from third-party > products (IBM Java, and a Log4J2 thread was added) > * some static imports were removed > * some reformatting, given that this whole patch is not about functional > changes I decided to leave them in. > * Some very minor code changes: > ** change "new Path(leaderPath).getParent().toString();" to > "Paths.get(leaderPath).getParent().toString();" > ** mods like new HashMap(); <- new HashMap<>(); > * Log messages added -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981164#comment-16981164 ] David Smiley commented on SOLR-13952: - Some of the changes here don't look like a good idea at all, and I think should be reverted. Did you really look over everything? See ExtractingDocumentLoader and notice the fully qualified class references. Did you approve of that? Ditto for WordDelimiterFilterFactory. Why shouldn't take what Mark did blindly. There may be other places but I did a little spot check. _At least_ the changes here are, from what I've seen, limited to minor compile time matters, and thus I don't mind one commit. > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13952.patch, fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > This turned out not to be as hard as I expected. I'll create a sub-task for > the functional changes and use this one for the non-functional changes. > Non-functional changes are the overwhelming majority of changes. There are a > few categories of change here: > * SuppressWarnings, rawtypes, deprecated. > * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter > and QuickPatchThreadsFilter. These are know thread leaks from third-party > products (IBM Java, and a Log4J2 thread was added) > * some static imports were removed > * some reformatting, given that this whole patch is not about functional > changes I decided to leave them in. > * Some very minor code changes: > ** change "new Path(leaderPath).getParent().toString();" to > "Paths.get(leaderPath).getParent().toString();" > ** mods like new HashMap(); <- new HashMap<>(); > * Log messages added -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981162#comment-16981162 ] David Smiley commented on SOLR-13952: - We can't change what's been committed but you can fix the CHANGES.txt entry and the title of this issue. Possible CHANGES.txt & Issue title: "Added SuppressWarnings and similar minor matters" Feel free to edit as you wish as well. > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13952.patch, fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > This turned out not to be as hard as I expected. I'll create a sub-task for > the functional changes and use this one for the non-functional changes. > Non-functional changes are the overwhelming majority of changes. There are a > few categories of change here: > * SuppressWarnings, rawtypes, deprecated. > * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter > and QuickPatchThreadsFilter. These are know thread leaks from third-party > products (IBM Java, and a Log4J2 thread was added) > * some static imports were removed > * some reformatting, given that this whole patch is not about functional > changes I decided to leave them in. > * Some very minor code changes: > ** change "new Path(leaderPath).getParent().toString();" to > "Paths.get(leaderPath).getParent().toString();" > ** mods like new HashMap(); <- new HashMap<>(); > * Log messages added -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981161#comment-16981161 ] David Smiley commented on SOLR-13952: - I'm frustrated. Did you read my message? You committed to master what I asked you not to do. It's a lot about the commit message. Imagine you are looking at the change history for a file and looking over the commit messages. Why should this commit message even mention gradle? It has nothing to do with Gradle. It should mention what it *does*. Like... "Adding @SuppressWarnings". Even list a bunch of things bulleted if you wish. First line is most important; probably minor non-functional edits or some-such. Can you appreciate my point? > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13952.patch, fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > This turned out not to be as hard as I expected. I'll create a sub-task for > the functional changes and use this one for the non-functional changes. > Non-functional changes are the overwhelming majority of changes. There are a > few categories of change here: > * SuppressWarnings, rawtypes, deprecated. > * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter > and QuickPatchThreadsFilter. These are know thread leaks from third-party > products (IBM Java, and a Log4J2 thread was added) > * some static imports were removed > * some reformatting, given that this whole patch is not about functional > changes I decided to leave them in. > * Some very minor code changes: > ** change "new Path(leaderPath).getParent().toString();" to > "Paths.get(leaderPath).getParent().toString();" > ** mods like new HashMap(); <- new HashMap<>(); > * Log messages added -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981155#comment-16981155 ] Erick Erickson commented on SOLR-13952: --- l'll close this JIRA when the sub-task is done. > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13952.patch, fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > This turned out not to be as hard as I expected. I'll create a sub-task for > the functional changes and use this one for the non-functional changes. > Non-functional changes are the overwhelming majority of changes. There are a > few categories of change here: > * SuppressWarnings, rawtypes, deprecated. > * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter > and QuickPatchThreadsFilter. These are know thread leaks from third-party > products (IBM Java, and a Log4J2 thread was added) > * some static imports were removed > * some reformatting, given that this whole patch is not about functional > changes I decided to leave them in. > * Some very minor code changes: > ** change "new Path(leaderPath).getParent().toString();" to > "Paths.get(leaderPath).getParent().toString();" > ** mods like new HashMap(); <- new HashMap<>(); > * Log messages added -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981152#comment-16981152 ] ASF subversion and git services commented on SOLR-13952: Commit f1cf3db588f858453b870d774948f11cc62cc520 in lucene-solr's branch refs/heads/master from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f1cf3db ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately, forgot CHANGES.txt > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13952.patch, fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > This turned out not to be as hard as I expected. I'll create a sub-task for > the functional changes and use this one for the non-functional changes. > Non-functional changes are the overwhelming majority of changes. There are a > few categories of change here: > * SuppressWarnings, rawtypes, deprecated. > * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter > and QuickPatchThreadsFilter. These are know thread leaks from third-party > products (IBM Java, and a Log4J2 thread was added) > * some static imports were removed > * some reformatting, given that this whole patch is not about functional > changes I decided to leave them in. > * Some very minor code changes: > ** change "new Path(leaderPath).getParent().toString();" to > "Paths.get(leaderPath).getParent().toString();" > ** mods like new HashMap(); <- new HashMap<>(); > * Log messages added -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981150#comment-16981150 ] ASF subversion and git services commented on SOLR-13952: Commit 4b34d726ab015172e87534cb0685f8626e63c9fe in lucene-solr's branch refs/heads/master from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4b34d72 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Build >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-13952.patch, fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > This turned out not to be as hard as I expected. I'll create a sub-task for > the functional changes and use this one for the non-functional changes. > Non-functional changes are the overwhelming majority of changes. There are a > few categories of change here: > * SuppressWarnings, rawtypes, deprecated. > * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter > and QuickPatchThreadsFilter. These are know thread leaks from third-party > products (IBM Java, and a Log4J2 thread was added) > * some static imports were removed > * some reformatting, given that this whole patch is not about functional > changes I decided to leave them in. > * Some very minor code changes: > ** change "new Path(leaderPath).getParent().toString();" to > "Paths.get(leaderPath).getParent().toString();" > ** mods like new HashMap(); <- new HashMap<>(); > * Log messages added -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980773#comment-16980773 ] David Smiley commented on SOLR-13952: - Then file an issue RE SuppressWarnings with 200 files and commit that. That's a valid subject/theme that could have a commit message that makes sense. I just don't want a commit/issue that's basically "Bunch of random stuff Mark did; he knows best" > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[
https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980771#comment-16980771
]
Erick Erickson commented on SOLR-13952:
---
Thanks for letting me know about XmlOffsetCorrector.
re: one big commit. There are over 200 (?) separate files affected, the vast
majority of them follow the pattern:
{code}
@SuppressWarning blah blah blah
{code}
Mostly for deprecations and the like and another group for thread leaks from
other packages that we don't control and shouldn't fail suites because of
thread leaks in them.
There are maybe 3-4 about matters like this. And this one (XmlOffsetCorrector)
doesn't count since I'm going to revert it on your advice.
I'm not willing to create a huge number of tickets for this. Look at the bright
side, at least the gradle branch won't have them (soon I hope).
The goal here is to peel this out of the Gradle build exactly to introduce
_some_ separation of changes in the gradle branch without losing Mark's efforts
at test improvement (or, in many cases compiler warnings).
So what do you suggest here? I'm not going to do a lot of busy work to address
this.
> Separate out Gradle-specific code from other (mostly test) changes and commit
> separately
>
>
> Key: SOLR-13952
> URL: https://issues.apache.org/jira/browse/SOLR-13952
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Erick Erickson
>Assignee: Erick Erickson
>Priority: Major
> Attachments: fordavid.patch
>
>
> The gradle_8 branch has many changes unrelated to gradle. It would be much
> easier to work on the gradle parts if these were separated. So here's my plan:
> - establish a branch to use for the non-gradle parts of the gradle_8 branch
> and commit separately. For a first cut, I'll make all the changes I'm
> confident of, and mark the others with nocommits so we can iterate and decide
> when to merge to master and 8x.
> - create a "gradle_9" branch that hosts only the gradle changes for us all to
> iterate on.
> I hope to have a preliminary cut at this over the weekend.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980670#comment-16980670 ] David Smiley commented on SOLR-13952: - So basically you ultimately plan on committing one issue with a bunch of random Solr changes? That's not cool. Commits & corresponding issues should have a particular subject, mostly. > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980665#comment-16980665 ] David Smiley commented on SOLR-13952: - Ignore his change to XmlOffsetCorrector. AFAICT he maybe barely started to try to have this class not depend on Woodstox for some reason... but didn't really. That's my guess. Harmless. > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: fordavid.patch > > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980373#comment-16980373 ] ASF subversion and git services commented on SOLR-13952: Commit 38c2ccf951e13886accecfa7ca2f1b0d1a2af8b3 in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=38c2ccf ] SOLR-13952: Resolved issue with QueryParser.jj and executed the 'ant javacc' target > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980311#comment-16980311 ] ASF subversion and git services commented on SOLR-13952: Commit 6474ea3c2296f3a4656c2d58ba6df277b2e2ba59 in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6474ea3 ] SOLR-13952: Removed all of the nocommits associated with TheadLeakFilters. These are well-known by Log4j and IBM so seem safe > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[
https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979772#comment-16979772
]
Erick Erickson commented on SOLR-13952:
---
Here are some things I'm seeing I could use some opinions on. This has been
pushed to a new branch in the repo, jira/SOLR-13952
--
Mark added the first two classes for ignoring thread leaks
SolrIgnoredThreadsFilter and QuickPathThreadsFilter to quite a number of Hdfs
tests: BadHdfsThreadsFilterClass was already there:
{code}
@ThreadLeakFilters(defaultFilters = true, filters = {
SolrIgnoredThreadsFilter.class,
QuickPatchThreadsFilter.class,
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
})
public class HdfsThreadLeakTest extends SolrTestCaseJ4 {
{code}
He also added
{code}
if (threadName.startsWith("Log4j2-TF-2-AsyncLoggerConfig")) {return true; }
{code}
to SolrIgnoredThreadsFilter.
Does anyone who knows more about Hdfs tests than I do have an opinion here? My
presumption is that this is fine, but I'd like to understand it a bit more.
There's also similar additions to SaslZkACLProviderTest,
SharedFSAutoReplicaFailoverTest, SolrTestCase, TestSolrCloudWithKerberosAlt
HTMLCharacterEntities.jflex, line 63 has been changed from:
{code}
| "zwj" | "zwnj" )
to
('| "zwj" | "zwnj"', ')')
{code}
Is this something that makes sense? This regenerates HtmlStripCharFilter of
course. I have no problem adding this in, just want a sanity check. For the
nonce, I've put a "nocommit" in the jflex file in a comment, I've made a note
to myself to grep _everything_ for nocommit
---
QueryParser.jj has a SynonymQueryStyle added to newFieldQuery that extends up
to the base class. Why?
-
I pretty much just accepted all of Mark's annotations.
-
XmlOffsetCorrector.java has some changes I don't understand. //nocommitted
--
Anyone who has any light to shed, please do. Otherwise that's enough for one
night. So far it compiles, but certainly doesn't succeed through precommit.
I'll try running through all the tests tonight. I _believe_ I've taken all of
the gradle-related changes out.
> Separate out Gradle-specific code from other (mostly test) changes and commit
> separately
>
>
> Key: SOLR-13952
> URL: https://issues.apache.org/jira/browse/SOLR-13952
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Erick Erickson
>Assignee: Erick Erickson
>Priority: Major
>
> The gradle_8 branch has many changes unrelated to gradle. It would be much
> easier to work on the gradle parts if these were separated. So here's my plan:
> - establish a branch to use for the non-gradle parts of the gradle_8 branch
> and commit separately. For a first cut, I'll make all the changes I'm
> confident of, and mark the others with nocommits so we can iterate and decide
> when to merge to master and 8x.
> - create a "gradle_9" branch that hosts only the gradle changes for us all to
> iterate on.
> I hope to have a preliminary cut at this over the weekend.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979760#comment-16979760 ] ASF subversion and git services commented on SOLR-13952: Commit 872e6b0a1d25b87c47cbd9c91293bb3c4f9f973e in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=872e6b0 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979753#comment-16979753 ] ASF subversion and git services commented on SOLR-13952: Commit f99374de39b9193d402ad7ebd5c5ee846d2bcb69 in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f99374d ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979755#comment-16979755 ] ASF subversion and git services commented on SOLR-13952: Commit d4c484655b200b577b21bff5b56e595c70abb395 in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d4c4846 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979754#comment-16979754 ] ASF subversion and git services commented on SOLR-13952: Commit 3eb89d6cbcb1052da0557d2b5cb2f055a5dd91e6 in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3eb89d6 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979756#comment-16979756 ] ASF subversion and git services commented on SOLR-13952: Commit 9ec33679ae4dcde49cc536bb058b991f66af514f in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9ec3367 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979757#comment-16979757 ] ASF subversion and git services commented on SOLR-13952: Commit 7756d5a3c8bde56b056938fd5f2cff185ef3d5f1 in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7756d5a ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979752#comment-16979752 ] ASF subversion and git services commented on SOLR-13952: Commit 5afe971e4a85b38b1f14247bd4edc456b491736d in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5afe971 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979751#comment-16979751 ] ASF subversion and git services commented on SOLR-13952: Commit a44cf63510b3d8ecbe6b68db159da27fe93d3c3d in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a44cf63 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979759#comment-16979759 ] ASF subversion and git services commented on SOLR-13952: Commit c1c05b51757b11504ccf4d69df7bcba15f5b0b38 in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c1c05b5 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13952) Separate out Gradle-specific code from other (mostly test) changes and commit separately
[ https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979758#comment-16979758 ] ASF subversion and git services commented on SOLR-13952: Commit 93f7055cfc21e7b08184159ded87e87ba5818fb6 in lucene-solr's branch refs/heads/jira/SOLR-13952 from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=93f7055 ] SOLR-13952: Separate out Gradle-specific code from other (mostly test) changes and commit separately > Separate out Gradle-specific code from other (mostly test) changes and commit > separately > > > Key: SOLR-13952 > URL: https://issues.apache.org/jira/browse/SOLR-13952 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > > The gradle_8 branch has many changes unrelated to gradle. It would be much > easier to work on the gradle parts if these were separated. So here's my plan: > - establish a branch to use for the non-gradle parts of the gradle_8 branch > and commit separately. For a first cut, I'll make all the changes I'm > confident of, and mark the others with nocommits so we can iterate and decide > when to merge to master and 8x. > - create a "gradle_9" branch that hosts only the gradle changes for us all to > iterate on. > I hope to have a preliminary cut at this over the weekend. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
