[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-20 Thread Jason Gerlowski (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112240#comment-17112240
 ] 

Jason Gerlowski commented on SOLR-14142:


Conceptually it's a different issue, but in practice tackling them separately 
opens the door to shipping Solr with a default setup that would happily eat 
user's disk on a busy cluster.

Tackling better request-log defaults can be its own jira, no objections there.  
But that ticket should be a pre-req for this one.  We shouldn't turn something 
on by default until it's configured in a way that won't bite users OOTB.

> Enable jetty's request log by default
> -
>
> Key: SOLR-14142
> URL: https://issues.apache.org/jira/browse/SOLR-14142
> Project: Solr
>  Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-14142.patch, SOLR-14142.patch
>
>
> I'd like to enable the jetty request log by default.
> This log is now in the correct directory, it no longer uses the deprecated 
> mechanisms (it is asynclogwriter + customformat), etc. See SOLR-14138.
> This log is in a standard format (NCSA) which is supported by tools 
> out-of-box. It does not contain challenges such as java exceptions and is 
> easy to work with. Without it enabled, solr really has insufficient logging 
> (e.g. no IP addresses).
> If someone's solr gets hacked, its only fair they at least get to see who did 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-19 Thread Robert Muir (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1708#comment-1708
 ] 

Robert Muir commented on SOLR-14142:


Days, bytes, maybe there are lots of options towards a good default. Have not 
even looked into jetty options around all this: there is no need to blow scope, 
I don't want to tackle this crap here. If you are interested, please open an 
issue and do the research and upload/test a patch.

This patch is tested and works, it just changes the default and remove 
deprecations. That's why I think retention is best handled as another issue.


> Enable jetty's request log by default
> -
>
> Key: SOLR-14142
> URL: https://issues.apache.org/jira/browse/SOLR-14142
> Project: Solr
>  Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-14142.patch, SOLR-14142.patch
>
>
> I'd like to enable the jetty request log by default.
> This log is now in the correct directory, it no longer uses the deprecated 
> mechanisms (it is asynclogwriter + customformat), etc. See SOLR-14138.
> This log is in a standard format (NCSA) which is supported by tools 
> out-of-box. It does not contain challenges such as java exceptions and is 
> easy to work with. Without it enabled, solr really has insufficient logging 
> (e.g. no IP addresses).
> If someone's solr gets hacked, its only fair they at least get to see who did 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-19 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111080#comment-17111080
 ] 

Uwe Schindler commented on SOLR-14142:
--

Maybe make days to keep confirgurable and start with 7 days. I agree, that's a 
different issue.

> Enable jetty's request log by default
> -
>
> Key: SOLR-14142
> URL: https://issues.apache.org/jira/browse/SOLR-14142
> Project: Solr
>  Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-14142.patch, SOLR-14142.patch
>
>
> I'd like to enable the jetty request log by default.
> This log is now in the correct directory, it no longer uses the deprecated 
> mechanisms (it is asynclogwriter + customformat), etc. See SOLR-14138.
> This log is in a standard format (NCSA) which is supported by tools 
> out-of-box. It does not contain challenges such as java exceptions and is 
> easy to work with. Without it enabled, solr really has insufficient logging 
> (e.g. no IP addresses).
> If someone's solr gets hacked, its only fair they at least get to see who did 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-19 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111079#comment-17111079
 ] 

Uwe Schindler commented on SOLR-14142:
--

I agree. Because of the security question coming in from somebody who was 
hacked, this is a good information. I would restrict it to even shorter time.

> Enable jetty's request log by default
> -
>
> Key: SOLR-14142
> URL: https://issues.apache.org/jira/browse/SOLR-14142
> Project: Solr
>  Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-14142.patch, SOLR-14142.patch
>
>
> I'd like to enable the jetty request log by default.
> This log is now in the correct directory, it no longer uses the deprecated 
> mechanisms (it is asynclogwriter + customformat), etc. See SOLR-14138.
> This log is in a standard format (NCSA) which is supported by tools 
> out-of-box. It does not contain challenges such as java exceptions and is 
> easy to work with. Without it enabled, solr really has insufficient logging 
> (e.g. no IP addresses).
> If someone's solr gets hacked, its only fair they at least get to see who did 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-19 Thread Robert Muir (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111015#comment-17111015
 ] 

Robert Muir commented on SOLR-14142:


Please, lets open a separate issue for that. It is completely unrelated.

> Enable jetty's request log by default
> -
>
> Key: SOLR-14142
> URL: https://issues.apache.org/jira/browse/SOLR-14142
> Project: Solr
>  Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-14142.patch, SOLR-14142.patch
>
>
> I'd like to enable the jetty request log by default.
> This log is now in the correct directory, it no longer uses the deprecated 
> mechanisms (it is asynclogwriter + customformat), etc. See SOLR-14138.
> This log is in a standard format (NCSA) which is supported by tools 
> out-of-box. It does not contain challenges such as java exceptions and is 
> easy to work with. Without it enabled, solr really has insufficient logging 
> (e.g. no IP addresses).
> If someone's solr gets hacked, its only fair they at least get to see who did 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-18 Thread David Smiley (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110559#comment-17110559
 ] 

David Smiley commented on SOLR-14142:
-

I'm +1 but my only concern is the default retention period.  
{{solr/server/etc/jetty-requestlog.xml:33}} shows a whopping 90 days.  There's 
no size constraint.  Since these logs are partially redundant with Solr's own 
logging, I propose we dial this down to 7 days.  WDYT?

> Enable jetty's request log by default
> -
>
> Key: SOLR-14142
> URL: https://issues.apache.org/jira/browse/SOLR-14142
> Project: Solr
>  Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-14142.patch, SOLR-14142.patch
>
>
> I'd like to enable the jetty request log by default.
> This log is now in the correct directory, it no longer uses the deprecated 
> mechanisms (it is asynclogwriter + customformat), etc. See SOLR-14138.
> This log is in a standard format (NCSA) which is supported by tools 
> out-of-box. It does not contain challenges such as java exceptions and is 
> easy to work with. Without it enabled, solr really has insufficient logging 
> (e.g. no IP addresses).
> If someone's solr gets hacked, its only fair they at least get to see who did 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-18 Thread Robert Muir (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110360#comment-17110360
 ] 

Robert Muir commented on SOLR-14142:


Oops, I forgot about this issue entirely. I'll take another look later today.

> Enable jetty's request log by default
> -
>
> Key: SOLR-14142
> URL: https://issues.apache.org/jira/browse/SOLR-14142
> Project: Solr
>  Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-14142.patch, SOLR-14142.patch
>
>
> I'd like to enable the jetty request log by default.
> This log is now in the correct directory, it no longer uses the deprecated 
> mechanisms (it is asynclogwriter + customformat), etc. See SOLR-14138.
> This log is in a standard format (NCSA) which is supported by tools 
> out-of-box. It does not contain challenges such as java exceptions and is 
> easy to work with. Without it enabled, solr really has insufficient logging 
> (e.g. no IP addresses).
> If someone's solr gets hacked, its only fair they at least get to see who did 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-18 Thread Jira


[ 
https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110334#comment-17110334
 ] 

Jan Høydahl commented on SOLR-14142:


+1

> Enable jetty's request log by default
> -
>
> Key: SOLR-14142
> URL: https://issues.apache.org/jira/browse/SOLR-14142
> Project: Solr
>  Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-14142.patch, SOLR-14142.patch
>
>
> I'd like to enable the jetty request log by default.
> This log is now in the correct directory, it no longer uses the deprecated 
> mechanisms (it is asynclogwriter + customformat), etc. See SOLR-14138.
> This log is in a standard format (NCSA) which is supported by tools 
> out-of-box. It does not contain challenges such as java exceptions and is 
> easy to work with. Without it enabled, solr really has insufficient logging 
> (e.g. no IP addresses).
> If someone's solr gets hacked, its only fair they at least get to see who did 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org