[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021166#comment-17021166 ] Kevin Risden commented on SOLR-14154: - Sorry Ishan I typoed the jira id and missed the CHANGES entry for this on 8.4. [~ichattopadhyaya] do you want me to fix the CHANGES.txt? > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.5, 8.4.1 > > Time Spent: 1h > Remaining Estimate: 0h > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020915#comment-17020915 ] Ishan Chattopadhyaya commented on SOLR-14154: - Ouch! This was committed in the branch_8_4 with wrong JIRA ID (SOLR-14153). Also, there was no corresponding changelog in CHANGES.txt in that branch. As a result, the release was made without this issue being part of the changelog. Lets fix the changelog in retrospect in that branch (and also in master and branch_8x), in case there's ever a 8.4.2 release. > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.5 > > Time Spent: 1h > Remaining Estimate: 0h > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020824#comment-17020824 ] Nick Vercammen commented on SOLR-14154: --- [~ichattopadhyaya] how did you validate it wasn't there in 8.4.1? When looking at the code I see it is being merged in branch_8_4 and when running my test-application with the 8.4.1 release it works as expected. > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.5 > > Time Spent: 1h > Remaining Estimate: 0h > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020800#comment-17020800 ] Ishan Chattopadhyaya commented on SOLR-14154: - This wasn't there in 8.4.1, so removing it from Fix Version. > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.5 > > Time Spent: 1h > Remaining Estimate: 0h > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007721#comment-17007721 ] Kevin Risden commented on SOLR-14154: - Well changes is correct. Commit message is incorrect. > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.5, 8.4.1 > > Time Spent: 1h > Remaining Estimate: 0h > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007720#comment-17007720 ] Kevin Risden commented on SOLR-14154: - Ugh typoed the jira. Will fix changes. Commit 1e0471a2476d66ff64e866b354253b8e76bcd7c7 in lucene-solr's branch refs/heads/master from Nick Vercammen [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1e0471a ] SOLR-14153: Return correct isolation level when retrieving it from the SQL Connection As transactions are not supported a request to getTransactionIsolation() should return TRANSACTION_NONE (https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#TRANSACTION_NONE) Signed-off-by: Kevin Risden Commit 1b40371d43fb82d03bff7ee3b14de26871a8637f in lucene-solr's branch refs/heads/branch_8x from Nick Vercammen [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1b40371 ] SOLR-14153: Return correct isolation level when retrieving it from the SQL Connection As transactions are not supported a request to getTransactionIsolation() should return TRANSACTION_NONE (https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#TRANSACTION_NONE) Signed-off-by: Kevin Risden Commit e2daabf2dc32c1062f8f9801c55dfb513b5e6ad0 in lucene-solr's branch refs/heads/branch_8_4 from Nick Vercammen [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e2daabf ] SOLR-14153: Return correct isolation level when retrieving it from the SQL Connection As transactions are not supported a request to getTransactionIsolation() should return TRANSACTION_NONE (https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#TRANSACTION_NONE) Signed-off-by: Kevin Risden > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.5, 8.4.1 > > Time Spent: 1h > Remaining Estimate: 0h > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[
https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007096#comment-17007096
]
Kevin Risden commented on SOLR-14154:
-
{quote}Do I make PR's for each version I want this to be backported to?{quote}
No don't worry about it. I'll backport the change to the applicable branches.
{code:java}
I'm trying to write a Solr driver for [Metabase|https://www.metabase.com/] and
the JDBC route seemed the way to go for me. Unfortunately metabase creates a
pooled connection wich uses the getTransactionIsolation() method and crashes
{code}
Ah neat. Looks like there isn't a check before getting the isolation level.
https://github.com/swaldman/c3p0/blob/master/src/java/com/mchange/v2/c3p0/impl/NewPooledConnection.java#L120
{quote}created the pull requests.{quote}
Thanks I'll try to get this in today or tomorrow.
> Return correct isolation level when retrieving it from the SQL Connection
> -
>
> Key: SOLR-14154
> URL: https://issues.apache.org/jira/browse/SOLR-14154
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Parallel SQL
>Affects Versions: 8.4
>Reporter: Nick Vercammen
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 8.5, 8.4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When calling the getTransactionIsolation() on the Sql.ConnectionImpl an
> UnsupportedException is thrown. It would be better to return TRANSACTION_NONE
> so clients can determine themselves it is not supported without receiving an
> exception
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007092#comment-17007092 ] Kevin Risden commented on SOLR-14154: - There probably won't be another 8.3.x release. Solr 8.4 was just released. There is an 8.4.1 release going out shortly. So this will target Solr 9.0, 8.5 and 8.4.1. > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Assignee: Kevin Risden >Priority: Minor > Fix For: 8.5, 8.4.1 > > Time Spent: 20m > Remaining Estimate: 0h > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006464#comment-17006464 ] Nick Vercammen commented on SOLR-14154: --- [~krisden] no problem created the pull requests. Could this also be included in the 8.3 version? > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006461#comment-17006461 ] Kevin Risden commented on SOLR-14154: - [~vercani] no worries if it's too much effort for a simple change. I can make the change too. Just wanted to give you a chance. Let me know if you want me to make it instead. > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Priority: Minor > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[
https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006330#comment-17006330
]
Nick Vercammen commented on SOLR-14154:
---
Sure ...setting up the development environment is more work than making the
change ;)
Do I make PR's for each version I want this to be backported to?
I'm trying to write a Solr driver for [Metabase|[https://www.metabase.com/]]
and the JDBC route seemed the way to go for me. Unfortunately metabase creates
a pooled connection wich uses the getTransactionIsolation() method and crashes:
{noformat}
01-01 08:09:56 WARN resourcepool.BasicResourcePool ::
com.mchange.v2.resourcepool.BasicResourcePool$ScatteredAcquireTask@188861ed --
Acquisition Attempt Failed!!! Clearing pending acquires. While trying to
acquire a needed new resource, we failed to succeed more than the maximum
number of allowed acquisition attempts (30). Last acquisition attempt exception:
java.lang.UnsupportedOperationException
at
org.apache.solr.client.solrj.io.sql.ConnectionImpl.getTransactionIsolation(ConnectionImpl.java:189)
at
com.mchange.v2.c3p0.impl.NewPooledConnection.(NewPooledConnection.java:120)
at
com.mchange.v2.c3p0.WrapperConnectionPoolDataSource.getPooledConnection(WrapperConnectionPoolDataSource.java:181)
at
com.mchange.v2.c3p0.WrapperConnectionPoolDataSource.getPooledConnection(WrapperConnectionPoolDataSource.java:147)
at
com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool$1PooledConnectionResourcePoolManager.acquireResource(C3P0PooledConnectionPool.java:202)
at
com.mchange.v2.resourcepool.BasicResourcePool.doAcquire(BasicResourcePool.java:1176)
at
com.mchange.v2.resourcepool.BasicResourcePool.doAcquireAndDecrementPendingAcquiresWithinLockOnSuccess(BasicResourcePool.java:1163)
at
com.mchange.v2.resourcepool.BasicResourcePool.access$700(BasicResourcePool.java:44)
at
com.mchange.v2.resourcepool.BasicResourcePool$ScatteredAcquireTask.run(BasicResourcePool.java:1908)
at
com.mchange.v2.async.ThreadPoolAsynchronousRunner$PoolThread.run(ThreadPoolAsynchronousRunner.java:696){noformat}
> Return correct isolation level when retrieving it from the SQL Connection
> -
>
> Key: SOLR-14154
> URL: https://issues.apache.org/jira/browse/SOLR-14154
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Parallel SQL
>Affects Versions: 8.4
>Reporter: Nick Vercammen
>Priority: Minor
>
> When calling the getTransactionIsolation() on the Sql.ConnectionImpl an
> UnsupportedException is thrown. It would be better to return TRANSACTION_NONE
> so clients can determine themselves it is not supported without receiving an
> exception
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14154) Return correct isolation level when retrieving it from the SQL Connection
[ https://issues.apache.org/jira/browse/SOLR-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006230#comment-17006230 ] Kevin Risden commented on SOLR-14154: - [~vercani] can you provide a PR for this? Should be a simple change. Mostly just should implement get/set here [1] at the same time following the Connection javadocs [2] I am curious about what SQL client is running into this. For reference, the database metadata itself shows no support for transactions [3] and [4]. [1] https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/io/sql/ConnectionImpl.java#L188 [2] https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#getTransactionIsolation-- [3] https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/io/sql/DatabaseMetaDataImpl.java#L672 [4] https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#supportsTransactionIsolationLevel-int- > Return correct isolation level when retrieving it from the SQL Connection > - > > Key: SOLR-14154 > URL: https://issues.apache.org/jira/browse/SOLR-14154 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Parallel SQL >Affects Versions: 8.4 >Reporter: Nick Vercammen >Priority: Minor > Fix For: master (9.0) > > > When calling the getTransactionIsolation() on the Sql.ConnectionImpl an > UnsupportedException is thrown. It would be better to return TRANSACTION_NONE > so clients can determine themselves it is not supported without receiving an > exception -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
