[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108493#comment-17108493
]
ASF subversion and git services commented on SOLR-14485:
Commit 34e5e6c1279a212b73219cc373b24c8b042bfea9 in lucene-solr's branch
refs/heads/master from erick
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=34e5e6c ]
SOLR-14485: Fix or suppress 11 resource leak warnings in apache/solr/cloud
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch, SOLR-14485-01.patch,
> SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 408)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 743)
> [ecj-lint] throw new IOException("currently only one listener can be set
> per trigger. Trigger name: " + trigger);
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'listener' is not closed at this location
> --
> [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 952)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 991)
> [ecj-lint] SimScenario scenario = new SimScenario();
> [ecj-lint]
> [ecj-lint] Resource leak: 'scenario' is never closed
> --
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
> (at line 264)
> [ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
> HttpShardHandlerFactory().getShardHandler(), updateShardHandler,
> "/admin/cores",
> [ecj-lint]
> ^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ZkNodePropsTest.java
[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108492#comment-17108492
]
ASF subversion and git services commented on SOLR-14485:
Commit 04deac1851cf929696c3d89e7bf11a14d8e2a1ae in lucene-solr's branch
refs/heads/branch_8x from erick
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=04deac1 ]
SOLR-14485: Fix or suppress 11 resource leak warnings in apache/solr/cloud
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch, SOLR-14485-01.patch,
> SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 408)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 743)
> [ecj-lint] throw new IOException("currently only one listener can be set
> per trigger. Trigger name: " + trigger);
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'listener' is not closed at this location
> --
> [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 952)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 991)
> [ecj-lint] SimScenario scenario = new SimScenario();
> [ecj-lint]
> [ecj-lint] Resource leak: 'scenario' is never closed
> --
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
> (at line 264)
> [ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
> HttpShardHandlerFactory().getShardHandler(), updateShardHandler,
> "/admin/cores",
> [ecj-lint]
> ^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 2. WARNING in
>
[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108488#comment-17108488
]
Erick Erickson commented on SOLR-14485:
---
Same patch with attribution in CHANGES.txt, will push shortly
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch, SOLR-14485-01.patch,
> SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 408)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 743)
> [ecj-lint] throw new IOException("currently only one listener can be set
> per trigger. Trigger name: " + trigger);
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'listener' is not closed at this location
> --
> [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 952)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 991)
> [ecj-lint] SimScenario scenario = new SimScenario();
> [ecj-lint]
> [ecj-lint] Resource leak: 'scenario' is never closed
> --
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
> (at line 264)
> [ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
> HttpShardHandlerFactory().getShardHandler(), updateShardHandler,
> "/admin/cores",
> [ecj-lint]
> ^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ZkNodePropsTest.java
> (at line 48)
> [ecj-lint] new JavaBinCodec().marshal(zkProps.getProperties(), baos);
> [ecj-lint] ^^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 3. WARNING in
>
[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107467#comment-17107467
]
Lucene/Solr QA commented on SOLR-14485:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 46m
35s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-14485 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13002958/SOLR-14485-01.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 08360a2997f |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/748/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/748/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch, SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this
[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107385#comment-17107385
]
Andras Salamon commented on SOLR-14485:
---
Uploaded a new patch (using the same filename)
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch, SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 408)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 743)
> [ecj-lint] throw new IOException("currently only one listener can be set
> per trigger. Trigger name: " + trigger);
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'listener' is not closed at this location
> --
> [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 952)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 991)
> [ecj-lint] SimScenario scenario = new SimScenario();
> [ecj-lint]
> [ecj-lint] Resource leak: 'scenario' is never closed
> --
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
> (at line 264)
> [ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
> HttpShardHandlerFactory().getShardHandler(), updateShardHandler,
> "/admin/cores",
> [ecj-lint]
> ^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ZkNodePropsTest.java
> (at line 48)
> [ecj-lint] new JavaBinCodec().marshal(zkProps.getProperties(), baos);
> [ecj-lint] ^^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 3. WARNING in
>
[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107369#comment-17107369
]
Andras Salamon commented on SOLR-14485:
---
I also prefer try-with-resources, on the other hand I don't like creating big
new try-with-resources blocks, when one single close() can solve the problem.
It's definitely a bit personal preference. In this jira, I'd say in
SimScenario it's easier to just add snapshotCloudManager.close, on the other
hand it would be better to use try-with-resource in RecoveryStrategy and
SyncStrategy.
I'll upload a new patch soon.
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 408)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 743)
> [ecj-lint] throw new IOException("currently only one listener can be set
> per trigger. Trigger name: " + trigger);
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'listener' is not closed at this location
> --
> [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 952)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 991)
> [ecj-lint] SimScenario scenario = new SimScenario();
> [ecj-lint]
> [ecj-lint] Resource leak: 'scenario' is never closed
> --
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
> (at line 264)
> [ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
> HttpShardHandlerFactory().getShardHandler(), updateShardHandler,
> "/admin/cores",
> [ecj-lint]
> ^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 2. WARNING in
>
[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107339#comment-17107339
]
Erick Erickson commented on SOLR-14485:
---
Actually, I had time today and did a quick review and I have a question:
Why are some of the changes calling close() and others use try-with-resources?
I think it's more robust to use try-with-resources and wondered what criteria
you use for one over the other. Take RecoveryStrategy. I see that it would take
a little bit of code re-arranging to use try-with-resources, but as long as the
changes are trivial I think it's worth it. It's a judgement call to be sure.
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 408)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 743)
> [ecj-lint] throw new IOException("currently only one listener can be set
> per trigger. Trigger name: " + trigger);
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'listener' is not closed at this location
> --
> [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 952)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 991)
> [ecj-lint] SimScenario scenario = new SimScenario();
> [ecj-lint]
> [ecj-lint] Resource leak: 'scenario' is never closed
> --
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
> (at line 264)
> [ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
> HttpShardHandlerFactory().getShardHandler(), updateShardHandler,
> "/admin/cores",
> [ecj-lint]
> ^
> [ecj-lint] Resource leak: '' is never
[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107297#comment-17107297
]
Andras Salamon commented on SOLR-14485:
---
Sure thing. I was following the Oozie naming convention, will change to the
Solr naming convention. :)
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 408)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 743)
> [ecj-lint] throw new IOException("currently only one listener can be set
> per trigger. Trigger name: " + trigger);
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'listener' is not closed at this location
> --
> [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 952)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 991)
> [ecj-lint] SimScenario scenario = new SimScenario();
> [ecj-lint]
> [ecj-lint] Resource leak: 'scenario' is never closed
> --
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
> (at line 264)
> [ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
> HttpShardHandlerFactory().getShardHandler(), updateShardHandler,
> "/admin/cores",
> [ecj-lint]
> ^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ZkNodePropsTest.java
> (at line 48)
> [ecj-lint] new JavaBinCodec().marshal(zkProps.getProperties(), baos);
> [ecj-lint] ^^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 3. WARNING in
>
[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud
[
https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107273#comment-17107273
]
Erick Erickson commented on SOLR-14485:
---
I'll take a look today/tomorrow.
A very minor nit: please just name the patches with the JIRA,
*SOLR-14485.patch* for instance. The Jira system will gracefully handle
multiple patches with the same name, graying out all the older copies but still
listing them. That just makes it easier to know which one's the most recent
without me having to think ;)
> Fix or suppress 11 resource leak warnings in apache/solr/cloud
> --
>
> Key: SOLR-14485
> URL: https://issues.apache.org/jira/browse/SOLR-14485
> Project: Solr
> Issue Type: Sub-task
>Reporter: Andras Salamon
>Assignee: Erick Erickson
>Priority: Minor
> Attachments: SOLR-14485-01.patch
>
>
> There are 11 warnings in apache/solr/cloud:
> {noformat}
> [ecj-lint] 2. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
> (at line 644)
> [ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
> PeerSyncWithLeader(core,
> [ecj-lint] ^^
> [ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
> --
> [ecj-lint] 3. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
> (at line 182)
> [ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
> core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
> peerSyncOnlyWithActive, false);
> [ecj-lint]
> [ecj-lint] Resource leak: 'peerSync' is never closed
> --
> [ecj-lint] 4. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 793)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 5. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
> (at line 799)
> [ecj-lint] throw new UnsupportedOperationException("must add at least 1
> node first");
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'queryRequest' is not closed at this location
> --
> [ecj-lint] 6. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 408)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 7. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 743)
> [ecj-lint] throw new IOException("currently only one listener can be set
> per trigger. Trigger name: " + trigger);
> [ecj-lint]
> ^^
> [ecj-lint] Resource leak: 'listener' is not closed at this location
> --
> [ecj-lint] 8. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 952)
> [ecj-lint] SnapshotCloudManager snapshotCloudManager = new
> SnapshotCloudManager(scenario.cluster, null);
> [ecj-lint]
> [ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
> --
> [ecj-lint] 9. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
> (at line 991)
> [ecj-lint] SimScenario scenario = new SimScenario();
> [ecj-lint]
> [ecj-lint] Resource leak: 'scenario' is never closed
> --
> [ecj-lint] 1. WARNING in
> /Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
> (at line 264)
> [ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
> HttpShardHandlerFactory().getShardHandler(), updateShardHandler,
> "/admin/cores",
> [ecj-lint]
> ^
> [ecj-lint] Resource leak: '' is never closed
> --
> [ecj-lint] 2. WARNING in
>
