[jira] [Updated] (SOLR-13870) eliminate getNextAvailablePort() dependency in SolrJmxReporterTest

[Chris M. Hostetter (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris M. Hostetter updated SOLR-13870:
--
Fix Version/s: 8.4
   master (9.0)
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> eliminate getNextAvailablePort() dependency in SolrJmxReporterTest
> --
>
> Key: SOLR-13870
> URL: https://issues.apache.org/jira/browse/SOLR-13870
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Chris M. Hostetter
>Assignee: Chris M. Hostetter
>Priority: Major
> Fix For: master (9.0), 8.4
>
> Attachments: SOLR-13870.patch
>
>
> {{SolrJmxReporterTest}} is currently the only solr test using (the 
> problematic) {{SolrTestCaseJ4.getNextAvailablePort}} helper method in order 
> to assign a RMI port for running a JMX server.
> This test doesn't actually care that it's using RMI for JMX, it only cares 
> that:
> # an MBeanServer is initialized that it can query
> # that MBeanServer can be specified in the plugin configuration for the 
> {{SolrJmxReporter}}
> We should cleanup the test initialization so that it no longer depends on RMI 
> via the {{serviceUrl}} plugin configuration option, and instead just use the 
> {{agentId}} to specify an MBeanServer bootstrapped by the test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-13870) eliminate getNextAvailablePort() dependency in SolrJmxReporterTest

[Chris M. Hostetter (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris M. Hostetter updated SOLR-13870:
--
Attachment: SOLR-13870.patch
Status: Open  (was: Open)

Attaching a patch to address this.

[~ab] - would appreciate a review.

> eliminate getNextAvailablePort() dependency in SolrJmxReporterTest
> --
>
> Key: SOLR-13870
> URL: https://issues.apache.org/jira/browse/SOLR-13870
> Project: Solr
>  Issue Type: Sub-task
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Chris M. Hostetter
>Assignee: Chris M. Hostetter
>Priority: Major
> Attachments: SOLR-13870.patch
>
>
> {{SolrJmxReporterTest}} is currently the only solr test using (the 
> problematic) {{SolrTestCaseJ4.getNextAvailablePort}} helper method in order 
> to assign a RMI port for running a JMX server.
> This test doesn't actually care that it's using RMI for JMX, it only cares 
> that:
> # an MBeanServer is initialized that it can query
> # that MBeanServer can be specified in the plugin configuration for the 
> {{SolrJmxReporter}}
> We should cleanup the test initialization so that it no longer depends on RMI 
> via the {{serviceUrl}} plugin configuration option, and instead just use the 
> {{agentId}} to specify an MBeanServer bootstrapped by the test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org