Re: [PR] Beef up `Terms#intersect` checks in `CheckIndex`. [lucene]

[via GitHub]

jpountz merged PR #12926:
URL: https://github.com/apache/lucene/pull/12926


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Re: [PR] Beef up `Terms#intersect` checks in `CheckIndex`. [lucene]

[via GitHub]

mikemccand commented on code in PR #12926:
URL: https://github.com/apache/lucene/pull/12926#discussion_r1424442691


##
lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectPostingsFormat.java:
##
@@ -1119,12 +1122,14 @@ public DirectIntersectTermsEnum(CompiledAutomaton 
compiled, BytesRef startTerm)
 }
   }
 
-  final int termOffset = termOffsets[termOrd];
-  final int termLen = termOffsets[1 + termOrd] - termOffset;
+  if (termOrd >= 0) {

Review Comment:
   Nice catch!!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Re: [PR] Beef up `Terms#intersect` checks in `CheckIndex`. [lucene]

[via GitHub]

mikemccand commented on PR #12926:
URL: https://github.com/apache/lucene/pull/12926#issuecomment-1852610006

   > This found bugs in `DirectPostingsFormat`
   
   Whoa, awesome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org