Re: [PR] Remove stale BWC tests [lucene]
s1monw merged PR #12874: URL: https://github.com/apache/lucene/pull/12874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove stale BWC tests [lucene]
github-actions[bot] commented on PR #12874: URL: https://github.com/apache/lucene/pull/12874#issuecomment-1880899116 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove stale BWC tests [lucene]
mikemccand commented on code in PR #12874:
URL: https://github.com/apache/lucene/pull/12874#discussion_r1418943291
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestIndexWriterOnOldIndex.java:
##
@@ -1,68 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.lucene.backward_index;
-
-import java.io.IOException;
-import java.io.InputStream;
-import java.nio.file.Path;
-import org.apache.lucene.index.IndexWriter;
-import org.apache.lucene.index.IndexWriterConfig.OpenMode;
-import org.apache.lucene.index.SegmentInfos;
-import org.apache.lucene.store.Directory;
-import org.apache.lucene.tests.util.LuceneTestCase;
-import org.apache.lucene.tests.util.TestUtil;
-import org.apache.lucene.util.Version;
-
-public class TestIndexWriterOnOldIndex extends LuceneTestCase {
-
- public void testOpenModeAndCreatedVersion() throws IOException {
-assumeTrue("Reenable when 8.0 is released", false);
Review Comment:
Sheesh ... this makes me wonder what other `assumeTrue` are lurking that we
failed to re-enable on XYZ release!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove stale BWC tests [lucene]
mikemccand commented on code in PR #12874:
URL: https://github.com/apache/lucene/pull/12874#discussion_r1418942637
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestManyPointsInOldIndex.java:
##
@@ -1,77 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.lucene.backward_index;
-
-import java.io.IOException;
-import java.io.InputStream;
-import java.nio.file.Path;
-import java.nio.file.Paths;
-import org.apache.lucene.document.Document;
-import org.apache.lucene.document.IntPoint;
-import org.apache.lucene.index.CheckIndex;
-import org.apache.lucene.index.IndexWriter;
-import org.apache.lucene.index.IndexWriterConfig;
-import org.apache.lucene.store.Directory;
-import org.apache.lucene.store.FSDirectory;
-import org.apache.lucene.tests.store.BaseDirectoryWrapper;
-import org.apache.lucene.tests.util.LuceneTestCase;
-import org.apache.lucene.tests.util.TestUtil;
-
-// LUCENE-7501
-public class TestManyPointsInOldIndex extends LuceneTestCase {
-
- // To regenerate the back index zip:
- //
- // Compile:
- // 1) temporarily remove 'extends LuceneTestCase' above (else java doesn't
see our static void
- // main)
- // 2) ant compile-test
- //
- // Run:
- // 1) java -cp
../build/backward-codecs/classes/test:../build/core/classes/java
- // org.apache.lucene.backward_index.TestManyPointsInOldIndex
- //
- // cd manypointsindex
- // zip manypointsindex.zip *
-
- public static void main(String[] args) throws IOException {
-Directory dir = FSDirectory.open(Paths.get("manypointsindex"));
-IndexWriter w = new IndexWriter(dir, new IndexWriterConfig());
-for (int i = 0; i < 1025; i++) {
- Document doc = new Document();
- doc.add(new IntPoint("intpoint", 1025 - i));
- w.addDocument(doc);
-}
-w.close();
-dir.close();
- }
-
- public void testCheckOldIndex() throws IOException {
-assumeTrue("Reenable when 7.0 is released", false);
Review Comment:
Doh! So I guess this test never got enabled, and now the index it is
testing (which is apparently nowhere to be found in our resources) is too
ancient for modern Lucene to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
