[jira] (MNG-5491) Resolve artifact failed because of using repo url instead of repo ID

2013-07-04 Thread David Fradin (JIRA)
David Fradin created MNG-5491:
-

 Summary: Resolve artifact failed because of using repo url instead 
of repo ID 
 Key: MNG-5491
 URL: https://jira.codehaus.org/browse/MNG-5491
 Project: Maven 2  3
  Issue Type: Bug
  Components: Artifacts and Repositories
Affects Versions: 3.0.5
 Environment: On several systems as Linux Redhat and Windows Vista
Reporter: David Fradin
 Attachments: settings.xml

We have develop a MOJO that downloads a list of artefacts and makes that 
operations on them. It works in Maven 3.0.3 but failed in Maven 3.0.5 on 
resolveArtifact method. It seems to be a regression on Maven 3.0.5 (we don't 
test on Maven 3.0.4).

In attached file, find our settings.xml (we have remove internal information).
You can see we have a plugin repository ID and a repository ID that use the 
same URL repository.

When we use our plugin, Maven downloads its dependencies and for example 
download javax.xml.stream:stax-api:jar:1.0-2 (it makes the same problem on all 
common artifacts).
On local repository, we can see in
cat repository/javax/xml/stream/stax-api/1.0-2/_maven.repositories :
#NOTE: This is an internal implementation file, its format can be changed 
without prior notice.
#Wed Jul 03 13:30:47 CEST 2013
stax-api-1.0-2.jarplugin-repository=
stax-api-1.0-2.pomplugin-repository=

Then Maven execute our plugin that has to download a list of artifacts.
But it failed to download javax.xml.stream:stax-api:jar:1.0-2 

Reason is that javax.xml.stream:stax-api:jar:1.0-2 is present on local 
repository, so it found by Maven but when it tests if it is up-to-date it 
failed because this file comes from another repository.

Explanation :
Class : DefaultArtifactResolver
Method : private ListArtifactResult resolve( RepositorySystemSession session,
  Collection? extends ArtifactRequest 
requests )
Call
Class : DefaultUpdateCheckManager
Method :public void checkArtifact( RepositorySystemSession session, 
UpdateCheckArtifact, ArtifactTransferException check )
{
[...]
if ( isAlreadyUpdated( session.getData(), updateKey ) )

updateKey contains repository.getUrl() and not repository.getID()
So isAlreadyUpdated answers yes because artefact as already been downloaded 
from this URL.

But when Maven reads _maven.repositories, it sees that repository ID 
public-repository is not here so the plugin is considered as unavailable.

So we have an artifact that is present in local repository but considered as 
unavailable by resolve and present by isAlreadyUpdated. 
So artifact is never updated so the repository ID is not added to 
_maven.repositories

Is it clear ?
I hope...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5491) Resolve artifact failed because of using repo url instead of repo ID

2013-07-04 Thread David Fradin (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=327950#comment-327950
 ] 

David Fradin commented on MNG-5491:
---

Current bypass : to avoid this problem, we have given the same repository ID 
for the two repositories that has the same URL.
But we always have to change plugin repository ID when we switch to another 
plugin repository.

 Resolve artifact failed because of using repo url instead of repo ID 
 -

 Key: MNG-5491
 URL: https://jira.codehaus.org/browse/MNG-5491
 Project: Maven 2  3
  Issue Type: Bug
  Components: Artifacts and Repositories
Affects Versions: 3.0.5
 Environment: On several systems as Linux Redhat and Windows Vista
Reporter: David Fradin
 Attachments: settings.xml


 We have develop a MOJO that downloads a list of artefacts and makes that 
 operations on them. It works in Maven 3.0.3 but failed in Maven 3.0.5 on 
 resolveArtifact method. It seems to be a regression on Maven 3.0.5 (we don't 
 test on Maven 3.0.4).
 In attached file, find our settings.xml (we have remove internal information).
 You can see we have a plugin repository ID and a repository ID that use the 
 same URL repository.
 When we use our plugin, Maven downloads its dependencies and for example 
 download javax.xml.stream:stax-api:jar:1.0-2 (it makes the same problem on 
 all common artifacts).
 On local repository, we can see in
 cat repository/javax/xml/stream/stax-api/1.0-2/_maven.repositories :
 #NOTE: This is an internal implementation file, its format can be changed 
 without prior notice.
 #Wed Jul 03 13:30:47 CEST 2013
 stax-api-1.0-2.jarplugin-repository=
 stax-api-1.0-2.pomplugin-repository=
 Then Maven execute our plugin that has to download a list of artifacts.
 But it failed to download javax.xml.stream:stax-api:jar:1.0-2 
 Reason is that javax.xml.stream:stax-api:jar:1.0-2 is present on local 
 repository, so it found by Maven but when it tests if it is up-to-date it 
 failed because this file comes from another repository.
 Explanation :
 Class : DefaultArtifactResolver
 Method : private ListArtifactResult resolve( RepositorySystemSession 
 session,
   Collection? extends 
 ArtifactRequest requests )
 Call
 Class : DefaultUpdateCheckManager
 Method :public void checkArtifact( RepositorySystemSession session, 
 UpdateCheckArtifact, ArtifactTransferException check )
 {
 [...]
   if ( isAlreadyUpdated( session.getData(), updateKey ) )
   
 updateKey contains repository.getUrl() and not repository.getID()
 So isAlreadyUpdated answers yes because artefact as already been downloaded 
 from this URL.
 But when Maven reads _maven.repositories, it sees that repository ID 
 public-repository is not here so the plugin is considered as unavailable.
 So we have an artifact that is present in local repository but considered as 
 unavailable by resolve and present by isAlreadyUpdated. 
 So artifact is never updated so the repository ID is not added to 
 _maven.repositories
 Is it clear ?
 I hope...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MSHADE-152) Shade plugin assumes all non-pom dependencies are .zip formatted files and should be on the classpath

2013-07-04 Thread Stephen Connolly (JIRA)
Stephen Connolly created MSHADE-152:
---

 Summary: Shade plugin assumes all non-pom dependencies are .zip 
formatted files and should be on the classpath
 Key: MSHADE-152
 URL: https://jira.codehaus.org/browse/MSHADE-152
 Project: Maven 2.x Shade Plugin
  Issue Type: Bug
Affects Versions: 2.0
Reporter: Stephen Connolly


http://maven.apache.org/plugins/maven-shade-plugin/xref/org/apache/maven/plugins/shade/mojo/ShadeMojo.html#455

This selects from *all* artifacts, even those which are not addedToClasspath, 
e.g. see 
https://github.com/torquebox/jruby-maven-plugins/blob/master/gem-maven-plugin/src/main/resources/META-INF/plexus/components.xml#L89

The net result is that, for example, if you have a dependency of type gem shade 
will barf with the ugly

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-shade-plugin:2.0:shade (default) on project 
shade-gems: Error creating shaded jar: error in opening zip file 
~/.m2/repository/rubygems/bundler/1.3.4/bundler-1.3.4.gem - [Help 1]

To my mind, the shade plugin should only shade artifacts that are added to the 
classpath and should ignore all non-classpath artifacts.

Fixing this may result in breaking backwards compatibility if anyone is relying 
on the side-effects of the current broken behaviour, so perhaps the solution is 
to either add a flag, defaulting to false, which would enable the broken 
behaviour or else allow the explicit includes to pull the files back in... in 
any case may require a bump to 3.0 when this issue is fixed

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MDEP-424) Maven Dependency Plugin homepage should link to dependency:list-repositories

2013-07-04 Thread Michael Vorburger (JIRA)
Michael Vorburger created MDEP-424:
--

 Summary: Maven Dependency Plugin homepage should link to 
dependency:list-repositories
 Key: MDEP-424
 URL: https://jira.codehaus.org/browse/MDEP-424
 Project: Maven 2.x Dependency Plugin
  Issue Type: Bug
Reporter: Michael Vorburger


http://maven.apache.org/plugins/maven-dependency-plugin/ should list and have a 
link to 
http://maven.apache.org/plugins/maven-dependency-plugin/list-repositories-mojo.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MDEP-425) dependency:list-repositories ignores pluginRepository (only lists repository)

2013-07-04 Thread Michael Vorburger (JIRA)
Michael Vorburger created MDEP-425:
--

 Summary: dependency:list-repositories ignores pluginRepository 
(only lists repository)
 Key: MDEP-425
 URL: https://jira.codehaus.org/browse/MDEP-425
 Project: Maven 2.x Dependency Plugin
  Issue Type: Bug
Reporter: Michael Vorburger


http://maven.apache.org/plugins/maven-dependency-plugin/list-repositories-mojo.html
 can be very useful! But unless we've missed something, it seems to only gather 
 list all repositoriesrepository but doesn't know about / ignores any 
pluginRepositoriespluginRepository ?

What I'm suggesting is more that something like 'mvn 
org.apache.maven.plugins:maven-dependency-plugin:2.8:list-repositories' also 
lists plugin repositories (with an indication of which is a plugin vs. a 
dependency plug-in?) than a new list-plugin-repositories goal (just because I 
think in practice one would typically want to see both).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MJAVADOC-372) Index page should refer to Apache Maven for at least the first mention

2013-07-04 Thread SebbASF (JIRA)
SebbASF created MJAVADOC-372:


 Summary: Index page should refer to Apache Maven for at least the 
first mention
 Key: MJAVADOC-372
 URL: https://jira.codehaus.org/browse/MJAVADOC-372
 Project: Maven 2.x Javadoc Plugin
  Issue Type: Bug
Affects Versions: 2.9.1
Reporter: SebbASF
Priority: Minor


Index page should refer to Apache Maven for at least the first mention, i.e. it 
should start:

Apache Maven Javadoc Plugin

The Apache Maven Javadoc Plugin uses the Javadoc ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MSITE-692) The maven-site-plugin v3.3 does not render snippets as in v3.2 (Syntax highlighting and line numbers)

2013-07-04 Thread Rautureau (JIRA)
Rautureau created MSITE-692:
---

 Summary: The maven-site-plugin v3.3 does not render snippets as in 
v3.2 (Syntax highlighting and line numbers)
 Key: MSITE-692
 URL: https://jira.codehaus.org/browse/MSITE-692
 Project: Maven 2.x and 3.x Site Plugin
  Issue Type: Bug
  Components: doxia integration
Affects Versions: 3.3
 Environment: Maven v3.0.5
Reporter: Rautureau
 Attachments: 3.2.png, 3.3.png, maven-site-example.zip

Hi,

you will find in attachment a maven project that shows the issue.
When you run the command {{mvn site}} you get:
!3.2.png

When you run the command {{mvn site -Dmaven.site.plugin.version=3.3}} you get 
!3.3.png!

By comparing html produce by maven-site-plugin:
* With 3.2, all snippets are in tag pre class=prettyprint linenumssome 
code/pre
* With 3.3, all snippets are in tag presome code/pre

This is why the fluido skin .js don't activate color syntax nor line numbering.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRESOURCES-175) Bad encoding in filtering

2013-07-04 Thread Emeric MARTINEAU (JIRA)

[ 
https://jira.codehaus.org/browse/MRESOURCES-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=328020#comment-328020
 ] 

Emeric MARTINEAU commented on MRESOURCES-175:
-

Hi,

after more search, it's not Maven issue.

If you look like java.util.Properties javadoc 
(http://docs.oracle.com/javase/6/docs/api/java/util/Properties.html) you can 
see :
except the input/output stream is encoded in ISO 8859-1 character encoding

and 

The native2ascii tool can be used to convert property files to and from other 
character encodings.

You can close this ticket.

No solution except rewrite Properties class.

 Bad encoding in filtering
 -

 Key: MRESOURCES-175
 URL: https://jira.codehaus.org/browse/MRESOURCES-175
 Project: Maven 2.x Resources Plugin
  Issue Type: Bug
  Components: filtering
Affects Versions: 2.6
 Environment: jdk1.6.0_43
Reporter: Pavel Zinoviev
Priority: Blocker

 I have a resources
 resources
  resource
   directorysrc/main/resources/directory
   filteringtrue/filtering 
   excludes
excludefilters/**.*/exclude
   /excludes
  /resource
 /resources
 and
 filters
  filtersrc/main/resources/filters/filter-ru.properties/filter 
 
 /filters
 in maven-resource-plugin defined UTF-8 encoding.
 but result of 'mvn resources:resources' is unreadable... It's not utf-8. May 
 be loading of filter file performed with some default encoding?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRESOURCES-175) Bad encoding in filtering

2013-07-04 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MRESOURCES-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MRESOURCES-175.
-

Resolution: Not A Bug
  Assignee: Robert Scholte

 Bad encoding in filtering
 -

 Key: MRESOURCES-175
 URL: https://jira.codehaus.org/browse/MRESOURCES-175
 Project: Maven 2.x Resources Plugin
  Issue Type: Bug
  Components: filtering
Affects Versions: 2.6
 Environment: jdk1.6.0_43
Reporter: Pavel Zinoviev
Assignee: Robert Scholte
Priority: Blocker

 I have a resources
 {code:xml}
 resources
  resource
   directorysrc/main/resources/directory
   filteringtrue/filtering 
   excludes
excludefilters/**.*/exclude
   /excludes
  /resource
 /resources
 {code}
 and
 {code:xml}
 filters
  filtersrc/main/resources/filters/filter-ru.properties/filter 
 
 /filters
 {code}
 in maven-resource-plugin defined UTF-8 encoding.
 but result of 'mvn resources:resources' is unreadable... It's not utf-8. May 
 be loading of filter file performed with some default encoding?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRESOURCES-175) Bad encoding in filtering

2013-07-04 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MRESOURCES-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MRESOURCES-175:
--

Description: 
I have a resources
{code:xml}
resources
 resource
  directorysrc/main/resources/directory
  filteringtrue/filtering   
  excludes
   excludefilters/**.*/exclude
  /excludes
 /resource
/resources
{code}
and
{code:xml}
filters
 filtersrc/main/resources/filters/filter-ru.properties/filter   

/filters
{code}
in maven-resource-plugin defined UTF-8 encoding.

but result of 'mvn resources:resources' is unreadable... It's not utf-8. May be 
loading of filter file performed with some default encoding?

  was:
I have a resources
resources
 resource
  directorysrc/main/resources/directory
  filteringtrue/filtering   
  excludes
   excludefilters/**.*/exclude
  /excludes
 /resource
/resources

and

filters
 filtersrc/main/resources/filters/filter-ru.properties/filter   

/filters

in maven-resource-plugin defined UTF-8 encoding.

but result of 'mvn resources:resources' is unreadable... It's not utf-8. May be 
loading of filter file performed with some default encoding?


 Bad encoding in filtering
 -

 Key: MRESOURCES-175
 URL: https://jira.codehaus.org/browse/MRESOURCES-175
 Project: Maven 2.x Resources Plugin
  Issue Type: Bug
  Components: filtering
Affects Versions: 2.6
 Environment: jdk1.6.0_43
Reporter: Pavel Zinoviev
Priority: Blocker

 I have a resources
 {code:xml}
 resources
  resource
   directorysrc/main/resources/directory
   filteringtrue/filtering 
   excludes
excludefilters/**.*/exclude
   /excludes
  /resource
 /resources
 {code}
 and
 {code:xml}
 filters
  filtersrc/main/resources/filters/filter-ru.properties/filter 
 
 /filters
 {code}
 in maven-resource-plugin defined UTF-8 encoding.
 but result of 'mvn resources:resources' is unreadable... It's not utf-8. May 
 be loading of filter file performed with some default encoding?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-156) Upgrading maven-enforcer-plugin from 1.2 to 1.3 breaks maven-assembly-plugin

2013-07-04 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MENFORCER-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MENFORCER-156.


   Resolution: Fixed
Fix Version/s: 1.3.1

Fixed in [r1499852|http://svn.apache.org/r1499852]

 Upgrading maven-enforcer-plugin from 1.2 to 1.3 breaks maven-assembly-plugin
 

 Key: MENFORCER-156
 URL: https://jira.codehaus.org/browse/MENFORCER-156
 Project: Maven 2.x Enforcer Plugin
  Issue Type: Bug
Affects Versions: 1.3
 Environment: Ubuntu 12.04 fully patched / Maven 3.0.5 / Oracle Java 
 1.7.0_25
Reporter: Wolf Geldmacher
Assignee: Robert Scholte
 Fix For: 1.3.1

 Attachments: extjars.xml, pom.xml


 After upgrading m-e-p from 1.2 to 1.3 the maven-assembly-plugin generates the 
 following error:
 [ERROR] Failed to execute goal 
 org.apache.maven.plugins:maven-assembly-plugin:2.4:single (assemble) on 
 project extjars: Execution assemble of goal 
 org.apache.maven.plugins:maven-assembly-plugin:2.4:single failed. 
 NullPointerException - [Help 1] 
 Downgrading to m-e-p 1.2 makes the assembly work again.
 Sample pom  assembly that expose the error attached.
 When called via:
 mvn -Dplugins.maven-enforcer-plugin.version=1.2
 a zip file is generated as expected, when called via
 mvn -Dplugins.maven-enforcer-plugin.version=1.3
 (or without argument) you will get the NPE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRESOURCES-175) Bad encoding in filtering

2013-07-04 Thread SebbASF (JIRA)

[ 
https://jira.codehaus.org/browse/MRESOURCES-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=328030#comment-328030
 ] 

SebbASF commented on MRESOURCES-175:


Using Properties#load(Reader) rather than Properties#load(InputStream) would 
solve the problem, unfortunately the method requires Java 1.6.

In the meantime it might perhaps be possible to use Commons IO:

http://commons.apache.org/proper/commons-io/javadocs/api-release/org/apache/commons/io/input/ReaderInputStream.html

I've not tried to see if this works.

 Bad encoding in filtering
 -

 Key: MRESOURCES-175
 URL: https://jira.codehaus.org/browse/MRESOURCES-175
 Project: Maven 2.x Resources Plugin
  Issue Type: Bug
  Components: filtering
Affects Versions: 2.6
 Environment: jdk1.6.0_43
Reporter: Pavel Zinoviev
Assignee: Robert Scholte
Priority: Blocker

 I have a resources
 {code:xml}
 resources
  resource
   directorysrc/main/resources/directory
   filteringtrue/filtering 
   excludes
excludefilters/**.*/exclude
   /excludes
  /resource
 /resources
 {code}
 and
 {code:xml}
 filters
  filtersrc/main/resources/filters/filter-ru.properties/filter 
 
 /filters
 {code}
 in maven-resource-plugin defined UTF-8 encoding.
 but result of 'mvn resources:resources' is unreadable... It's not utf-8. May 
 be loading of filter file performed with some default encoding?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-157) NOTICE file bad indentation references software which is not actually included

2013-07-04 Thread SebbASF (JIRA)
SebbASF created MENFORCER-157:
-

 Summary: NOTICE file bad indentation  references software which 
is not actually included
 Key: MENFORCER-157
 URL: https://jira.codehaus.org/browse/MENFORCER-157
 Project: Maven 2.x Enforcer Plugin
  Issue Type: Bug
Reporter: SebbASF


The NOTICE file says:

{noformat}
Apache Maven Enforcer Plugin
   Copyright 1999-2013 The Apache Software Foundation

   This product includes software developed at
   The Apache Software Foundation (http://www.apache.org/).
   
   Portions of this software utilize the Plexus Container, API, and
   Components.  Copyright the Codehaus. The original software is
   available from http://plexus.codehaus.org/
{noformat}

The lines should all start in column 1

The last paragraph refers to software that is not actually included in the 
source release (nor the binary release, AFAIK). The NOTICE file needs to relate 
to the actual contents of the release and must contain required notices only. I 
think it should be removed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-158) LICENSE file contains duplicated copy

2013-07-04 Thread SebbASF (JIRA)
SebbASF created MENFORCER-158:
-

 Summary: LICENSE file contains duplicated copy
 Key: MENFORCER-158
 URL: https://jira.codehaus.org/browse/MENFORCER-158
 Project: Maven 2.x Enforcer Plugin
  Issue Type: Bug
Reporter: SebbASF


The LICENSE file contains the text of the AL 2.0 twice.

This is unnecessary and confusing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira