[jira] [Commented] (MJAVADOC-483) Needs support for https.proxySet etc.

[Laird Nelson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011486#comment-16011486
 ] 

Laird Nelson commented on MJAVADOC-483:
---

Here are changes I made (I cannot get the plugin to compile; I figure something 
here is better than nothing).  This starts at line {{3536}} in 
{{AbstractJavadocMojo.java}}.  As mentioned, I cannot tell if this compiles but 
you should get the idea:
{code:title=AbstractJavadocMojo.java line 3536}
List proxies = settings.getProxies();
if ( proxies != null && !proxies.isEmpty() )
{
for ( Proxy activeProxy : proxies )
{
if (activeProxy != null && activeProxy.isActive())
{
String protocol = StringUtils.isNotEmpty( activeProxy.getProtocol() 
) ? activeProxy.getProtocol() + "." : "";
if ( StringUtils.isNotEmpty( activeProxy.getHost() ) )
{
cmd.createArg().setValue( "-J-D" + protocol + "proxySet=true" );
cmd.createArg().setValue( "-J-D" + protocol + "proxyHost=" + 
activeProxy.getHost() );

if ( activeProxy.getPort() > 0 )
{
cmd.createArg().setValue( "-J-D" + protocol + "proxyPort=" 
+ activeProxy.getPort() );
}

if ( StringUtils.isNotEmpty( activeProxy.getNonProxyHosts() ) )
{
cmd.createArg().setValue("-J-D" + protocol + 
"nonProxyHosts=\"" + activeProxy.getNonProxyHosts() + "\"" );
}

if ( StringUtils.isNotEmpty( activeProxy.getUsername() ) )
{
cmd.createArg().setValue( "-J-D" + protocol + 
"proxyUser=\"" + activeProxy.getUsername() + "\"" );

if ( StringUtils.isNotEmpty( activeProxy.getPassword() ) )
{
cmd.createArg().setValue( "-J-D" + protocol + 
"proxyPassword=\"" + activeProxy.getPassword() + "\"" );
}
}
}
}
}
}
{code}

> Needs support for https.proxySet etc.
> -
>
> Key: MJAVADOC-483
> URL: https://issues.apache.org/jira/browse/MJAVADOC-483
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
>Reporter: Laird Nelson
>
> I work at a ginormous company that has a proxy server.  I have an active 
> {{}} in my {{.m2/settings.xml}} for the {{http}} protocol.  The 
> {{maven-javadoc-plugin}} picks this up fine.
> Weirdly, the {{javadoc}} invocation _also_ requires the {{https}} proxy to be 
> set.  There is no way to accomplish this with the {{maven-javadoc-plugin}}.
> IMHO it should see if there is an active {{}} element whose protocol 
> is {{https}} as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MJAVADOC-483) Needs support for https.proxySet etc.

[Laird Nelson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011462#comment-16011462
 ] 

Laird Nelson commented on MJAVADOC-483:
---

Huh; I notice in {{Settings#getActiveProxy()}} that there is an assumption that 
there is [only one active 
proxy|http://maven.apache.org/ref/3.5.0/maven-settings/apidocs/org/apache/maven/settings/Settings.html#getActiveProxy()]
 with (presumably?) one protocol.  Probably the section in 
{{AbstractJavadocMojo}} that calls this method should be amended to get _all_ 
proxies and select active ones with the {{http}} or {{https}} protocols.  I'll 
see if I can put together a PR.

> Needs support for https.proxySet etc.
> -
>
> Key: MJAVADOC-483
> URL: https://issues.apache.org/jira/browse/MJAVADOC-483
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 2.10.4
>Reporter: Laird Nelson
>
> I work at a ginormous company that has a proxy server.  I have an active 
> {{}} in my {{.m2/settings.xml}} for the {{http}} protocol.  The 
> {{maven-javadoc-plugin}} picks this up fine.
> Weirdly, the {{javadoc}} invocation _also_ requires the {{https}} proxy to be 
> set.  There is no way to accomplish this with the {{maven-javadoc-plugin}}.
> IMHO it should see if there is an active {{}} element whose protocol 
> is {{https}} as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MJAVADOC-483) Needs support for https.proxySet etc.

[Laird Nelson (JIRA)]

Laird Nelson created MJAVADOC-483:
-

 Summary: Needs support for https.proxySet etc.
 Key: MJAVADOC-483
 URL: https://issues.apache.org/jira/browse/MJAVADOC-483
 Project: Maven Javadoc Plugin
  Issue Type: Bug
  Components: javadoc
Affects Versions: 2.10.4
Reporter: Laird Nelson


I work at a ginormous company that has a proxy server.  I have an active 
{{}} in my {{.m2/settings.xml}} for the {{http}} protocol.  The 
{{maven-javadoc-plugin}} picks this up fine.

Weirdly, the {{javadoc}} invocation _also_ requires the {{https}} proxy to be 
set.  There is no way to accomplish this with the {{maven-javadoc-plugin}}.

IMHO it should see if there is an active {{}} element whose protocol is 
{{https}} as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MINVOKER-219) Change default value for cloneProjectsTo

[Robert Scholte (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MINVOKER-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MINVOKER-219:

Description: 
Up until now {{cloneProjectsTo}} is never set, which means that by default the 
source-directory gets polluted with the IT test execution.
You often see this parameter is set to {{target/its}}, so let's use that as the 
new default.
To ensure the IT output-folder is in the correct state, it is also better the 
set {{cloneClean}} to {{true}} by default. This is more efficient compared to 
{{mvn clean}} because only a subset of the folders are cleaned.


  was:
Up until now {{cloneProjectsTo}} is never set, which means that by default the 
source-directory gets polluted with the IT test execution.
You often see this parameter is ste to {{target/its}}, so let's use that as the 
new default.


> Change default value for cloneProjectsTo
> 
>
> Key: MINVOKER-219
> URL: https://issues.apache.org/jira/browse/MINVOKER-219
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.0.0
>
>
> Up until now {{cloneProjectsTo}} is never set, which means that by default 
> the source-directory gets polluted with the IT test execution.
> You often see this parameter is set to {{target/its}}, so let's use that as 
> the new default.
> To ensure the IT output-folder is in the correct state, it is also better the 
> set {{cloneClean}} to {{true}} by default. This is more efficient compared to 
> {{mvn clean}} because only a subset of the folders are cleaned.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MINVOKER-219) Change default value for cloneProjectsTo

[Robert Scholte (JIRA)]

Robert Scholte created MINVOKER-219:
---

 Summary: Change default value for cloneProjectsTo
 Key: MINVOKER-219
 URL: https://issues.apache.org/jira/browse/MINVOKER-219
 Project: Maven Invoker Plugin
  Issue Type: Improvement
Reporter: Robert Scholte
Assignee: Robert Scholte
Priority: Minor
 Fix For: 3.0.0


Up until now {{cloneProjectsTo}} is never set, which means that by default the 
source-directory gets polluted with the IT test execution.
You often see this parameter is ste to {{target/its}}, so let's use that as the 
new default.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINVOKER-218) Change package to o.a.m.plugins

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINVOKER-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011356#comment-16011356
 ] 

Hudson commented on MINVOKER-218:
-

SUCCESS: Integrated in Jenkins build maven-plugins #8963 (See 
[https://builds.apache.org/job/maven-plugins/8963/])
[MINVOKER-218] Change package to o.a.m.plugins (rfscholte: 
[http://svn.apache.org/viewvc/?view=rev=1795243])
* (edit) 
maven-invoker-plugin/src/it/local-repo-url/src/it/project/postbuild.groovy
* (delete) maven-invoker-plugin/src/main/java/org/apache/maven/plugin
* (add) maven-invoker-plugin/src/main/java/org/apache/maven/plugins
* (add) maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/CompositeMap.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/FileLogger.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/InstallMojo.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/IntegrationTestMojo.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/InvokerMojo.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/InvokerProperties.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/InvokerReport.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/InvokerSession.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/MetadataUtils.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/PomUtils.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/ReportUtils.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/Selector.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/SelectorUtils.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/SystemPropertyPrinter.java
* (add) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/VerifyMojo.java
* (edit) maven-invoker-plugin/src/main/mdo/invocation.mdo
* (delete) maven-invoker-plugin/src/test/java/org/apache/maven/plugin
* (add) maven-invoker-plugin/src/test/java/org/apache/maven/plugins
* (add) maven-invoker-plugin/src/test/java/org/apache/maven/plugins/invoker
* (add) 
maven-invoker-plugin/src/test/java/org/apache/maven/plugins/invoker/ExtendedMavenProjectStub.java
* (add) 
maven-invoker-plugin/src/test/java/org/apache/maven/plugins/invoker/InterpolationTest.java
* (add) 
maven-invoker-plugin/src/test/java/org/apache/maven/plugins/invoker/InvokerMojoTest.java
* (add) 
maven-invoker-plugin/src/test/java/org/apache/maven/plugins/invoker/InvokerPropertiesTest.java
* (add) 
maven-invoker-plugin/src/test/java/org/apache/maven/plugins/invoker/SelectorTest.java
* (add) 
maven-invoker-plugin/src/test/java/org/apache/maven/plugins/invoker/SelectorUtilsTest.java


> Change package to o.a.m.plugins
> ---
>
> Key: MINVOKER-218
> URL: https://issues.apache.org/jira/browse/MINVOKER-218
> Project: Maven Invoker Plugin
>  Issue Type: Task
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MINVOKER-188) IT - staging-dependencies fails when using with maven mirror

[Robert Scholte (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MINVOKER-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MINVOKER-188.
---
Resolution: Cannot Reproduce
  Assignee: Robert Scholte  (was: Karl Heinz Marbaise)

Cannot reproduce it anymore, with 3.0.0-SNAPSHOT the test succeeds.
That's good enough for me to confirm it is fixed.

> IT - staging-dependencies fails when using with maven mirror
> 
>
> Key: MINVOKER-188
> URL: https://issues.apache.org/jira/browse/MINVOKER-188
> Project: Maven Invoker Plugin
>  Issue Type: Task
>Affects Versions: 1.10
>Reporter: Dan Tran
>Assignee: Robert Scholte
>
> When running mirror settings under ~/.m2/setttings.xml, this test always fail
> [INFO] Building: staging-dependencies/pom.xml
> [INFO] ..FAILED (2.9 s)
> [INFO]   The build exited with code 1. See 
> /data/jenkins-work/jobs/maven-invoker-plugin/workspace/target/it/staging-dependencies/build.log
>  for details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MINVOKER-204) Upgrade to Maven3 plugin

[Robert Scholte (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MINVOKER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MINVOKER-204.
---
Resolution: Fixed

Fixed in [r1795239|http://svn.apache.org/viewvc?rev=1795239=rev]

> Upgrade to Maven3 plugin
> 
>
> Key: MINVOKER-204
> URL: https://issues.apache.org/jira/browse/MINVOKER-204
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> All Maven2 dependencies will be upgraded to Maven3. We remove Maven2 code 
> when there's a better solution with Maven3.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MINVOKER-218) Change package to o.a.m.plugins

[Robert Scholte (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MINVOKER-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MINVOKER-218.
---
Resolution: Fixed

Fixed in [r1795243|http://svn.apache.org/viewvc?rev=1795243=rev]

> Change package to o.a.m.plugins
> ---
>
> Key: MINVOKER-218
> URL: https://issues.apache.org/jira/browse/MINVOKER-218
> Project: Maven Invoker Plugin
>  Issue Type: Task
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Minor
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MINVOKER-204) Upgrade to Maven3 plugin

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINVOKER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011329#comment-16011329
 ] 

Hudson commented on MINVOKER-204:
-

FAILURE: Integrated in Jenkins build maven-plugins #8962 (See 
[https://builds.apache.org/job/maven-plugins/8962/])
[MINVOKER-204] Upgrade to Maven3 plugin (rfscholte: 
[http://svn.apache.org/viewvc/?view=rev=1795239])
* (edit) maven-invoker-plugin/pom.xml
* (edit) 
maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java


> Upgrade to Maven3 plugin
> 
>
> Key: MINVOKER-204
> URL: https://issues.apache.org/jira/browse/MINVOKER-204
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> All Maven2 dependencies will be upgraded to Maven3. We remove Maven2 code 
> when there's a better solution with Maven3.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MINVOKER-218) Change package to o.a.m.plugins

[Robert Scholte (JIRA)]

Robert Scholte created MINVOKER-218:
---

 Summary: Change package to o.a.m.plugins
 Key: MINVOKER-218
 URL: https://issues.apache.org/jira/browse/MINVOKER-218
 Project: Maven Invoker Plugin
  Issue Type: Task
Reporter: Robert Scholte
Assignee: Robert Scholte
Priority: Minor
 Fix For: 3.0.0






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation

[Sebastian Kirsch (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011317#comment-16011317
 ] 

Sebastian Kirsch commented on SUREFIRE-1373:


I merely mentioned the {{threadCount}} to illustrate the given example.

The thread is running in parallel to the others; that's what my test code is 
demonstrating.

> Tests annotated with @NotThreadSafe are not executed in isolation
> -
>
> Key: SUREFIRE-1373
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1373
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Sebastian Kirsch
>Assignee: Tibor Digana
>
> The [surefire 
> documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html]
>  states that 
> bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on 
> the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in 
> order to execute it in single Thread instance. The Thread has name 
> maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test 
> run.
> However, the thread is run in parallel to the other tests being executed, 
> which contradicts the documentation and defeats the purpose of running tests 
> sequentially in a single thread.
> See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6130) Loss of profile information in workaround for MNG-4900

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011274#comment-16011274
 ] 

Michael Osipov commented on MNG-6130:
-

[~boris_brodski], are you able to create a sample project? I'd like to turn 
that into an IT. At best, you provide the IT.

> Loss of profile information in workaround for MNG-4900
> --
>
> Key: MNG-6130
> URL: https://issues.apache.org/jira/browse/MNG-6130
> Project: Maven
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.9, 3.5.0
> Environment: Windows
>Reporter: Boris Brodski
>Assignee: Michael Osipov
>  Labels: easyfix, patch
> Fix For: 3.5.1-candidate
>
> Attachments: MNG-6130.patch
>
>
> Please, forgive me not providing example project reproducing the bug.
> It's very tricky and hopefully not necessary, since the 1-line fix is 
> provided.
> Using profiles together with maven-javadoc-plugin results in the following 
> problem:
> - Configuration from active profiles is not considered during dependency 
> resolution started problematically from the maven-javadoc-plugin.
> This leads to unpredictable behavior, that is somewhat hard to reproduce.
> Here is the technical inside and the 1-line fix:
> In the DefaultMavenProjectBuilder.toRequest():
> {noformat}
> if ( profileManager != null ) {
>...
> } else {
>   ...
>   /*
>* MNG-4900: Hack to workaround deficiency of legacy API which makes it 
> impossible for plugins to access the
>* global profile manager which is required to build a POM like a CLI 
> invocation does. Failure to consider
>* the activated profiles can cause repo declarations to be lost which in 
> turn will result in artifact
>* resolution failures, in particular when using the enhanced local repo 
> which guards access to local files
>* based on the configured remote repos.
>*/
> request.setActiveProfileIds( req.getActiveProfiles() );
> request.setInactiveProfileIds( req.getInactiveProfiles() );
> }
> {noformat}
> Here we copy active and inactive profile ids, but we don't copy the list of 
> all profile ids. Missing line:
> {noformat}
> request.setProfiles( req.getProfiles() );
> {noformat}
> As the result the method DefaultProfileManager.getActiveProfiles() always 
> returns an empty list:
> {noformat}
>   List activeProfiles = new ArrayList<>( profiles.size() );
>   for ( Profile profile : profiles ) {
>  ...
>   }
>   return activeProfiles;
> {noformat}
> "profiles" here is empty, since it wasn't copied together with 
> "getActiveProfiles()" and "getInactiveProfiles()"
> Adding the missing line fixes the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MCOMPILER-295) Upgrade ASM to 6.0_ALPHA2

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MCOMPILER-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011242#comment-16011242
 ] 

Hudson commented on MCOMPILER-295:
--

SUCCESS: Integrated in Jenkins build maven-plugins #8961 (See 
[https://builds.apache.org/job/maven-plugins/8961/])
[MCOMPILER-295] remove unused import (rfscholte: 
[http://svn.apache.org/viewvc/?view=rev=1795234])
* (edit) 
maven-compiler-plugin/src/main/java/org/apache/maven/plugin/compiler/module/AsmModuleInfoParser.java


> Upgrade ASM to 6.0_ALPHA2
> -
>
> Key: MCOMPILER-295
> URL: https://issues.apache.org/jira/browse/MCOMPILER-295
> Project: Maven Compiler Plugin
>  Issue Type: New Feature
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>
> 6.0_ALPHA uses an old format of the module-info.class



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011237#comment-16011237
 ] 

Tibor Digana commented on SUREFIRE-1373:


[~apache-bugzi...@sebastian-kirsch.org]
[~sebastiankirsch]
The Thread {{maven-surefire-plugin@NotThreadSafe}} has nothing to do with any 
{{threadCount}}.
It is extra Thread. I will check the code if it is really running in parallel 
with parallel tests..

> Tests annotated with @NotThreadSafe are not executed in isolation
> -
>
> Key: SUREFIRE-1373
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1373
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Sebastian Kirsch
>Assignee: Tibor Digana
>
> The [surefire 
> documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html]
>  states that 
> bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on 
> the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in 
> order to execute it in single Thread instance. The Thread has name 
> maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test 
> run.
> However, the thread is run in parallel to the other tests being executed, 
> which contradicts the documentation and defeats the purpose of running tests 
> sequentially in a single thread.
> See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MNG-6130) Loss of profile information in workaround for MNG-4900

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6130:

Summary: Loss of profile information in workaround for MNG-4900  (was: Lost 
of profile information in workaround for MNG-4900)

> Loss of profile information in workaround for MNG-4900
> --
>
> Key: MNG-6130
> URL: https://issues.apache.org/jira/browse/MNG-6130
> Project: Maven
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.9, 3.5.0
> Environment: Windows
>Reporter: Boris Brodski
>Assignee: Michael Osipov
>  Labels: easyfix, patch
> Fix For: 3.5.1-candidate
>
> Attachments: MNG-6130.patch
>
>
> Please, forgive me not providing example project reproducing the bug.
> It's very tricky and hopefully not necessary, since the 1-line fix is 
> provided.
> Using profiles together with maven-javadoc-plugin results in the following 
> problem:
> - Configuration from active profiles is not considered during dependency 
> resolution started problematically from the maven-javadoc-plugin.
> This leads to unpredictable behavior, that is somewhat hard to reproduce.
> Here is the technical inside and the 1-line fix:
> In the DefaultMavenProjectBuilder.toRequest():
> {noformat}
> if ( profileManager != null ) {
>...
> } else {
>   ...
>   /*
>* MNG-4900: Hack to workaround deficiency of legacy API which makes it 
> impossible for plugins to access the
>* global profile manager which is required to build a POM like a CLI 
> invocation does. Failure to consider
>* the activated profiles can cause repo declarations to be lost which in 
> turn will result in artifact
>* resolution failures, in particular when using the enhanced local repo 
> which guards access to local files
>* based on the configured remote repos.
>*/
> request.setActiveProfileIds( req.getActiveProfiles() );
> request.setInactiveProfileIds( req.getInactiveProfiles() );
> }
> {noformat}
> Here we copy active and inactive profile ids, but we don't copy the list of 
> all profile ids. Missing line:
> {noformat}
> request.setProfiles( req.getProfiles() );
> {noformat}
> As the result the method DefaultProfileManager.getActiveProfiles() always 
> returns an empty list:
> {noformat}
>   List activeProfiles = new ArrayList<>( profiles.size() );
>   for ( Profile profile : profiles ) {
>  ...
>   }
>   return activeProfiles;
> {noformat}
> "profiles" here is empty, since it wasn't copied together with 
> "getActiveProfiles()" and "getInactiveProfiles()"
> Adding the missing line fixes the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MCOMPILER-295) Upgrade ASM to 6.0_ALPHA2

[Robert Scholte (JIRA)]

Robert Scholte created MCOMPILER-295:


 Summary: Upgrade ASM to 6.0_ALPHA2
 Key: MCOMPILER-295
 URL: https://issues.apache.org/jira/browse/MCOMPILER-295
 Project: Maven Compiler Plugin
  Issue Type: New Feature
Reporter: Robert Scholte
Assignee: Robert Scholte


6.0_ALPHA uses an old format of the module-info.class



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6233) maven-resolver-provider mixes jsr330 and plexus annotations

[Igor Fedorenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011187#comment-16011187
 ] 

Igor Fedorenko commented on MNG-6233:
-

We already have plenty of jsr330 components in maven, so this is my no means 
new in Maven. I was slowly replacing plexus annotations with jsr330 over last 
few years, but if anyone feels like doing bulk conversion I won't object ;-)

[~rfscholte] maven does not do classpath scanning for jsr330 components, check 
how plexus container is created in MavenCli.

> maven-resolver-provider mixes jsr330 and plexus annotations
> ---
>
> Key: MNG-6233
> URL: https://issues.apache.org/jira/browse/MNG-6233
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.9, 3.5.0
>Reporter: Igor Fedorenko
> Fix For: 3.5.1-candidate
>
>
> Mixed annotations confuse guice/sisu and result in hard to troubleshoot and 
> impossible to workaround problems in applications that embed Maven core 
> runtime, like m2e and gshell. 
> I believe plugins annotations where left in the code by mistake so the plan 
> is to update the code to use jsr330 exclusively and completely remove plexus 
> annotations. This change is fully transparent to the users (and we've been 
> using it internally for couple of months now).
> See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MCOMPILER-294) test-compile broken due to -Xmodule removal in jdk-ea167

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MCOMPILER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011176#comment-16011176
 ] 

Hudson commented on MCOMPILER-294:
--

FAILURE: Integrated in Jenkins build maven-plugins #8959 (See 
[https://builds.apache.org/job/maven-plugins/8959/])
[MCOMPILER-294] replace -Xmodule with --patch-module
[MCOMPILER-293] Add advice message in case automodules are used
[MCOMPILER-286] Detect if dependencies should be added to classpath or 
modulepath (rfscholte: [http://svn.apache.org/viewvc/?view=rev=1795232])
* (edit) maven-compiler-plugin/pom.xml
* (edit) maven-compiler-plugin/src/it/automodules-application/invoker.properties
* (edit) 
maven-compiler-plugin/src/it/automodules-application/src/main/java/org/maven/test/Main.java
* (edit) maven-compiler-plugin/src/it/automodules-library/invoker.properties
* (edit) 
maven-compiler-plugin/src/it/automodules-library/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-manifest
* (add) maven-compiler-plugin/src/it/automodules-manifest/invoker.properties
* (add) maven-compiler-plugin/src/it/automodules-manifest/pom.xml
* (add) maven-compiler-plugin/src/it/automodules-manifest/src
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven/test
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-manifest/verify.groovy
* (add) maven-compiler-plugin/src/it/automodules-transitive-module
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/invoker.properties
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/pom.xml
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/module-info.java
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven/test
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/verify.groovy
* (add) maven-compiler-plugin/src/it/setup_jar_automodule
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com/ta3
* (add) 
maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com/ta3/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_classic
* (add) maven-compiler-plugin/src/it/setup_jar_classic/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_classic/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com/ta2
* (add) 
maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com/ta2/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_module
* (add) maven-compiler-plugin/src/it/setup_jar_module/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_module/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_module/src
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com/ta2
* (add) 
maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com/ta2/MyClass.java
* (add) 
maven-compiler-plugin/src/it/setup_jar_module/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/setup_module-transitive
* (add) 

[jira] [Commented] (MCOMPILER-293) Add advice message in case automodules are used

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MCOMPILER-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011177#comment-16011177
 ] 

Hudson commented on MCOMPILER-293:
--

FAILURE: Integrated in Jenkins build maven-plugins #8959 (See 
[https://builds.apache.org/job/maven-plugins/8959/])
[MCOMPILER-294] replace -Xmodule with --patch-module
[MCOMPILER-293] Add advice message in case automodules are used
[MCOMPILER-286] Detect if dependencies should be added to classpath or 
modulepath (rfscholte: [http://svn.apache.org/viewvc/?view=rev=1795232])
* (edit) maven-compiler-plugin/pom.xml
* (edit) maven-compiler-plugin/src/it/automodules-application/invoker.properties
* (edit) 
maven-compiler-plugin/src/it/automodules-application/src/main/java/org/maven/test/Main.java
* (edit) maven-compiler-plugin/src/it/automodules-library/invoker.properties
* (edit) 
maven-compiler-plugin/src/it/automodules-library/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-manifest
* (add) maven-compiler-plugin/src/it/automodules-manifest/invoker.properties
* (add) maven-compiler-plugin/src/it/automodules-manifest/pom.xml
* (add) maven-compiler-plugin/src/it/automodules-manifest/src
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven/test
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-manifest/verify.groovy
* (add) maven-compiler-plugin/src/it/automodules-transitive-module
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/invoker.properties
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/pom.xml
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/module-info.java
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven/test
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/verify.groovy
* (add) maven-compiler-plugin/src/it/setup_jar_automodule
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com/ta3
* (add) 
maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com/ta3/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_classic
* (add) maven-compiler-plugin/src/it/setup_jar_classic/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_classic/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com/ta2
* (add) 
maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com/ta2/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_module
* (add) maven-compiler-plugin/src/it/setup_jar_module/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_module/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_module/src
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com/ta2
* (add) 
maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com/ta2/MyClass.java
* (add) 
maven-compiler-plugin/src/it/setup_jar_module/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/setup_module-transitive
* (add) 

[jira] [Commented] (MCOMPILER-286) Detect if dependencies should be added to classpath or modulpath

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MCOMPILER-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011178#comment-16011178
 ] 

Hudson commented on MCOMPILER-286:
--

FAILURE: Integrated in Jenkins build maven-plugins #8959 (See 
[https://builds.apache.org/job/maven-plugins/8959/])
[MCOMPILER-294] replace -Xmodule with --patch-module
[MCOMPILER-293] Add advice message in case automodules are used
[MCOMPILER-286] Detect if dependencies should be added to classpath or 
modulepath (rfscholte: [http://svn.apache.org/viewvc/?view=rev=1795232])
* (edit) maven-compiler-plugin/pom.xml
* (edit) maven-compiler-plugin/src/it/automodules-application/invoker.properties
* (edit) 
maven-compiler-plugin/src/it/automodules-application/src/main/java/org/maven/test/Main.java
* (edit) maven-compiler-plugin/src/it/automodules-library/invoker.properties
* (edit) 
maven-compiler-plugin/src/it/automodules-library/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-manifest
* (add) maven-compiler-plugin/src/it/automodules-manifest/invoker.properties
* (add) maven-compiler-plugin/src/it/automodules-manifest/pom.xml
* (add) maven-compiler-plugin/src/it/automodules-manifest/src
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven/test
* (add) 
maven-compiler-plugin/src/it/automodules-manifest/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-manifest/verify.groovy
* (add) maven-compiler-plugin/src/it/automodules-transitive-module
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/invoker.properties
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/pom.xml
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/module-info.java
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven/test
* (add) 
maven-compiler-plugin/src/it/automodules-transitive-module/src/main/java/org/maven/test/Main.java
* (add) maven-compiler-plugin/src/it/automodules-transitive-module/verify.groovy
* (add) maven-compiler-plugin/src/it/setup_jar_automodule
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com/ta3
* (add) 
maven-compiler-plugin/src/it/setup_jar_automodule/src/main/java/com/ta3/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_classic
* (add) maven-compiler-plugin/src/it/setup_jar_classic/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_classic/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com/ta2
* (add) 
maven-compiler-plugin/src/it/setup_jar_classic/src/main/java/com/ta2/MyClass.java
* (add) maven-compiler-plugin/src/it/setup_jar_module
* (add) maven-compiler-plugin/src/it/setup_jar_module/invoker.properties
* (add) maven-compiler-plugin/src/it/setup_jar_module/pom.xml
* (add) maven-compiler-plugin/src/it/setup_jar_module/src
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com
* (add) maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com/ta2
* (add) 
maven-compiler-plugin/src/it/setup_jar_module/src/main/java/com/ta2/MyClass.java
* (add) 
maven-compiler-plugin/src/it/setup_jar_module/src/main/java/module-info.java
* (add) maven-compiler-plugin/src/it/setup_module-transitive
* (add) 

[jira] [Commented] (MNG-6233) maven-resolver-provider mixes jsr330 and plexus annotations

[Robert Scholte (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011158#comment-16011158
 ] 

Robert Scholte commented on MNG-6233:
-

IIRC [~jvanzyl] prepared this on his system. However, JSR330 doesn't support 
different configurations with the same implementation, like we do for 
lifecycles. Not sure what happened to that part.
If Jason can apply it on the current sourcetree without issues, we could do 
that. Otherwise let's go for a per-module upgrade, although I think it should 
all fit within one release. That said, having 1 issue with a checklist for all 
modules is good enough for me.

> maven-resolver-provider mixes jsr330 and plexus annotations
> ---
>
> Key: MNG-6233
> URL: https://issues.apache.org/jira/browse/MNG-6233
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.9, 3.5.0
>Reporter: Igor Fedorenko
> Fix For: 3.5.1-candidate
>
>
> Mixed annotations confuse guice/sisu and result in hard to troubleshoot and 
> impossible to workaround problems in applications that embed Maven core 
> runtime, like m2e and gshell. 
> I believe plugins annotations where left in the code by mistake so the plan 
> is to update the code to use jsr330 exclusively and completely remove plexus 
> annotations. This change is fully transparent to the users (and we've been 
> using it internally for couple of months now).
> See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6233) maven-resolver-provider mixes jsr330 and plexus annotations

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011145#comment-16011145
 ] 

Michael Osipov commented on MNG-6233:
-

Sounds reasonable. Though, I cannot even find an issue for the JSR330 move. 
Maybe we need an umbrella ticket and change module by module?

> maven-resolver-provider mixes jsr330 and plexus annotations
> ---
>
> Key: MNG-6233
> URL: https://issues.apache.org/jira/browse/MNG-6233
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.9, 3.5.0
>Reporter: Igor Fedorenko
> Fix For: 3.5.1-candidate
>
>
> Mixed annotations confuse guice/sisu and result in hard to troubleshoot and 
> impossible to workaround problems in applications that embed Maven core 
> runtime, like m2e and gshell. 
> I believe plugins annotations where left in the code by mistake so the plan 
> is to update the code to use jsr330 exclusively and completely remove plexus 
> annotations. This change is fully transparent to the users (and we've been 
> using it internally for couple of months now).
> See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6233) maven-resolver-provider mixes jsr330 and plexus annotations

[Robert Scholte (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011143#comment-16011143
 ] 

Robert Scholte commented on MNG-6233:
-

I assume we still generate the metadata-descriptor to have faster access 
compared to class scanning.

> maven-resolver-provider mixes jsr330 and plexus annotations
> ---
>
> Key: MNG-6233
> URL: https://issues.apache.org/jira/browse/MNG-6233
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.9, 3.5.0
>Reporter: Igor Fedorenko
> Fix For: 3.5.1-candidate
>
>
> Mixed annotations confuse guice/sisu and result in hard to troubleshoot and 
> impossible to workaround problems in applications that embed Maven core 
> runtime, like m2e and gshell. 
> I believe plugins annotations where left in the code by mistake so the plan 
> is to update the code to use jsr330 exclusively and completely remove plexus 
> annotations. This change is fully transparent to the users (and we've been 
> using it internally for couple of months now).
> See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6233) maven-resolver-provider mixes jsr330 and plexus annotations

[Igor Fedorenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011125#comment-16011125
 ] 

Igor Fedorenko commented on MNG-6233:
-

I don't believe IT is justified here. The change completely removes 
plexus-annotations support from the project and I think it is proof enough the 
two annotations are not being used simultaneously. From what I recall, the plan 
has always been to fully migrate to jsr330, we just never spent the time to do 
that.


> maven-resolver-provider mixes jsr330 and plexus annotations
> ---
>
> Key: MNG-6233
> URL: https://issues.apache.org/jira/browse/MNG-6233
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.9, 3.5.0
>Reporter: Igor Fedorenko
> Fix For: 3.5.1-candidate
>
>
> Mixed annotations confuse guice/sisu and result in hard to troubleshoot and 
> impossible to workaround problems in applications that embed Maven core 
> runtime, like m2e and gshell. 
> I believe plugins annotations where left in the code by mistake so the plan 
> is to update the code to use jsr330 exclusively and completely remove plexus 
> annotations. This change is fully transparent to the users (and we've been 
> using it internally for couple of months now).
> See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6233) maven-resolver-provider mixes jsr330 and plexus annotations

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1604#comment-1604
 ] 

Michael Osipov commented on MNG-6233:
-

Looking forward to see the branch. Do you think we can provide an IT for that?

> maven-resolver-provider mixes jsr330 and plexus annotations
> ---
>
> Key: MNG-6233
> URL: https://issues.apache.org/jira/browse/MNG-6233
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.9, 3.5.0
>Reporter: Igor Fedorenko
> Fix For: 3.5.1-candidate
>
>
> Mixed annotations confuse guice/sisu and result in hard to troubleshoot and 
> impossible to workaround problems in applications that embed Maven core 
> runtime, like m2e and gshell. 
> I believe plugins annotations where left in the code by mistake so the plan 
> is to update the code to use jsr330 exclusively and completely remove plexus 
> annotations. This change is fully transparent to the users (and we've been 
> using it internally for couple of months now).
> See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6233) maven-resolver-provider mixes jsr330 and plexus annotations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1601#comment-1601
 ] 

ASF GitHub Bot commented on MNG-6233:
-

Github user ifedorenko commented on the issue:

https://github.com/apache/maven/pull/116
  
Opened https://issues.apache.org/jira/browse/MNG-6233. If you any concerns 
or suggestions, I suggest we continue the discussion there.

@jdillon I can't close this pull request


> maven-resolver-provider mixes jsr330 and plexus annotations
> ---
>
> Key: MNG-6233
> URL: https://issues.apache.org/jira/browse/MNG-6233
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.3.9, 3.5.0
>Reporter: Igor Fedorenko
> Fix For: 3.5.1-candidate
>
>
> Mixed annotations confuse guice/sisu and result in hard to troubleshoot and 
> impossible to workaround problems in applications that embed Maven core 
> runtime, like m2e and gshell. 
> I believe plugins annotations where left in the code by mistake so the plan 
> is to update the code to use jsr330 exclusively and completely remove plexus 
> annotations. This change is fully transparent to the users (and we've been 
> using it internally for couple of months now).
> See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MNG-6233) maven-resolver-provider mixes jsr330 and plexus annotations

[Igor Fedorenko (JIRA)]

Igor Fedorenko created MNG-6233:
---

 Summary: maven-resolver-provider mixes jsr330 and plexus 
annotations
 Key: MNG-6233
 URL: https://issues.apache.org/jira/browse/MNG-6233
 Project: Maven
  Issue Type: Bug
Affects Versions: 3.5.0, 3.3.9
Reporter: Igor Fedorenko
 Fix For: 3.5.1-candidate


Mixed annotations confuse guice/sisu and result in hard to troubleshoot and 
impossible to workaround problems in applications that embed Maven core 
runtime, like m2e and gshell. 

I believe plugins annotations where left in the code by mistake so the plan is 
to update the code to use jsr330 exclusively and completely remove plexus 
annotations. This change is fully transparent to the users (and we've been 
using it internally for couple of months now).

See also https://github.com/apache/maven/pull/116



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6130) Lost of profile information in workaround for MNG-4900

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011096#comment-16011096
 ] 

Michael Osipov commented on MNG-6130:
-

Thank you. I will apply your patch to a local branch and run all ITs too.

> Lost of profile information in workaround for MNG-4900
> --
>
> Key: MNG-6130
> URL: https://issues.apache.org/jira/browse/MNG-6130
> Project: Maven
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.9, 3.5.0
> Environment: Windows
>Reporter: Boris Brodski
>Assignee: Michael Osipov
>  Labels: easyfix, patch
> Fix For: 3.5.1-candidate
>
> Attachments: MNG-6130.patch
>
>
> Please, forgive me not providing example project reproducing the bug.
> It's very tricky and hopefully not necessary, since the 1-line fix is 
> provided.
> Using profiles together with maven-javadoc-plugin results in the following 
> problem:
> - Configuration from active profiles is not considered during dependency 
> resolution started problematically from the maven-javadoc-plugin.
> This leads to unpredictable behavior, that is somewhat hard to reproduce.
> Here is the technical inside and the 1-line fix:
> In the DefaultMavenProjectBuilder.toRequest():
> {noformat}
> if ( profileManager != null ) {
>...
> } else {
>   ...
>   /*
>* MNG-4900: Hack to workaround deficiency of legacy API which makes it 
> impossible for plugins to access the
>* global profile manager which is required to build a POM like a CLI 
> invocation does. Failure to consider
>* the activated profiles can cause repo declarations to be lost which in 
> turn will result in artifact
>* resolution failures, in particular when using the enhanced local repo 
> which guards access to local files
>* based on the configured remote repos.
>*/
> request.setActiveProfileIds( req.getActiveProfiles() );
> request.setInactiveProfileIds( req.getInactiveProfiles() );
> }
> {noformat}
> Here we copy active and inactive profile ids, but we don't copy the list of 
> all profile ids. Missing line:
> {noformat}
> request.setProfiles( req.getProfiles() );
> {noformat}
> As the result the method DefaultProfileManager.getActiveProfiles() always 
> returns an empty list:
> {noformat}
>   List activeProfiles = new ArrayList<>( profiles.size() );
>   for ( Profile profile : profiles ) {
>  ...
>   }
>   return activeProfiles;
> {noformat}
> "profiles" here is empty, since it wasn't copied together with 
> "getActiveProfiles()" and "getInactiveProfiles()"
> Adding the missing line fixes the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (MNG-6130) Lost of profile information in workaround for MNG-4900

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MNG-6130:
---

Assignee: Michael Osipov

> Lost of profile information in workaround for MNG-4900
> --
>
> Key: MNG-6130
> URL: https://issues.apache.org/jira/browse/MNG-6130
> Project: Maven
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.9, 3.5.0
> Environment: Windows
>Reporter: Boris Brodski
>Assignee: Michael Osipov
>  Labels: easyfix, patch
> Fix For: 3.5.1-candidate
>
> Attachments: MNG-6130.patch
>
>
> Please, forgive me not providing example project reproducing the bug.
> It's very tricky and hopefully not necessary, since the 1-line fix is 
> provided.
> Using profiles together with maven-javadoc-plugin results in the following 
> problem:
> - Configuration from active profiles is not considered during dependency 
> resolution started problematically from the maven-javadoc-plugin.
> This leads to unpredictable behavior, that is somewhat hard to reproduce.
> Here is the technical inside and the 1-line fix:
> In the DefaultMavenProjectBuilder.toRequest():
> {noformat}
> if ( profileManager != null ) {
>...
> } else {
>   ...
>   /*
>* MNG-4900: Hack to workaround deficiency of legacy API which makes it 
> impossible for plugins to access the
>* global profile manager which is required to build a POM like a CLI 
> invocation does. Failure to consider
>* the activated profiles can cause repo declarations to be lost which in 
> turn will result in artifact
>* resolution failures, in particular when using the enhanced local repo 
> which guards access to local files
>* based on the configured remote repos.
>*/
> request.setActiveProfileIds( req.getActiveProfiles() );
> request.setInactiveProfileIds( req.getInactiveProfiles() );
> }
> {noformat}
> Here we copy active and inactive profile ids, but we don't copy the list of 
> all profile ids. Missing line:
> {noformat}
> request.setProfiles( req.getProfiles() );
> {noformat}
> As the result the method DefaultProfileManager.getActiveProfiles() always 
> returns an empty list:
> {noformat}
>   List activeProfiles = new ArrayList<>( profiles.size() );
>   for ( Profile profile : profiles ) {
>  ...
>   }
>   return activeProfiles;
> {noformat}
> "profiles" here is empty, since it wasn't copied together with 
> "getActiveProfiles()" and "getInactiveProfiles()"
> Adding the missing line fixes the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MNG-6130) Lost of profile information in workaround for MNG-4900

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6130:

Fix Version/s: 3.5.1-candidate

> Lost of profile information in workaround for MNG-4900
> --
>
> Key: MNG-6130
> URL: https://issues.apache.org/jira/browse/MNG-6130
> Project: Maven
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.9, 3.5.0
> Environment: Windows
>Reporter: Boris Brodski
>Assignee: Michael Osipov
>  Labels: easyfix, patch
> Fix For: 3.5.1-candidate
>
> Attachments: MNG-6130.patch
>
>
> Please, forgive me not providing example project reproducing the bug.
> It's very tricky and hopefully not necessary, since the 1-line fix is 
> provided.
> Using profiles together with maven-javadoc-plugin results in the following 
> problem:
> - Configuration from active profiles is not considered during dependency 
> resolution started problematically from the maven-javadoc-plugin.
> This leads to unpredictable behavior, that is somewhat hard to reproduce.
> Here is the technical inside and the 1-line fix:
> In the DefaultMavenProjectBuilder.toRequest():
> {noformat}
> if ( profileManager != null ) {
>...
> } else {
>   ...
>   /*
>* MNG-4900: Hack to workaround deficiency of legacy API which makes it 
> impossible for plugins to access the
>* global profile manager which is required to build a POM like a CLI 
> invocation does. Failure to consider
>* the activated profiles can cause repo declarations to be lost which in 
> turn will result in artifact
>* resolution failures, in particular when using the enhanced local repo 
> which guards access to local files
>* based on the configured remote repos.
>*/
> request.setActiveProfileIds( req.getActiveProfiles() );
> request.setInactiveProfileIds( req.getInactiveProfiles() );
> }
> {noformat}
> Here we copy active and inactive profile ids, but we don't copy the list of 
> all profile ids. Missing line:
> {noformat}
> request.setProfiles( req.getProfiles() );
> {noformat}
> As the result the method DefaultProfileManager.getActiveProfiles() always 
> returns an empty list:
> {noformat}
>   List activeProfiles = new ArrayList<>( profiles.size() );
>   for ( Profile profile : profiles ) {
>  ...
>   }
>   return activeProfiles;
> {noformat}
> "profiles" here is empty, since it wasn't copied together with 
> "getActiveProfiles()" and "getInactiveProfiles()"
> Adding the missing line fixes the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MNG-6130) Lost of profile information in workaround for MNG-4900

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6130:

Affects Version/s: 3.5.0

> Lost of profile information in workaround for MNG-4900
> --
>
> Key: MNG-6130
> URL: https://issues.apache.org/jira/browse/MNG-6130
> Project: Maven
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.9, 3.5.0
> Environment: Windows
>Reporter: Boris Brodski
>  Labels: easyfix, patch
> Attachments: MNG-6130.patch
>
>
> Please, forgive me not providing example project reproducing the bug.
> It's very tricky and hopefully not necessary, since the 1-line fix is 
> provided.
> Using profiles together with maven-javadoc-plugin results in the following 
> problem:
> - Configuration from active profiles is not considered during dependency 
> resolution started problematically from the maven-javadoc-plugin.
> This leads to unpredictable behavior, that is somewhat hard to reproduce.
> Here is the technical inside and the 1-line fix:
> In the DefaultMavenProjectBuilder.toRequest():
> {noformat}
> if ( profileManager != null ) {
>...
> } else {
>   ...
>   /*
>* MNG-4900: Hack to workaround deficiency of legacy API which makes it 
> impossible for plugins to access the
>* global profile manager which is required to build a POM like a CLI 
> invocation does. Failure to consider
>* the activated profiles can cause repo declarations to be lost which in 
> turn will result in artifact
>* resolution failures, in particular when using the enhanced local repo 
> which guards access to local files
>* based on the configured remote repos.
>*/
> request.setActiveProfileIds( req.getActiveProfiles() );
> request.setInactiveProfileIds( req.getInactiveProfiles() );
> }
> {noformat}
> Here we copy active and inactive profile ids, but we don't copy the list of 
> all profile ids. Missing line:
> {noformat}
> request.setProfiles( req.getProfiles() );
> {noformat}
> As the result the method DefaultProfileManager.getActiveProfiles() always 
> returns an empty list:
> {noformat}
>   List activeProfiles = new ArrayList<>( profiles.size() );
>   for ( Profile profile : profiles ) {
>  ...
>   }
>   return activeProfiles;
> {noformat}
> "profiles" here is empty, since it wasn't copied together with 
> "getActiveProfiles()" and "getInactiveProfiles()"
> Adding the missing line fixes the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6130) Lost of profile information in workaround for MNG-4900

[Boris Brodski (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011050#comment-16011050
 ] 

Boris Brodski commented on MNG-6130:


Hello Michael,

Thank you for the URL.
With this proposed change all integration tests are passing!

If I can further assist you here in any way, please let me know.

Cheers,
Boris

> Lost of profile information in workaround for MNG-4900
> --
>
> Key: MNG-6130
> URL: https://issues.apache.org/jira/browse/MNG-6130
> Project: Maven
>  Issue Type: Bug
>  Components: core
>Affects Versions: 3.3.9
> Environment: Windows
>Reporter: Boris Brodski
>  Labels: easyfix, patch
> Attachments: MNG-6130.patch
>
>
> Please, forgive me not providing example project reproducing the bug.
> It's very tricky and hopefully not necessary, since the 1-line fix is 
> provided.
> Using profiles together with maven-javadoc-plugin results in the following 
> problem:
> - Configuration from active profiles is not considered during dependency 
> resolution started problematically from the maven-javadoc-plugin.
> This leads to unpredictable behavior, that is somewhat hard to reproduce.
> Here is the technical inside and the 1-line fix:
> In the DefaultMavenProjectBuilder.toRequest():
> {noformat}
> if ( profileManager != null ) {
>...
> } else {
>   ...
>   /*
>* MNG-4900: Hack to workaround deficiency of legacy API which makes it 
> impossible for plugins to access the
>* global profile manager which is required to build a POM like a CLI 
> invocation does. Failure to consider
>* the activated profiles can cause repo declarations to be lost which in 
> turn will result in artifact
>* resolution failures, in particular when using the enhanced local repo 
> which guards access to local files
>* based on the configured remote repos.
>*/
> request.setActiveProfileIds( req.getActiveProfiles() );
> request.setInactiveProfileIds( req.getInactiveProfiles() );
> }
> {noformat}
> Here we copy active and inactive profile ids, but we don't copy the list of 
> all profile ids. Missing line:
> {noformat}
> request.setProfiles( req.getProfiles() );
> {noformat}
> As the result the method DefaultProfileManager.getActiveProfiles() always 
> returns an empty list:
> {noformat}
>   List activeProfiles = new ArrayList<>( profiles.size() );
>   for ( Profile profile : profiles ) {
>  ...
>   }
>   return activeProfiles;
> {noformat}
> "profiles" here is empty, since it wasn't copied together with 
> "getActiveProfiles()" and "getInactiveProfiles()"
> Adding the missing line fixes the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (ARCHETYPE-439) Remove archetypeRepository param

[Henry Saputra (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARCHETYPE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010710#comment-16010710
 ] 

Henry Saputra edited comment on ARCHETYPE-439 at 5/15/17 4:41 PM:
--

The description of this bug is also bit vague. 
Why is it not good? What is the proposed solution? Why would proposed solution 
work?

See ARCHETYPE-519 for after math of these changes. 

I understand major version changes can be used for "breaking" changes but it 
should have good reason why and have users to have equivalent solution or path 
to achieve similar result. 
Thanks. 


was (Author: hsaputra):
The description of this bug is very vague. Why is it not good? What is the 
proposed solution? Why would proposed solution work?

See ARCHETYPE-519 for after math of these changes. 

I understand major version changes can be used for "breaking" changes but it 
should have good reason why and have users to have equivalent solution or path 
to achieve similar result.

> Remove archetypeRepository param
> 
>
> Key: ARCHETYPE-439
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-439
> Project: Maven Archetype
>  Issue Type: Improvement
>  Components: Generator
> Environment: n/a
>Reporter: Anders Hammar
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> The archetypeRepository param makes it possible to bypass the configured 
> Maven repos for retrieving an archetype. This is not good.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARCHETYPE-519) archetype:generate with specified remote archetypeCatalog falls back to internal catalog

[Henry Saputra (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARCHETYPE-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010819#comment-16010819
 ] 

Henry Saputra commented on ARCHETYPE-519:
-

Ah cool, thanks

> archetype:generate with specified remote archetypeCatalog falls back to 
> internal catalog
> 
>
> Key: ARCHETYPE-519
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-519
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Generator
>Affects Versions: 3.0.0
> Environment: Mac OS X 10.11.6, Apache Maven 3.2.3
>Reporter: Philip Mundt
>Assignee: Robert Scholte
> Fix For: 3.0.1
>
>
> We were surprised to find out that our archetype was "suddenly" not working 
> anymore. It turns out it was the release of 
> {{org.apache.maven.plugins:maven-archetype-plugin:3.0.0}} from 12/Feb/17 that 
> was the culprit.
> When running:
> {{mvn org.apache.maven.plugins:maven-archetype-plugin:3.0.0:generate 
> -DarchetypeCatalog=}} we end up with the 
> plugin falling back to the internal catalog:
> {code}
> [INFO] Scanning for projects...
> [INFO]
> [INFO] 
> 
> [INFO] Building Maven Stub Project (No POM) 1
> [INFO] 
> 
> [INFO]
> [INFO] >>> maven-archetype-plugin:3.0.0:generate (default-cli) > 
> generate-sources @ standalone-pom >>>
> [INFO]
> [INFO] <<< maven-archetype-plugin:3.0.0:generate (default-cli) < 
> generate-sources @ standalone-pom <<<
> [INFO]
> [INFO] --- maven-archetype-plugin:3.0.0:generate (default-cli) @ 
> standalone-pom ---
> [INFO] Generating project in Interactive mode
> [INFO] No catalog defined. Using internal catalog
> [INFO] No archetype defined. Using maven-archetype-quickstart 
> (org.apache.maven.archetypes:maven-archetype-quickstart:1.0)
> Choose archetype:
> 1: internal -> org.apache.maven.archetypes:maven-archetype-archetype (An 
> archetype which contains a sample archetype.)
> 2: internal -> org.apache.maven.archetypes:maven-archetype-j2ee-simple (An 
> archetype which contains a simplifed sample J2EE application.)
> 3: internal -> org.apache.maven.archetypes:maven-archetype-plugin (An 
> archetype which contains a sample Maven plugin.)
> 4: internal -> org.apache.maven.archetypes:maven-archetype-plugin-site (An 
> archetype which contains a sample Maven plugin site.
>   This archetype can be layered upon an existing Maven plugin project.)
> 5: internal -> org.apache.maven.archetypes:maven-archetype-portlet (An 
> archetype which contains a sample JSR-268 Portlet.)
> 6: internal -> org.apache.maven.archetypes:maven-archetype-profiles ()
> 7: internal -> org.apache.maven.archetypes:maven-archetype-quickstart (An 
> archetype which contains a sample Maven project.)
> 8: internal -> org.apache.maven.archetypes:maven-archetype-site (An archetype 
> which contains a sample Maven site which demonstrates
>   some of the supported document types like APT, XDoc, and FML and 
> demonstrates how
>   to i18n your site. This archetype can be layered upon an existing Maven 
> project.)
> 9: internal -> org.apache.maven.archetypes:maven-archetype-site-simple (An 
> archetype which contains a sample Maven site.)
> 10: internal -> org.apache.maven.archetypes:maven-archetype-webapp (An 
> archetype which contains a sample Maven Webapp project.)
> Choose a number or apply filter (format: [groupId:]artifactId, case sensitive 
> contains):
> {code}
> Version 2.4 works as expected (the archetype catalog exists under given URL 
> and can be downloaded).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-5756) Java home output in mvn -v is misleading

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010756#comment-16010756
 ] 

ASF GitHub Bot commented on MNG-5756:
-

GitHub user eis opened a pull request:

https://github.com/apache/maven/pull/117

[MNG-5756] Java home output in mvn -v is misleading

Renamed previous printing of JRE to "JRE used" and provided
separate mechanism to actually tell value of JAVA_HOME

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eis/maven jre-reporting-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit d1911049823bd4ba5f695904500ab4cf2b16207c
Author: eis 
Date:   2017-05-15T15:58:40Z

[MNG-5756] Java home output in mvn -v is misleading

Renamed previous printing of JRE to "JRE used" and provided
separate mechanism to actually tell value of JAVA_HOME




> Java home output in mvn -v is misleading
> 
>
> Key: MNG-5756
> URL: https://issues.apache.org/jira/browse/MNG-5756
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.2.5, 3.3.3
> Environment: any
>Reporter: Jarkko Rantavuori
>Priority: Minor
>
> For example on my windows box, mvn -v prints the following:
> {code}
> Java home: C:\Program Files (x86)\Java\jdk1.7.0_51\jre
> {code}
> But my JAVA_HOME is actually
> {code}
> > echo %JAVA_HOME%
> C:\Program Files (x86)\Java\jdk1.7.0_51
> {code}
> In the source code, the line comes from:
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java#l63
> {code}
> version.append( "Java home: " ).append( System.getProperty( "java.home", 
> "" ) ).append( ls );
> {code}
> which is using property "java.home" to fetch java home. However, "java.home" 
> property is not JAVA_HOME! This is explained in detail in here: 
> http://javahowto.blogspot.fi/2006/05/javahome-vs-javahome.html
> To quote:
> {quote}
> What's the difference between JAVA_HOME and java.home?
> JAVA_HOME is the JDK install directory, e.g., C:\jdk5. It's meant to be 
> set as an environment variable and referenced in Windows batch files or Unix 
> scripts. I always have it in my Windows Control Panel and .tcsh files,along 
> with other common environment variables. Some Java applications use the name 
> jdk.home for this purpose, which I think is a better name. But JAVA_HOME has 
> been used since the beginning and is now a convention.
> java.home is the JRE install directory, e.g., C:\jdk5\jre, or C:\Program 
> Files\Java\jre1.5.0_06. Unlike JAVA_HOME, I never seen java.home as an 
> environment variable. java.home is a build-in Java system property, whose 
> value is the JRE install directory. Since all Java system properties are also 
> exposed as Ant build properties, you can also use $java.home in 
> build files.
> Would jre.home be a better name? Maybe, but I don't think Sun will change 
> it.
> {quote}
> This is a source of constant confusion. Some stackoverflow threads to 
> illustrate:
> http://stackoverflow.com/questions/15279586/java-home-in-maven
> http://stackoverflow.com/questions/17620531/maven-pointing-to-jre-instead-of-jdk
> The correct way to print JAVA_HOME would be to use 
> System.getenv("JAVA_HOME"). Either that should be used or current output 
> should be changed so it wouldn't be so misleading.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARCHETYPE-439) Remove archetypeRepository param

[Henry Saputra (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARCHETYPE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010710#comment-16010710
 ] 

Henry Saputra commented on ARCHETYPE-439:
-

The description of this bug is very vague. Why is it not good? What is the 
proposed solution? Why would proposed solution work?

See ARCHETYPE-519 for after math of these changes. 

I understand major version changes can be used for "breaking" changes but it 
should have good reason why and have users to have equivalent solution or path 
to achieve similar result.

> Remove archetypeRepository param
> 
>
> Key: ARCHETYPE-439
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-439
> Project: Maven Archetype
>  Issue Type: Improvement
>  Components: Generator
> Environment: n/a
>Reporter: Anders Hammar
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> The archetypeRepository param makes it possible to bypass the configured 
> Maven repos for retrieving an archetype. This is not good.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MNG-6167) Clean up dependency mess (reported by dependency:analyze)

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6167:

Affects Version/s: 3.5.0

> Clean up dependency mess (reported by dependency:analyze)
> -
>
> Key: MNG-6167
> URL: https://issues.apache.org/jira/browse/MNG-6167
> Project: Maven
>  Issue Type: Task
>Affects Versions: 3.3.9, 3.5.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.5.1-candidate
>
> Attachments: dep-analayze.log
>
>
> {{mvn dependency:analyze}} reports that a lot of transitive dependencies are 
> used directly, but never declared in the POMs.
> Parts have been done in 
> [934e030f049d955c330c4b61abb66a543f9ca990|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=934e030f049d955c330c4b61abb66a543f9ca990].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARCHETYPE-519) archetype:generate with specified remote archetypeCatalog falls back to internal catalog

[JIRA]

[ 
https://issues.apache.org/jira/browse/ARCHETYPE-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010680#comment-16010680
 ] 

Amélie Deltour commented on ARCHETYPE-519:
--

I answered to the discussion on the dev-list. I hope my explanation was clear 
enough.
It is a pity that we, as users, need to subscribe to a "dev" mailing-list to be 
able to argue our case. And this issue (ARCHETYPE-519) which is the main issue 
where users complain about the release was not even mentioned in the thread.

> archetype:generate with specified remote archetypeCatalog falls back to 
> internal catalog
> 
>
> Key: ARCHETYPE-519
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-519
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Generator
>Affects Versions: 3.0.0
> Environment: Mac OS X 10.11.6, Apache Maven 3.2.3
>Reporter: Philip Mundt
>Assignee: Robert Scholte
> Fix For: 3.0.1
>
>
> We were surprised to find out that our archetype was "suddenly" not working 
> anymore. It turns out it was the release of 
> {{org.apache.maven.plugins:maven-archetype-plugin:3.0.0}} from 12/Feb/17 that 
> was the culprit.
> When running:
> {{mvn org.apache.maven.plugins:maven-archetype-plugin:3.0.0:generate 
> -DarchetypeCatalog=}} we end up with the 
> plugin falling back to the internal catalog:
> {code}
> [INFO] Scanning for projects...
> [INFO]
> [INFO] 
> 
> [INFO] Building Maven Stub Project (No POM) 1
> [INFO] 
> 
> [INFO]
> [INFO] >>> maven-archetype-plugin:3.0.0:generate (default-cli) > 
> generate-sources @ standalone-pom >>>
> [INFO]
> [INFO] <<< maven-archetype-plugin:3.0.0:generate (default-cli) < 
> generate-sources @ standalone-pom <<<
> [INFO]
> [INFO] --- maven-archetype-plugin:3.0.0:generate (default-cli) @ 
> standalone-pom ---
> [INFO] Generating project in Interactive mode
> [INFO] No catalog defined. Using internal catalog
> [INFO] No archetype defined. Using maven-archetype-quickstart 
> (org.apache.maven.archetypes:maven-archetype-quickstart:1.0)
> Choose archetype:
> 1: internal -> org.apache.maven.archetypes:maven-archetype-archetype (An 
> archetype which contains a sample archetype.)
> 2: internal -> org.apache.maven.archetypes:maven-archetype-j2ee-simple (An 
> archetype which contains a simplifed sample J2EE application.)
> 3: internal -> org.apache.maven.archetypes:maven-archetype-plugin (An 
> archetype which contains a sample Maven plugin.)
> 4: internal -> org.apache.maven.archetypes:maven-archetype-plugin-site (An 
> archetype which contains a sample Maven plugin site.
>   This archetype can be layered upon an existing Maven plugin project.)
> 5: internal -> org.apache.maven.archetypes:maven-archetype-portlet (An 
> archetype which contains a sample JSR-268 Portlet.)
> 6: internal -> org.apache.maven.archetypes:maven-archetype-profiles ()
> 7: internal -> org.apache.maven.archetypes:maven-archetype-quickstart (An 
> archetype which contains a sample Maven project.)
> 8: internal -> org.apache.maven.archetypes:maven-archetype-site (An archetype 
> which contains a sample Maven site which demonstrates
>   some of the supported document types like APT, XDoc, and FML and 
> demonstrates how
>   to i18n your site. This archetype can be layered upon an existing Maven 
> project.)
> 9: internal -> org.apache.maven.archetypes:maven-archetype-site-simple (An 
> archetype which contains a sample Maven site.)
> 10: internal -> org.apache.maven.archetypes:maven-archetype-webapp (An 
> archetype which contains a sample Maven Webapp project.)
> Choose a number or apply filter (format: [groupId:]artifactId, case sensitive 
> contains):
> {code}
> Version 2.4 works as expected (the archetype catalog exists under given URL 
> and can be downloaded).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MNGSITE-295) Document Jansi native library search path feature in install.md.vm

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNGSITE-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MNGSITE-295.
--
Resolution: Won't Fix

This is not necessary anymore since all native dependencies are exploded and 
visible to the user.

> Document Jansi native library search path feature in install.md.vm
> --
>
> Key: MNGSITE-295
> URL: https://issues.apache.org/jira/browse/MNGSITE-295
> Project: Maven Project Web Site
>  Issue Type: New Feature
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>
> By adding MNG-6115 people should actually know how to utilize the 
> improvement. Document it in {{install.md.vm}}. This has to be done when Maven 
> 3.5.0 is released.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MPMD-237) Unnecessary modifiers on variables

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MPMD-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MPMD-237.
---
Resolution: Invalid

This is not a support forum.

> Unnecessary modifiers on variables
> --
>
> Key: MPMD-237
> URL: https://issues.apache.org/jira/browse/MPMD-237
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.8
>Reporter: Kiranchandreddy Janga
>
> Why we are seeing UnnecessaryModifier rule set on enum/constants.?
> Facing new issues with this check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MNG-6232) Version range is not resolved correctly

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010514#comment-16010514
 ] 

Michael Osipov commented on MNG-6232:
-

I agree with Marek that this is counter intuitive for our users.

> Version range is not resolved correctly
> ---
>
> Key: MNG-6232
> URL: https://issues.apache.org/jira/browse/MNG-6232
> Project: Maven
>  Issue Type: Bug
>  Components: Dependencies
>Affects Versions: 3.3.3
>Reporter: Marek Budyn
> Attachments: pom.xml
>
>
> When dependency is specified as range, e.g slf4j-api version [1.7, 1.8) as in 
> provided pom.xml, one would expect to resolver to version 1.7.X (e.g. 
> 1.7.25). Instead maven resolves version 1.8.0-alpha 2.
> Output of command 'mvn dependenct:tree' on provided pom.xml:
> [INFO] Scanning for projects...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building project 1.0.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ project ---
> [INFO] test:project:jar:1.0.0-SNAPSHOT
> [INFO] \- org.slf4j:slf4j-api:jar:1.8.0-alpha2:compile
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1.273 s
> [INFO] Finished at: 2017-05-12T23:37:02+02:00
> [INFO] Final Memory: 13M/225M
> [INFO] 
> 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (MNG-5567) Zip files are not included in classpaths at all

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MNG-5567:
---

Assignee: (was: Michael Osipov)

> Zip files are not included in classpaths at all
> ---
>
> Key: MNG-5567
> URL: https://issues.apache.org/jira/browse/MNG-5567
> Project: Maven
>  Issue Type: Bug
>  Components: Dependencies
>Affects Versions: 3.3.9
>Reporter: Pablo La Greca
>Priority: Critical
> Fix For: Issues to be reviewed for 4.x
>
>
> when i added a dependency that was zip file 
> eg
> {code:xml}
>   hsqldb
>   hsqldb
>   1.7.3.0
>   provided
>   zip
>   
> {code}
>  this file was not included in the test classpath and so the test would not 
> pass



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MDEP-434) Give better explanation of dependency intent.

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MDEP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MDEP-434.
---

> Give better explanation of dependency intent.
> -
>
> Key: MDEP-434
> URL: https://issues.apache.org/jira/browse/MDEP-434
> Project: Maven Dependency Plugin
>  Issue Type: Wish
>Reporter: Benson Margulies
>
> If MNG-3879 ever gets done, this plugin could decorate its output with 
> human-readable content about dependency intent.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MDEP-409) dependency:tree fails for a multi-module project where one module depends on another and "mvn install" has not been run yet

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010499#comment-16010499
 ] 

Michael Osipov commented on MDEP-409:
-

This will take some a day.

> dependency:tree fails for a multi-module project where one module depends on 
> another and "mvn install" has not been run yet
> ---
>
> Key: MDEP-409
> URL: https://issues.apache.org/jira/browse/MDEP-409
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: tree
>Affects Versions: 2.7
> Environment: Linux
>Reporter: Eric Pabst
>Assignee: Michael Osipov
> Fix For: 3.0.1
>
> Attachments: MDEP-409.patch
>
>
> When I run dependency:tree on a multi-module project without having run a 
> "mvn install", it fails with this error: {noformat}
> [ERROR] Failed to execute goal on project slide-test-module-svn-2: Could not 
> resolve dependencies for project 
> org.slide:slide-test-module-svn-2:jar:1.1-SNAPSHOT: The following artifacts 
> could not be resolved: org.slide:slide-test-module-svn-3:jar:1.1-SNAPSHOT, 
> org.slide:git-component-for-testing-slide:jar:1.0.b1782: Could not find 
> artifact org.slide:slide-test-module-svn-3:jar:1.1-SNAPSHOT in maven-central 
> -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MDEP-495) Remove deprecated parameters

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MDEP-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MDEP-495.
---

> Remove deprecated parameters
> 
>
> Key: MDEP-495
> URL: https://issues.apache.org/jira/browse/MDEP-495
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>Affects Versions: 2.10
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> || Goal || Parameter || Solution ||
> | build-classpath | cpFile | use outputFile instead |
> | get | destination | if you need to copy the resolved artifact, use 
> dependency:copy |
> | get | repositoryId | Use remoteRepositories |
> | get | repositoryUrl | Use remoteRepositories |
> | tree | output | use outputFile instead |



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept null input

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010492#comment-16010492
 ] 

Hudson commented on MRESOLVER-4:


SUCCESS: Integrated in Jenkins build maven-resolver #51 (See 
[https://builds.apache.org/job/maven-resolver/51/])
[MRESOLVER-4] Use java.util.Objects#requireNonNull to intercept invalid 
(michaelo: 
[http://git-wip-us.apache.org/repos/asf/?p=maven-resolver.git=commit=6b9d07b8193090cdc22871d2ff8abd854d0bd570])
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/version/VersionRange.java
* (edit) 
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java
* (edit) 
maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/internal/transport/wagon/PlexusWagonProvider.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/resolution/VersionRangeResult.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/version/GenericVersionConstraint.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/StringAuthentication.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyGraphTransformationContext.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/ComponentAuthentication.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/resolution/VersionResult.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java
* (edit) 
maven-resolver-api/src/test/java/org/eclipse/aether/repository/RemoteRepositoryBuilderTest.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/DefaultProxySelector.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/resolution/DependencyResult.java
* (edit) 
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestVersionConstraint.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/TreeDependencyVisitor.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java
* (edit) 
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestDependencyGraphTransformationContext.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java
* (edit) 
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/resolution/MetadataResult.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResult.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/concurrency/RunnableErrorForwarder.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/ConservativeProxySelector.java
* (edit) 

[jira] [Commented] (MRESOLVER-5) Update minimum Java version to 1.7

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010493#comment-16010493
 ] 

Hudson commented on MRESOLVER-5:


SUCCESS: Integrated in Jenkins build maven-resolver #51 (See 
[https://builds.apache.org/job/maven-resolver/51/])
[MRESOLVER-5] Update minimum Java version to 1.7 (michaelo: 
[http://git-wip-us.apache.org/repos/asf/?p=maven-resolver.git=commit=e83567652fea414751f30dd2b9d8834fa3b97230])
* (edit) pom.xml


> Update minimum Java version to 1.7
> --
>
> Key: MRESOLVER-5
> URL: https://issues.apache.org/jira/browse/MRESOLVER-5
> Project: Maven Resolver
>  Issue Type: Task
>Affects Versions: Maven Artifact Resolver 1.2.0 pre-reset
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.1.0
>
>
> Maven Resolver is highly coupled in Maven 3. Since Maven now requires 1.7, 
> Resolver as a key component should require it too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MRESOLVER-6) Use java.nio.charset.StandardCharsets wherever possible

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010491#comment-16010491
 ] 

Hudson commented on MRESOLVER-6:


SUCCESS: Integrated in Jenkins build maven-resolver #51 (See 
[https://builds.apache.org/job/maven-resolver/51/])
[MRESOLVER-6] Use java.nio.charset.StandardCharsets wherever possible 
(michaelo: 
[http://git-wip-us.apache.org/repos/asf/?p=maven-resolver.git=commit=0d01ff75c18d51a6e30c0439c800a9c92f6bced9])
* (edit) 
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/GetTask.java
* (edit) 
maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java
* (edit) 
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java
* (edit) 
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultInstallerTest.java
* (edit) 
maven-resolver-transport-classpath/src/test/java/org/eclipse/aether/transport/classpath/ClasspathTransporterTest.java
* (edit) 
maven-resolver-transport-file/src/test/java/org/eclipse/aether/transport/file/FileTransporterTest.java
* (edit) 
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpTransporterTest.java
* (edit) 
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/TrackingFileManagerTest.java
* (edit) 
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestFileUtils.java
* (edit) 
maven-resolver-transport-wagon/src/test/java/org/eclipse/aether/transport/wagon/AbstractWagonTransporterTest.java
* (edit) 
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestFileProcessor.java
* (edit) 
maven-resolver-connector-basic/src/test/java/org/eclipse/aether/connector/basic/ChecksumCalculatorTest.java
* (edit) 
maven-resolver-transport-wagon/src/test/java/org/eclipse/aether/transport/wagon/MemStreamWagon.java
* (edit) 
maven-resolver-test-util/src/test/java/org/eclipse/aether/internal/test/util/DependencyGraphParserTest.java
* (edit) 
maven-resolver-util/src/test/java/org/eclipse/aether/util/ChecksumUtilTest.java
* (edit) 
maven-resolver-transport-wagon/src/test/java/org/eclipse/aether/transport/wagon/MemWagon.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultFileProcessor.java
* (edit) 
maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java
* (edit) 
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpServer.java
* (edit) 
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/PutTask.java
* (edit) 
maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/IniArtifactDataReader.java
* (edit) 
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleDigest.java


> Use java.nio.charset.StandardCharsets wherever possible
> ---
>
> Key: MRESOLVER-6
> URL: https://issues.apache.org/jira/browse/MRESOLVER-6
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Aether 1.0.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.1.0
>
>
> In many spots an {{UnsupportedEncodingException}} has to be caught because 
> {{UTF-8}} is passed as string, though this encoding must be supported by 
> every JVM implementation. So we can use {{StandardCharsets.UTF_8}} and remove 
> boilerplate code around it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MDEP-409) dependency:tree fails for a multi-module project where one module depends on another and "mvn install" has not been run yet

[Archimedes Trajano (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010481#comment-16010481
 ] 

Archimedes Trajano commented on MDEP-409:
-

https://github.com/apache/maven-plugins/commit/71c24e418afd37b8f4290fd1a4e0419bc9e2285a
 seems like it was released but I don't see it on central.

> dependency:tree fails for a multi-module project where one module depends on 
> another and "mvn install" has not been run yet
> ---
>
> Key: MDEP-409
> URL: https://issues.apache.org/jira/browse/MDEP-409
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: tree
>Affects Versions: 2.7
> Environment: Linux
>Reporter: Eric Pabst
>Assignee: Michael Osipov
> Fix For: 3.0.1
>
> Attachments: MDEP-409.patch
>
>
> When I run dependency:tree on a multi-module project without having run a 
> "mvn install", it fails with this error: {noformat}
> [ERROR] Failed to execute goal on project slide-test-module-svn-2: Could not 
> resolve dependencies for project 
> org.slide:slide-test-module-svn-2:jar:1.1-SNAPSHOT: The following artifacts 
> could not be resolved: org.slide:slide-test-module-svn-3:jar:1.1-SNAPSHOT, 
> org.slide:git-component-for-testing-slide:jar:1.0.b1782: Could not find 
> artifact org.slide:slide-test-module-svn-3:jar:1.1-SNAPSHOT in maven-central 
> -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MRESOLVER-6) Use java.nio.charset.StandardCharsets wherever possible

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRESOLVER-6:
---
Fix Version/s: (was: Maven Artifact Resolver 1.2.0 pre-reset)
   Maven Artifact Resolver 1.1.0

> Use java.nio.charset.StandardCharsets wherever possible
> ---
>
> Key: MRESOLVER-6
> URL: https://issues.apache.org/jira/browse/MRESOLVER-6
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Aether 1.0.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.1.0
>
>
> In many spots an {{UnsupportedEncodingException}} has to be caught because 
> {{UTF-8}} is passed as string, though this encoding must be supported by 
> every JVM implementation. So we can use {{StandardCharsets.UTF_8}} and remove 
> boilerplate code around it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MRESOLVER-6) Use java.nio.charset.StandardCharsets wherever possible

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRESOLVER-6.
--
Resolution: Fixed

Fixed with 
[0d01ff75c18d51a6e30c0439c800a9c92f6bced9|https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=0d01ff75c18d51a6e30c0439c800a9c92f6bced9].

> Use java.nio.charset.StandardCharsets wherever possible
> ---
>
> Key: MRESOLVER-6
> URL: https://issues.apache.org/jira/browse/MRESOLVER-6
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Affects Versions: Aether 1.0.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.1.0
>
>
> In many spots an {{UnsupportedEncodingException}} has to be caught because 
> {{UTF-8}} is passed as string, though this encoding must be supported by 
> every JVM implementation. So we can use {{StandardCharsets.UTF_8}} and remove 
> boilerplate code around it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept null input

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRESOLVER-4.
--
Resolution: Fixed

Fixed with 
[6b9d07b8193090cdc22871d2ff8abd854d0bd570|https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=6b9d07b8193090cdc22871d2ff8abd854d0bd570].


> Use java.util.Objects#requireNonNull to intercept null input
> 
>
> Key: MRESOLVER-4
> URL: https://issues.apache.org/jira/browse/MRESOLVER-4
> Project: Maven Resolver
>  Issue Type: Improvement
>Affects Versions: Maven Artifact Resolver 1.2.0 pre-reset
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.0
>
>
> In several spots of Maven Resolver IAE is thrown where an argument is null. 
> This should be turned into NullPointerException since JDK adheres to this, 
> the description of this exception indicates that and Effective Java does that 
> too. Java 7 even provides a new 
> [{{Objects}}|https://docs.oracle.com/javase/7/docs/api/java/util/Objects.html]
>  class with {{requireNonNull(Object,String)}} method to ease checking
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
> throw new IllegalArgumentException( "Bad artifact coordinates " + 
> coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
> throw new IllegalArgumentException( "dependency collection 
> request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
> throw new IllegalArgumentException( "repository system session 
> not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
> throw new IllegalArgumentException( "deploy request has not been 
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:  
>   throw new IllegalArgumentException( "no artifact specified for 
> dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
> throw new IllegalArgumentException( "install request has not been 
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
> throw new IllegalArgumentException( "metadata nature was not 
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "repository system session 
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key 
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key 
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
> throw new IllegalArgumentException( "local artifact request has 
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
> throw new IllegalArgumentException( "local metadata request has 
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
> throw new IllegalArgumentException( "repository prototype 
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:   
>  throw new IllegalArgumentException( "session not specified" );
> 

[jira] [Updated] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept null input

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRESOLVER-4:
---
Fix Version/s: (was: Maven Artifact Resolver 1.2.0 pre-reset)
   Maven Artifact Resolver 1.1.0

> Use java.util.Objects#requireNonNull to intercept null input
> 
>
> Key: MRESOLVER-4
> URL: https://issues.apache.org/jira/browse/MRESOLVER-4
> Project: Maven Resolver
>  Issue Type: Improvement
>Affects Versions: Maven Artifact Resolver 1.2.0 pre-reset
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Maven Artifact Resolver 1.1.0
>
>
> In several spots of Maven Resolver IAE is thrown where an argument is null. 
> This should be turned into NullPointerException since JDK adheres to this, 
> the description of this exception indicates that and Effective Java does that 
> too. Java 7 even provides a new 
> [{{Objects}}|https://docs.oracle.com/javase/7/docs/api/java/util/Objects.html]
>  class with {{requireNonNull(Object,String)}} method to ease checking
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
> throw new IllegalArgumentException( "Bad artifact coordinates " + 
> coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
> throw new IllegalArgumentException( "dependency collection 
> request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
> throw new IllegalArgumentException( "repository system session 
> not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
> throw new IllegalArgumentException( "deploy request has not been 
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:  
>   throw new IllegalArgumentException( "no artifact specified for 
> dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
> throw new IllegalArgumentException( "install request has not been 
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
> throw new IllegalArgumentException( "metadata nature was not 
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "repository system session 
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key 
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key 
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
> throw new IllegalArgumentException( "local artifact request has 
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
> throw new IllegalArgumentException( "local metadata request has 
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
> throw new IllegalArgumentException( "repository prototype 
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:   
>  throw new IllegalArgumentException( "session not specified" );
> 

[jira] [Closed] (MRESOLVER-5) Update minimum Java version to 1.7

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRESOLVER-5.
--
Resolution: Fixed

Fixed with 
[e83567652fea414751f30dd2b9d8834fa3b97230|https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=e83567652fea414751f30dd2b9d8834fa3b97230].

> Update minimum Java version to 1.7
> --
>
> Key: MRESOLVER-5
> URL: https://issues.apache.org/jira/browse/MRESOLVER-5
> Project: Maven Resolver
>  Issue Type: Task
>Affects Versions: Maven Artifact Resolver 1.2.0 pre-reset
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.1.0
>
>
> Maven Resolver is highly coupled in Maven 3. Since Maven now requires 1.7, 
> Resolver as a key component should require it too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MRESOLVER-5) Update minimum Java version to 1.7

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRESOLVER-5:
---
Fix Version/s: (was: Maven Artifact Resolver 1.2.0 pre-reset)
   Maven Artifact Resolver 1.1.0

> Update minimum Java version to 1.7
> --
>
> Key: MRESOLVER-5
> URL: https://issues.apache.org/jira/browse/MRESOLVER-5
> Project: Maven Resolver
>  Issue Type: Task
>Affects Versions: Maven Artifact Resolver 1.2.0 pre-reset
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: Maven Artifact Resolver 1.1.0
>
>
> Maven Resolver is highly coupled in Maven 3. Since Maven now requires 1.7, 
> Resolver as a key component should require it too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation

[Sebastian Kirsch (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010150#comment-16010150
 ] 

Sebastian Kirsch edited comment on SUREFIRE-1373 at 5/15/17 1:09 PM:
-

You're correct, we're using {{parallel}} in order to speed up execution. And 
yes, there's a bunch of tests that are considered to be _not thread-safe_, 
hence we're using the {{@NotThreadSafe}} annotation to mark them. We assume 
that those marked tests are executed sequentially in the specific 
_non-thread-safe_ thread; though that's not the point. Our assumption is that 
by configuring a {{threadCount}} of two, that execution behaves like this:
{noformat}
## 1. parallel execution #  |
|## non thread-safe execution ##|DONE
## 2. parallel execution ###|
{noformat}
i.e. there is the configured number of threads running tests in parallel and 
only afterwards, the tests marked as non-thread-safe are executed, as suggested 
by the documentation:
bq. The Thread has name maven-surefire-plugin@NotThreadSafe and it is executed 
*at the end of the test run*.

Now I understand that tests are executed like this by design:
{noformat}
## 1. parallel execution #  |
## non thread-safe execution ## |DONE
## 2. parallel execution ###|
{noformat}
If that is the case, let me share our use case/understanding of the situation: 
we have a handful of tests we consider to be non thread-safe, because they 
cannot be run in parallel to most other tests; not only because those marked 
tests cannot interfere with each other - they manipulate Environment/System 
properties to test bootstrapping. If _non-thread-safe_ test execution would run 
like I illustrated in the first diagram, we would not run into occasional test 
execution failures.


was (Author: sebastiankirsch):
You're correct, we're using {{parallel}} in order to speed up execution. And 
yes, there's a bunch of tests that are considered to be _not thread-safe_, 
hence we're using the {{@NotThreadSafe}} annotation to mark them. We assume 
that those marked tests are executed sequentially in the specific 
_non-thread-safe_ thread; though that's not the point. Our assumption is that 
by configuring a {{threadCount}} of two, that execution behaves like this:
{noformat}
## 1. parallel execution #  |
|## non thread-safe execution ##|DONE
## 2. parallel execution ###|
{noformat}
i.e. there is the configured number of threads running tests in parallel and 
only afterwards, the tests marked as non-thread-safe are executed, as suggested 
by the documentation:
bq. The Thread has name maven-surefire-plugin@NotThreadSafe and it is executed 
*at the end of the test run*.

Now I understand that tests are executed like this by design:
{noformat}
## 1. parallel execution #  |
## non thread-safe execution ## |DONE
## 2. parallel execution ###|
{noformat}
If that is case, let me share our use case/understanding of the situation: we 
have a handful of tests we consider to be non thread-safe, because they cannot 
be run in parallel to most other tests; not only because those marked tests 
cannot interfere with each other - they manipulate Environment/System 
properties to test bootstrapping. If _non-thread-safe_ test execution would run 
like I illustrated in the first diagram, we would not run into occasional test 
execution failures.

> Tests annotated with @NotThreadSafe are not executed in isolation
> -
>
> Key: SUREFIRE-1373
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1373
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Sebastian Kirsch
>Assignee: Tibor Digana
>
> The [surefire 
> documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html]
>  states that 
> bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on 
> the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in 
> order to execute it in single Thread instance. The Thread has name 
> maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test 
> run.
> However, the thread is run in parallel to the other tests being executed, 
> which contradicts the documentation and defeats the purpose of running tests 
> sequentially in a single thread.
> See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MDEP-568) dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx

[Archimedes Trajano (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MDEP-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archimedes Trajano updated MDEP-568:

Component/s: resolve

> dependency:go-offline -DexcludeGroupIds= still try to resolve artifacts 
> in the excluded group 
> --
>
> Key: MDEP-568
> URL: https://issues.apache.org/jira/browse/MDEP-568
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: go-offline, resolve
>Affects Versions: 2.3, 3.0.0
> Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
>Reporter: Archimedes Trajano
> Attachments: go-offline_copy-dependencies_patch_sample.zip, test.tgz
>
>
> see thread: 
> http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e
> in attached sample pom structure:
> mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline 
> -DexcludeGroupIds=us.pdinc.foo.maven.test
> fails



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (MDEP-568) dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx

[Archimedes Trajano (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010447#comment-16010447
 ] 

Archimedes Trajano edited comment on MDEP-568 at 5/15/17 1:01 PM:
--

Reopenning as the original problem is still there and the original one was 
autoclosed.  The problem is still present on 3.0.0 and also on the `resolve` 
goal.


was (Author: trajano):
Reopenning as the original problem is still there and the original one was 
autoclosed.  The problem is still present on 3.0.0

> dependency:go-offline -DexcludeGroupIds= still try to resolve artifacts 
> in the excluded group 
> --
>
> Key: MDEP-568
> URL: https://issues.apache.org/jira/browse/MDEP-568
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: go-offline, resolve
>Affects Versions: 2.3, 3.0.0
> Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
>Reporter: Archimedes Trajano
> Attachments: go-offline_copy-dependencies_patch_sample.zip, test.tgz
>
>
> see thread: 
> http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e
> in attached sample pom structure:
> mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline 
> -DexcludeGroupIds=us.pdinc.foo.maven.test
> fails



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (MDEP-568) dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx

[Archimedes Trajano (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010447#comment-16010447
 ] 

Archimedes Trajano edited comment on MDEP-568 at 5/15/17 1:00 PM:
--

Reopenning as the original problem is still there and the original one was 
autoclosed.  The problem is still present on 3.0.0


was (Author: trajano):
Reopenning as the original problem is still there and the original one was 
autoclosed.

> dependency:go-offline -DexcludeGroupIds= still try to resolve artifacts 
> in the excluded group 
> --
>
> Key: MDEP-568
> URL: https://issues.apache.org/jira/browse/MDEP-568
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: go-offline
>Affects Versions: 2.3, 3.0.0
> Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
>Reporter: Archimedes Trajano
> Attachments: go-offline_copy-dependencies_patch_sample.zip, test.tgz
>
>
> see thread: 
> http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e
> in attached sample pom structure:
> mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline 
> -DexcludeGroupIds=us.pdinc.foo.maven.test
> fails



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MDEP-568) dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx

[Archimedes Trajano (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MDEP-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archimedes Trajano updated MDEP-568:

Affects Version/s: 3.0.0

> dependency:go-offline -DexcludeGroupIds= still try to resolve artifacts 
> in the excluded group 
> --
>
> Key: MDEP-568
> URL: https://issues.apache.org/jira/browse/MDEP-568
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: go-offline
>Affects Versions: 2.3, 3.0.0
> Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
>Reporter: Archimedes Trajano
> Attachments: go-offline_copy-dependencies_patch_sample.zip, test.tgz
>
>
> see thread: 
> http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e
> in attached sample pom structure:
> mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline 
> -DexcludeGroupIds=us.pdinc.foo.maven.test
> fails



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MDEP-568) dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx

[Archimedes Trajano (JIRA)]

Archimedes Trajano created MDEP-568:
---

 Summary: dependency:go-offline -DexcludeGroupIds= still try to 
resolve artifacts in the excluded group 
 Key: MDEP-568
 URL: https://issues.apache.org/jira/browse/MDEP-568
 Project: Maven Dependency Plugin
  Issue Type: Bug
  Components: go-offline
Affects Versions: 2.3
 Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
Reporter: Archimedes Trajano
 Attachments: go-offline_copy-dependencies_patch_sample.zip, test.tgz

see thread: 
http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e

in attached sample pom structure:

mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline 
-DexcludeGroupIds=us.pdinc.foo.maven.test

fails





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MDEP-568) dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx

[Archimedes Trajano (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010447#comment-16010447
 ] 

Archimedes Trajano commented on MDEP-568:
-

Reopenning as the original problem is still there and the original one was 
autoclosed.

> dependency:go-offline -DexcludeGroupIds= still try to resolve artifacts 
> in the excluded group 
> --
>
> Key: MDEP-568
> URL: https://issues.apache.org/jira/browse/MDEP-568
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: go-offline
>Affects Versions: 2.3
> Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
>Reporter: Archimedes Trajano
> Attachments: go-offline_copy-dependencies_patch_sample.zip, test.tgz
>
>
> see thread: 
> http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e
> in attached sample pom structure:
> mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline 
> -DexcludeGroupIds=us.pdinc.foo.maven.test
> fails



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MDEP-562) Make extended tokens default for displaying trees

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010314#comment-16010314
 ] 

Michael Osipov commented on MDEP-562:
-

[~hboutemy], I do not intend to make exteded default. I have described in 
already. The proper value will be calculated at runtime wether your have a 
proper locale or Windows 10

> Make extended tokens default for displaying trees
> -
>
> Key: MDEP-562
> URL: https://issues.apache.org/jira/browse/MDEP-562
> Project: Maven Dependency Plugin
>  Issue Type: Wish
>  Components: tree
>Affects Versions: 3.0.0
>Reporter: Keir
>
> Now that MSHARED-615 has been merged I would like to propose that this be 
> made the default behavior.  By this point most developers have 
> unicode-compatible terminals and given the extended characters make the tree 
> more readable it would be nice to have this as the default option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SUREFIRE-1302) Surefire does not wait long enough for the forked VM and assumes it to be dead

[Olivier Peyrusse (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010206#comment-16010206
 ] 

Olivier Peyrusse commented on SUREFIRE-1302:


Hello Tibor,

new surefire built and I am starting the tests. Although, it is hard to 
reproduce ...

> Surefire does not wait long enough for the forked VM and assumes it to be dead
> --
>
> Key: SUREFIRE-1302
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1302
> Project: Maven Surefire
>  Issue Type: Request
>  Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Yuriy Zaplavnov
>Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: 
> surefire-tests-terminated-master-aa9330316038f6b46316ce36ff40714ffc7cf299.zip,
>  tests_log_01.txt, tests_log_02.txt
>
>
> This issue happens because surefire kills the forked container if it times 
> out waiting for the 'ping'.
> In org.apache.maven.surefire.booter.ForkedBooter class there is hardcoded 
> constant PING_TIMEOUT_IN_SECONDS  = 20 which is used in the following method:
> {code}
> private static ScheduledFuture listenToShutdownCommands( CommandReader 
> reader )
> {
> reader.addShutdownListener( createExitHandler( reader ) );
> AtomicBoolean pingDone = new AtomicBoolean( true );
> reader.addNoopListener( createPingHandler( pingDone ) );
> return JVM_TERMINATOR.scheduleAtFixedRate( createPingJob( pingDone, 
> reader ),
>0,PING_TIMEOUT_IN_SECONDS, 
> SECONDS );
> }
> {code}
> to create ScheduledFuture.
> In some of the cases the forked container might respond a bit later than it's 
> expected and surefire kills it
> {code}
> private static Runnable createPingJob( final AtomicBoolean pingDone, final 
> CommandReader reader  )
> {
> return new Runnable()
> {
> public void run()
> {
> boolean hasPing = pingDone.getAndSet( false );
> if ( !hasPing )
> {
> exit( 1, KILL, reader, true );
> }
> }
> };
> }
> {code}
> As long as we need to terminate it anyway, It would be really helpful if the 
> problem could be solved making the PING_TIMEOUT_IN_SECONDS  configurable with 
> the ability to specify the value from maven-surefire-plugin. 
> It would help to configure this timeout based on needs and factors of the 
> projects where surefire runs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (MENFORCER-269) RequireUpperBoundDeps does not consider wildcard (*) excluded transitive dependencies

[Eduard Moraru (JIRA)]

Eduard Moraru created MENFORCER-269:
---

 Summary: RequireUpperBoundDeps does not consider wildcard (*) 
excluded transitive dependencies
 Key: MENFORCER-269
 URL: https://issues.apache.org/jira/browse/MENFORCER-269
 Project: Maven Enforcer Plugin
  Issue Type: Improvement
  Components: Standard Rules
Affects Versions: 1.4.1
 Environment: maven 3.5.0
Reporter: Eduard Moraru


Fixing a {{RequireUpperBoundDeps}} error by using an {{}} tag normally 
works, but not when the {{artefactId}} is specified with {{*}}. A crude example 
would be:
{noformat}
A
  X1 (version 1.0 but excluded for A by groupId X artefactId *)
B
  B1
X1 (version 2.0)
C
...
{noformat}

The regular dependency tree properly sees this exclude and no longer lists X1 
as dep of A, however, the enforcer plugin fails and still displays the excluded 
dependency under the "paths to dependency" trees when the error is reported.

AFAIK, wildcard excludes were introduced in MNG-3832.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MDEP-562) Make extended tokens default for displaying trees

[Keir (JIRA)]

[ 
https://issues.apache.org/jira/browse/MDEP-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010163#comment-16010163
 ] 

Keir commented on MDEP-562:
---

Yep I checked, as per comment #4 on this issue, windows 7 CMD does not support 
the extended tokens.

> Make extended tokens default for displaying trees
> -
>
> Key: MDEP-562
> URL: https://issues.apache.org/jira/browse/MDEP-562
> Project: Maven Dependency Plugin
>  Issue Type: Wish
>  Components: tree
>Affects Versions: 3.0.0
>Reporter: Keir
>
> Now that MSHARED-615 has been merged I would like to propose that this be 
> made the default behavior.  By this point most developers have 
> unicode-compatible terminals and given the extended characters make the tree 
> more readable it would be nice to have this as the default option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SUREFIRE-1373) Tests annotated with @NotThreadSafe are not executed in isolation

[Sebastian Kirsch (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010150#comment-16010150
 ] 

Sebastian Kirsch commented on SUREFIRE-1373:


You're correct, we're using {{parallel}} in order to speed up execution. And 
yes, there's a bunch of tests that are considered to be _not thread-safe_, 
hence we're using the {{@NotThreadSafe}} annotation to mark them. We assume 
that those marked tests are executed sequentially in the specific 
_non-thread-safe_ thread; though that's not the point. Our assumption is that 
by configuring a {{threadCount}} of two, that execution behaves like this:
{noformat}
## 1. parallel execution #  |
|## non thread-safe execution ##|DONE
## 2. parallel execution ###|
{noformat}
i.e. there is the configured number of threads running tests in parallel and 
only afterwards, the tests marked as non-thread-safe are executed, as suggested 
by the documentation:
bq. The Thread has name maven-surefire-plugin@NotThreadSafe and it is executed 
*at the end of the test run*.

Now I understand that tests are executed like this by design:
{noformat}
## 1. parallel execution #  |
## non thread-safe execution ## |DONE
## 2. parallel execution ###|
{noformat}
If that is case, let me share our use case/understanding of the situation: we 
have a handful of tests we consider to be non thread-safe, because they cannot 
be run in parallel to most other tests; not only because those marked tests 
cannot interfere with each other - they manipulate Environment/System 
properties to test bootstrapping. If _non-thread-safe_ test execution would run 
like I illustrated in the first diagram, we would not run into occasional test 
execution failures.

> Tests annotated with @NotThreadSafe are not executed in isolation
> -
>
> Key: SUREFIRE-1373
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1373
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Sebastian Kirsch
>Assignee: Tibor Digana
>
> The [surefire 
> documentation|http://maven.apache.org/components/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html]
>  states that 
> bq. you can apply the JCIP annotation @net.jcip.annotations.NotThreadSafe on 
> the Java class of JUnit test (pure test class, Suite, Parameterized, etc.) in 
> order to execute it in single Thread instance. The Thread has name 
> maven-surefire-plugin@NotThreadSafe and it is executed at the end of the test 
> run.
> However, the thread is run in parallel to the other tests being executed, 
> which contradicts the documentation and defeats the purpose of running tests 
> sequentially in a single thread.
> See https://github.com/sebastiankirsch/surefire-nonthreadsafe for a test case.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (MDEP-562) Make extended tokens default for displaying trees

[JIRA]

[ 
https://issues.apache.org/jira/browse/MDEP-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010026#comment-16010026
 ] 

Hervé Boutemy edited comment on MDEP-562 at 5/15/17 6:29 AM:
-

one question: did anybody try on Windows? particularly Windows 7 (since Windows 
10 looks to have enhanced a lot)
because, from experience with Jansi, Windows encoding is quite tricky... then 
anything like this has to be checked and confirmed by humans that it works as 
expected


was (Author: hboutemy):
one question: did anybody try on Windows?
because, from experience with Jansi, Windows encoding is quite tricky... then 
anything like this has to be checked and confirmed by humans that it works as 
expected

> Make extended tokens default for displaying trees
> -
>
> Key: MDEP-562
> URL: https://issues.apache.org/jira/browse/MDEP-562
> Project: Maven Dependency Plugin
>  Issue Type: Wish
>  Components: tree
>Affects Versions: 3.0.0
>Reporter: Keir
>
> Now that MSHARED-615 has been merged I would like to propose that this be 
> made the default behavior.  By this point most developers have 
> unicode-compatible terminals and given the extended characters make the tree 
> more readable it would be nice to have this as the default option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MDEP-562) Make extended tokens default for displaying trees

[JIRA]

[ 
https://issues.apache.org/jira/browse/MDEP-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010026#comment-16010026
 ] 

Hervé Boutemy commented on MDEP-562:


one question: did anybody try on Windows?
because, from experience with Jansi, Windows encoding is quite tricky... then 
anything like this has to be checked and confirmed by humans that it works as 
expected

> Make extended tokens default for displaying trees
> -
>
> Key: MDEP-562
> URL: https://issues.apache.org/jira/browse/MDEP-562
> Project: Maven Dependency Plugin
>  Issue Type: Wish
>  Components: tree
>Affects Versions: 3.0.0
>Reporter: Keir
>
> Now that MSHARED-615 has been merged I would like to propose that this be 
> made the default behavior.  By this point most developers have 
> unicode-compatible terminals and given the extended characters make the tree 
> more readable it would be nice to have this as the default option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept null input

[JIRA]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MRESOLVER-4:
--
Description: 
In several spots of Maven Resolver IAE is thrown where an argument is null. 
This should be turned into NullPointerException since JDK adheres to this, the 
description of this exception indicates that and Effective Java does that too. 
Java 7 even provides a new 
[{{Objects}}|https://docs.oracle.com/javase/7/docs/api/java/util/Objects.html] 
class with {{requireNonNull(Object,String)}} method to ease checking

Most likely to be misused:
{noformat}
$ grep -r "throw new IllegalArgumentException" .
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
throw new IllegalArgumentException( "Bad artifact coordinates " + 
coords
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
throw new IllegalArgumentException( "no type id specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
throw new IllegalArgumentException( "no type id specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
throw new IllegalArgumentException( "dependency collection request 
has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
throw new IllegalArgumentException( "repository system session not 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
throw new IllegalArgumentException( "deploy request has not been 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
throw new IllegalArgumentException( "no artifact specified for 
dependency" );
./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
throw new IllegalArgumentException( "install request has not been 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
throw new IllegalArgumentException( "metadata nature was not 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "repository system session 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "authentication data key 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "authentication data key 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
throw new IllegalArgumentException( "local artifact request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
throw new IllegalArgumentException( "local metadata request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
throw new IllegalArgumentException( "repository prototype 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java: 
   throw new IllegalArgumentException( "session not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java: 
   throw new IllegalArgumentException( "event type not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:
throw new IllegalArgumentException( "artifact descriptor request 
has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResult.java:
throw new IllegalArgumentException( "resolution request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/DependencyResult.java:
throw new IllegalArgumentException( "dependency request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/MetadataResult.java:
throw new 

[jira] [Updated] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept null input

[JIRA]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MRESOLVER-4:
--
Description: 
In several spots of Maven Resolver IAE is thrown where an argument is null. 
This should be turned into NullPointerException since JDK adheres to this, the 
description of this exception indicates that and Effective Java does that too. 
JDK 7 even provides a new 
[{{Objects}}|https://docs.oracle.com/javase/7/docs/api/java/util/Objects.html] 
class with {{requireNonNull(Object,String)}} method to ease checking

Most likely to be misused:
{noformat}
$ grep -r "throw new IllegalArgumentException" .
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
throw new IllegalArgumentException( "Bad artifact coordinates " + 
coords
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
throw new IllegalArgumentException( "no type id specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
throw new IllegalArgumentException( "no type id specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
throw new IllegalArgumentException( "dependency collection request 
has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
throw new IllegalArgumentException( "repository system session not 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
throw new IllegalArgumentException( "deploy request has not been 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
throw new IllegalArgumentException( "no artifact specified for 
dependency" );
./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
throw new IllegalArgumentException( "install request has not been 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
throw new IllegalArgumentException( "metadata nature was not 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "repository system session 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "authentication data key 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "authentication data key 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
throw new IllegalArgumentException( "local artifact request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
throw new IllegalArgumentException( "local metadata request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
throw new IllegalArgumentException( "repository prototype 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java: 
   throw new IllegalArgumentException( "session not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java: 
   throw new IllegalArgumentException( "event type not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:
throw new IllegalArgumentException( "artifact descriptor request 
has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResult.java:
throw new IllegalArgumentException( "resolution request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/DependencyResult.java:
throw new IllegalArgumentException( "dependency request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/MetadataResult.java:
throw new 

[jira] [Updated] (MRESOLVER-4) Use java.util.Objects#requireNonNull to intercept null input

[JIRA]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MRESOLVER-4:
--
Description: 
In several spots of Maven Resolver IAE is thrown where an argument is null. 
This should be turned into NullPointerException since JDK adheres to this, the 
description of this exception indicates that and Effective Java does that too. 
JDK 7 even provides a new 
[{{Objects}}|https://docs.oracle.com/javase/7/docs/api/java/util/Objects.html] 
class with {{requireNonNull}} method to ease checking

Most likely to be misused:
{noformat}
$ grep -r "throw new IllegalArgumentException" .
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
throw new IllegalArgumentException( "Bad artifact coordinates " + 
coords
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
throw new IllegalArgumentException( "no type id specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
throw new IllegalArgumentException( "no type id specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
throw new IllegalArgumentException( "dependency collection request 
has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
throw new IllegalArgumentException( "repository system session not 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:  
  throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
throw new IllegalArgumentException( "deploy request has not been 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
throw new IllegalArgumentException( "no artifact specified for 
dependency" );
./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
throw new IllegalArgumentException( "install request has not been 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
throw new IllegalArgumentException( "metadata nature was not 
specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "repository system session 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "authentication data key 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
throw new IllegalArgumentException( "authentication data key 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
throw new IllegalArgumentException( "local artifact request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
throw new IllegalArgumentException( "local metadata request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
throw new IllegalArgumentException( "repository prototype 
missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java: 
   throw new IllegalArgumentException( "session not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java: 
   throw new IllegalArgumentException( "event type not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:
throw new IllegalArgumentException( "artifact descriptor request 
has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResult.java:
throw new IllegalArgumentException( "resolution request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/DependencyResult.java:
throw new IllegalArgumentException( "dependency request has not 
been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/MetadataResult.java:
throw new